14:01:39 <rafaelweingartner> #startmeeting cloudkitty
14:01:39 <opendevmeet> Meeting started Mon May 27 14:01:39 2024 UTC and is due to finish in 60 minutes.  The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:01:39 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:01:39 <opendevmeet> The meeting name has been set to 'cloudkitty'
14:01:43 <rafaelweingartner> Hello guys!
14:01:46 <rafaelweingartner> Roll count
14:01:48 <rafaelweingartner> \o
14:01:52 <mkarpiarz> Hi!
14:02:03 <priteau> Hello
14:02:10 <priteau> mkarpiarz: I thought you might be on holiday
14:03:18 <mkarpiarz> Ah, yes, it's a bank holiday in the UK but I'm here today. :)
14:05:01 <rafaelweingartner> I see
14:05:07 <rafaelweingartner> awesome that you are here :)
14:05:22 <mkarpiarz> :)
14:05:28 <rafaelweingartner> #topic Old branches deprecation/deletion
14:05:40 <rafaelweingartner> This one is one me. I forgot to address it this past weeks
14:05:48 <rafaelweingartner> I will try to add to my list and not forget about it
14:06:02 <rafaelweingartner> sorry for that
14:08:01 <priteau> rafaelweingartner: Would you like me to create the release patch to drop these branches? I can do it if you are busy.
14:08:13 <rafaelweingartner> yes
14:08:15 <rafaelweingartner> that is the idea
14:08:33 <rafaelweingartner> if you can, that would be awesome!
14:10:34 <priteau> I will check if I can do it.
14:10:43 <priteau> You will still need to give your +1
14:11:09 <mkarpiarz> OK
14:11:28 <rafaelweingartner> sure, I will
14:12:46 <rafaelweingartner> #topic Target reviews
14:13:06 <rafaelweingartner> We have this one, #link https://review.opendev.org/c/openstack/cloudkitty/+/917445 , which is a cherry-pick and seems to be fine for merging
14:13:28 <rafaelweingartner> mkarpiarz: can you do the honours?
14:13:49 <mkarpiarz> Sure
14:14:05 <priteau> Same for https://review.opendev.org/c/openstack/cloudkitty/+/917446 and https://review.opendev.org/c/openstack/cloudkitty/+/917447
14:14:18 <priteau> rafaelweingartner: you gave W+1 but without Code=Review+2 first
14:14:52 <rafaelweingartner> probably selected the wrong options there
14:15:33 <rafaelweingartner> fixed
14:16:31 <priteau> Thanks both
14:17:34 <rafaelweingartner> moving on, we have #link https://review.opendev.org/c/openstack/cloudkitty/+/876643.
14:17:50 <rafaelweingartner> This one has been in the making for a while, and Pedro has added the documentation requested by priteau
14:19:05 <mkarpiarz> The change still looks good to me. :)
14:19:16 <priteau> I will do another review this week. I was out of the office last week
14:20:42 <rafaelweingartner> ok, thanks for the reviews!
14:21:44 <rafaelweingartner> That patch is a new step to CloudKitty regarding rating rules management
14:23:13 <mkarpiarz> So is backward compatibility of rules without start and end date still an issue we need to discuss?
14:24:48 <rafaelweingartner> for us it is not an issue, because one can always set a start date in the past. However, if needed, I can discuss with pedro. For instance, to allow somebody to create a rating rule without start, which would mean that it is valid since eer
14:24:51 <rafaelweingartner> ever*
14:25:07 <rafaelweingartner> this is the same as setting a start timestamp in the distant past, for instance
14:27:29 <mkarpiarz> I'm fine with either but it would be nice if we came to a broader agreement, not just majority.
14:27:39 <mkarpiarz> (i.e. 2/3)
14:27:56 <priteau> I still think backward compatibility is a nice thing, but I need to test a bit more how it behaves currently
14:28:35 <priteau> I am afraid I have to leave for school pickup
14:28:58 <rafaelweingartner> ok
14:29:01 <rafaelweingartner> we can close for today then
14:29:14 <rafaelweingartner> and discuss this further in our next meeting
14:29:20 <priteau> mkarpiarz: Thanks for the quick review of https://review.opendev.org/c/openstack/cloudkitty/+/919751
14:29:33 <priteau> Matt is back tomorrow and will respond to your comment
14:29:46 <priteau> And update the patch if required
14:29:46 <mkarpiarz> OK
14:29:53 <mkarpiarz> Thanks!
14:30:07 <priteau> Good bye!
14:30:12 <rafaelweingartner> bye
14:30:15 <mkarpiarz> Bye!
14:30:21 <rafaelweingartner> Thank you guys for participating. Have a nice week.
14:30:24 <rafaelweingartner> #endmeeting