14:00:15 <rafaelweingartner> #startmeeting cloudkitty 14:00:15 <opendevmeet> Meeting started Mon Oct 14 14:00:15 2024 UTC and is due to finish in 60 minutes. The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:00:15 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:00:15 <opendevmeet> The meeting name has been set to 'cloudkitty' 14:00:23 <rafaelweingartner> Hello guys! 14:00:26 <rafaelweingartner> Roll count 14:01:15 <priteau> o/ 14:01:27 <priteau> Hello Rafael 14:01:27 <mattcrees> Hello o/ 14:02:40 <rafaelweingartner> hey guys! 14:03:26 <rafaelweingartner> #topic vPTG meeting 14:03:58 <rafaelweingartner> If you did not register yet, please do register at http://ptg.openinfra.dev/ 14:04:17 <rafaelweingartner> The schedule is not open for us to select, yet, right? 14:04:42 <priteau> It has been open for some time now 14:04:51 <priteau> https://ptg.opendev.org/ptg.html 14:05:06 <priteau> We can book time on #openinfra-events 14:06:25 <rafaelweingartner> can we book monday? 14:06:40 <priteau> Of course 14:07:16 <rafaelweingartner> I booked three slots, just in case 14:08:15 <priteau> Can we start from 1400 UTC? 14:08:32 <rafaelweingartner> sure 14:08:35 <rafaelweingartner> I will update then 14:08:51 <rafaelweingartner> #cloudkitty unbook cactus-MonB1 14:13:36 <priteau> Thanks 14:16:10 <rafaelweingartner> #topic Taget reviews 14:16:23 <rafaelweingartner> #topic Python 3.12 unit test failures 14:16:30 <rafaelweingartner> I guess we will need to update the tests, right? 14:16:53 <rafaelweingartner> The issue is related with this patch: #link https://review.opendev.org/c/openstack/cloudkitty/+/915479 14:17:33 <priteau> For some reason the test failure that was random on Python 3.12 seems to be much more common now 14:17:44 <opendevreview> James Page proposed openstack/cloudkitty master: Misc fixes for Python 3.12 compatibility https://review.opendev.org/c/openstack/cloudkitty/+/915479 14:17:53 <rafaelweingartner> yes, I am seeing it 14:18:04 <rafaelweingartner> but, I guess we should not change the API, but rather the client, right? 14:18:31 <rafaelweingartner> for instance, using round on the client side, and then we leave the api to return the complete result 14:21:19 <priteau> Do we know if it is the result sent back by the API that changed in 3.12? 14:21:39 <priteau> I would assume so, given it used to work with assertEqual 14:22:21 <rafaelweingartner> It seems that the precision in Python has changed 14:22:25 <rafaelweingartner> and not the API process itself 14:22:35 <priteau> But rounding just at 3 digits is a big change 14:22:45 <rafaelweingartner> exactly 14:22:54 <rafaelweingartner> that is why I mean saying not to round in the API 14:22:57 <rafaelweingartner> we can just fix the client 14:23:01 <rafaelweingartner> by client here, I mean the test 14:26:09 <priteau> Well, the unit test rather than the client? 14:26:24 <rafaelweingartner> exactly 14:26:39 <rafaelweingartner> the "thing" consuming the API 14:27:04 <rafaelweingartner> which is the test, and it consumes the API unsing the cloudkitty client. However, the outptu is received form the CLI, and processed (validated) in the test code 14:29:31 <priteau> Let's continue discussion on the patch itself once Zuul has finished checking 14:31:01 <rafaelweingartner> That was my question there some months ago: https://review.opendev.org/c/openstack/cloudkitty/+/915479/comments/ea69b564_4189d0c2 14:32:23 <priteau> I know, but it looks like the author is inactivate 14:32:29 <priteau> inactive 14:32:53 <rafaelweingartner> yes =) 14:32:59 <rafaelweingartner> but we can discuss there 14:35:55 <rafaelweingartner> Moving on 14:35:57 <rafaelweingartner> #topic Core reviewer team 14:36:20 <rafaelweingartner> We sent the email to invite Matt 14:36:25 <rafaelweingartner> I guess there is nothing against it 14:36:37 <rafaelweingartner> so, I guess we will be adding him to the team 14:36:46 <rafaelweingartner> priteau: do you know the process from this point? 14:37:35 <priteau> On Gerrit, go to Browse > Groups, search for cloudkitty-core, click on Members 14:37:45 <priteau> You will be able to add Matt there. 14:39:31 <rafaelweingartner> done! 14:39:35 <rafaelweingartner> matt can you test it? 14:39:55 <mattcrees> Sweet, yes I can now see +2 powers in Gerrit :) 14:40:00 <rafaelweingartner> =) 14:40:04 <priteau> Should we remove Mariusz too? 14:40:33 <rafaelweingartner> I do not know 14:40:41 <rafaelweingartner> maybe wait some more mnths before removing him? 14:42:23 <priteau> He said he would be inactive 14:42:41 <rafaelweingartner> Ok 14:42:45 <rafaelweingartner> I can remove him then 14:42:56 <rafaelweingartner> done 14:45:54 <rafaelweingartner> besides these topics. Do you guys have something els? 14:46:34 <priteau> Just sharing that we should add topics to the PTG Etherpad: https://etherpad.opendev.org/p/oct2024-ptg-cloudkitty 14:47:08 <rafaelweingartner> yes, I know 14:47:19 <rafaelweingartner> I will try to review the previous one, and see what we want to do next 14:47:27 <rafaelweingartner> your additions are welcome as well :) 14:48:56 <priteau> Also there are some simple patches to review 14:48:57 <priteau> https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/932265 14:49:47 <priteau> https://review.opendev.org/c/openstack/python-cloudkittyclient/+/931181 14:51:30 <rafaelweingartner> thanks! 14:52:46 <priteau> https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/925736 14:54:07 <priteau> There will be more once we fix the py3.12 issues 14:54:46 <rafaelweingartner> yes 14:56:09 <opendevreview> Merged openstack/cloudkitty-dashboard master: tox: Drop envdir https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/932265 14:57:08 <rafaelweingartner> I guess that is all for today then 14:57:32 <priteau> All good 14:57:35 <rafaelweingartner> Thank you guys for participating. Have a nice week. 14:57:43 <mattcrees> Cheers 14:57:48 <rafaelweingartner> #endmeeting