04:01:19 <ekcs> #startmeeting congressteammeeting
04:01:20 <openstack> Meeting started Fri Dec 28 04:01:19 2018 UTC and is due to finish in 60 minutes.  The chair is ekcs. Information about MeetBot at http://wiki.debian.org/MeetBot.
04:01:21 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
04:01:23 <openstack> The meeting name has been set to 'congressteammeeting'
04:01:34 <ekcs> hi all. happy holidays!
04:01:54 <ekcs> topics collected here as usual: #link https://etherpad.openstack.org/p/congress-meeting-topics
04:02:01 <ekcs> feel free to add more
04:02:19 <akhil_jain> ekcs: Hi. happy holidays :)
04:02:53 <ekcs> akhil_jain: thanks! is this a holiday time in india?
04:03:54 <akhil_jain> it will start from tomorrow
04:04:03 <akhil_jain> in india and japan both
04:04:43 <akhil_jain> will continue till 6th january
04:05:34 <ekcs> ah got it great!
04:05:43 <ekcs> well lets get started then.
04:05:48 <akhil_jain> what about your place
04:05:56 <ekcs> ah
04:06:17 <ekcs> it’s not officially a holiday. but many people take time off between 12/24 (christmas eve) and 1/1 (new year).
04:06:51 <akhil_jain> ohk great, so you taking off?
04:07:19 <ekcs> yup I’m actually off now =)
04:07:35 <ekcs> #topic nova postgres
04:07:45 <akhil_jain> thats nice
04:07:49 <ekcs> just a quick update that the nova postgres bug fixed: https://bugs.launchpad.net/nova/+bug/1804271
04:07:50 <openstack> Launchpad bug 1804271 in OpenStack Compute (nova) rocky "nova-api is broken in postgresql jobs" [Medium,Fix committed] - Assigned to Matt Riedemann (mriedem)
04:07:55 <ekcs> congress postgres dsvm should be passing now
04:08:26 <ekcs> so now the congress postgres jobs are informative again.
04:09:32 <ekcs> #topic nova addresses tempest test
04:10:05 <ekcs> akhil_jain: would this be a good time to clarify a bit on that patch?
04:10:06 <ekcs> https://review.openstack.org/#/c/618951/
04:10:26 <ekcs> I’m trying to understand where we need the sleep-wait.
04:11:07 <akhil_jain> just after attaching floating ip to server. if we list floating ip is not there
04:11:33 <akhil_jain> in server list i mean
04:11:51 <akhil_jain> to update self.server
04:12:13 <ekcs> just so I make sure I understand exactly, which line in which file would you add the sleep?
04:13:20 <akhil_jain> https://github.com/openstack/congress-tempest-plugin/blob/master/congress_tempest_plugin/tests/scenario/manager_congress.py#L100
04:13:29 <akhil_jain> just after this
04:14:25 <akhil_jain> we need to use sleep/wait then show server again using id, and finally update self.server with updated value having floating ip
04:14:50 <ekcs> Ah I see. I don’t see any major problem with it. but can you help me understand why the retry in the nova test doesn’t solve the problem?
04:16:15 <akhil_jain> that can do i guess. thats why asked in review. if sleep/wait or i should follow some other approach
04:17:23 <akhil_jain> i have tried with sleep wait in my env. worked. i will test using retry and update the same. thanks for your input
04:17:57 <ekcs> well aside from which approach is better, I’m trying to understand why the retry already in the code hasn’t already solved the problem
04:17:58 <ekcs> https://review.openstack.org/#/c/618951/2/congress_tempest_plugin/tests/scenario/congress_datasources/test_nova.py@159
04:19:49 <akhil_jain> thats because in manager_congress self.servers is set before adding floating ip to it. but in test we need updated one
04:20:38 <akhil_jain> self.servers is from nova service via tempest. not the one from congress datasource table
04:20:46 <ekcs> ooooh I get it now. that’s why I needed to ask there clarifying questions =p
04:21:14 <akhil_jain> :D great
04:22:14 <akhil_jain> so now i will try it with retry and update it
04:23:15 <ekcs> I’m still kind of confused as to why adding a wait after this line would help: https://github.com/openstack/congress-tempest-plugin/blob/master/congress_tempest_plugin/tests/scenario/manager_congress.py#L100
04:23:52 <ekcs> because the self.servers is set before that anyway. so waiting until the attachment takes place should not lead the self.servers[0] object to reflect the new information right?
04:25:25 <akhil_jain> not exactly after this line but in subsequent functions in manager.py where floating ip, servers are being created and self.servers is updated
04:26:15 <ekcs> I see. well I see the problem to be solve.
04:26:38 <ekcs> I think retry is better than time out because it’s more robust (time out may be too short).
04:26:39 <akhil_jain> i will leave before floating ip attachment part as it is. just update self.servers after floating ip attachment
04:27:14 <akhil_jain> ok i will try with retry.
04:27:23 <ekcs> but please go ahead and do a solution that makes sense to you.
04:27:53 <akhil_jain> thanks.
04:28:05 <ekcs> yup thanks!
04:28:51 <ekcs> ok seems we’re done with that topic for now =)
04:28:55 <ekcs> #topic open discussion
04:29:03 <ekcs> anything else we want to talk about today?
04:30:16 <akhil_jain> also i have added Wip patch for tacker test. https://review.openstack.org/#/c/627346/
04:30:41 <akhil_jain> if you get some time. please check my approach
04:31:11 <ekcs> oh great thanks for the reminder!
04:32:04 <akhil_jain> :)
04:32:18 <akhil_jain> nothing else from my side. for today
04:32:23 <ekcs> cool.
04:32:38 <ekcs> oh of course the json data spec is still there =) https://review.openstack.org/#/c/616077/
04:32:51 <ekcs> well let’s wrap up then if there’s nothing else to discuss today.
04:35:55 <ekcs> ok let’s end meeting then. happy holidays!
04:36:02 <ekcs> more on gerrit =)
04:36:06 <ekcs> #endmeeting