14:04:53 #startmeeting freezer 14:04:53 Meeting started Thu Jun 2 14:04:53 2016 UTC and is due to finish in 60 minutes. The chair is slashme. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:04:54 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:04:58 The meeting name has been set to 'freezer' 14:05:04 :0 14:05:09 :) 14:05:12 Hello everyone 14:05:15 hello 14:05:16 hello 14:05:54 As usual, the agenda is available here: https://etherpad.openstack.org/p/freezer_meetings 14:05:59 Hi 14:06:07 Feel free to add anything there 14:11:28 Okay, First topic 14:11:38 #topic mid-cycle meetup 14:12:44 It will happen in Galway I suppose. 14:12:47 location: philiphines 14:12:57 so the last meeting we discussed end of july in galway 14:13:35 I'll be in Germany between 19/07 and 29/07 14:13:58 does anyone have the link to the meeting minutes from last week? 14:14:06 I'll be in Egypt from 18 Jun till 23rd of July 14:14:35 http://eavesdrop.openstack.org/meetings/freezer/ 14:15:26 so no philiphines :( 14:16:21 so, last meeting we voted for the last week of july, i believe 14:16:29 And I'll be out 27/07 yo 18/08 14:16:30 july 25 14:17:03 you europeans and your wacky way of showing dates ;-) 14:17:24 so then can we do first week of august? 14:17:42 A one day event should be enought this time I think. No ? 14:17:59 i can't justify a trip for one day :-( 14:18:37 i think deamontool said that he was unavailable in auguest 14:18:53 I am unavailable in august as well 14:19:23 if we go to september, that is not really mid-cycle though 14:19:36 ddieterly: yes 14:21:06 july 11? 14:21:15 ddieterly: regarding your travel issues, we can arrange for some skype/hangout. 14:21:31 @slashme ok 14:21:49 i can also schedule a trip independently to get some face time 14:26:44 so, it seems pretty much up in the air at this point? 14:26:50 It seems like it is going to be hard to get everyone here physicaly (ddieterly, szaher, jonaspf) 14:27:10 Let's agree on a date and have people joining virtualy 14:27:21 +1 14:27:28 We don't have as much things as last time to discuss 14:29:14 I'm okay with 15th of July 14:29:41 works for me (virtually) 14:31:06 Okay. 14:31:42 There is no other points in the agenda today (except the pending reviews) 14:32:01 i had a question about the reviews 14:32:01 Anyone has a topic he/she wants to discuss ? 14:32:16 Go ahead 14:32:50 usually, before +2/A a review in other projects, we would have tests or, a reviewer would test the patch himself 14:33:16 are people doing that in freezer? testing the patch before +2/A? 14:33:32 agree 14:33:54 this takes a lot of work, but it definitely safe time in the long run 14:34:03 s/safe/saves 14:34:10 What a reviewer should do before approving a patch: 14:34:16 We should be more timely review 14:34:18 - Read the code 14:34:40 - Check for the presence of a bug-id or blueprint-id 14:34:46 - Test the code 14:35:13 - Check for documentation of the code (Both comment and addition to the doc) 14:35:40 - Check if the mappings have been updated accordingly if necessary 14:36:19 Anything to add to this ? 14:36:58 looks good, i think the testing of code will definitely slow down the review process 14:37:16 i think that each patch should have unit tests and integration tests as well before approved 14:37:24 +1 14:41:03 Any other comments on that ? 14:41:17 Or topic you want to discuss ? 14:43:07 kind of a slow day 14:43:11 For me I am good. Thanks :) 14:43:34 I would appreciate If we can review this one https://review.openstack.org/#/c/324529/ 14:45:10 And these patches are also waiting for reviews: 14:45:13 https://review.openstack.org/#/c/312430/ 14:45:13 https://review.openstack.org/#/c/315939/ 14:45:14 https://review.openstack.org/#/c/318551/ 14:45:14 https://review.openstack.org/#/c/323644/ 14:48:29 szaher will https://review.openstack.org/#/c/324529/ address the issues that mohan found? 14:50:18 ddieterly: which issues ? 14:50:25 Can you give me a link to that issues ? 14:50:33 bura-479 14:50:49 unable to start a default job 14:51:02 the version field in the db seems to be the issue 14:51:52 ddieterly: I think this patch is the one solved the problem https://review.openstack.org/#/c/322928/ 14:53:09 how long does it usually take to get from stable/mitaka to hp/prerelease/mitaka? 14:53:17 Einstcrazy: plz check my comments https://review.openstack.org/#/c/324529/ 14:54:21 ddieterly: it's landed already 14:55:08 well, I think the second one my comment may be a clear way . Anyway all is ok 14:55:16 so then it could not have fixed the issue 14:55:28 either is ok 14:56:10 EinstCrazy: I just wanted to know what is the difference between if do_update and if not do_update ? 14:56:48 It's neater to do "if not do_update"... and return and unindent the larger block that happens if do_update, I guess? 14:57:06 Readability? 14:59:17 o, I think the code may be like this 14:59:21 # check if doc_type exists or not 14:59:21 if self._check_mapping_exists(doc_type): 14:59:22 do_update = self.prompt('[[[ {0} ]]] already exists in index => {1}' 14:59:23 ' <= Do you want to update it ? (y/n) ' 14:59:25 .format(doc_type, self.index) 14:59:27 ) 14:59:29 if not do_update: 14:59:31 return {'acknowledged': False} 14:59:33 return self.elk.indices.put_mapping(doc_type=doc_type, body=body, 14:59:35 index=self.index) 14:59:37 but anyway I think either is ok 15:00:04 meeting is about to end 15:00:07 ciao! 15:00:10 #openstack-freezer? 15:00:33 * bswartz waves to freezer team 15:00:42 bye bye 15:01:34 #endmeeting 15:01:39 freezer guys you going to end meeting? 15:01:47 vponomaryov, afaik only the moderator can end the meeting 15:01:54 slashme you need to end the meeting, i think 15:02:05 Oops 15:02:12 #endmeeting freezer