14:03:29 <m3m0> #startmeeting freezer
14:03:30 <openstack> Meeting started Thu Aug  4 14:03:29 2016 UTC and is due to finish in 60 minutes.  The chair is m3m0. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:03:32 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:03:34 <openstack> The meeting name has been set to 'freezer'
14:03:39 <m3m0> who's here for freezer meeting?
14:03:49 <ddieterly> o/
14:03:56 <yangyapeng> hello m3m0
14:04:52 <timothyb89> hello all
14:04:57 <m3m0> let's wait for more people to join
14:05:20 <zhurong> 0/
14:07:40 <m3m0> please add your pending reviews here and topics if you have https://etherpad.openstack.org/p/freezer_meetings
14:09:33 <m3m0> #topic freezer mascot
14:09:59 <m3m0> ok this is easy, there is a survey to chose the new mascot, please vote: https://www.surveymonkey.com/r/R6VGGGG
14:12:59 <ddieterly> i voted
14:14:33 <m3m0> thanks, does anyone have more topics?
14:14:58 <m3m0> timothyb89  ddieterly  zhurong yangyapeng ^^
14:15:16 <ddieterly> no, i'm busy with hpe hos related stuff
14:16:19 <timothyb89> nothing from me either
14:16:27 <yangyapeng> no, me too
14:16:33 <yangyapeng> zhurong:
14:16:52 <zhurong> no from me
14:17:14 <m3m0> yeah I'm the same here
14:17:52 <m3m0> ddieterly: do we need to backport this as well? https://review.openstack.org/#/c/350234/2
14:18:21 <ddieterly> yes, we should
14:19:02 <m3m0> more reviews: https://review.openstack.org/#/c/349940/
14:19:06 <m3m0> https://review.openstack.org/#/c/340307/
14:19:47 <m3m0> yangyapeng: what about this ones: https://review.openstack.org/#/c/339477 https://review.openstack.org/#/c/350110
14:23:55 <yangyape_> ping zhurong
14:24:12 <m3m0> yangyape_: thanks :)
14:24:41 <yangyape_> :)
14:26:36 <zhurong> I am here
14:27:15 <yangyape_> https://review.openstack.org/#/c/339477 if you can review it about dashbord
14:27:46 <m3m0> ddieterly: https://review.openstack.org/#/c/339477/4 please
14:28:30 <m3m0> yangyape_: and what about this one: https://review.openstack.org/#/c/350110/1
14:29:13 <ddieterly> yangyape_ are you sure that it will work?
14:29:20 <ddieterly> i don't have a way of testing it right now
14:29:32 <yangyape_> m3m0:   I test it in dashboard. it is ok
14:29:45 <m3m0> where does WEBROOT comes from?
14:29:47 <zhurong> I think the most import patch is this: https://review.openstack.org/#/c/335410/
14:29:51 <yangyape_> ddieterly:  create job  and edit action in job and so on .
14:29:58 <zhurong> m3m0 from horizon dashbaord
14:30:23 <m3m0> ok, so are those 2 commits related?
14:30:40 <ddieterly> they look like competing commits
14:32:05 <yangyape_> ddieterly:  yeah , but the first one , I have no test.
14:32:47 <zhurong> m3m0 url_path have get the full path, I think we doesn't need to using the WEBROOT
14:33:19 <m3m0> zhurong: that's not the case when horizon is configured to have "/horizon/" prefix
14:34:07 <m3m0> WEBROOT can be or and there is a distinction there for javascript
14:34:38 <zhurong> m3m0 maybe not  /horizon
14:34:45 <yangyape_> dashboard?
14:34:57 <m3m0> because /horizon/ is no longer part of the pathname nor the host
14:35:36 <m3m0> could you print what's your WEBROOT?
14:35:51 <zhurong> We can setting any WEBROOT
14:36:06 <zhurong> devstack set with /dashboard
14:36:44 <m3m0> and what's the full value?
14:38:20 <zhurong>
14:38:48 <yangyape_> m3m0:  i think use url_path is better to fix it
14:42:39 <m3m0> for me: url_path = /disaster_recovery/
14:42:50 <m3m0> WEBROOT /
14:44:08 <zhurong> m3m0 yep, this two patch can solve the problem, but if using WEBROOT, get url_path should remove, and If we change the url, also should change this js
14:44:09 <m3m0> which I think should solve the issue
14:44:36 <m3m0> zhurong: so, I got confused, which one do you think is best?
14:46:23 <zhurong> m3m0 all depends you, :D. Both are OK, but using WEBROOT one should remove get url_path.
14:46:55 <m3m0> let's go for WEBROOT seems cleaner, do you want to update the patch?
14:47:41 <yangyape_> zhurong:  remove the url_path other patch
14:48:36 <m3m0> in the smae
14:52:09 <m3m0> guys can we discuss this in the #openstack-freezer channel?
14:52:14 <m3m0> and close this meeting?
14:52:26 <zhurong> Sure
14:52:46 <m3m0> #endmeeting