14:02:08 <yangyapeng> #startmeeting freezer
14:02:09 <openstack> Meeting started Thu Dec  1 14:02:08 2016 UTC and is due to finish in 60 minutes.  The chair is yangyapeng. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:02:10 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:02:12 <openstack> The meeting name has been set to 'freezer'
14:02:25 <yangyapeng> hello freezer guys
14:02:54 <raliev> yangyapeng, hey :)
14:03:03 <yangyapeng> hello raliev
14:03:29 <yangyapeng> Let's wait for more people to join
14:05:05 <yangyapeng> Please add more topic to https://etherpad.openstack.org/p/freezer_meetings
14:06:06 <yangyapeng> zhusz1: hello
14:06:10 <zhusz2> hello
14:07:18 <yangyapeng> zhusz1:  I see you have some patches in review :)
14:07:40 <yangyapeng> zhusz2: if it have some topic to discuss ?
14:08:58 <zhusz2> No topic now. Only some patches need to be reviewed.
14:09:43 <yangyapeng> OKay, We need more  to review these patch :)
14:10:39 <yangyapeng> raliev: zhusz2 https://review.openstack.org/#/c/372193/
14:10:47 <raliev> yangyapeng, could you please review this one  https://review.openstack.org/#/c/397861/ https://review.openstack.org/#/c/397874/?
14:11:06 <yangyapeng> ok , I have a patch need to review  :)
14:12:19 <zhusz2> yangyapeng, I have reviewed that patch. It's OK for me.
14:12:27 <yangyapeng> thank you zhusz2
14:13:08 <yangyapeng> raliev: https://review.openstack.org/#/c/397861/  i have a quickly review. it is ok , Workflow  :)
14:13:12 <raliev> yangyapeng, I already reviewed this https://review.openstack.org/#/c/372193/, lgtm
14:14:04 <raliev> yangyapeng, thx :)
14:14:11 <yangyapeng> thank you raliev
14:16:29 <zhusz2> yangyapeng, could you please review https://review.openstack.org/#/c/400671/?
14:16:45 <zhusz2> And https://review.openstack.org/#/c/398101/
14:18:38 <zhusz2> raliev, could you review https://review.openstack.org/#/c/402279/? I think it's important.
14:19:07 <raliev> zhusz2, sure
14:20:09 <zhusz2> Thanks raliev
14:20:33 <yangyapeng> hi zhusz2 https://review.openstack.org/#/c/400671/   Can you explain it, about the order,
14:22:03 <zhusz2> column =
14:23:03 <yangyapeng> oh oh.
14:23:23 <raliev> zhusz2,  regarding https://review.openstack.org/#/c/402279/, looks good, if it works well - no objections from me
14:23:32 <zhusz2> 'Start Date', 'End Date', 'Interval'
14:23:53 <yangyapeng> :)
14:24:40 <zhusz2> raliev, yes. I have a validation on my local environment
14:24:57 <raliev> zhusz2, +1 from me :)
14:25:08 <zhusz2> OK, thanks
14:26:09 <raliev> guys, there are two patches with pep8 fixes, please take a look - https://review.openstack.org/#/c/404761/ ,  https://review.openstack.org/#/c/403738/
14:30:46 <slashme_> Hi guys, sorry I'm late.
14:31:00 <yangyapeng> hello slashme_
14:31:02 <zhusz2> Hello slashme
14:31:19 <yangyapeng> we have some peeding review  patch
14:31:21 <raliev> slashme_, hey:)
14:31:25 <slashme_> Thx yangyapeng for taking care of the meeting
14:31:36 <dstepanenko_> hello slashme_
14:32:46 <yangyapeng> it's my pleasure
14:35:16 <yangyapeng> raliev: pep8 patch  i have a review. nice
14:37:13 <raliev> yangyapeng, that wasn't easy to fix freezer-api code, too many code style problems :)
14:39:43 <yangyapeng> yes
14:39:46 <yangyapeng> bug raliev
14:40:06 <yangyapeng> http://docs.openstack.org/developer/hacking/ [H306] Alphabetically order your imports by the full module path
14:40:19 <yangyapeng> we should have that import alphabetically
14:41:21 <raliev> yangyapeng, where it is not done?
14:42:12 <yangyapeng> eg: https://review.openstack.org/#/c/404761/2/freezer_api/storage/elastic.py
14:42:32 <yangyapeng> in freezer-api  about unittest and mock.
14:43:24 <raliev> imports ordered in blocks as in Import order template - http://docs.openstack.org/developer/hacking/#import-order-template
14:43:57 <raliev> unittest is stdlib, it should be at block#1, mock is third-party
14:44:22 <dstepanenko_> yangyapeng, there are 3 blocks of imports here, so libs should be sorted inside their blocks
14:47:09 <yangyapeng> raliev dstepanenko_ Thanks   I made the same mistake ^^
14:47:45 <yangyapeng> {{stdlib imports in human alphabetical order}}
14:47:46 <yangyapeng> \n
14:47:46 <yangyapeng> {{third-party lib imports in human alphabetical order}}
14:47:48 <yangyapeng> \n
14:47:48 <dstepanenko_> yangyapeng: no problems :)
14:47:50 <yangyapeng> {{project imports in human alphabetical order}}
14:47:52 <yangyapeng> \n
14:47:53 <yangyapeng> \n
14:47:55 <yangyapeng> {{begin your code}}
14:51:01 <raliev> yangyapeng, hacking H306 is checked alphabetical order of imports, I can't made a mistake, otherwise pep8 gate check will fail :)
14:51:11 <raliev> https://github.com/openstack-dev/hacking/blob/master/hacking/checks/imports.py#L80
14:53:06 <yangyapeng> raliev: thanks
14:56:51 <dstepanenko_> guys, could you please also take a look into https://review.openstack.org/#/c/379281/
14:59:16 <yangyapeng> hello guys
14:59:47 <yangyapeng> if we have more patch to review, please add it to https://etherpad.openstack.org/p/freezer_meetings.
15:00:00 <yangyapeng> 1 minutes left
15:00:21 <yangyapeng> thanks everyone
15:00:34 * bswartz waves to yangyapeng
15:00:42 <yangyapeng> #endmeeting