14:01:17 #startmeeting fwaas 14:01:18 Meeting started Thu Nov 8 14:01:17 2018 UTC and is due to finish in 60 minutes. The chair is yushiro. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:01:20 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:01:22 The meeting name has been set to 'fwaas' 14:01:48 Let's start weekly meeting. 14:02:09 #topic announcements 14:03:11 Hi yushiro 14:03:31 A name of "T" cycle may be "train" :p hahaha 14:03:41 annp_: Hi 14:03:51 SridarK is not here today. 14:04:26 #topic Stein 14:04:32 :D 14:04:58 Hi SridarK, 14:04:58 Hi All 14:05:04 Sorry to be late 14:05:22 no worries. we've just start 14:05:32 #chair SridarK xgerman_ 14:05:33 Current chairs: SridarK xgerman_ yushiro 14:05:43 SridarK: Hi. Yes, No warries :) 14:05:50 :-) 14:05:55 Long time, SridarK 14:06:09 Yes was on PTO had to travel 14:06:29 so could not attend last few mtgs 14:06:33 SridarK: Wow, sounds great!! I hope your travel was good :) 14:06:44 yes hectic 14:06:46 thx yushiro 14:07:52 :) 14:08:38 #topic specs 14:09:25 Fwaas: add support for dynamic rules: https://review.openstack.org/#/c/597724/ 14:09:40 Fwaas: extend firewall group inclusion: https://review.openstack.org/#/c/600261/ 14:09:55 Today I don't see hongbin. 14:10:29 There was one more 14:10:43 on policy priority 14:11:03 Aha, yes. 14:11:05 #link https://review.openstack.org/#/c/600870/ 14:11:16 i added some comments on that last night 14:11:31 Policy priority: https://review.openstack.org/#/c/600870/ 14:11:34 SridarK: Thanks. 14:11:53 I will check it. 14:12:12 yushiro: yes thx 14:12:39 had some more clarifications and then can move fwd 14:12:48 OK 14:14:27 BTW SridarK, I'd like to check current patches in neutron-fwaas today. 14:15:10 https://review.openstack.org/#/q/project:openstack/neutron-fwaas+status:open+branch:master 14:15:14 yushiro: yes i saw some updates yday 14:15:48 Make OVS the default option for L2 FWaaS V2: https://review.openstack.org/605866 14:16:16 I updated a little for xgerman_'s patch but got some errors due to impl miss :p 14:17:05 yushiro: ok 14:17:12 When we create VM instances, default FWG will be associated automatically. Therefore, in order to test with self-created fwg, we have to unset all ports from default fwg at once. 14:17:53 yushiro: yes exactly 14:18:17 annp_: I don't have an environment for tempest testing in my local. Do you know how to make it ? 14:18:33 WIP: Removing FWaaS v1 source code: https://review.openstack.org/616410 14:18:49 yushiro, yes. I will let you know tomorrow morning. 14:18:49 Thanks annp_ for your patch. 14:19:16 yushiro for bring it up. 14:20:19 I will remove WIP after this ready for review. 14:20:33 OK 14:20:43 Add python 3.6 unit test job: https://review.openstack.org/615904 14:20:52 I think it's OK to merge it. Just put +2 14:20:54 We will need to prepare for a funeral for v1 :-( 14:21:33 Aha 14:21:48 SridarK :-) 14:22:04 Done for 615904 14:22:09 SridarK: +1 14:22:18 :-) 14:24:31 https://review.openstack.org/#/c/614950/ (Update min tox version to 2.0) This patch is duplicated for https://review.openstack.org/#/c/613299/ and it has already been merged. 14:24:53 So, I'll put some comments for it. 14:25:27 In DVR model the port name binding iptables rules is not correct.: https://review.openstack.org/#/c/606007/ 14:26:14 SridarK: This patch needs your review :) I and annp have commented on it but need to sync up more. 14:26:36 DVR case 14:27:00 yushiro: ok got it, will review this today 14:27:13 Thank you ! 14:27:17 I think there was one where Swami asked a question too 14:27:20 +1 14:27:28 I will catch up today 14:28:10 when i restart l3-agent,inactive group will change to acitve: https://review.openstack.org/#/c/585688/8 14:29:04 This patch fixes wrong status transition when restarting l3-agent. I commented on this patch and want to fix commit msg. 14:29:46 Don't bind FWG on vm port if no firewall_l2_driver.: https://review.openstack.org/605988 14:30:00 yushiro: yes ur comments are good - will look for it 14:30:47 I and annp_ discussed with Wang and explained on launchpad: https://bugs.launchpad.net/neutron/+bug/1798713 This is not a bug. 14:30:47 Launchpad bug 1798713 in neutron "[fwaas]wrong judgment in _is_supported_by_fw_l2_driver method" [Low,Invalid] - Assigned to Wang Weijia (wangweij) 14:32:21 yushiro, +1 14:32:45 yes agreed 14:33:11 Default firewall rules from configuration file: https://review.openstack.org/#/c/612617/3 14:34:51 This patch enables to configure default firewall rules. However, I think it is more better to define not into source code but conf file (neutron_fwaas.conf etc..) 14:35:23 Yeah, I think it make sense. 14:35:36 I'll comment it later. 14:35:53 yes i think so too that is better 14:36:01 OK :) 14:36:05 +1 14:37:09 Others are failed in zuul 14:37:51 https://review.openstack.org/#/q/f8e4a193e7930c2e9ef169c6e3be53a3e2a39dbe 14:37:58 Fix associating firewall group with DVR/L3HA port 14:38:54 Thanks SridarK for your review and I'm sorry for confusing. annp_ has tested my patch and worked correctly. 14:39:57 Unfortunately, there was some error with zuul on stable branch. 14:40:13 yes ok - will look also 14:40:45 ok, I will take a look also 14:41:18 zuul gate in Rocky stable branch ok 14:42:53 http://logs.openstack.org/69/613669/4/check/openstack-tox-py27/09ed3b5/job-output.txt.gz#_2018-10-29_23_55_21_289000 14:44:00 Oh, I forgot 1 patch from me: https://review.openstack.org/#/c/614091/ 14:44:26 Currently, when we test in local with 'tox -epyxx', it will be raised an error. 14:46:35 But still got 2 errors. It was due to 'fake_notifier' has moved from neutron to neutron-lib. Notification events are not registered correctly... I think it's 1 way to skip these 2 tests until this bug has fixed :p 14:47:26 yushiro: ok 14:49:12 +1 14:51:23 #topic Open Discussion 14:51:37 Thanks SridarK and annp_ for clean-up existing patches. 14:51:55 yushiro: no thx for tracking all of them 14:52:00 yushiro, Thank you too. 14:52:09 yushiro: annp_: are u going to Berlin ? 14:52:22 SridarK, I won't go there 14:52:30 Will you be there? 14:52:34 Me either. 14:52:46 annp_: yushiro: My travel is also not sure 14:53:11 initially i was going to - but some changes at work - so a bit uncertain 14:53:39 it is very close - will know only by tomorrow 14:54:02 Aha. 14:54:27 SridarK: In fact, we maybe change our job field unfortunately. 14:54:43 yushiro: oh really 14:55:12 Maybe next week, it is clarified I think. 14:55:20 yushiro: oh ok 14:55:33 both u & annp ? 14:56:26 SridarK: Yes. We maybe move to k8s. 14:56:37 yushiro: ah ok 14:57:11 yushiro: ok will talk more 14:57:18 later 14:57:20 yeah 14:57:44 I should sign off - have a mtg right after 14:57:50 OK, let's close this meeting. 14:57:52 will exchange email 14:58:01 SridarK: Sure 14:58:02 thx yushiro annp_ 14:58:04 OK. 14:58:05 #endmeeting