20:00:41 <markwash> #startmeeting glance 20:00:42 <openstack> Meeting started Thu Sep 5 20:00:41 2013 UTC and is due to finish in 60 minutes. The chair is markwash. Information about MeetBot at http://wiki.debian.org/MeetBot. 20:00:42 <zhiyan> \o 20:00:43 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 20:00:45 <openstack> The meeting name has been set to 'glance' 20:00:55 * markwash waits, wishing he had remembered to send out a reminder 20:01:59 <zhiyan> Hi, any items on agenda ? 20:02:21 <markwash> yes, mostly related to the recent release of Havana 3 20:03:05 <iccha> hey 20:03:14 <markwash> hurray for highlighting! 20:03:28 <iccha> everyones coming 20:03:40 <esheffield> o/ 20:04:09 <markwash> I wanna try to keep my part short, to allow for more open discussion or just plain taking a break today 20:04:18 <markwash> so here are the items I want to touch on today 20:04:27 <markwash> 1) How to handle reviews during the FFE 20:04:39 <jbresnah> wave 20:04:47 <markwash> s/FFE/feature freeze/ 20:04:58 <markwash> 2) current and possible feature freeze exceptions 20:05:04 <markwash> 3) what's going on with async workers 20:05:16 <markwash> 4) priorities during FF 20:05:23 <markwash> so let's get started! :-) 20:05:31 <iccha> woohoo <3 agenda 20:05:38 <markwash> Just wanted to remind all core reviewers that we're now in feature freeze 20:05:47 <markwash> so if you see a new feature in a review, -2 it! 20:06:05 <markwash> after RC1 is cut, we can remove our -2's (sep 26th ish) 20:06:18 <zhiyan> markwash: cool 20:06:22 <iccha> if soemthing is assigned to rc-1 is it in FFE? 20:06:28 <iccha> or for after it? 20:06:38 <markwash> important bug fixes are still fine to let through, but let's make sure they're important / safe 20:06:46 <markwash> iccha: that's what I was aiming for 20:07:24 <markwash> I'd also like to see those aforementioned important bugs targeted to RC1 just to make sure we're reporting up all the things we need to share, and not letting any important issues slip by 20:07:52 <markwash> #link https://bugs.launchpad.net/glance/+milestone/havana-rc1 20:08:07 <markwash> that ^^ shows what we're tracking as important bug fixes and FFE blueprints 20:08:21 <markwash> Any questions about reviews and bugs during FF? 20:08:39 <jbresnah> so if a review references a bug in that list we can approve it? 20:08:49 <markwash> definitely 20:08:57 <jbresnah> ok cool 20:08:58 <markwash> and its possible that some bug fixes need to be added to that list 20:09:15 <nikhil> jbresnah: when I'm using tox, the bug https://bugs.launchpad.net/glance/+bug/1220919 never happend 20:09:20 <jbresnah> does that list need to freeze soon? 20:09:25 <markwash> well, they should have "triaged" status 20:09:33 <markwash> jbresnah: I don't think it needs to freeze 20:09:37 <markwash> but its important we curate it well 20:09:41 <jbresnah> yeah 20:09:49 <markwash> no sneaky wishlist feature-y bugs coming in :-) 20:09:56 <iccha> hehe 20:10:15 <markwash> the thing we want to care about right now is stability in the code 20:10:26 <markwash> because there are folks who will be testing out the milestone proposed branch 20:10:39 <markwash> so we want to minimize the significance of changes between those two 20:10:49 <markwash> Other questions? 20:10:52 <zhiyan> markwash: can we add https://code.launchpad.net/bugs/1202098 in the rc1 list? 20:11:13 <zhiyan> markwash: https://review.openstack.org/#/c/44490/ 20:11:14 <markwash> zhiyan: I think so 20:11:30 <jbresnah> yeah, that one is pretty straight forward and ready to go too i think 20:11:58 <markwash> cool 20:11:59 <zhiyan> markwash: can you help adding it to list? since i can't change its Milestone field.. 20:12:10 <markwash> done 20:12:12 <zhiyan> jbresnah: yes 20:12:19 <zhiyan> markwash: jbresnah: thanks. 20:12:21 <markwash> Let's move on to current and proposed FFEs 20:12:43 <markwash> #1 on this list for me is the last patch in protected properties, regarding v1 changes 20:12:54 <markwash> I'd actually like to see that land today so that I can push it into milestone proposed 20:12:56 <jbresnah> ah right 20:13:10 <markwash> but I can't tell quite if its ready 20:13:29 * markwash looks for link 20:13:37 <iccha> needs little work but looks mostly good 20:13:45 <markwash> https://review.openstack.org/#/c/44703/ 20:14:15 <jbresnah> i havent looked at it again since the integration tests were added back in 20:14:58 <markwash> we might just have to send it in RC1 20:15:11 <markwash> if we can't get it together before very very early tomorrow 20:15:23 <markwash> okay, a few other things have popped up 20:15:43 <markwash> First off, https://review.openstack.org/#/q/status:open+project:openstack/glance+branch:master+topic:bp/glance-tests-code-duplication,n,z 20:15:55 <markwash> this feels like its just test cleanup 20:16:11 <markwash> so I don't know that it should really be blocked by FF 20:16:33 <ameade_> +1 20:16:45 <markwash> I want to double check the reviews to ensure its only mucking with tests, but if that checks out, I'd like to grant an FFE and land it. . any other thoughts though? I don't want to be rash 20:17:12 <jbresnah> well, it would be nice to verify that they offer the same test coverage 20:17:16 <jbresnah> not just in terms of LOC 20:17:20 <jbresnah> but in terms of logical paths 20:17:23 <jbresnah> that is sort of hard to do 20:17:26 <markwash> jbresnah: good point 20:17:40 <jbresnah> i would be ok with letting them in tho 20:17:46 <jbresnah> but the reviews will take time 20:18:13 <markwash> I guess we can give it an FFE, but if the coverage changes for the worse, we'd just want to give a -1 regardless. . does that make sense? 20:18:29 <iccha> makes sense 20:18:50 <jbresnah> yeah 20:19:06 <iccha> https://review.openstack.org/#/c/34801/ is close but its a big change 20:19:06 <markwash> cool 20:19:23 <markwash> yes I wanted to talk about that one. . lets hear about it now 20:19:43 <markwash> one worry I have there is the docimpact 20:19:45 <markwash> which seems pretty large 20:19:47 <iccha> it involves migrations 20:19:51 <iccha> and docimpact 20:19:59 <markwash> do we have time/bandwidth to prep this? 20:20:00 <iccha> and I am not sure if enough ppl have reviewed it 20:20:12 <markwash> OTOH I'm worried that it is critical with the locations feature we released to make sense 20:21:02 <markwash> iccha: so in the migration, credentials are stripped out 20:21:09 <iccha> yes thats right markwash 20:21:17 <markwash> and the administrator is required to put the right creds into the config 20:21:23 <iccha> yeah thats right 20:21:36 <iccha> it deprecates some of the existing conf 20:21:39 <iccha> and introduces new 20:22:08 <markwash> the config part looks good 20:22:25 <markwash> I feel like this bp is good for an FFE if we have the bandwidth to do the docs right 20:22:45 <iccha> lets go for it i know sridevi was asking about docs for it today 20:23:07 <markwash> we just need to yell as loud as possible about this one to make sure people don't destroy their credential data 20:23:15 <iccha> +10 that 20:23:20 <nikhil> or +1M 20:23:23 <markwash> :-) 20:23:46 <markwash> so here's my plan 20:23:52 <markwash> I still want another outside sanity check on this one 20:24:10 <markwash> so let's put target the bp to RC1, but hold off on sending it in until at least next wednesday 20:24:14 <iccha> stuart has been looking at . but yes more the merrier 20:24:23 <ameade_> how do we yell loud enough? 20:24:25 <markwash> that way ttx and others will have a chance to look at the fact we're proposing this 20:24:26 * ameade_ is nervous 20:24:33 <nikhil> outside meaning, outside glance? 20:24:38 <markwash> yeah, outside glance 20:24:42 <nikhil> +1 20:24:57 <markwash> I think an email to the list about it is also important at this stage 20:25:06 <iccha> this kinda breaks backward compatibility for config 20:25:11 <iccha> is there a rule for such things? 20:25:23 <markwash> iccha: hmm, it shouldn't do that 20:25:36 <nikhil> did we cover string freeze? 20:25:58 <markwash> iccha: let's circle around about the config changes 20:26:01 <iccha> markwash: hmm yeah u re right 20:26:03 <nikhil> or that is included in FFE? 20:26:04 <iccha> cool next one 20:26:09 <markwash> I wanna grok that, a little distracted at this point 20:26:20 <markwash> nikhil: good point, missed string freeze 20:26:27 <markwash> let's hit that in a moment 20:27:03 <markwash> another possible FFE 20:27:08 <markwash> https://review.openstack.org/#/q/status:open+project:openstack/glance+branch:master+topic:bp/db-use-oslo-common-code,n,z 20:27:27 <markwash> this one feels more borderline to me. . I think we can probably afford to wait 20:27:38 <ameade> is this a feature? 20:27:38 <markwash> but I'm a bit sad.. I meant to get it in in time :-( 20:28:10 <markwash> ameade: good question, I was assuming a few features were being picked up in the meanwhile 20:28:41 <markwash> maybe we can ask for some clarification about the feature-y-ness 20:28:46 <iccha> it introduced common code 20:29:06 <nikhil> haha, the MP says blueprint however, it does not exist! 20:29:09 <iccha> dont mind me i looked at only one review 20:29:47 <markwash> okay, I'll leave that one on the docket and see if I can clear things up for myself in review 20:29:55 <markwash> or bug boris-42 if I have questions 20:30:26 <markwash> but it might be most sensible to just land it very soon after RC1 20:30:53 <markwash> okay, last one on my list is *drumroll* 20:31:00 <iccha> maybe after rc1 20:31:30 * markwash searches for link 20:31:37 * jbresnah anxiousy awaits 20:31:38 <iccha> lol 20:31:45 * iccha waiting in anticipation 20:31:48 <jbresnah> . o O ( that drummer must be exhausted ) 20:31:48 <boris-42> markwash hi 20:32:00 <markwash> haha 20:32:00 <boris-42> markwash whats up? 20:32:23 <markwash> boris-42: we were looking at FFE for bp db-use-oslo-common-code 20:32:32 <markwash> ffe -> feature freeze exception 20:32:40 <boris-42> markwash I am not sure that it is good thing to merge it now 20:32:52 <nikhil> jbresnah: nice 1 20:32:54 <markwash> okay, will it be fine to merge right after RC1? 20:32:54 <boris-42> markwash it is better to wait IceHouse imho 20:33:08 <markwash> boris-42: thanks so much! that saves some effort 20:33:50 <boris-42> markwash but it will be really nice to make some efforts around reviewing it at benign of IceHouse 20:34:00 <markwash> the other bp I wanted to mention to folks in general is common notifier code 20:34:04 <boris-42> markwash I real don't won't to block oslo.db lib 20:34:07 <markwash> boris-42: great, will do! 20:34:14 <boris-42> markwash thank you 20:34:29 <iccha> https://review.openstack.org/#/c/37511/ 20:34:39 <iccha> notifier patch ^ 20:34:39 <markwash> iccha: you beat me to it 20:34:51 <markwash> that is listed as a bug but its really a feature 20:35:06 <markwash> I'd still prefer to wait if possible, but I do hate to not have support for rabbit HA queues 20:35:25 <markwash> though I was recently informed that rabbit v3 doesn't require client changes to support HA 20:36:07 <markwash> looks like best course here is also to leave this on the docket and square up with flwang later 20:36:54 <markwash> any other ffe topics people want to bring up before we touch on async workers? 20:37:24 <markwash> cool 20:37:32 <markwash> so I talked with nikhil and rosmaita yesterday 20:37:59 <markwash> and we eventually agreed that, without actual conversion code at the ready, it makes sense to push off landing async processing until early havana 20:38:14 <markwash> but it is my desire to merge that stuff as quickly as possible in H1 20:38:29 <markwash> so it makes sense to keep working / reviewing for the current time period 20:38:53 <markwash> that's all I have there, any notes people want to share? 20:39:05 <nikhil> thanks markwash , I'd communicated to flwang your concerns 20:39:19 <nikhil> ameade is here too :) 20:39:23 <markwash> nikhil: thanks so much for your understanding and all the hard work 20:39:37 <nikhil> markwash: one comment though (tiny one) 20:39:51 <nikhil> can we have some solid reviews on the existing patches? 20:40:12 <nikhil> so, that there is some clear path forward and good momentum to build on :) 20:40:24 <markwash> nikhil: yes I think that's absolutely critical 20:40:28 <nikhil> i mean, glance-core-reviewers in general 20:40:36 <nikhil> :) 20:40:40 <markwash> I'd really like to keep it basically in a rebased and +2-ready state as much as possible 20:41:04 <nikhil> will be on it 20:41:21 <markwash> I think as long as we keep the first review in the series -2 for FF reasons, we can do whatever we want +2 wise for the later reviews 20:41:44 <markwash> okay, finally, I have a note or two about priorities for our time during FF 20:41:53 <markwash> not that I get to say how people spend their time! :-) 20:42:06 <nikhil> thanks, though if we'd clear consensus on the design it would be awesome \o/ 20:42:22 <markwash> as I think I mentioned before, we want to make sure important bugs are being noted and prioritized 20:42:24 <markwash> at minimum 20:42:31 <markwash> it would also be nice to start adding some more docs 20:42:47 <markwash> which is an area I've been woefully inadequate with 20:43:11 <markwash> and finally, the FF doesn't really affect glanceclient 20:43:11 <ameade> docs are a good point 20:43:30 <markwash> so esheffield I'd like us to keep pushing in the direction of a fully-fledged v2 client 20:43:39 <markwash> don't let me miss out on such reviews 20:44:13 <markwash> I'd really like to release v1.0 of the client before the stable branch of openstack/glance is cut 20:44:25 <markwash> and might finally have some time to spend there! :-) 20:44:44 <esheffield> sounds good to me! 20:44:56 <esheffield> I think we're really close 20:44:59 <iccha> it doesnt have v1.0 yet ! :O 20:45:24 <markwash> iccha: well. . not quite what I meant :-) 20:45:38 <markwash> so, nikhil brought up stringfreeze 20:45:46 <markwash> that's something I neglected to mention as part of the general FF 20:45:52 <markwash> we are not supposed to change any public-facing strings 20:46:01 <markwash> lest we muck up translation efforts I believe 20:46:14 <markwash> any other FF related notes? or should we jump into open discussion? 20:47:08 <markwash> #topic open-discussion 20:48:14 <iccha> markwash: https://review.openstack.org/#/c/44801/ is this imp enough for FFE? 20:48:21 <ameade> +1 20:48:49 <markwash> I like it 20:49:42 <markwash> who's going to be at the summit? 20:49:45 <nikhil> looks like they are addressing those comments 20:49:46 <markwash> o/ 20:50:00 <nikhil> -1 20:50:05 <iccha> -1 20:50:22 <iccha> i think zhi or flwang said they ll be there 20:50:26 <iccha> and flavio i guess 20:50:36 <zhiyan> iccha: :) 20:50:40 <jbresnah> i will not be 20:50:46 <zhiyan> jbresnah: oh no 20:50:48 * jbresnah bursts into tears 20:50:54 <zhiyan> jbresnah: confirmed? 20:50:57 * iccha hands jbresnah a tissue 20:50:59 <jbresnah> seems so 20:51:26 <markwash> sigh 20:51:43 <zhiyan> markwash: btw, as you mentioned, i think we'd better give a priority to https://bugs.launchpad.net/bugs/1202098 , can you help set that? 20:51:49 <nikhil> isn't it nearer from hawaii 20:51:57 <nikhil> or my geagraphy is weak :( 20:52:29 <nikhil> need to spell right 20:52:35 <jbresnah> heh 20:52:37 <jbresnah> sort of near 20:52:58 <jbresnah> but still way too expensive to cover myself 20:52:59 <markwash> obviously we need the summit to be in hawaii sometime 20:53:05 <jbresnah> nod 20:53:06 <iccha> glance summit 20:53:11 <markwash> haha yes that one 20:53:12 <jbresnah> everyone wins with thta! 20:53:20 <nikhil> +1B*e^1B 20:53:23 <jbresnah> its in the middle of nowhere! 20:53:28 <iccha> so it makes it absolutely vital for us to be there 20:53:29 <jbresnah> and i am the only developer that lives here 20:53:31 <jbresnah> heh 20:53:33 <jbresnah> i looked into a meetup 20:53:38 <jbresnah> but i thought it would be lonely 20:54:21 <markwash> lol 20:54:31 <markwash> just jbresnah hanging out in a room 20:54:52 <jbresnah> nod 20:54:58 <markwash> okay thanks everybody 20:55:01 <markwash> #endmeeting