14:01:24 #startmeeting Glance 14:01:25 Meeting started Thu Oct 1 14:01:24 2015 UTC and is due to finish in 60 minutes. The chair is flaper87. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:01:27 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:01:29 The meeting name has been set to 'glance' 14:01:34 Courtesy meeting reminder: ativelkov, cpallares, flaper87, flwang1, hemanthm, ivasilevskaya, jokke_, kragniz, lakshmiS, mclaren, mfedosin, nikhil_k, Nikolay_St, Olena, pennerc, rosmaita, sigmavirus24, sabari, TravT, pkoniszewski, krykowski, ajayaa, GB21, bpoulos, harshs, abhishekk, bunting, dshakhray, wxy 14:01:35 o/ 14:01:36 o/ 14:01:38 o/ 14:01:42 o/ 14:01:45 o/ 14:01:50 yoooooooooooooooooooooooooo, everyone! 14:01:51 o/ 14:02:17 Awesome, we have quorum 14:02:20 #topic Agenda 14:02:24 #link https://etherpad.openstack.org/p/glance-team-meeting-agenda 14:02:43 o/ 14:02:52 that's our agenda for today. There are quite some topics to discuss. If yo uhave something urgent please, let me know and we can re-arrange at runtime 14:02:55 o/ 14:02:59 #topic Updates 14:03:09 ativelkov: nikhil artifacts ? 14:03:26 I didn't see ativelkov ping 14:03:30 Alex will miss this meeting 14:03:36 ok 14:03:43 mfedosin: updates fro myou? 14:03:49 I think no artifact updates on this week 14:03:50 We had a full meeting this Monday. 14:04:33 something else? Otherwise we'll move on with drivers updates 14:04:33 :) 14:04:38 #link http://eavesdrop.openstack.org/meetings/glance_artifacts_sub_team/2015/glance_artifacts_sub_team.2015-09-28-14.01.html 14:04:55 Quite a few things there. 14:05:17 okidoki, I'll read through 14:05:24 Mostly updates on what to come reviews, API discussion and community App catalog 14:05:51 okay, I was on sick leave on Monday. so wan't able to attend the meeting 14:05:54 Questions? concerns ? something the rest of the community can help with? 14:05:56 THere's some winding up for Liberty that's merely formality, I will try to get it through this week. 14:06:04 nikhil: ++ 14:06:08 * nikhil done 14:06:10 o/ 14:06:16 dhellmann: welcome 14:06:35 Updates from drivers: I don't think there's much other than we disucssed lakshmiS patch 14:06:48 We've agreed to not backport that patch into Liberty 14:06:56 yes 14:07:07 lakshmiS: mind elaborating on the consecuences from a searchlight perspective? 14:07:15 so that we have those logged here 14:07:18 sure 14:07:35 without image member notifications searchlight RBAC will not be correct 14:08:02 searchlight users would have to reindex to get the member updates 14:08:22 Thanks and sorry about that 14:08:26 so the patch on glance generates member notifications 14:08:36 We can work on getting it merge soon for Mitaka 14:08:44 * flaper87 reviewed it yday 14:08:48 (that were missing until now) 14:08:48 or was that today? 14:08:51 mmh 14:09:17 lakshmiS: thanks for the updates 14:09:20 nikhil: ++ 14:09:20 for now we are putting a release note on searchlight by linking it to the glance patch for users to manually apply it on top of glance liberty release 14:09:37 it'll remain a users choice 14:09:50 * nikhil nods 14:09:50 to backport it or wait until mitaka 14:09:54 coolio 14:09:57 One more affect point -- this also affects all the clouds that expose notifications. 14:10:16 yup 14:10:19 o/ sry being bit late 14:10:29 one more good reason for not rushing it 14:10:31 ok 14:10:33 moving on 14:10:34 (and or use them for other purposes -- I think no one has complained until now so most likely not a biggest of issues) 14:10:46 * nikhil shuts up 14:10:52 #topic More cores (nikhil) 14:11:14 nikhil: floor is yours 14:11:15 So, I started the part one rotation earlier in Sept 14:11:18 thanks flaper87 14:11:22 I will try to be quick 14:11:42 And I had refrained from making more changes as we have a few important discussions going on. 14:12:04 makes sense 14:12:27 Since this is a transition period, I wanted to raise this as a general question on what are our plans. Of course, I do not wish to propose rushing either way. 14:12:49 yeah, my personal feeling is that we should wait a bit more before expanding the core team 14:12:54 to keep these logged -- My observation in Liberty has been that Abhishek and Sabari have done good work overall and are good candidates. So, I would like to propose for them to be cores if/when we are planning to add more to the team. 14:13:26 That feeling is related to the upcoming discussions. That said, I do agree that both, Abhishek and Sabari have been great 14:13:37 If other folks have a different view, please, do share 14:13:54 Sort of felt like giving them a passive shout out for helping with critical reviews at certain phases of Liberty and make them valuable assets to the team. 14:13:56 * nikhil done 14:14:01 thanks nikhil and flapper87 14:14:02 Otherwise, I think we can talk about this again after the summit 14:14:13 abhishekk: no, thank you for all your reviews 14:14:16 my observation is that we've contracted the core team, so adding these 2 wouldn't really be expanding 14:14:35 I will be keep doing the same :) 14:14:58 sabari and abhishekk do both contribute detailed, high-quality reviews 14:15:08 rosmaita: +1 14:15:15 rosmaita: it's expanding its current size. :P Jokes apart, I'm not worried about expanding it but I'd like us to clarify our goals for mitaka so we can communicate them properly and help new members to get on board 14:15:21 rosmaita: +1 to that 14:15:22 I agree with both 14:15:50 flaper87: ++ 14:15:53 flaper87: +1 to goal clarification 14:16:04 agree there flaper87 14:16:27 coolio, so. We agree these to humans are amazing and we'd like them in the core team 14:16:33 +1 14:16:34 but lets wait until goals are written down 14:16:53 #agreed these to humans are amazing and we'd like them in the core team but we'll wait until the goals have been written down 14:16:58 * flaper87 is getting bot-fancy 14:17:00 ok 14:17:02 moving on 14:17:14 #topic Dashboard (flaper87) 14:17:38 not much to say here other than I put some time to create this dashboard for Glance reviews: 14:17:44 #link http://tinyurl.com/glance-review-dashboard 14:17:53 Hope you guys like it and that you'll help improving it 14:18:06 nice 14:18:13 it comes from this project: 14:18:15 that is really handy 14:18:17 #link http://github.com/stackforge/gerrit-dash-creator 14:18:36 I proposed a patch to merge the dashboard you'll on that link 14:18:43 but that can still be improved 14:18:43 I know the swift folks have something similar. Their PTL can mark high priority stuff with a star I think. 14:18:59 yup, I'm planning to do that by keeping topics updated 14:19:08 mclaren: jokke_: what browser are you using, theat tinyurl gives me an error in firefox 14:19:12 I'll need some help from reviewers but nothing we can't do together 14:19:18 rosmaita: firefox 14:19:20 rosmaita: I'm on firefox 14:19:28 rosmaita: I'll pm you the long one 14:19:34 ty 14:19:36 ok, moving on 14:19:43 #topic https://review.openstack.org/#/c/229220/ (nikhil_k) 14:19:49 it doesn't work in firefox 14:19:49 (or nikhil ) 14:19:51 :P 14:19:56 :) 14:20:37 So, I think this is mere formality but removing downgrade can mean a project wide impact 14:21:01 nikhil: agreed and I agree a spec would be nice to have 14:21:11 For example, all the scripts should be updated, all the other specs should be updated and marked an impact update etc 14:21:21 From the comments I can tell one is going to be written 14:21:50 yeah, I hope that the developer writes one (code review) for other updates 14:22:30 coolio, I'll make sure you're added to that spec as soon as it shows up 14:22:31 :P 14:22:36 you just volunteered 14:22:41 Also, this means that new scripts wouldn't downgrades, can we improve the upgrade path a bit? 14:23:05 * nikhil done 14:23:26 all good points, it'd be probably worth discussing those on the spec as soon as it shows up 14:23:28 thanks 14:23:40 #topic https://review.openstack.org/#/c/228559/ (rosmaita) 14:23:41 As we are still waiting on lite-specs I was keeping an eye on some of the stuff like this. (waiting on lite-specs discussion to begin) :P 14:24:01 nikhil: speaking of that, I've some material for next drivers meeting :P 14:24:05 * flaper87 gets back on topic 14:24:09 rosmaita: floor is yours 14:24:10 flaper87: nice! 14:24:24 rosmaita: stop playing with the dashboard 14:24:26 :P 14:24:29 sorry 14:24:36 my comment is on the agenda 14:24:50 which i hav ejust lost 14:24:56 rosmaita: that's a really good raise 14:25:06 https://review.openstack.org/#/c/228559/ (rosmaita) - this is a fix so that 'deactivated' images cannot be downloaded by non-admin users. The discussion on the patch is that the only circumstances under which Glance should allow an image to be downloaded are: (1) image status is 'active' (all users), or (2) image status is 'deactivated' (admin users only). I think this makes sense, but think it's worth pointing this out to the wider Glance 14:25:13 I think this sort of overlaps with the re-upload to error state a bit. 14:25:28 Yeah 14:25:59 like i said, i don't have a particular problem in mind, but thought it was worth pointing out 14:26:01 I agree w/ rosmaita on the reasoning about when an image should be able to be downloaded 14:26:07 rosmaita: ++ 14:26:22 rosmaita: iiuc that fix is so deactivated images can be downloaded by admin user 14:26:41 jokke_: yup 14:26:44 possibly defining what happens on certain image-loc statuses 14:26:50 jokke_: well, i think that was the bug, but the patch is evolving to be a bit more restrictive 14:26:50 ah no sorry 14:27:02 mixed with the previous one around that topic 14:27:09 So the big change is previously only active images could be downloaded by anyone? There's nothing jumping out at me that it's a problem 14:27:35 there is a mistake - should be 'not req.contex.is_admin' 14:27:37 i think the prob is the admin restriction 14:27:44 mfedosin: I totally agree 14:27:59 rosmaita: problem in what sense? 14:28:03 mfedosin: good eye! 14:28:05 mfedosin: good catch 14:28:14 mfedosin: please add to the review comments ;) 14:28:27 jokke_, already 14:28:43 well, we should backport this if it merges, thoughts? 14:28:49 my totally agree was for mclaren not to mfedosin ;) 14:29:19 mclaren: i think previously admin could download any state, e.g., pending_delete ? 14:29:20 lol :) 14:29:52 rosmaita: ah, thanks 14:29:54 rosmaita: then it looks like a breaking change 14:29:55 why is the bug targeted to glanceclient ? 14:29:57 rosmaita: and I think that's fine as well ... admin should be able to 14:29:59 prob a mistake 14:30:31 jokke_: well, sabari pointed out that since there's an external scrubber, a pending_delete image could be scrubbed while you were trying to download 14:30:35 IIUC, rosmaita said that the patch is evolving into something more restrictive, which means we can't backport it 14:31:14 giving 1 more minute to this discussion. We can follow up on the review as well 14:31:31 I think it's a race condition issues that we should solve by locking mechanisms and not adding restrictions to the API 14:31:36 issue* 14:31:47 hmm an image could transition to pending_delete and get scrubbed if it started as active (during download) 14:31:48 that's all from me, please put comments on the patch 14:32:04 or even delete 14:32:19 mclaren: good point 14:32:21 or it could be d/l from cache while deleted from backend too 14:32:29 sorry for changing topics, I'd like us to go through the agenda and this looks like something we can follow-up on the review 14:32:31 thanks rosmaita 14:32:37 yeah and that's end user facing, not just admin who has control over that scrubber as well if needed 14:32:40 so, I think this stuff is impl detail and not API detail 14:32:43 I guess download of pending delete is a gray area. I'm not overly concerned about it tbh. 14:32:52 #topic Mitaka summit sessions (flaper87) 14:33:04 #link https://etherpad.openstack.org/p/mitaka-glance-summit-topics 14:33:14 There's no much there, yet! 14:33:32 I've added a placeholder for the upload process discussion and put rosmaita name there 14:33:39 but, we should start adding more topics 14:33:51 I think it was nikhil that mentioned a pre-summit brainstorm 14:33:51 the nova v2 stuff? 14:33:57 yes 14:33:59 nikhil: do you want to elaborate? 14:34:03 flaper87: sure 14:34:20 mclaren: That's going to be a cross-project session, AFAIK. If not, it'll be a nova session. 14:34:29 mclaren: but it's a great topic and we should discuss it 14:34:31 ++ 14:34:37 so, I think a lot of fuzziness exists on what's going around with the upload path, what are the possible priorities and summit topics for Tokyo 14:34:43 oh, ok. As long as it's not forgotten 14:35:20 And I find it useful to be prepared with concise thoughts around each topic that we plan to discuss as that usually means, it's going to show up on the priority and be implemented for cycle 14:35:22 I hope there will be at least one about artifacts 14:35:40 sort of makes me feel like having a productive discussion on each topic 14:35:41 IMHO the priorities are the upload reload and the v2 nova/cinder stuff. 14:35:58 so 14:35:59 define the scope of implementation and the project universe (To think about) 14:36:01 flaper87: if the session only affects 2 projects, we try to put it in one of their tracks, so either nova or glance should host the session for the v2 work 14:36:24 mclaren: ++ 14:36:29 dhellmann: yeah, I thought that would be the case 14:36:34 dhellmann: so, nova it is 14:36:44 I've talked w/ johnthetubaguy already about this 14:36:48 flaper87: great 14:36:49 right, johnthetubaguy ? 14:36:50 :P 14:37:09 Sorry if I fail to understand if nothing else is likely to go? 14:37:11 so, I think it'd be super useful to have a clear list of what the summit will look like before the summit 14:37:39 I'd also like to encourage folks to write specs for their sessions as that helps having more useful conversations 14:37:58 I think we can decide based on the topics that are proposed whether a pre-summit brainstorm would be useful or not 14:38:11 flaper87: does the v2 stuff also affect cinder? if it affects cinder and nova should it be a glance session. (Not super important either way) 14:38:20 mclaren: yes 14:38:27 flaper87: it would be super useful to know what else we can fit on our bowl after those two ... so how much the Nova migration will be this team's problem and how much work wil be needed for that upload stuff for DefCore 14:38:59 mclaren: it affects ciner but there's lot to do in nova and it could use more nova folks in the room 14:39:06 so, I'd probably vote for doing a nova session 14:39:10 ok, whatever works 14:39:40 flaper87: ++ I think the topic need Nova attention 14:39:55 jokke_: yup, I think we'll be able to tell more once we have some draft for the specs written down. As in, there's lot to do on both sides. The Nova work is being split between both teams, which is super great. 14:40:14 The upload work is us in terms of implementation but it requires collaboration with the overall community as well 14:40:28 which brings me to the next topic, which will hopefully answer nikhil's question 14:40:39 (unless there's something else people want to add here) 14:40:41 sure 14:40:53 While upload is super important, I think we can still work on download, members, metadef improvements 14:41:08 not sure how much is in the bucket for those, but that can come in the priority list too. 14:41:23 sure, but if everything's a priority nothing is ... 14:41:30 mclaren: ++ 14:41:33 ok, next topic 14:41:36 #topic Glance Priorities list (i.e: http://specs.openstack.org/openstack/nova-specs/priorities/liberty-priorities.html ) 14:41:40 BAM! 14:41:45 sooooooooo 14:41:53 mclaren: how would you define a priority heirarchy? 14:42:05 v2 affects horizon FYI. 14:42:12 one thing I think we as a team have failed to communicate internally and upstream is our priorities 14:42:12 nikhil: not sure 14:42:24 We've had etherpads and other things but no official process 14:42:44 I dug a bit into how nova handles this and they use what it's called "nova-priorities-list" 14:42:53 I'd like the glance team to do the same 14:42:57 TL;DR: 14:43:00 swift have this (review centric) https://wiki.openstack.org/wiki/Swift/PriorityReviews 14:43:18 The team agrees on what the priorities for the cycle are and puts extra efforts on that 14:43:33 I'm not going to get into the hows/whys of the workflow in this meeting 14:43:35 BUT 14:43:43 I'd love to get feedback from everyone 14:43:58 This list of priorities does not mean that things that aren't there won't land 14:44:04 Can we define things we must get done in the cycle? 14:44:13 mclaren: ++ 14:44:16 heat has an etherpad with priority review and they discuss progress on it every week during the meeting 14:44:16 ++ 14:44:16 It means that: 1) Things in that list are top-prio for reviews, patches, etch! 14:44:39 so would it be enough for glance? 14:44:40 It also helps providing feedback for the rest of the community 14:44:53 and to provide a clear view of what glance mitaka will look like 14:45:10 mclaren: I think we should do that when we start defining that list 14:45:16 Nova uses a full session for that 14:45:35 and I'd like to have a pre-summit meeting about that 14:45:44 ok. 14:45:50 so that we go to the summit wit ha clear view and we can also prioritize topics based on that 14:46:06 If that makes sense, I'll schedule some time during the next meeting for this 14:46:14 So that people can start preparing topics 14:46:19 +1 14:46:24 I think the community will be watching closely on the upload/v2 stuff over the cycle. 14:46:34 Note that this conversation will take some time, which means next meeting will be mostly abou this 14:46:49 flaper87: may be write a review against glance-specs repo? 14:47:10 nikhil: yup, that's how nova does it and I'd like us to follow that pattern 14:47:23 I'll prepare the first draft 14:47:26 * nikhil ack 14:47:28 the priorities are recorded as a spec? 14:47:35 we can start commenting on it and complete it next week 14:47:37 mclaren: yes 14:47:43 sounds good I think 14:47:46 mclaren: Glance Priorities list (i.e: http://specs.openstack.org/openstack/nova-specs/priorities/liberty-priorities.html ) 14:47:54 thanks 14:47:54 nova does not accept any specs after milestone 1 and it will be submitted as backlog 14:48:05 mclaren: it's there, public and we can link to it to inform people and te overall community 14:48:15 and be held accountable to :-) 14:48:16 abhishekk: that brings me to the next topic :P 14:48:18 #link https://github.com/openstack/nova-specs/tree/master/priorities 14:48:24 :) 14:48:25 mclaren: ++ 14:48:47 #action flaper87 to write the draft for mitaka glance priorities 14:49:27 Actually, I'll let the next topic for next week, I'd like to leave time for open discussions since there are some reviews requests 14:49:45 #topic Open Discussion 14:49:59 https://review.openstack.org/#/c/221307/ (lakshmiS, TravT) 14:50:13 flaper87, what is the weather in Japan? :) 14:50:21 did we cover that one? 14:50:23 This is the patch we agreed not to backport to RC2 14:50:38 flaper87: thanks for one round of reviews on that. I think lakshmiS has addressed your set of comments 14:50:44 mclaren: yup, but it'd be great to review it so it lands in early mitaka and Searchlight can link to it 14:50:46 mclaren: yes 14:50:51 TravT: awesome! 14:50:54 mfedosin: Rainy 14:50:56 :D 14:50:56 ack 14:51:00 we have a patch sitting in our queue for searchlight liberty actually that can listen to these notifications. 14:51:22 It'd be great to get one extra pair of eyes on that one 14:51:32 and looking for reviews as soon as possible 14:51:39 it's adding new notifications for members and there's a contract related to that one 14:51:45 of particular interest is the notifications names and content 14:51:51 As in, it's a public format that needs to be supported 14:52:10 * flaper87 's wording is terrible today 14:52:19 Glance store exceptions: https://bugs.launchpad.net/glance-store/+bug/1501443 14:52:19 Launchpad bug 1501443 in glance_store "glance_store exceptions trigger child exceptions (which break Glance's error handling)" [Undecided,Opinion] 14:52:24 mclaren: jokke_ is that yours ^ ? 14:52:26 that's me 14:52:28 since the names and content represent the API, basically 14:52:31 mclaren: shoot 14:52:39 flaper87: I take no credit on that 14:52:45 TravT: ++ 14:52:49 So it look's to me like a lot of our exception handling doesn't work 14:53:04 But I'm interested to know of someone else could confirm, I may be seeing things 14:53:08 of/if 14:53:24 flaper87, nikhil : I plan to use glance as a demo of a new release note management tool we're rolling out for the liberty stable releases. I'll ping you when those patches are ready. 14:53:43 dhellmann: awesome, thanks! 14:53:49 mclaren, I wrote a fix for that 14:53:50 dhellmann: add me to the list ;) 14:53:56 jokke_: ack 14:54:04 mfedosin: I think I have that change 14:54:06 dhellmann: sounds intriguing! Would love to learn more.. 14:54:10 mclaren: I don't think you're seeing things but I'm curious to know how you hit that 14:54:25 https://review.openstack.org/#/c/202083/ 14:54:26 testing an upcoming policy fix 14:54:33 mclaren: ah-ha. gotcha 14:55:04 I think there's something fishy in there 14:55:11 mfedosin: ah, I can check if my version of the store has that -- thanks 14:55:17 it's probably related to the old store code being migrated to the library 14:55:24 which basically means it's my fault 14:55:25 mfedosin, mclaren: I thought I had seen fix for that! 14:55:26 :P 14:55:38 mfedosin: is that in a released version of the store? 14:55:41 mclaren: that fix has not merged yet 14:55:46 not merged 14:55:54 mclaren, no, it's still on review 14:56:22 well that explains it! 14:56:27 I don't recall how big/invasive the fix is but it may even be good backport material 14:56:40 flaper87: looks like so 14:56:45 flaper87: yes I agree if feasible 14:56:52 there'll be a lot of 500s otherwise 14:57:07 if you want I can update the commit message 14:57:09 mclaren: :( 14:57:10 mfedosin: I'll test that out and review, thanks again 14:57:17 flaper87: now when we have bug fir it :P 14:57:24 jokke_: ++ 14:57:37 mclaren, you're welcome 14:58:08 Anything else? Anyone? 14:58:18 Who's going to attend the summit? 14:58:30 o/ 14:58:32 o/ 14:58:42 o/ 14:58:44 o/ 14:58:44 o/ 14:58:56 nnnnnnnnnnnnnnice! 14:58:57 jokke_: ? 14:59:02 o/ 14:59:05 rc2 might be out soon (fyi) 14:59:09 nikhil: rosmaita ? 14:59:18 o/ 14:59:23 o/ 14:59:27 nikhil: good news, thanks! 14:59:44 hope it's the last RC 14:59:46 :D 14:59:57 it's prolly not 14:59:58 nikhil: I think it is out ... I saw the config bug moving from committed to released 15:00:04 We should all give Glance-rc2 a crazy test session as soon as it's out 15:00:14 weird, wonder why I did not get a ping back 15:00:19 ++ 15:00:31 lakshmiS: I am removing the liberty tag from https://bugs.launchpad.net/glance/+bug/1441453 15:00:31 Launchpad bug 1441453 in Glance "Image members CRUD doesn't generate notifications which impacts searchlight RBAC." [High,In progress] - Assigned to Lakshmi N Sampath (lakshmi-sampath) 15:00:42 6min before meeting started 15:00:55 flaper87: that'w what we agreed, correct me if I am wrong 15:01:11 nikhil: we agreed that! 15:01:15 ty 15:01:17 no liberty, full mitaka 15:01:23 and we ran out of time! 15:01:28 Thanks everyone for attending 15:01:31 #endmeeting