14:06:52 #startmeeting Glance 14:06:57 Meeting started Thu Nov 26 14:06:52 2015 UTC and is due to finish in 60 minutes. The chair is flaper87. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:06:59 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:07:00 w00000h000000000000000 14:07:00 \o/ 14:07:01 The meeting name has been set to 'glance' 14:07:03 \\o \o/ o// o/7 14:07:08 #topic Agenda 14:07:15 #link https://etherpad.openstack.org/p/glance-team-meeting-agenda 14:07:28 As usual, that's the link to our, very dynamic, agenda 14:07:39 #topic Next week is Mitaka-1: FIIIIIIRE FIIIIIIRE FIIIIIIIRE (flaper87) 14:07:53 Just want to give everyone a heads up that next week is the M-1 cut off 14:08:01 Few notes on that 14:08:19 It'd be great to focus our reviews a bit more on bug fixes for the rest of this week and next one 14:08:27 Look out for failures and gate stability 14:08:47 It should be painless since that's normally the csae for the first milestone of th ecycle 14:08:56 however, we know Murphy and we all hate him 14:09:08 I'll let everyone know when the cut is done 14:09:33 Also, if you're part of the bug triage team, we could use some help triaging bugs and targeting to the right milestone 14:09:42 especially for bugs that have patches that had already landed 14:09:58 That's all from me 14:10:05 Are there questions? comments? feedback? 14:10:13 also feel free to tag with backport-candidate for anything you think could be backported 14:10:17 thanks 14:10:26 Jokke_: ++ 14:10:44 ooooooooooooooooooooooooook, moving on 14:10:54 #topic Bug report and review process (flaper87) 14:11:30 I've seen several cases (not going to point fingers on anyone) of bugs being reported and patches being proposed 2 seconds after the bug goes public 14:11:45 while I'm very happy to see this and it's super cool to have patches fixing bugs 14:12:13 this is causing an issue from a bug triage perspective as those bugs are basically being self-triaged 14:12:27 It's happened that these very same bugs are the ones that land w/ a milestone proposed 14:12:54 Since I don't want to tell people to not propose patches (that would be insane), I'm now calling out reviewers on this 14:13:06 Please, do not blindly approve patches w/ reviewing the bug 14:13:24 if a bug doesn't have a milestone set, please, ping me or any of the drivers 14:13:49 The bug should also have an importance set as that's what is also being used as a criteria for backports 14:14:05 and, if the bug never went from New -> triaged/confirmed then please, try to verify the bug 14:14:10 +1 14:14:39 (I found one reviewing) 14:14:44 and do not set the importance apart from wishlist (feature request) if you can verify it 14:14:54 can't even 14:14:59 Bugs that go from New -> In progress are the ones that haven't been verified and we need to have second tests to avoid approving bug fixes for things that may be a misconfiguration 14:15:12 right! 14:15:17 ok, that's it from me 14:15:28 I hope I didn't come off harsh and that the rant didn't offend anyone 14:15:35 I do like all this bugs+patches 14:15:50 but I hope you can understand the impact that has from a release/management perspective 14:15:58 closed bug is the best kind of bug 14:15:59 so this is about setting milestone, importance etc rather than the act of fileling a bug and submitting a patch at the same time? 14:16:03 the core of this is don't merge unconfirmed bugs? 14:16:06 for clarification 14:16:29 mclaren: kragniz don't merge unconrimed/untriaged/untargeted bugs 14:16:35 that's the TL;DR 14:16:39 cool 14:16:55 unconfirmed even 14:17:02 so mark confirmed, set the target, then merge? 14:17:31 if the bug is "In Progress" changing the status would break the process so, I'd recommend commenting with a confirmation 14:17:38 well sometimes people don't set the importance but confirm it on comments and I think that's fine 14:18:37 glance bug team is open to public and mirco-managing would be tricky 14:18:39 ok, anything else? feedback? yells? concerns? 14:18:49 nikhil_k: ++ 14:19:04 flaper87: sounds good to me 14:19:22 Reviewer's *must* click on the bug link and read through before approving patches :) 14:19:26 Reviewers 14:19:28 ok 14:19:29 moving on 14:19:39 #topic python-glanceclient 1.2.0 and 1.1.2(?) released 14:19:42 Jokke_: ^? 14:19:45 I guess that's you 14:20:06 yeah, Noticed that it wasn't in our meeting agenda so must have slipped 14:20:35 yup 14:20:44 we did tag releases on master and I'm just trying to check irt was either from kilo or Liberty where we tagged release as well ... that was days ago and gates looking good 14:20:59 yeah, we announced that last week 14:21:02 didn't we? 14:21:10 0.17.3 14:21:13 that's kilo 14:21:35 k sorry for spam then 14:21:41 no worries 14:21:46 #topic Glance_store 0.10.0 release requested probably either today or early next week 14:21:50 and the next is mine as well 14:21:50 ok, that one is new for sure 14:21:53 :D 14:21:57 so glance_store going out 14:22:00 keep eyes open 14:22:06 major note 14:22:32 store configs under [DEFAULT] got removed after deprecation 14:22:52 w000h000000 14:22:53 Jokke_: shouldn't that really bump the major version? 14:22:53 so might cause some unexpected. That's in the release highlight as well as in the release notes 14:23:02 Jokke_: thanks for handling the release 14:23:05 (assuming we're following semver) 14:23:25 kragniz: we are under 0.* still 14:23:30 if it is needed it will be caught prior to release 14:23:34 flaper87: I guess so 14:23:37 I mean, in theory it should but the library is not considered stable yet 14:23:39 kragniz: I was wondering that as well 14:23:49 That's how I feel about it, at least 14:23:50 :P 14:24:17 not sure what others think 14:24:17 flaper87: yeah, makes sense 14:24:37 kragniz: but like Flavio said and minor version was expected by others 14:24:51 I think if this breaks stuff we may need to release 6.0.0 like pip :P 14:24:59 LOL 14:25:02 Oh this most probably does not happen today but next week due to thanks giving I doubt dhellmann is around to answer on this either ;) 14:25:16 right 14:25:18 if we're still planning the large glance_store api refactor, it's a lot easier to keep it under 0.* 14:25:29 I'm fine with 0.10.0 14:25:33 kragniz: ++ 14:25:37 I believe that's still planned, I saw the spc up again 14:25:40 some day we get there 14:25:43 he's in eu somewhere, somone ask him in person :P 14:25:58 okidoki, moving on 14:26:04 #topic Community Feedback 14:26:14 This is not a really long topic but more of an open question 14:26:50 I'm on a mission of gathering feedback from folks in the Glance community about.. well... Glance. I'll likely ping you on IRC looking for this info 14:26:58 Somethings I'd love to hear from you all are: 14:27:11 1. How do you feel about the Glance community? 14:27:17 2. What would you like to change? 14:27:31 3. What's your impression about the reviews rate, feedback, etc? 14:27:46 4. What areas of Glance itself would you like to improve next? 14:27:54 And whatever comes to your mind 14:28:04 Feel free to share them in openstack-glance or in private 14:28:12 I'd love to get that feedback from you all 14:28:17 and it won't take you long 14:28:19 :D 14:28:24 it's all for the best, I promise 14:28:31 we need to have our own foundation :P (jk) 14:28:31 * flaper87 does his evil laugh 14:28:48 * flaper87 votes for nikhil_k to the board 14:29:02 That's it! 14:29:12 Please, share your thoughts. I'm looking forward to them 14:29:47 Also, feel free to rant and complain about patches, bugs and anything else 14:29:48 :D 14:29:52 #topic Reviews, Bugs 14:29:58 Adding 'docker' as container_format https://review.openstack.org/249282 (mclaren) 14:30:07 that's me 14:30:40 I guess this is a fairly binary "do we want this or not". It's kind of a one line change at heart. 14:30:48 what do folks feel about this? 14:31:11 I don't mind having it, tbh. 14:31:20 I do have some questions that I'd like to raise on the bug/review 14:31:30 and I'd like to understand where nikhil_k was coming from 14:31:44 nikhil_k: where were you coming from? :-) 14:31:45 Why is that a question? (asking seriously not rhetorically) 14:31:58 I'd like to have it and enable the nova-docker team to work without needing to add it to configs every time. But I'd really like to hear where all that fuzz came from? 14:32:02 I'm going to be honest, I don't quite get the amount of pushback this change is getting 14:32:18 as I said, I don't see any problems with that 14:32:31 tbh it was more noise than pushback imho 14:32:33 kragniz: it's not really a pushback. I think the only think that was asked was to follow a bit of a process 14:32:38 my request was to have a lite-spec 14:32:44 flaper87: exactly 14:32:46 just to have a way to track it 14:32:56 mclaren, flaper87: I think -2 is pretty clear pushback, not noise ;P 14:33:09 and I remember we discussing that like Nova is it's API affecting change it needs a full spec 14:33:14 Jokke_: wait, I requested the -2 on IRC. It's my fault for not doing it myself 14:33:24 Jokke_: actually, yes. noise and pushback 14:33:27 the reason I requested it is the same reason I just talked about proper bug triage 14:33:45 because I was afraid it'd have been merged without a propre triage 14:33:49 I guess one thing to bear in mind is that I don't think the reviewer got a clear idea of what we wanted. Did we communicate what a lite-spec is? 14:33:51 nikhil_k: it's not API affecting change 14:34:00 and I feel that calling it a `pushback` is noise now 14:34:13 mclaren: we can't because the docs for that haven't been reviewed *hint* *hint* 14:34:33 we don't add APIImpact on every image-create and image-delete call because those changes the output of image-get and image-list :P 14:34:44 so we requested a lite spec which isn't a thing yet? 14:34:52 mclaren: it is a thing 14:34:58 the docs haven't been merged 14:35:05 we've talked about it in glance drivers meetings several times 14:35:14 and we have several bugs filed as lite-specs 14:35:23 So, again 14:35:31 if the schema changes and can potentially break clients it's a API change Jokke_ 14:35:41 I don't think there was a pushback on the feature, there was just a request for some process 14:35:50 Should we have used -1 instead of -2? probably 14:35:52 nikhil_k: break client? 14:35:57 the schema API call will be different (look at my comment) 14:36:04 flaper87: Ok. I'm just not sure Dave was left with a super clear path forward. 14:36:04 Could this have been communicated better to the committer? Sure, I agree 14:36:18 mclaren: I agree with that 14:36:23 nikhil_k: schema won't change 14:36:52 So I will review the lite-spec to help out here. And we can reference that in future. Problem solved! 14:37:11 mclaren: thank you :D 14:37:16 nikhil_k: IIRC last time we were fighting with the schema issues we made sure that clanceclient does not use cached schemas, so that should not be the case ;) 14:37:22 mclaren: disclaimer: you'll have to deal with my english 14:37:23 hahahaha 14:37:25 flaper87: okay, that clarifies it 14:37:38 Porque no es en Espanol? 14:37:56 Jokke_: kragniz mfedosin mclaren FWIW, the technical discussion we're having here is awesome and I'd like this to be reflected on the bug! 14:38:05 mfedosin: the schema should change based on the different accepted values 14:38:21 Otherwise we'll have lengthy discussions burried in IRC logs and no comments on the lite-spec, which we should use to discuss proposals 14:38:23 :D 14:38:27 I think container_type is one of the things delivered there 14:38:46 mclaren: lol, I mean, I could. That'd be way easier 14:38:47 :D 14:38:49 flaper87: I add link to the logs after the meeting :P 14:39:03 Jokke_: ah yes, you're right 14:39:09 Entonces, cambiamos? lol 14:39:10 Jokke_: sounds great. Or copy/paste the convo removing the parts not related 14:39:31 should we rather have this meeting in spanish? 14:39:59 Mita jos kaikki vaan kaytetaan omaa aidinkieltamme? :P 14:40:02 ok, I hope it's clear that no one is rejecting the feautre. 14:40:14 I'll comment on the review and apologize for the lack of proper communication and support 14:40:19 someone's keyboard is broken 14:40:25 flaper87: we still need to conclude on this API change -- breaking or otherwsie 14:41:01 so container_format is configurable 14:41:02 nikhil_k: yes! Fully agree. I'll read through your comments and the discussion you and Jokke_ just had 14:41:08 and I will get in touch with Drew in one of our mtgs 14:41:31 flaper87: ok, thanks. I will move my -2 back to -1 14:41:39 so existing deployments can return customized json 14:41:49 ie add whatever formats they like 14:42:03 I guess my question is 'is this an api change?' 14:42:18 also, bare in mind that we'll have a version bump in mitaka anyway because of the import process changes 14:42:21 If it is, DefCore is so going to love us 14:43:08 I doubt it if it will affect defcore 14:43:17 the whole thing is so far in the future and undecided 14:43:19 flaper87: I forget the process. Do we have two bumps for each new thing, or a bump for a few things in a cycle? 14:43:33 kragniz: 1 bump for few things 14:43:34 ideally the same patch 14:43:40 flaper87: cool 14:43:40 kragniz: bump for each release where something bumpworthy has merged 14:43:51 * flaper87 likes bumpworthy 14:43:57 but since we do milestone based releases it's okay to do before the official release 14:43:58 ok, lets give time to other topics 14:44:14 Spec-lite https://bugs.launchpad.net/python-glanceclient/+bug/1489534 (bunting) 14:44:14 Launchpad bug 1489534 in python-glanceclient "Move metadef commands to sub-commands" [Wishlist,In progress] - Assigned to Niall Bunting (niall-bunting) 14:44:19 Thats me 14:44:37 Just bring this spec lite into the light for moving metadefs into a subset of commands 14:44:46 bunting: coolio, thanks 14:44:48 Since i guess spec lites can easily get hidden 14:45:06 so, the spec-lite process says that the drivers team will review spec-lites during the drivers meeting 14:45:09 flaper87: anyone sourcing the master HEAD for CI/CD will have breaking changes in their repo (if that's something cared for) (imdone) 14:45:20 question, I think I have raised before, why only metadefs? 14:45:32 There's a query we use to list those lite specs and review them 14:45:42 but thanks for bringing it up here too 14:45:49 flaper87: Ah okay, did'nt know that 14:45:50 Jokke_: because there's a lot of them 14:45:51 * flaper87 needs to chase people to get the process reviewed 14:45:55 bunting: not your fault, really 14:45:56 kragniz: ++ 14:45:58 Jokke_: because there's so many md commands -- have you looked at the v2 help? They kind of spam everything else 14:46:28 my current feeling about that is that we should either do it for everything or not doing it. 14:46:30 AS Brian said, it makes glance look like a metadata service with some extra image related bits 14:46:43 if you look at `neutron --help` you'll get a huge list of commands 14:46:47 where really most folks think of it the other way around 14:46:54 but I need to look into this a bit better 14:46:57 flaper87: yes, but they're all networking related 14:47:03 mclaren: right 14:47:13 flaper87: I don't think we want to change general usage of the client 14:47:26 otherwise we might as well just tell people to use osc 14:47:28 kragniz: agreed but this change is a breaking change 14:47:37 I mean, we can proxy the old way to the new way 14:47:40 kragniz: it's backwards compatible 14:47:49 I'm all up for subcommanding stuff, but I do agree that it would make sense to do it once for all then 14:47:51 but it'll require a major release to completely remove the old one 14:48:04 it's fully backwards compatible 14:48:09 flaper87: that's true, but md-* are far less likely to be used by some end user 14:48:19 flaper87: that's the beauty of it, all the old ones works while they don't show up 14:48:30 kragniz: assume makes an A** between U and ME 14:48:43 :D 14:49:01 so are doing some redirect or something? 14:49:14 won't the CLI change (backward incompat)? 14:49:17 I'm not opposed to it, I just shout my first thought 14:49:26 nikhil_k: https://review.openstack.org/#/c/218864/ 14:49:30 nikhil_k: the old commands are staying there, just suppressed form help 14:49:46 nikhil_k: Thats the link 14:49:50 and I guess we need to keep in mind to remove those on the next major 14:49:51 making it super easy to transform 14:50:01 flaper87: or not ;) 14:50:13 Jokke_: the old ones 14:50:18 ah, nice trick. So suppressed is fine w/o deprecation (clarification needed)? 14:50:21 the current trend seems to be bloat all so we can just leave them there 14:50:31 mmh, I don't like having 2 ways of doing things 14:50:31 flaper87: ok 14:50:46 if we can do redirects , that would be ideal 14:50:53 we have two apis, I thought it was a requirement! 14:51:03 mclaren: ++ :) 14:51:05 loooooooooooooooooooooooooool 14:51:08 (or in bash semantics it would be alias) 14:51:10 mclaren: :D 14:51:16 nice one 14:51:24 sad but true 14:51:28 ok 14:51:33 remember ... never remove anything 14:51:49 bunting: thanks for link 14:51:49 maybe we just remove the suppressions on next major :P 14:51:56 Jokke_: well, lets not go crazy extreme with that 14:52:06 anyway 14:52:10 #topic Open Discussion 14:52:25 Happy thanksgiving to everyone who celebrates it 14:52:35 hope your holidays will be awesome 14:52:40 Can i just ask what mk-1 actually is for? 14:52:57 bunting: mk-1 ? mitaka-1 ? 14:53:07 * mclaren can't find the lite-spec review :-/ 14:53:11 that's the first milestone in the Mitaka release 14:53:14 right back atchya 14:53:15 mikita-1 14:53:20 What is it used for? 14:53:36 gtg, thanks everyone 14:53:39 just a release milestone, I don't think it has a proper "goal" 14:53:43 There are 3 milesotnes per release 14:53:47 have a fun rest of week/end. 14:53:50 there's -1, -2 and -3 14:54:05 That allows teams for planning based on the release schedule 14:54:09 mainly for tracking progress and enabling teams to target specific changes to milestones 14:54:20 Targeting bug fixes, cutting points were there have been things done, etc 14:54:23 there is also tarball generated out of them for testing purposes 14:54:33 mclaren: https://review.openstack.org/#/c/234653/ 14:54:37 #link https://review.openstack.org/#/c/234653/ 14:54:41 flaper87: thank you! 14:54:49 mclaren: no no no, thank you :D 14:54:52 cheers, just wondering 14:54:53 actually, I take that back 14:54:58 I'll thank you based on your review 14:55:34 bunting: think it as long sprint in the agile format 14:55:59 btw, if you ping me on IRC to provide feedback about the community and I'm not around, feel free to drop me an email and or dump everything on IRC. I have a bouncer 14:56:33 okidoki 14:56:37 * Jokke_ starts planning to dump everything to flaper87's bouncer 14:56:47 great meeting everyone, enjoy your weekend and have fun! 14:56:50 Jokke_: >.> 14:56:55 thanks flaper87 14:56:56 as a late psa it seems kilo has a broken gate 14:57:06 bunting: ceph ? 14:57:08 the glance_store ? 14:57:14 yes ceph I think 14:57:27 Anyone know if they're actively looking? 14:57:31 #link https://review.openstack.org/#/c/250368/ 14:57:33 #link https://review.openstack.org/#/c/250368/ 14:57:35 I am 14:57:37 #undo 14:57:41 wupf 14:58:17 ok, we're done 14:58:19 thanks everyone 14:58:23 Thanks everyone 14:58:25 #endmeeting