14:00:20 <rosmaita> #startmeeting glance 14:00:21 <openstack> Meeting started Thu Jun 22 14:00:20 2017 UTC and is due to finish in 60 minutes. The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:00:22 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:00:26 <openstack> The meeting name has been set to 'glance' 14:00:30 <rosmaita> #topic roll call 14:00:44 <smcginnis> o/ 14:00:48 <jokke_> o/ 14:00:54 <abhishekk_> 0/ 14:00:59 * smcginnis is here until they call my boarding group 14:01:07 <rosmaita> that's dedication! 14:01:10 <smcginnis> Hah 14:01:16 <rosmaita> have a safe flight 14:01:35 <smcginnis> Thanks, this ones a shorter one so shouldn't be too bad. 14:01:54 <rosmaita> looks like we have a quorum 14:01:56 <rosmaita> #link https://etherpad.openstack.org/p/glance-team-meeting-agenda 14:02:22 <rosmaita> #topic updates - congratulations Abhishek 14:02:33 <rosmaita> i'd like to welcome our newest glance core 14:02:46 <smcginnis> abhishekk_: Congrats! 14:02:46 <mfedosin> o/ 14:02:47 <abhishekk_> Thank you all for your support 14:02:59 <jokke_> welcome \o/ 14:03:06 <abhishekk_> I will justify my selection 14:03:25 <rosmaita> i'm not worried, i'm happy you've agreed to serve 14:04:00 <rosmaita> ok, on the other hand, Fei Long Wang has indicated that he doesn't have much time to devote to glance currently 14:04:09 <mfedosin> abhishekk_: I join in congratulations! 14:04:11 <abhishekk_> jokke_: rosmaita: thank you, need your guidance as well :) 14:04:19 <rosmaita> #link http://lists.openstack.org/pipermail/openstack-dev/2017-June/118599.html 14:04:29 <abhishekk_> mfedosin: thanka 14:04:36 <rosmaita> sorry, i should be more patient and let everyone congratulate abhishekk_ 14:05:15 <rosmaita> anyway, abhishekk_ , you have a lot of glance knowledge, are a long-time contributor, and i'm glad to see you on the glance core list 14:05:32 <abhishekk_> I think we should proceed quickly to help sean :) 14:05:53 <smcginnis> Nah, don't worry about me. Thank you though. :) 14:06:13 <rosmaita> smcginnis: you have been doing a lot of helpful reviews recently, thank you 14:06:28 <smcginnis> rosmaita: No problem, glad to be able to help out. 14:06:33 <rosmaita> ok, i'll talk about fei long in item 2 on the agenda 14:06:36 <rosmaita> one last update 14:06:39 <abhishekk_> right, smcginnis thank you too 14:06:51 <rosmaita> #topic updates - metadefs changes 14:07:08 <rosmaita> every cycle we get a few metadefs changes 14:07:22 <rosmaita> to make it easy, i'm proposing that we just have one release note about metadefs 14:07:41 <rosmaita> that way, a metadefs patch can just also patch that releasenote 14:07:49 <rosmaita> and we won't have a whole bunch of these things 14:07:58 <rosmaita> just want you to be aware of that plan 14:08:05 <rosmaita> and here's the first one: 14:08:17 <rosmaita> #link https://review.openstack.org/476522 14:08:58 <rosmaita> i guess one last update 14:09:09 <rosmaita> #topic updates - glance specs 14:09:30 <rosmaita> there are 2 specs that jesse proposed that were really well worked out, but they are languishing 14:09:47 <rosmaita> the multihash in particular would be a good item for a new contributor to get into 14:10:10 <rosmaita> anyway, i'm going to amend jesse's patches to move them to the new 'untargeted' 14:10:13 <rosmaita> directory 14:10:41 <jokke_> ++ 14:10:51 <rosmaita> just a heads-up to look for those so we can get them +A'd and ready in case some new people come on board 14:11:07 <rosmaita> that's all the updates from me 14:11:35 <rosmaita> #topic Flavio's proposal for emergency provisional cores 14:11:49 <rosmaita> here's a link to the relevant part of the email thread 14:12:02 <rosmaita> #link http://lists.openstack.org/pipermail/openstack-dev/2017-June/118281.html 14:12:19 <rosmaita> two things here that are on my mind right now 14:12:36 <rosmaita> 1 - do we accept fei long's resignation from core? 14:12:50 <rosmaita> 2 - what is the general feeling in the community about provisional cores? 14:13:11 <mfedosin> 1 - if he wants, we can't hold him 14:13:14 <rosmaita> i can't answer either of those, so i need some input from you all 14:13:35 <smcginnis> mfedosin: That's my thought on 1. 14:13:38 <abhishekk_> mfedosin: ++ 14:13:44 <rosmaita> mfedosin: what i mean is that we can leave hiim on the list, so when he does occasionally have time, he can +2 stuff 14:14:04 <smcginnis> Ah, no harm in that I guess. 14:14:05 <rosmaita> or, we can remove him until such time as he says he has time 14:14:45 <mfedosin> he can put +1 any time he wants, what's the problem in that? 14:15:29 <rosmaita> well, the problem is that flavio is proposing people that ordinarily would not be considered as glance cores yet to be given +2 powers 14:15:47 <rosmaita> and here is a guy who we are saying can give +1s 14:15:48 <mfedosin> I think the main responsibility of cores is to review features - anyone can put +2A on typo fix 14:15:58 <jokke_> I'm with Mike on this. Is there specific reason to keep people on the list? Like Fei Long said himself it just gives wrong image of our current situation 14:17:07 <mfedosin> I think Fei won't review features and big patches, so I think there is no reason to keep him 14:17:32 <rosmaita> ok, sounds reasonable 14:17:41 <jokke_> So I would see how we are doing now when we have Mike back and Abhishek on board 14:17:46 <rosmaita> let's move on to #2 14:17:54 <mfedosin> if he wants to return we will add him in the list again without any objections 14:17:57 <abhishekk_> And in future we can add him back again 14:18:13 <rosmaita> abhishekk_: good point 14:18:39 <rosmaita> ok, i will reply to his message accepting his resignation and thanking him for his service 14:19:15 <rosmaita> jokke_: was your comment about mike and abhishek being available addressed to #2? 14:19:56 <jokke_> rosmaita: yeah and the first as well 14:20:35 <rosmaita> so do we want to hold off on flavio's idea for a week or two? 14:20:37 <jokke_> somewhat 14:21:08 <smcginnis> It does seem the situation has improved somewhat from when flavio proposed that. 14:21:13 <rosmaita> i should say here that i think smcginnis is contributing solid reviews, and i appreciate the time he's devoting to glance 14:21:24 <smcginnis> rosmaita: Thanks! 14:21:33 <rosmaita> smcginnis: just want that to be clear 14:21:42 <smcginnis> :) 14:21:46 <rosmaita> my hesitation isn't about you, it's about the idea of "provisional 14:21:49 <rosmaita> " cores 14:21:58 <smcginnis> rosmaita: Yeah, don't worry. Totally get it. 14:21:59 <rosmaita> not sure it's a good precedent 14:22:03 <smcginnis> I'm fine either way really. 14:22:04 <rosmaita> thanks! 14:22:30 <jokke_> well Mike has been doing lots of good reviews lately, lets see how we are doing now when Abhishek is picking up part of the load and let the situation stabilize and see where we're at 14:22:56 <jokke_> smcginnis: indeed, thanks for stepping in 14:23:02 <rosmaita> that sounds good to me ... mike, abhishekk_ any comments? 14:23:12 <smcginnis> Glad to help. Sounds like a good plan jokke_ 14:23:22 <mfedosin> smcginnis: I'm happy to have you in the team too 14:23:34 <abhishekk_> Sounds good to me as well 14:24:06 <rosmaita> smcginnis: and to be clear, you are doing all the stuff we'd expect from a potential core 14:24:18 <rosmaita> it's just that we'd ordinarily wait a bit longer 14:25:06 <rosmaita> ok, so to summarize: 14:25:09 <smcginnis> rosmaita: Cool. I do plan on sticking around as long as I'm useful. 14:25:38 <rosmaita> 1 - we appreciate the good work smcginnis is doing and encourage him to continue 14:25:50 <rosmaita> 2 - we will hold off on the "provisional 14:26:11 <rosmaita> " core idea for a week or two to see what the situation is 14:26:30 <rosmaita> any other comments? 14:26:43 <smcginnis> +1 14:26:54 <abhishekk_> agree 14:26:56 <mfedosin> +2 14:27:46 <rosmaita> cool 14:28:10 <rosmaita> mfedosin: thank you for your work on the wsgi community goal reviews 14:28:44 <rosmaita> let's talk priorities for this week 14:28:54 <rosmaita> #topic priorities for the coming week 14:29:13 <rosmaita> jokke_: do you have image import stuff that needs review? 14:29:29 <smcginnis> Sorry, about to board. I just wanted to point out I added a "review dashboard" link to the Glance wiki. 14:29:36 <smcginnis> I've found it useful for other projects. 14:29:48 <smcginnis> In particular, there's a section of reviews waiting for final +2A. 14:29:54 <smcginnis> Sorry to interupt the topic. 14:30:10 <rosmaita> smcginnis: that's a good interruption! 14:30:17 <smcginnis> :) 14:30:23 <smcginnis> Gotta drop off now. Thanks! 14:30:56 <abhishekk_> smcginnis: thank you 14:31:05 <rosmaita> smcginnis: happy journey 14:31:07 <jokke_> rosmaita: not now ... I've spent more time this week on reviewing than writing 14:31:14 <jokke_> smcginnis: safe travels 14:31:50 <rosmaita> boy that glance wiki page could use some updating 14:31:59 <rosmaita> #link https://wiki.openstack.org/wiki/Glance 14:32:02 <jokke_> picking up my part of that review load as well ;) 14:32:28 <rosmaita> jokke_: understandable 14:32:33 <rosmaita> thanks for keeping things moving 14:33:26 <rosmaita> are there any particular things on people's minds that need attention this week? 14:34:28 <abhishekk_> doc-migration patches, how urgent they are? 14:35:10 <rosmaita> we should probably clear them out 14:35:31 <abhishekk_> Ok 14:36:02 <rosmaita> i'll go through them after the meeting 14:36:14 <jokke_> There has been lots of gate failures on them 14:36:16 <rosmaita> i don't think there's anything controversial, just stuff to look at 14:36:24 <rosmaita> jokke_: that is not good 14:36:26 <jokke_> I haven't looked too much why 14:36:52 <rosmaita> there was a weird gate failure on ian's patch, a pep8 thing 14:37:09 <rosmaita> other patches weren't having that problem, so i rebased ian's patch 14:37:31 <jokke_> dhellmann has been coming up with new revisions and turning them green bit by bit so I've been looking when they stabilize 14:37:44 <rosmaita> it's a metadefs problem completely unrelated to ian's change 14:37:55 <jokke_> rosmaita: yeah saw that and I was wondering as well were it came from 14:38:08 <rosmaita> ok, i will commit to watching dhellmann's patches too 14:38:37 <rosmaita> jokke_: i checked the pip freeze output, flake8 and pep8 versions match passing runs 14:38:47 <rosmaita> i was hoping something was simply out of date 14:40:11 <rosmaita> ok, let's open the floor 14:40:16 <rosmaita> #topic open discussion 14:41:33 <jokke_> rosmaita: just wanted to point out 14:42:57 <jokke_> have been pushing back removing the translation functions. We discussed it briefly when you were away and thought it's better not to refactor every single line of logging at this point when we're already stretched with reviews 14:46:16 <rosmaita> i thought i saw a patch for making _ a no-op or something like that? 14:47:01 <jokke_> yes _L* 14:47:11 <rosmaita> right, that's what i meant 14:47:46 <jokke_> that way we avoided to refactor all logging and not be breaking if someone suddenly decides to remove those 14:48:27 <jokke_> on the same change the hacking rules were removed so we can move away from using those gradually 14:49:28 <rosmaita> well, the downside is that they'll have to be removed eventually 14:49:45 <rosmaita> or, we can require that log messages still use them to keep the codebase consistent 14:50:37 <rosmaita> i'm thinking maybe what we should've done was make them no-ops but keep the hacking checks 14:50:53 <rosmaita> for when they get restored 14:50:54 <jokke_> that 14:51:26 <dhellmann> those doc patches won't land until the spec is approved, and I think the number of depends-on is part of why I'm seeing compaints from zuul 14:51:56 <rosmaita> dhellmann: thanks 14:52:17 <jokke_> dhellmann: thanks for the heads up. Long dependency chains are always "fun" 14:52:22 <dhellmann> right 14:52:41 <dhellmann> the spec approval is scheduled for the next couple of days, after we give ptls more time to +1 (thanks rosmaita for doing that already) 14:52:51 <rosmaita> dhellmann: do you have an opinion on the logging situation, that is, eliminating the _L* from the codebase? 14:52:53 <dhellmann> so we should be unclogging the tubes by the middle of next week 14:53:19 <dhellmann> I think the general sense on that was to go ahead and do it if you wanted, but it isn't pressing 14:53:35 <dhellmann> so it could be done all at once to avoid lots of rebasing, or it could be done as follow-up patches as other files are touched 14:53:48 <dhellmann> is that what you were looking for? 14:54:49 <jokke_> I think it makes our lives easier if that's not yet another "needs priority now" case 14:55:05 <dhellmann> oh, it's definitely not that 14:56:04 <dhellmann> some teams wanted to rip it out to avoid confusion, but I expect it to linger for a while 14:56:49 <rosmaita> it's kind of a distraction we don't need atm, but i dont' know that waiting is a good idea either 14:57:27 <dhellmann> if you have 11 things on the priority list, I would put this somewhere around #20 14:58:39 <rosmaita> ok, just about out of time ... any last comments from anyone? 14:59:00 <abhishekk_> no 14:59:12 <dhellmann> thanks for keeping an eye on those doc patches, folks 14:59:26 <rosmaita> ok, well, congratulations abhishek and happy reviewing! 14:59:35 <abhishekk_> Thank you :) 14:59:37 <rosmaita> thanks everyone! 14:59:41 <rosmaita> #endmeeting