14:00:02 <abhishekk> #startmeeting glance 14:00:02 <opendevmeet> Meeting started Thu Feb 3 14:00:02 2022 UTC and is due to finish in 60 minutes. The chair is abhishekk. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:00:02 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:00:02 <opendevmeet> The meeting name has been set to 'glance' 14:00:05 <abhishekk> #topic roll call 14:00:17 <abhishekk> #link https://etherpad.openstack.org/p/glance-team-meeting-agenda 14:00:23 <abhishekk> o/ 14:00:30 <rosmaita> o/ 14:00:48 <abhishekk> Lets wait couple of minutes for others 14:01:06 <jokke_> o/ 14:01:47 <abhishekk> Small agenda, lets start and finish this early 14:01:58 <jokke_> ++ 14:02:00 <abhishekk> #topic release/periodic jobs update 14:02:10 <abhishekk> Milestone-3 3 weeks from now 14:02:23 <abhishekk> Possible targets for M3 14:02:24 <abhishekk> Cache API 14:02:24 <abhishekk> Stores detail API 14:02:24 <abhishekk> Unified limits usage API 14:02:24 <abhishekk> Append existing metadef tags 14:03:05 <abhishekk> We are good for non client release, nothing is pending from store side 14:03:17 <abhishekk> Periodic jobs all green 14:03:58 <abhishekk> #topic Review priorities this week 14:04:17 <abhishekk> This week we have two feature reviews on priority list 14:04:32 <abhishekk> cache api work 14:04:35 <abhishekk> #link https://review.opendev.org/q/topic:bp%252Fcache-api 14:04:48 <abhishekk> All patches are listed here 14:05:11 <abhishekk> we also have a tempest coverage to verify that we can cache image on different glance node 14:05:26 <abhishekk> 2nd on priority list is 14:05:27 <abhishekk> Unified limits usage API 14:05:43 <abhishekk> #link https://review.opendev.org/q/topic:bp/glance-unified-quotas+status:open 14:05:54 <abhishekk> Just two patches, one for API and one for client 14:06:07 <abhishekk> Kindly put some time in reviewing above patches 14:06:20 <abhishekk> That's all for today 14:06:26 <abhishekk> #topic Open discussion 14:06:33 <abhishekk> Glance db migration constant check 14:06:44 <abhishekk> I have put a WIP patch to modify this check 14:06:51 <abhishekk> #link https://review.opendev.org/c/openstack/glance/+/827587 14:07:03 <jokke_> kk I'll try to give another round on the cache 14:07:08 <abhishekk> This will work if release version is less than current release 14:07:14 <abhishekk> cool, thank you 14:07:40 <abhishekk> and will pass if release name is equal to or next release 14:08:00 <abhishekk> means it will work if version is xena, yoga or z 14:08:17 <abhishekk> but will break if it is wallaby and less 14:08:36 <abhishekk> Other than this I am not able to think of better way to tackle this 14:09:50 <jokke_> need to look into that unless rosmaita feels it still fulfils it's purpose ... kind of feels by your description that it's kind of not doing the check why that test was introduced 14:10:29 <rosmaita> looking at your patch now 14:10:38 <abhishekk> there is a readme file in tests/gate repo to explain what is it doing 14:11:00 <abhishekk> * glance/tests/gate repo 14:11:09 <abhishekk> rosmaita, thanks 14:12:08 <abhishekk> jokke_, Before my change it was givng error if release is > or < x 14:13:13 <rosmaita> yeah, the problem with this is that what happens is: test is passing fine, next release is cut (or SemVer patch is landed), test breaks, fix the code ... wait for next release 14:13:31 <jokke_> yeh, the whole point was to ensure it was correct for the migrations being recognized, 14:13:48 <abhishekk> yeah 14:13:50 <rosmaita> so the test doesn't break until the release is cut, but before the release happens, it will fail if we fix it early 14:13:58 <jokke_> rosmaita: yeah kind of just forcing us to do what we do now but cycle later? 14:14:10 <jokke_> ah 14:14:12 <jokke_> ok 14:14:56 <jokke_> so can we make the test pass on milestone release but break if the latest tag is anything else (like RC)? 14:14:59 <abhishekk> also we need to find out how we should use this logic post 'z' 14:15:12 <rosmaita> abhishekk: ++++++++++ 14:15:15 <jokke_> that way it will not block the gate on milestones but makes sure we do update it before final 14:16:13 <abhishekk> I have hackish logic in mind :D 14:16:17 <rosmaita> yeah, i think it only pays attention to the major version number 14:16:25 <abhishekk> yes 14:16:51 <rosmaita> jokke_: i think you are right, maybe only look for the b1 suffix or rc1 14:17:34 <rosmaita> we'll have the same situation though that the test will only break after the release 14:17:48 <abhishekk> yep 14:17:54 <jokke_> rosmaita: that's what I'm thinking ... that way we still need to do the change like before but we don't jam the gate right on first milestone tag 14:17:56 <rosmaita> and if we wait for rc1, then we will definitely have an rc2 14:18:13 <jokke_> as it gets the version from pbr which updates when the tag hits the repo 14:18:51 <rosmaita> well, we can force the version change with a patch that has a 'SemVer' tag in the commit message 14:19:01 <rosmaita> without actually doing a release 14:19:27 <rosmaita> it's still manual, we land the semver patch, then have to land the constant change patch 14:19:32 <rosmaita> but we could do it at any time 14:19:47 <rosmaita> i can't figure out how to do this simultaneously 14:20:06 <abhishekk> yeah 14:20:13 <rosmaita> smcginnis would be good to ask about this 14:20:15 <jokke_> I don't think you can as pbr looks what's merged in the repo 14:20:32 <rosmaita> when he was release ptl, he put up the SemVer patches 14:20:40 <rosmaita> i dont think Elod does that anymore 14:21:54 <abhishekk> I am not able to see any patches recently doing it 14:22:17 <rosmaita> i am trying to remember where i saw docs about this, it was recent, but i can't remember what i was looking for 14:23:25 <abhishekk> Ok, I will also keep digging for it 14:23:35 <abhishekk> anything else you guys have to put here? 14:23:49 <jokke_> not me 14:24:05 <rosmaita> hang on 14:24:59 <abhishekk> ack 14:25:49 <rosmaita> https://review.opendev.org/c/openstack/glance/+/809404 14:27:30 <abhishekk> ok 14:27:34 <rosmaita> so ... looks like it didn't work 14:27:40 <jokke_> ooh yeah there was that ... the renos rendered weird too 14:28:35 <rosmaita> in glance master i see: 14:28:35 <rosmaita> [master] wha'ppen? python setup.py --version 14:28:35 <rosmaita> 23.1.0.dev40 14:28:46 <rosmaita> and 23.x is the xena series 14:28:52 <abhishekk> yes 14:30:04 <rosmaita> same thing in cinder, python setup.py --version is giving me xena series (19.x) 14:30:49 <abhishekk> because cinder also haven't tagged anything yet 14:31:10 <rosmaita> right, but i think we had the Sem-Ver thing also 14:31:29 <abhishekk> aah, got it 14:31:32 <rosmaita> give me the action item to ask about this at the release team meeting tomorrow 14:31:40 <rosmaita> it's 1400 utc 14:31:48 <rosmaita> i don't mind going 14:32:02 <abhishekk> if you do, please 14:32:19 <abhishekk> because I will not be around tomorrow :( 14:32:37 <rosmaita> np, i will also ask if they have a better idea for how to do this test 14:32:52 <abhishekk> great, thank you 14:33:12 <abhishekk> I think we should call it now 14:33:27 <abhishekk> thank you rosmaita and jokke_ 14:33:39 <jokke_> sure np 14:33:47 <jokke_> thanks 14:33:49 <rosmaita> have a good day all 14:33:49 <abhishekk> have a nice weekend!! 14:34:01 <abhishekk> #endmeeting