13:59:36 <pdeore> #startmeeting glance
13:59:36 <opendevmeet> Meeting started Thu Apr 20 13:59:36 2023 UTC and is due to finish in 60 minutes.  The chair is pdeore. Information about MeetBot at http://wiki.debian.org/MeetBot.
13:59:36 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
13:59:36 <opendevmeet> The meeting name has been set to 'glance'
13:59:36 <pdeore> #topic roll call
13:59:36 <pdeore> #link https://etherpad.openstack.org/p/glance-team-meeting-agenda
13:59:40 <pdeore> o/
13:59:43 <mrjoshi> o/
14:00:45 <pdeore> we have very short agenda for today, let's wait for few mins for others to join
14:00:48 <dansmith> o/
14:01:51 <pdeore> let's start, others may join in between :)
14:01:56 <pdeore> #topic release/periodic jobs updates
14:02:07 <pdeore> M1 is 3 weeks away from now
14:02:25 <pdeore> Periodic job all green except failure on some functional py38 tests may be due to castellan version conflict
14:02:33 <pdeore> #link https://5e09181bcc1a50499619-17764b56a5c622705c872e3c7dca2597.ssl.cf2.rackcdn.com/periodic/opendev.org/openstack/glance/master/glance-tox-functional-py38-cursive-tips/32bbbc2/tox/functional-py38/functional-py38-siblings.txt
14:02:50 <pdeore> Not exactly sure but seems that castellan failure might be bcz of moving py3.8 support to py3.10
14:02:56 <pdeore> #link https://review.opendev.org/c/openstack/castellan/+/879932
14:03:22 <pdeore> so do we need to move these periodic jobs to py3.10 ?
14:03:43 <croelandt> Py3.8 sounds like a thing of the past to me :)
14:03:50 <pdeore> #link https://review.opendev.org/c/openstack/governance/+/872232
14:03:52 <dansmith> 3.8 is in focal yeah?
14:03:54 <croelandt> but I think people still use 3.8
14:04:00 <pdeore> As per this, within 2023.2 python version 3.9 and 3.10 are the supported python runtimes
14:04:15 <croelandt> pdeore: oh that is a good point
14:05:11 <dansmith> yeah, was just looking for that because I couldn't remember if we dropped focal yet
14:05:53 <pdeore> yeah it's in focal
14:06:45 <dansmith> right, so nova is only running 39 and 310 now
14:07:33 <pdeore> ohk ok, so can we move these jobs to py310?
14:08:02 <dansmith> actually, nova has a 38 functional job, but I'm not sure why
14:08:36 <dansmith> but yeah the governance patch means you don't *have* to test 3.8 anymore, so if something is broken there specifically, we can drop it
14:09:22 <croelandt> If it's a setup issue, that should not really affect distros either, right?
14:09:35 <croelandt> as they'll be using their own packages rather than recreating virtual envs
14:10:44 <dansmith> I'm not really seeing *why* castellan is breaking on 38 though, but if it's confirmed it did something to break support (like using importlib.resources or something) then it makes sense to move on
14:11:58 <croelandt> on master, python_requires is now set to >=3.9
14:12:10 <croelandt> in setup.cfg
14:12:32 <croelandt> I'm not sure whether that is actually enforced by setuptools, but it shows they won't try to support 3.8 anymore anyway
14:13:05 <dansmith> master castellan right?
14:13:11 <dansmith> that might be why it's just failing to install then yeah
14:13:26 <dansmith> and yeah, it will be enforced, AFAIK, I just expected a better error message :)
14:13:50 <croelandt> master castellan, yes
14:14:00 <croelandt> dansmith: yeah I've given up on error messages being useful :-(
14:15:07 <pdeore> yeah exactly
14:15:16 <croelandt> So, let's move to py310?
14:15:38 <pdeore> yeah doesn't seem any other option for now :)
14:16:37 <croelandt> It's settled then
14:17:36 <pdeore> it would be nice if other members would also ack on this :)
14:17:50 <abhishekk> what about our default jobs in tox should we drop py38 from there as well?
14:19:03 <croelandt> We might want to keep unit tests as some distros are lagging behind (Debian cough cough)
14:19:18 <pdeore> I think thats what other projects have done ?
14:19:24 <croelandt> but functional tests 1) are a pain to debug 2) will require installing a lot more stuff (like castellan)
14:20:38 <abhishekk> Ideally we should move
14:21:14 <croelandt> +1
14:21:14 <abhishekk> I think rosmaita already submitted one patch, https://review.opendev.org/c/openstack/glance/+/880685
14:22:27 <pdeore> can we move these py38 job to 310 in the same patch then ?
14:22:30 <dansmith> ah yep, that's the patch we need
14:22:48 <abhishekk> pdeore, no that should be different one
14:22:51 <dansmith> although it kept 38 fips
14:23:01 <croelandt> do we get rid of all the 38 tests?
14:23:09 <dansmith> oh and several others
14:23:15 <dansmith> hmm, I wonder why he didn't convert those
14:23:35 <dansmith> ah fips requires 38 still, in the commit message
14:23:36 <croelandt> well Brian's patch is keeping functional-38 though
14:23:39 <abhishekk> he just moved functional tests
14:24:13 <dansmith> right but there are other 38 functional jobs that can probably go
14:24:14 <croelandt> oh but the functional-38 is only local ok
14:24:23 <dansmith> functional-py38-glance_store-tips for example
14:24:39 <abhishekk> ack
14:24:42 <croelandt> dansmith: do you wish to review his patch and suggest a second patchset?
14:24:43 <dansmith> oh are those defined in glance_store?
14:25:26 <dansmith> I think we should just approve this and follow up with more
14:25:41 <abhishekk> I am just confused, with his patch
14:25:58 <dansmith> unless it will fail on the job that requires castellan now?
14:26:08 <abhishekk> what is the difference between line 45~47 and 49 onwards
14:26:37 <abhishekk> if I run tox -e functional-py39 it will refer line 46 or 56?
14:27:05 <croelandt> hm
14:27:08 <dansmith> 45
14:27:13 <croelandt> functional-py39 and functional-py39-rbac are not the same thing
14:27:15 <dansmith> 55 is the rbac
14:27:17 <dansmith> right
14:27:35 <abhishekk> hmm, dumb me :/
14:27:53 <abhishekk> we can define similar for rbac as well and reduce some lines :D
14:27:58 <croelandt> I kind of like the patch, but I think dansmith wants more agressive cleaning up
14:28:15 <croelandt> abhishekk: right
14:28:19 <croelandt> this would be good feedback
14:28:55 <abhishekk> yep anyone can add that feedback
14:29:22 <dansmith> croelandt: no, I said we should merge this now and follow up with more :)
14:29:53 <dansmith> the cleanup is not relevant to the actual work of the patch though, which is to change the jobs in zuul
14:30:09 <dansmith> which requires the 311 to be added, which is why he's converting the existing functional targets to the pattern
14:30:29 <croelandt> ok ok
14:30:40 <dansmith> if we're going to convert the rbac 38 to 311 as well, then sure, but I'm just saying, we might as well iterate and get this going, IMHO
14:30:53 <abhishekk> works either way for me
14:31:09 * dansmith +2d
14:31:28 <croelandt> +2+1d
14:31:51 <abhishekk> cool, just remember someone has to work on migrating other tests as well
14:31:59 <pdeore> ack
14:33:13 <pdeore> croelandt, is it possible for you to submit the patch ? otherwise I will start that tmrw morning :)
14:33:42 <croelandt> for rbac 38->311, yes
14:33:57 <pdeore> ok
14:34:16 <pdeore> let's move ahead
14:34:20 <pdeore> #topic Specs
14:34:47 <pdeore> there are few specs up for review, so kindly have a look
14:34:55 <pdeore> #link https://review.opendev.org/c/openstack/glance-specs/+/880627
14:35:21 <pdeore> I have reproposed the image encryption spec to the current cycle
14:35:41 <pdeore> I have also submitted bobcat project priorities
14:35:42 <pdeore> #link https://review.opendev.org/c/openstack/glance-specs/+/880637
14:36:07 <pdeore> moving ahead
14:36:11 <pdeore> #topic Important Bugs
14:36:24 <pdeore> croelandt, ^
14:36:40 <croelandt> yep
14:36:51 <croelandt> so the glanceclient gate is blocked
14:37:01 <croelandt> if we could merge this https://review.opendev.org/c/openstack/python-glanceclient/+/880765 that would be great
14:37:04 <croelandt> some tox4 magic I guess
14:37:36 <croelandt> Then the glance-download plugin does not work well in the glanceclient, because we're trying to get attributes with invalid names
14:37:39 <croelandt> see https://review.opendev.org/c/openstack/python-glanceclient/+/880696
14:38:00 <croelandt> there is a follow-up patch that I don't really like, but sent to get input from the bug reporter, I'll try to rework this ASAP
14:40:01 <pdeore> ohh ok
14:40:52 <pdeore> so this skipsdist thing we have already removed from glance
14:40:56 <croelandt> and glance_store, yes
14:41:05 <pdeore> yeah
14:41:06 * croelandt has given up on understanding the underlying details
14:41:27 * croelandt is shoving up code in there, pushing it with his boots until it works
14:42:26 <pdeore> ohk let's wait for the reporter to test it
14:42:54 <croelandt> yeah the first patch is defintily good
14:43:04 <croelandt> getattr(x, 'foo-bar') cannot work
14:43:09 <croelandt> since 'foo-bar' is not a valid attribute
14:43:27 <croelandt> --foo-bar is converted to "foo_bar" by argparse
14:44:52 <pdeore> not sure how it missed while implementing this :/
14:45:00 <croelandt> other than that, there were a few bugs on Launchpad with not enough info so I'm not gonna bother you with this :)
14:45:03 <croelandt> yeah it happens
14:45:39 <pdeore> cool, let's move to open discussions then :)
14:45:46 <pdeore> #topic Open Discussions
14:46:15 <pdeore> Artem has added abhishekk & croelandt into the openstacksdk-service-core group
14:46:58 <croelandt> \o/
14:46:58 <pdeore> so yeah that's it from me for today
14:47:03 * croelandt has nothing more
14:47:10 <abhishekk> added?
14:47:19 <pdeore> #link https://review.opendev.org/admin/groups/33c03b5e000a75ffc476c51d484c5111648d399c,members
14:47:21 <pdeore> yes
14:47:35 <pdeore> I thought you must have got that notification
14:47:36 <abhishekk> ack
14:48:15 <pdeore> ok, let's conclude for today then :)
14:48:20 <abhishekk> Wait
14:48:27 <pdeore> ohh
14:48:33 <abhishekk> I had something
14:48:41 <pdeore> yeah plz go ahead
14:48:48 <abhishekk> any update from the author which added new proposal last week?
14:49:13 <abhishekk> whether he is going to work on it or not
14:49:20 <pdeore> no updates yet
14:49:48 <abhishekk> also cyril is working on migrating rbac jobs,so periodic jobs will be still pending
14:50:11 <abhishekk> ack, I guess you can try to reach him by mail if no reply till next week
14:50:39 <pdeore> yeah that I will start working on tmrw
14:50:47 <abhishekk> AND, last is there is slight change in new Location API work, rajat will submit the spec
14:50:52 <pdeore> yeah I will try to ping him
14:50:59 <abhishekk> so all reviewers please kindly have a look at it
14:51:11 <abhishekk> done from me
14:51:27 <pdeore> he has not yet updated the spec
14:51:52 <abhishekk> he will submit the updated spec
14:51:58 <pdeore> ahh missed that :/
14:52:00 <pdeore> cool
14:52:12 <pdeore> let's wrap up then
14:52:26 <pdeore> Thanks evryone for joining
14:52:52 <pdeore> #endmeeting