13:59:28 <pdeore> #startmeeting glance
13:59:28 <opendevmeet> Meeting started Thu Jun 15 13:59:28 2023 UTC and is due to finish in 60 minutes.  The chair is pdeore. Information about MeetBot at http://wiki.debian.org/MeetBot.
13:59:28 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
13:59:28 <opendevmeet> The meeting name has been set to 'glance'
13:59:28 <pdeore> #topic roll call
13:59:28 <pdeore> #link https://etherpad.openstack.org/p/glance-team-meeting-agenda
13:59:35 <pdeore> o/
13:59:52 <dansmith> o/
14:00:21 <abhishekk> o/
14:00:39 <abhishekk> rosmaita will be in summit so might not be aorund
14:00:40 <pdeore> rosmaita is in PTG & mrjoshi is on leave today so only 4 of us would be there
14:00:44 <pdeore> yeah
14:00:50 <pdeore> shall we start
14:01:22 <croeland1> yes
14:01:27 <pdeore> cool
14:01:29 <pdeore> #topic release/periodic jobs updates
14:01:37 <pdeore> M2 is 3 weeks from now
14:01:54 <pdeore> Periodic jobs are all green
14:02:18 <pdeore> moving to next
14:02:22 <pdeore> #topic RBD deferred deletion
14:02:48 <pdeore> Not sure if eharney has got a chance to work on this, i have pinged him, waiting for his reply
14:03:11 <abhishekk> he also might be in summit
14:03:15 <pdeore> I think if he has not started working on the spec yet someone from glance team will have to work on the spec based on the poc submitted since we have a very short time left for spec freeze deadline ..
14:03:21 <pdeore> ohh
14:04:16 <pdeore> so i think we should submit the spec
14:05:13 <abhishekk> I will not be able to help here, have some other work to address
14:05:16 <pdeore> abhishekk, croeland1 is it possible for you to work on this? I'm already engaged in the location api work, so not sure if it's possible for me to work on spec this week
14:05:28 <pdeore> abhishekk, ack
14:05:41 <croeland1> where's the POC again?
14:05:50 <pdeore> #link https://review.opendev.org/c/openstack/glance_store/+/884524
14:06:29 <dansmith> seems like a pretty minor thing.. is a spec really required?
14:06:54 <dansmith> as far as glance is concerned the image is gone/deleted like normal, we just told rbd to do it later and then we're no longer involved right?
14:07:57 <pdeore> yeah, but not even a spec lite ?
14:08:00 <croeland1> even the periodical purge is not on us
14:08:50 <dansmith> spec-lite at the most, but honestly, it feels like it could be just code and docs
14:08:55 <dansmith> and a reno
14:09:13 <dansmith> the PTL should decide, but just MHO :)
14:09:52 <pdeore> yeah that's right, if everyone agrees then let's skip it :D
14:11:02 <croeland1> yeah a bit ridiculous to write the spec after the fact :)
14:11:11 <dansmith> I can try to do some poking at it locally and make sure it's getting run against our big ceph multistore job
14:11:34 <pdeore> dansmith, ack
14:11:42 <dansmith> what does abhishekk think?
14:11:44 <pdeore> abhishekk, what do you think ?
14:12:00 <abhishekk> I think we already have a bug for it
14:12:38 <abhishekk> https://review.opendev.org/c/openstack/glance_store/+/885595
14:12:51 <abhishekk> https://launchpad.net/bugs/1954883
14:13:12 <abhishekk> we can add related-fix or related-bug tag
14:14:09 <pdeore> ok cool
14:15:04 <abhishekk> We need to get weight and rbd patch in so that we can release the store library
14:15:39 <croeland1> so did we decide to do weight and drop the previous location strategy?
14:15:54 <dansmith> yeah, I'll try to test this rbd trash patch this week and vote on it
14:16:09 <pdeore> croeland1, that's  our next topic :)
14:16:11 <dansmith> so maybe we can get those merged and released next week
14:16:22 <abhishekk> we can work on weight and then drop location strategy when we can remove single store support
14:16:32 <abhishekk> dansmith, ++
14:16:52 <pdeore> ack
14:17:27 <pdeore> abhishekk, we need to abandon the new location strategy spec ?
14:17:43 <abhishekk> I will abandon it when weight spec merges
14:17:55 <pdeore> ack
14:18:02 <dansmith> I just +2d that again
14:18:45 <abhishekk> cool
14:20:17 <pdeore> the next topic was about discussing these 2 specs only
14:20:32 <pdeore> so let's move to the important bugs if any
14:20:43 <pdeore> #topic Important Bugs ?
14:20:49 <pdeore> croeland1, ?
14:21:45 <abhishekk> #link https://launchpad.net/bugs/1916482
14:22:09 <croeland1> I noticed glance image-create --property min_ram=123 does not work, but that's not critical :)
14:22:15 <croeland1> Been there for a while I think
14:23:38 <abhishekk> you can pass --min-ram directly
14:23:54 <dansmith> does not work as in .. doesn't get set or doesn't get honored?
14:24:15 <croeland1> as in glanceclient returns an error message :)
14:24:31 <abhishekk> https://paste.opendev.org/show/bWwn7qzX3RIlDq291b02/
14:24:32 <croeland1> abhishekk: oh I did not know that
14:24:50 <dansmith> min-ram vs min_ram ?
14:25:16 <croeland1> dansmith: https://review.opendev.org/c/openstack/python-glanceclient/+/858757
14:25:22 <croeland1> dansmith: it's specific to --property
14:25:38 <dansmith> ah
14:28:17 <abhishekk> why to use --property min_ram if client has support to provide --min-ram ?
14:28:52 <croeland1> why provide --property if it does not work? :)
14:29:12 <abhishekk> didn't understood
14:30:33 <croeland1> If it's legal to use --property min_ram=123
14:30:38 <croeland1> then users should be able to do it
14:30:49 <croeland1> or we should remove it and only use the shorter version "--min-ram"
14:31:44 <abhishekk> I think --property is used for additional properties only
14:32:22 <croeland1> so do you use a JSON schema for those?
14:33:02 <abhishekk> I think glance internally uses it
14:33:49 <croeland1> but if it's for a custom property
14:33:54 <croeland1> you need to give the schema somehow, right?
14:34:47 <abhishekk> I don't think so
14:35:43 <croeland1> oh ok indeed
14:35:53 <croeland1> just tried with --property foo=123l
14:36:22 <abhishekk> it will work
14:36:43 <croeland1> yeah it does
14:36:52 <croeland1> because there is no schema specifying types
14:37:23 <abhishekk> yes
14:38:13 <dansmith> while ya'll were arguing about min_ram, I tested the trash patch locally and it looks good to me: https://review.opendev.org/c/openstack/glance_store/+/884524
14:38:32 <dansmith> I think eharney is busy, so I can update the log line and add a reno for him if you think that's appropriate
14:38:51 <abhishekk> superdan :D
14:39:00 <abhishekk> ++
14:39:05 <pdeore> dansmith, Thanks !! :D
14:40:25 <pdeore> so are we good with using --min-ram instead of passing it in property ? :)
14:41:18 <pdeore> #1916482 this one has a patch up already, so need reviews
14:42:08 <abhishekk> yes
14:42:30 <croeland1> pdeore: feels like a bit of an issue to me, even though --min-ram works as well
14:42:36 <pdeore> shall we move to open discussions if we are done with the BZs ?
14:43:13 <pdeore> croeland1, hmm .. we can discuss more about this on glance channel
14:43:27 <pdeore> let's move to open discussions :)
14:43:29 <pdeore> #topic Open Discussions
14:43:45 <croeland1> yeah :)
14:43:48 <croeland1> not critical anyway
14:43:54 <pdeore> yeah :)
14:44:20 <pdeore> anyone has anything else to discuss ? or we are good to wrap up ?
14:44:53 <abhishekk> nothing from me, when will be the next review party?
14:45:15 <pdeore> 29th ?
14:45:17 <abhishekk> I think we should have some patches up for review though :D
14:45:37 <abhishekk> 29th is holiday for us
14:45:44 <pdeore> ohh is it?
14:45:57 <pdeore> i didn't check that :P
14:46:09 <abhishekk> pls confirm
14:46:37 <pdeore> yes it's holiday
14:46:49 <pdeore> can we have review party on 28th then ?
14:47:14 <pdeore> croeland1, ?
14:47:28 <pdeore> till then we might have some patches for review :P
14:47:55 <croeland1> pdeore: sure
14:48:00 <pdeore> cool :)
14:48:46 <pdeore> ok, let's conclude for the day
14:48:55 <pdeore> Thanks everyone for joining !!
14:49:01 <abhishekk> thanks!
14:49:02 <pdeore> see you next week !
14:49:16 <pdeore> #endmeeting