15:00:58 <mfedosin> #startmeeting glare
15:00:59 <openstack> Meeting started Tue May 23 15:00:58 2017 UTC and is due to finish in 60 minutes.  The chair is mfedosin. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:01:00 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:01:03 <openstack> The meeting name has been set to 'glare'
15:01:08 <mfedosin> #topic agenda
15:01:21 <mfedosin> #link https://etherpad.openstack.org/p/glare-meeting-agenda
15:01:39 <mfedosin> #topic updates
15:02:08 <mfedosin> I think today we may have a short meeting
15:02:44 <inarotzk> I think also
15:02:45 <mfedosin> we've discussed all important topics recently
15:03:00 <mfedosin> okay, agree :)
15:03:12 <mfedosin> my update is:
15:03:45 <mfedosin> I implemented several new unit-tests
15:04:00 <mfedosin> some of them are already merged
15:04:12 <mfedosin> https://review.openstack.org/#/q/project:openstack/glare+status:merged
15:04:59 <mfedosin> a couple is still on review
15:05:02 <mfedosin> #link https://review.openstack.org/#/c/466300/
15:05:15 <mfedosin> #link https://review.openstack.org/#/c/465744/
15:06:07 <mfedosin> I addressed inarotzk's comments in 'fault' middleware patch
15:06:29 <mfedosin> inarotzk: if you have time, review them please
15:07:01 <mfedosin> Also I reviewed code and merged several patches
15:07:13 <mfedosin> that's all :)
15:07:26 <mfedosin> inarotzk: do you have any update?
15:07:28 <inarotzk> yes, i was actually reviewing fault middleware before the meeting :)
15:08:24 <mfedosin> great!
15:08:42 <inarotzk> yes, i addressed mfedosin's comments with new patch - https://review.openstack.org/#/c/466803/
15:09:59 <mfedosin> btw, I'm reviewing it now
15:10:06 <mfedosin> this patch looks good
15:10:12 <inarotzk> :)
15:11:13 <mfedosin> also, we merged yours sorting tests
15:11:15 <mfedosin> finally :)
15:11:59 <inarotzk> oh ,right
15:12:35 <mfedosin> okay, that's good
15:12:44 <mfedosin> now we can define plans for next week
15:13:02 <mfedosin> #topic tests and coverage
15:13:21 <mfedosin> I measured our coverage before this meeting...
15:13:49 <mfedosin> It's slightly below than I expected
15:13:54 <mfedosin> near 78%
15:14:16 <mfedosin> I hoped we would be able to reach 80%
15:14:44 <mfedosin> but unfortunately I couldn't finish tests for links before the meeting
15:15:11 <mfedosin> but they are almost done and I'll upload them today
15:15:23 <inarotzk> oh cool :)
15:16:03 <mfedosin> Also I promised that we will get 90% next week
15:16:39 <mfedosin> so we need to cover 400 loc
15:16:53 <mfedosin> which is hard, but doable
15:17:18 <mfedosin> inarotzk: your tests for common utils are really handy in this case
15:18:07 <inarotzk> I would like to discuss regarding the future unit tests  for common utils
15:18:27 <mfedosin> yes, sure
15:19:29 <inarotzk> There are a few functions , that you suggested to take. And i want us to split this task in the best way :)
15:20:06 <mfedosin> you can take only those functions you like
15:20:18 <inarotzk> LoL
15:20:27 <mfedosin> it's not necessary to cover them all in one patch
15:20:47 <mfedosin> I think it's impossible, because your patch will be 1000+ loc
15:21:32 <mfedosin> You covered several most important functions and I believe it's enough for now
15:21:36 <mfedosin> we have several big uncovered topics:
15:22:03 <mfedosin> Serializer/Deserializer
15:22:06 <inarotzk> Yep
15:22:25 <mfedosin> Links (which I will upload today)
15:22:45 <mfedosin> Adding custom location
15:23:04 <mfedosin> Download
15:23:19 <mfedosin> you may take download, for example
15:23:37 <mfedosin> there shouldn't be a lot of tests
15:23:38 <inarotzk> Great !
15:24:06 <mfedosin> I can write down a list of possible scenarios
15:24:45 <inarotzk> I am listening :)
15:25:20 <mfedosin> emmm... I wanted to write it after the meeting
15:25:28 <inarotzk> Of course :)
15:25:29 <mfedosin> but for example
15:26:01 <mfedosin> basic download, storage error during the download, download from folders
15:26:11 <mfedosin> download from non-blob field
15:26:21 <mfedosin> from non-existing field
15:26:33 <mfedosin> download of 'saving' blob
15:26:37 <mfedosin> and so on
15:27:48 <mfedosin> okay, after Links I'll take custom locations and you - downloads
15:28:22 <inarotzk> What do you think that i can take after downloads?
15:28:50 <inarotzk> So, there wouldn't be a chance that i won't be busy :)
15:29:55 <mfedosin> hmm... it's a good question
15:30:31 <mfedosin> when we have 90% of coverage by unit tests we should start implementing new features :)
15:30:53 <mfedosin> also we need to create tempest tests
15:31:25 <mfedosin> imho, tempest (integration) tests are next big thing
15:31:48 <inarotzk> oh , wonderful
15:31:50 <mfedosin> because we'll be able to create new testing gates
15:32:27 <mfedosin> and test integration with swift/ceph
15:33:06 <mfedosin> but let's finish units first :)
15:33:37 <mfedosin> #topic Open Discussion
15:33:37 <inarotzk> Yep :)
15:33:56 <mfedosin> btw, I'm started digging in mistrals actions
15:34:04 <mfedosin> how they are implemented for Nova
15:34:21 <mfedosin> and I think I will demonstrate some POC next week
15:34:38 <inarotzk> :) :) :) awesome!
15:34:40 <mfedosin> probably we should invite somebody from Mistral team next week
15:34:46 <mfedosin> what do you think?
15:35:09 <inarotzk> We can invite michal , i am curious about it
15:35:39 <mfedosin> and Renat
15:36:01 <mfedosin> one of them will come for sure :)
15:36:04 <inarotzk> Yep
15:36:56 <mfedosin> also I need to say a couple of words about documentation
15:37:47 <mfedosin> I think there is a technical writer for glare from Nokia
15:38:19 <mfedosin> I got a message that they're waiting for our documentation drafts
15:38:33 <mfedosin> we have 3 parts merged
15:38:37 <mfedosin> and one on review
15:39:03 <mfedosin> I'll tell about the update next week
15:39:35 <mfedosin> okay, I think that's all from my side
15:39:36 <inarotzk> So i'll review it soon, and when you think it's enought documentation i can find out about the technical writer
15:40:02 <mfedosin> inarotzk: yes, thanks
15:40:49 <mfedosin> inarotzk: do you have anything else to discuss?
15:40:54 <inarotzk> From my side, i have a question: which hooks do we have in glare ?
15:41:09 <mfedosin> oh... there are 3 hooks
15:41:35 <mfedosin> validate_upload, validate_activate, validate_publish
15:43:06 <mfedosin> there was a bright idea to create another one for deletion
15:43:31 <mfedosin> #link https://github.com/openstack/glare/blob/master/glare/objects/base.py#L814-L827
15:44:05 <mfedosin> inarotzk: if you have time you may add this hook too
15:44:34 <inarotzk> Does those hooks do something? because i see "pass" for validate_activate and for validate_publish
15:45:02 <mfedosin> these are stubs
15:45:26 <mfedosin> you may reimplement these methods in your artifact type
15:45:36 <mfedosin> and make them do something
15:46:20 <mfedosin> Base artifact type is an abstract class
15:46:25 <inarotzk> Do we it for any artifact?
15:46:41 <inarotzk> *Do we have one of them for some artifact?
15:47:30 <mfedosin> vnf_package
15:47:37 <mfedosin> ns_package
15:47:50 <mfedosin> previously we had one for images
15:48:15 <inarotzk> Was it removed?
15:48:23 <mfedosin> but decided to get rid of it when after removal of community app catalog fields
15:48:31 <mfedosin> yes, now it's removed
15:49:51 <mfedosin> this is the original version https://github.com/openstack/glare/blob/ebe19e95358918f0a68ac4b598ed3e886a775ce5/glare/objects/image.py
15:50:49 <inarotzk> cool
15:51:50 <mfedosin> so, you may add 'validate_delete' hook, similarly to what we have in 'validate_publish' and 'validate_activate'
15:52:35 <inarotzk> Yes, i am on it :)
15:52:49 <mfedosin> awesome :)
15:52:54 <mfedosin> anything else?
15:53:08 <inarotzk> Nope
15:53:24 <mfedosin> okay then :)
15:53:32 <mfedosin> I think we can finish for today
15:53:43 <mfedosin> plans for this week
15:53:52 <mfedosin> reach 90% of coverage
15:53:57 <mfedosin> create poc for mistral
15:54:15 <mfedosin> inarotzk: thanks for coming
15:54:25 <inarotzk> Thank you Mike !
15:54:32 <mfedosin> #endmeeting