12:01:15 <mfedosin> #startmeeting glare
12:01:16 <openstack> Meeting started Tue Jun  6 12:01:15 2017 UTC and is due to finish in 60 minutes.  The chair is mfedosin. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:01:18 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
12:01:20 <openstack> The meeting name has been set to 'glare'
12:01:49 <mfedosin> idanaroz: hi :)
12:01:55 <idanaroz> HI :)
12:02:14 <mfedosin> we organize meeting at new time
12:02:25 <mfedosin> little bit earlier
12:02:32 <mfedosin> #topic agenda
12:02:48 <mfedosin> #link https://etherpad.openstack.org/p/glare-meeting-agenda
12:03:40 <mfedosin> #topic updates
12:04:06 <mfedosin> okay. let's iterate through what has been done
12:05:27 <mfedosin> default parameters for sorting and filtering was fixed recently: https://review.openstack.org/469834
12:06:30 <mfedosin> currently we don't have this weird behavior when defaults were added even if they already exist in user's requests
12:07:03 <mfedosin> log translations were removed as well: https://review.openstack.org/469979
12:08:02 <mfedosin> it was decided by openstack community team not to translate logs
12:08:45 <mfedosin> also we've fixed a bug related to 4-bytes unicode characters in db: https://review.openstack.org/467363
12:09:19 <mfedosin> before glare returned 500 if user tried to set these characters to artifact fields
12:09:56 <mfedosin> a big bunch of unit tests were merged as well:
12:10:12 <mfedosin> https://review.openstack.org/468873
12:10:18 <mfedosin> https://review.openstack.org/468722
12:10:31 <mfedosin> https://review.openstack.org/466803
12:10:43 <mfedosin> https://review.openstack.org/466300
12:11:04 <mfedosin> I don't want to discuss them too much
12:12:00 <mfedosin> another bug fixed is https://review.openstack.org/468393
12:12:28 <mfedosin> before we forgot to close db connections after request had been done
12:12:58 <mfedosin> these connection were closed by timeout after 1 hour, which is not good
12:13:07 <mfedosin> right now it is fixed
12:13:36 <mfedosin> also idanaroz added new feature - validation hook https://review.openstack.org/467306
12:14:26 <mfedosin> now users may specify additional actions on artifact deletion in their artifact types
12:15:07 <mfedosin> I think that's all I remember was done during last week
12:15:41 <mfedosin> idanaroz: do you have any updates I forgot to mention?
12:16:16 <idanaroz> We added download unit tests as well :)
12:17:04 <mfedosin> yeah, I put the link
12:17:51 <mfedosin> okay, we can go to the next topic
12:18:22 <mfedosin> #topic Patches on review
12:19:04 <mfedosin> idanaroz: you found absolutely right thing, that we confuse attributes and fields in the code
12:20:10 <mfedosin> in some places these entities are called 'fields' as it is customary in oslo.versionedobjects
12:20:23 <mfedosin> in other places - 'attributes'
12:20:47 <mfedosin> so, it was decided to bring it to one universal format - 'fields'
12:21:12 <mfedosin> I proposed a patch: https://review.openstack.org/#/c/471046/
12:21:40 <mfedosin> it renames all occasions of attributes into fields
12:22:28 <mfedosin> patch doesn't add new functionality or fix bugs, but I think it's useful for clarity
12:22:52 <mfedosin> idanaroz: I addressed your comments in the second patch
12:24:18 <mfedosin> another patch I added is renaming of six.iteritems to items
12:24:19 <mfedosin> https://review.openstack.org/#/c/469972/
12:24:30 <idanaroz> Thanks you, I will review it
12:24:55 <mfedosin> it's a requirement of openstack to stop using it
12:25:04 <mfedosin> so, I proposed the patch
12:25:35 <mfedosin> btw, we have to do the same with python-glareclient :)
12:26:51 <mfedosin> several tests patches are still on review:
12:26:53 <mfedosin> https://review.openstack.org/468733
12:27:09 <mfedosin> https://review.openstack.org/468025
12:27:37 <mfedosin> this one needs rebasing on master: https://review.openstack.org/468731
12:28:39 <idanaroz> Yes, I wondered what we should about it
12:29:07 <mfedosin> it's a merge conflict there
12:29:56 <mfedosin> nothing serious - just some manual intervention is required
12:30:13 <mfedosin> I'll update it right after the meeting
12:30:27 <mfedosin> about coverage situation - we've reached 90%
12:31:12 <mfedosin> if all the remaining patches are merged, of course
12:31:37 <mfedosin> but it doesn't meant that we can't do even better!
12:32:25 <mfedosin> we've covered all most important things: engine and base artifact types are covered by 100%
12:33:41 <mfedosin> unfortunately we still have a few uncovered things: validators, file_utils and api classes
12:34:08 <mfedosin> so, I'll continue implementing unit tests for them in next weeks
12:36:01 <mfedosin> idanaroz: I saw you'd started adding new documentation: https://review.openstack.org/#/c/470747/
12:36:30 <mfedosin> this is really awesome! and I want to thank you for that
12:36:33 <idanaroz> yes, i will continue with that in the next few days :)
12:37:22 <mfedosin> amazing work!
12:37:30 <mfedosin> thank you again for that
12:37:42 <mfedosin> I'll review it and add my comments inside
12:37:59 <idanaroz> Thank you
12:38:37 <mfedosin> #topic Tempest tests
12:39:20 <mfedosin> to increase our test power I suggest to implement several integrational tests
12:39:43 <mfedosin> and enable tempest gates in jenkins
12:40:11 <mfedosin> I think for the first time we need to cover some basic things
12:40:41 <mfedosin> I mean normal behavior, without any extreme things
12:41:10 <mfedosin> idanaroz: I may start this patch and you'll join later
12:41:30 <mfedosin> right now we have all required infrastructure
12:42:04 <idanaroz> Yes, Sure
12:42:16 <mfedosin> https://github.com/openstack/glare/tree/master/glare_tempest_plugin
12:42:29 <mfedosin> so we just need to start implementing tests
12:43:27 <mfedosin> with it we'll be able to test integration with ceph and swift stores, and with postgres db
12:44:51 <mfedosin> all right, go further
12:45:05 <mfedosin> #topic New artifact types
12:45:34 <mfedosin> there are several things we may add to glare
12:45:59 <mfedosin> 1. it was suggested to keep secrets in glare
12:46:33 <mfedosin> service can handle it and my idea that we should implement it
12:47:32 <mfedosin> idanaroz: your opinion?
12:48:04 <idanaroz> I would love to implement it
12:48:45 <mfedosin> great
12:49:23 <mfedosin> #action (idanaroz) Implement "secrets" artifact type
12:49:37 <mfedosin> 2. Mistral workbooks
12:50:04 <mfedosin> it's definitely nice to have this type
12:50:29 <mfedosin> and it was requested by Nokia management, as far as I remember
12:52:05 <mfedosin> I think I'll take it
12:52:28 <mfedosin> #action (mfedosin) Implement mistral workbooks artifact type
12:53:07 <mfedosin> other possible artifact types, like docker images and ansible playbooks can be postponed
12:54:04 <mfedosin> idanaroz: or inarotzk ? :)
12:54:25 <inarotzk> It's equal LOL
12:55:28 <mfedosin> #topic Open discussion
12:55:40 <mfedosin> we have several minutes left
12:56:09 <mfedosin> inarotzk: do you have anything left to discuss?
12:56:17 <idanaroz> I wanted to ask about sharing and hard dependencies features
12:56:35 <mfedosin> yes, we need them
12:56:45 <mfedosin> but only after stable branch is created
12:57:06 <mfedosin> my opinion is that we should start with sharing first
12:57:08 <idanaroz> Okay, so another task, is for me to create stable branch
12:57:31 <mfedosin> but before we create it we need to merge all unit tests
12:57:51 <idanaroz> Oh, Yes...
12:58:00 <mfedosin> and release cloudband :)
12:58:11 <mfedosin> so let's wait for two more weeks
12:58:22 <idanaroz> Does  the creation is from gitub/gerrit/openstack?
12:58:36 <mfedosin> we'll create the stable branch on 20th of June
12:58:45 <mfedosin> it's git
12:59:07 <idanaroz> Okay
12:59:47 <mfedosin> all right, I think we can finish for today
12:59:58 <idanaroz> Yes, Thank you very much
13:00:04 <mfedosin> inarotzk: thanks for coming!
13:00:14 <mfedosin> #endmeeting