12:02:10 #startmeeting heat 12:02:11 Meeting started Wed Jun 25 12:02:10 2014 UTC and is due to finish in 60 minutes. The chair is shardy. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:02:12 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 12:02:14 The meeting name has been set to 'heat' 12:02:21 #topic rollcall 12:02:23 hi all 12:02:27 here 12:02:29 hi all, who's around? 12:02:30 o/ 12:02:35 Hi everyone 12:02:44 shardy: I think zaneb said last week that he would be out Mo-Wed 12:02:53 hi all 12:03:01 Oh yeah, and therve was supposed to run the meeting! 12:03:12 therve: sorry, I forgot, do you want to take over? 12:03:12 Hi! :) 12:03:18 shardy, Please continue :) 12:03:22 :) 12:03:47 I'm here. Dies Koper. First time here. 12:03:50 o/ 12:03:58 dkoper: Hi, welcome! 12:04:14 Hi all 12:04:42 Hi All. First time me too 12:04:52 Hi avquadri, welcome! 12:04:57 Ok, lets get started 12:05:01 #link https://wiki.openstack.org/wiki/Meetings/HeatAgenda 12:05:15 #topic review last weeks actions 12:05:26 #link http://eavesdrop.openstack.org/meetings/heat/2014/heat.2014-06-18-20.00.html 12:05:43 zaneb book space for the meetup and then make an announcement on the ML 12:05:48 I think that was done 12:06:09 #info zaneb booked space for heat mid-cycle meetup and announced on ML 12:06:14 I saw the email 12:06:28 ${next PTL} before summit plan an early mid-cycle meetup 12:06:35 Ok I guess that's ongoing 12:06:45 #info ongoing action ${next PTL} before summit plan an early mid-cycle meetup 12:06:59 add mid-cycle meetup planning to Heat PTL guide on wiki 12:07:06 Not sure if that happened.. 12:07:40 #action zaneb add mid-cycle meetup planning to Heat PTL guide on wiki 12:07:59 Anything else from last meeting? 12:08:16 #topic Adding items to the agenda 12:08:26 Anyone have anything to add? 12:08:40 How about an action to put a link to that Heat PTL guide somewhere that can be found? 12:08:59 mspreitz: it should be linked from https://wiki.openstack.org/wiki/Heat 12:09:17 shardy: as far as I can tell, it is not 12:09:30 shardy, I added some items in the wiki already about specs 12:09:31 mspreitz: I know, that's why I just actioned zaneb to do it again 12:09:40 mspreitz: it's not been done yet 12:10:04 therve: yup, saw those, thanks 12:10:20 #topic Mid-cycle meetup 12:10:21 shardy: I meant "#action put link to PTL guide in Heat wiki page" 12:10:48 #action zaneb put link to PTL guide in Heat wiki page 12:11:07 poor Zane is getting all the actions today ;) 12:11:18 I'll add a link if I can find it 12:11:45 So zaneb posted info about the mid-cycle meetup, does anyone have anything they want to discuss about it? 12:11:46 A link from the agenda page to the project page would not be bad either 12:11:54 #link https://wiki.openstack.org/wiki/Heat/PTLGuide#Mid-cycle_Meetup 12:11:57 just for convenience 12:11:58 Put your names on https://etherpad.openstack.org/p/heat-juno-midcycle-meetup 12:12:02 mspreitz: feel free to add it :) 12:12:43 pas-ha: thanks, I hadn't seen that 12:13:08 could you repeat what would be the focus of the meetup? convergence drafting/crafting? 12:13:31 #info Heat mid-cycle meetup confirmed 12:13:36 #link http://www.mail-archive.com/openstack-dev@lists.openstack.org/msg27516.html 12:13:58 pas-ha: That is tbc, but it will be more about doing work than planning 12:14:02 Hi, I am first time here 12:14:10 jyoti-ranjan: hi, welcome 12:14:21 Do we have any link where we have agenda for meet-up? 12:14:28 I did not find at https://wiki.openstack.org/wiki/Heat/PTLGuide#Mid-cycle_Meetup. 12:14:37 There is no agenda, except "Do stuff" 12:14:42 jyoti-ranjan: not yet, the exact agenda is still tbc 12:15:06 I understand, thanks 12:15:22 depends on what folks want to do, but I expect update enhancements and convergence will feature prominently 12:15:57 updates - cool :) 12:16:07 Althought that should happen at the previous one too 12:16:45 therve: Yeah, myself and stevebaker will be at the tripleo meetup to represent heat 12:16:53 shardy, Sweet 12:16:57 I won't be at the heat-specific event unfortunately 12:17:03 not sure about stevebaker 12:17:33 Ok lets defer further meetup planning for when zaneb is back next week 12:17:39 #topic Spec backlog: review items, have a spec review day 12:17:48 therve: care to take this one? 12:17:54 Yes 12:18:11 I talked to ttx about our spec repository 12:18:22 We have some backlog, nothing to worry about, but we should start kicking it a bit 12:18:43 I told him we were a bit afraid of the first merge or so it seemed :) 12:19:00 therve: Yeah I agree, although with specs generally (not just heat) I worry there's the risk of rat-holing on details before there is any code 12:19:10 He suggested to have a review day so that we can all talk about it and just land them 12:19:23 shardy, Yeah that's one issue 12:19:34 It's good to have details, but we don't want the process to introduce huge overhead, just get consensus on the direction and top-level design 12:19:37 I think we should emphasize that you can make the specs evolve 12:19:45 It's not like we print them on stone tablets 12:19:57 therve: +1, get the outline agreed, then push it 12:20:06 revise if necessary if the implementation evolves 12:20:21 Yeah it'd be nice to keep them somewhat in sync 12:20:36 folks reviewing the code should check that the spec reflects roughly what has been implemented 12:21:01 therve +1, necessary to keep specs in sync with implementation 12:21:10 how one should ref the new spec in the commit? 12:21:21 pas-ha: reference the blueprint 12:21:25 Do we keep spec in line with impl going forward? 12:21:31 then the spec should be linked from the blueprint 12:21:35 looks like it would be roundtrip gerrit-launchpad-gerrit 12:21:36 shardy: if we see that the code is not impelmenting what is defined in the specs we should cahnge the specs? it doesn't seem to me correct 12:21:58 pas-ha, If there are too many round trips it means you don't know what you're doing :) 12:22:00 mspreitz: yes, that's what was just mentioned 12:22:10 Indefinitely? 12:22:25 mspreitz, No just until the bp has been implemented 12:22:48 mspreitz: No, I think it's just a sanity-check thing, where if folks propose one thing, and implement something substantially different, reviewers pick it up when reviewing the code 12:23:08 thanks 12:23:15 mspreitz: ultimately the spec represents a "design document" of sorts, so it's worthless if it's completely different to the code 12:23:25 IMO we should resist super-detailed specs though 12:23:40 ultimately, I'd like to have maintained design docs, but I thin that's too much to ask here now 12:23:44 shardy: +1 12:24:17 tspatzier: IMO your action-aware-sw-config one strikes a good balance 12:24:18 shardy: I agree with that but the code can't diverge too much from the specs 12:24:31 thanks shardy :-) 12:24:43 detailed discussion of the use-case and interfaces, consideration of backwards compatibility, but not too many details on the exact implementation 12:25:05 #link https://review.openstack.org/#/c/98742/ 12:25:09 yep, otherwise we end up in a waterfall model 12:25:10 everyone copy tspatzier ;) 12:25:44 therve: so you think we need a review-day, or just a general push to get things merged? 12:25:59 The convergence stuff looks mostly nearly there, I need to revisit it 12:26:10 shardy, Maybe lt's give it another week, and if nothing moved we can talk during the next meeting? 12:26:21 therve: Ok, sounds good 12:26:40 #info reviewers to review specs, revisit progress at next meeting 12:27:29 #topic Discuss spec approval deadline 12:27:39 Something that came up during project meeting 12:27:53 therve: so you're thinking we need a feature proposal freeze for specs? 12:27:56 Nova is adopting some deadlines around specs 12:28:11 In case anyone wants to contribute for testing the heat, is their any testplan or test case document available? 12:28:19 A proposal one and a approval one, I think an email has been sent 12:29:29 IMO for big features we do need a proposal one, but I wouldn't want to block small features which are posted near FPF just because they need a spec 12:29:49 #link http://lists.openstack.org/pipermail/openstack-dev/2014-June/038475.html 12:30:04 So we talked about it during the meeting, and I don't think we need this 12:30:10 particularly if we get picky about requiring a spec for anything that changes observable behavior 12:30:17 Projects are free to choose their policy, fwiw 12:30:36 therve: FWIW I think that is too early for heat 12:30:42 So I suggest not having specific deadlines outside of the Feature proposal freeze 12:31:09 If simple specs get proposed early in J3 I'd be OK with that, provided they don't impact too much existing code 12:31:31 Yeah I feel we can have small enough spec that it doesn't matter 12:31:50 Nova already has a 154 specs backlog, so has to set some expectations 12:32:07 therve: +1, Ok well I guess it's up to zaneb to have the final say on this, but I don't think strictly aligning with the nova timetable makes sense for heat 12:32:22 shardy, agreed 12:32:27 +1 12:33:05 That's all I had :) 12:33:46 #topic Critical issues sync 12:34:08 So we had some gate-affecting issues, I know therve fixed one, and stevebaker posted a fix for another 12:34:14 Has anybody successfully exercised an OS::Heat::AutoScalingGroup whose member type is a nested stack? 12:34:33 Anyone else have any critical issues to raise? 12:34:34 mspreitz, My example used to work some weeks ago 12:34:47 mspreitz: we need a tempest test for it IMO 12:34:51 Hi, I have got another issue for the team to consider, not a new one 12:35:00 shardy, stevebaker problem has been reverted first, no? 12:35:03 it is actually about scenario test 12:35:13 shardy: Yes, I think we need to get Tempest exercising some of the heat-templates 12:35:26 therve: my patch exposed a race, but didn't cause it, so it got reverted 12:35:46 Ah so there is an underlying bug 12:35:50 therve: last night stevebaker found a fix to the DB session lockup which was related to lock stealing on delete 12:35:58 Cool 12:36:04 therve: Yeah, my code just made things run faster, so it broke more regularly 12:36:21 Less cool 12:36:22 :) 12:36:26 shardy that means your token patch is back? 12:36:36 therve: https://review.openstack.org/#/c/102377 12:36:38 Qiming, yeah? 12:36:55 BillArnold__: it's queued after that one I just posted 12:37:01 so it's coming back ;) 12:37:03 there are many scenarios where simple unit tests are not adquate to find problems 12:37:24 Qiming: The answer is more tempest tests 12:37:31 these scenarios can be treated as heat-very-very-slow, e.g. softwareconfig, autoscaling ... 12:37:46 I've been working on some, but getting them in is proving extremely slow and frustrating 12:38:02 Qiming: That's what the tempest heat-slow job is for 12:38:09 it already has an autoscaling test 12:38:16 (not for the native resources yet) 12:38:21 okay, just don't know how slow is that :) 12:38:41 https://github.com/openstack/tempest/tree/master/tempest/scenario/orchestration 12:38:43 shardy: what is making it slow and frustrating to land more heat-slow tests? 12:39:15 an example is that a recent patch to ceilometer broke autoscaling, though the original intent was to make metadata matching capable of handling 'or' clauses ... 12:39:16 someone just asked about test plans - tempest is the place to look, although it's not a "plan" as such 12:39:26 mspreitz: lack of tempest-core reviewer attention 12:40:03 my most recent attempt at adding a new test has taken three months so far 12:40:27 shardy: I presume lack of attention slows down landing of all sorts of tempest tests. Ugh! 12:40:39 Qiming: IMO, every time we have a functional regression, we should add a new test in tempest to catch it 12:40:50 shardy: +1 12:40:59 I was going to sugget that myself 12:41:01 shardy, but 3 months is terrible ... 12:41:07 shardy, +1, in that case the bug was a ceilometer bug 12:41:09 shardy, thanks. any document on adding a new tempest test would be appreciated. will help in getting started 12:41:16 Qiming: Then tag it as Related-Bug to the original bug in the commit, e.g like 12:41:19 https://review.openstack.org/#/c/90143/ 12:41:31 got it 12:41:42 But how do we solve this problem: (a) regression discovered; (b) new test proposed --- and rejected because it fails! 12:41:53 avquadri: The best thing is looking at reviews like the one I posted above, also tempest documentation is OK 12:42:21 mspreitz, Considering what shardy just talked about regarding lack of review attention, it shouldn't be a problem 12:42:27 mspreitz: fix regression, propose tempest test, test accepted so we catch it next time 12:42:48 thanks 12:42:51 shardy: but that means there is no testing that the test actually catches the regression 12:43:11 I actually think the whole model of having tempest-core review all projects test-cases is broken, but that's another discussion 12:43:21 mspreitz: testing that is up to the test author 12:43:45 shardy: there is no annotation that means "expect this to fail until bug NNN is fixed" ? 12:43:46 Like other unit tests really 12:44:05 mspreitz: Or, you could post it before the fix, see it fail, then recheck after the fix lands 12:44:30 mspreitz: Yeah, there is also a skip_because(bug...) decorator in tempest, but you're not allowed to land skipped tests 12:44:38 shardy: it's obvious that the test author can test once, I was just thinking about whether something a little more robust is possible/desirable 12:44:58 mspreitz: given the review latency, probably not at this point 12:45:07 We haven't had that problem yet, let's just write tests and see 12:45:12 therve: +1 12:45:25 Ok, 15mins left, any other things to discuss? 12:45:44 #topic open discussion 12:46:14 The oslo.messaging patch is ready for me, any additional testing would be welcome 12:46:30 I hope it won't stay around too long because it's costly to maintain 12:46:48 #link https://review.openstack.org/#/c/99648/ 12:47:02 #info oslo messaging patch about to land, please test/review it 12:47:05 could core team take a look at new Sahara resources? https://review.openstack.org/#/q/status:open+project:openstack/heat+branch:master+topic:bp/sahara-as-heat-resource,n,z 12:47:12 any tips for new contributors for heat? 12:47:51 avquadri, Review patches, fixes small bugs 12:48:04 Have a look at heat-templates and try to run them 12:48:12 small bugs are tagged as low-hanging-fruit? 12:48:13 avquadri: and do reviews, it will help you get familiar with the code, and reduce the time your patches wait for review 12:48:15 Read documentation carefully :) 12:48:31 get to know gerrit and git review :) 12:48:32 thanks a lot :) 12:49:08 avquadri: https://wiki.openstack.org/wiki/Heat/DevelopmentProcess 12:49:53 thanks, these things should get us started 12:49:55 avquadri: Mostly they're not, but perhaps we should start doing that 12:50:12 avquadri: If you need help finding small bugs, come ask in #heat 12:50:32 Ok, anything else or shall we wrap things up? 12:50:42 great ... sure 12:51:21 Actually, I have one thing, someone said to me it's weird that we have #heat now we're integrated 12:51:35 Does anyone thing we should move to a #openstack-orchestration or something? 12:51:44 No :) 12:51:55 I don't have strong opinions about it, just passing on an observation ;) 12:51:59 I really don't care. 12:52:03 therve: fair enough ;) 12:52:25 It's all random enough I have to look it up until I learn 12:52:27 We could open the channel and redirect to #heat though 12:52:32 mspreitz: neither does anyone who knows what the channel is already, it's about making it more discoverable for new folks I guess 12:52:44 There's a wiki page for that 12:52:58 That's what I was saying, I look up in wiki page rather than trying to guess 12:53:05 shardy openstack-heat would be easy to type 12:53:37 BillArnold__: yeah, it's just like ceilometer moved to #openstack-metering after integration 12:53:38 and #orchestration would be pointless, but rounds out the quartet that any guesser would start with 12:54:00 anyway, probably not important, let's leave it as something to think about ;) 12:54:11 shardy, It didn't ? 12:54:31 actually for conformity with other projects it should be openstack-heat 12:54:44 Yes, it good to aling rest of Openstack world like openstack-heat. 12:54:48 #link https://wiki.openstack.org/wiki/IRC 12:54:56 therve: Oh, am I wrong? I thought they moved. 12:55:15 shardy, Well it's openstack-ceilometer, maybe they move from ceilometer 12:55:35 #openstack-metering points to the same channel 12:55:58 Qiming, No? 12:55:59 Ok, lets stay in #heat and look into getting a redirect to align with other projects then 12:56:32 * shardy is regretting bringing up this topic 12:56:43 Heh 12:56:47 :) 12:56:54 Ok, let's leave it at that, thanks everyone! 12:56:58 #endmeeting