16:01:26 <david-lyle> #startmeeting Horizon
16:01:26 <openstack> Meeting started Tue Mar  4 16:01:26 2014 UTC and is due to finish in 60 minutes.  The chair is david-lyle. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:01:27 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:01:30 <openstack> The meeting name has been set to 'horizon'
16:01:40 <david-lyle> Hello everyone
16:01:42 <lsmola> hello
16:01:46 <mrunge> o/
16:01:52 <akrivoka> hello \o
16:01:53 <lcheng_> hello
16:01:55 <tmazur> hello o/
16:02:10 <jpich> Hi
16:02:19 <lblanchard> hi all
16:02:23 <doug-fish1> greetings!
16:02:29 <jpomero> hi
16:02:43 <david-lyle> The final day for features and strings in Icehouse is upon us
16:02:49 <david-lyle> https://launchpad.net/horizon/+milestone/icehouse-3
16:02:57 <david-lyle> 1 Blocked, 17 Needs Code Review, 22 Implemented
16:03:12 <david-lyle> The top two in the list are FFE material
16:03:16 <jomara> hi
16:03:32 <david-lyle> 2-3 were approved and had merge conflicts
16:03:46 <david-lyle> and some need reviews or more work
16:04:20 <david-lyle> if we can clearly identify the items we think need more work and should be pushed to Juno, it would simplify the rest of the day :)
16:04:38 <mrunge> david-lyle, te
16:05:03 <mrunge> david-lyle, the separation of horizon and dashboard is one thing for juno
16:05:04 <jpich> IMO at this stage, if the "more work" is a nice to have, or smaller bugs that can be handled before RC (e.g. small performance improvements, docs, etc) it's ok to +2 and open a new bug for the extra work
16:05:51 <jomara> david-lyle: ive had some reviews get approved but out of order (ie, a string of dependent patches), so there are merge conflicts that wont resolve until the dependency chain is reviewed
16:07:25 <david-lyle> jomara, I think the ones not approved have -1's on them
16:07:42 <jomara> do they?? i will double check, from my dashboard they appeared green butr maybe that is misleading
16:07:45 <david-lyle> we can discuss it those are enough to block the change and be fixed in the RC
16:08:00 <jpich> a +2 can hide -1s
16:08:10 <jomara> david-lyle: oh boy, it looks like if someone +2s, the -1 doesnt show up on from the front view
16:08:17 <jomara> yeah.. dang
16:08:36 <david-lyle> jomara: https://review.openstack.org/#/c/73433/ is just a merge conflict as well
16:08:41 <jpich> :( IIRC some of them could easily be done after FF and before the RC, e.g. fixing up docstrings
16:08:44 <david-lyle> no dependency
16:09:03 <david-lyle> I would be fine with that
16:09:13 <lcheng_> jomara: seems like the bottleneck is here: https://review.openstack.org/#/c/71395/4
16:09:18 <david-lyle> Lot's of good work to block on a doc string
16:09:32 <lcheng_> Got approved but it was not merged, I'll approve it again to trigger the build.
16:09:56 <jomara> lcheng_: ah, thanks
16:10:01 <jomara> ok, ill try to get everything fixed up ASAP
16:10:12 <jomara> sorry about that, i didnt realize i wasnt seeing the -1s
16:10:33 <jpich> lcheng_: The review it depends on isn't merged though, I don't think it'll go through yet
16:10:47 <david-lyle> I think jpich is correct
16:11:13 <lcheng_> jpich: you're right
16:11:18 <lcheng_> https://review.openstack.org/#/c/66603/19
16:11:21 <jomara> david-lyle: the one you linked is also dependent, but it says its a merge conflict, i assumed it was due to earlier patches
16:12:01 <david-lyle> ok, just not a dependency according to gerrit
16:12:22 <lcheng_> jomara: I think this is the top of the chain https://review.openstack.org/#/c/66603/19
16:12:59 <jomara> lcheng_: yes, that should be
16:13:06 <jomara> lcheng_: it has 2 -1s that were hidden by the +2
16:13:14 <jomara> so ill start there and owrk my way down
16:14:34 <david-lyle> as a heads up https://blueprints.launchpad.net/horizon/+spec/django-1point6 is blocked by an openstack/requirements approval
16:15:16 <david-lyle> once that happens, I going to update and release django_openstack_auth and the update Horizon to have a tox env for 1.5 and 1.6
16:15:20 <jpich> david-lyle: Will adding a django15 job be done separately or is there a related patch already?
16:15:29 <jpich> Sounds good
16:15:58 <david-lyle> in openstack_auth, it will happen in one patch, in Horizon I will update the requirements and add the tox job in the same patch
16:16:14 <lcheng_> jomara: thanks, me and david-lyle are in the US. We can follow-up on the heat patches for the rest of the day.
16:16:16 <david-lyle> depending on who's awake, I may just push the changes through
16:16:30 <jomara> lcheng_: awesome, thanks
16:16:34 <david-lyle> It's really just book keeping at that point
16:19:35 <david-lyle> also looks like https://review.openstack.org/#/c/61032/ is a priority for Hyper-V support
16:20:06 <david-lyle> it wasn't targeted until yesterday
16:21:43 <david-lyle> So after icehouse-3 is tagged, master will still be icehouse until RC1 is but in a few weeks
16:21:58 <david-lyle> then the items left over can start merging to Juno
16:23:36 <david-lyle> #topic Open Discussion
16:23:48 <david-lyle> I think we were there, but now it's official :)
16:24:12 <lblanchard> I worked with sayalilunkad last week to put together a design for Sparklines on the instance table. We are hoping to hear from lsmola on his thoughts on direction for her to go in…here is the design: http://people.redhat.com/~lsurette/OpenStack/Sparklines%20on%20Instance%20Table
16:25:03 <david-lyle> you know, that table could really use more columns ;)
16:25:07 <lblanchard> haha
16:25:12 <lsmola> lblanchard: great
16:25:22 <lblanchard> might push us towards a "Add/Remove Columns" feature :)
16:25:35 <akrivoka> lblanchard: nice!
16:25:40 <lsmola> lblanchard: sayali is investigating whether the meters are good for this
16:25:49 <lblanchard> but the thoughts is that RAM and vCPU would be two very nice metrics to show here for each instance
16:25:55 <lblanchard> lsmola: great!
16:26:16 <jpich> Maybe we should move the actions toward the beginning of the table at some point, to avoid having to scroll to do stuff
16:26:21 <david-lyle> I do like the look of it, very clean
16:26:26 <lblanchard> and also…adding two sparklines to the instance table would be a nice attainable goal before her internship ends on the 10th :)
16:26:40 <david-lyle> 10th of?
16:26:47 <lblanchard> david-lyle: march
16:26:50 <david-lyle> :(
16:26:55 <lblanchard> david-lyle: yeah :(
16:26:58 <lblanchard> jpich: great point
16:27:27 <david-lyle> or perhaps a different way to render colums
16:27:30 <david-lyle> columns
16:27:35 <lblanchard> david-lyle: yes for sure
16:27:50 <lblanchard> one thing to ask too is…are all of these columns necessary here
16:27:57 <lblanchard> or would some be okay to drop to the details view
16:28:02 <david-lyle> put state information in the same column but in multiple rows, sparklines in the same column, etc
16:28:39 <lblanchard> david-lyle: right, we can definitely merge and reformat some of these values
16:28:55 <lblanchard> I will brainstorm an idea for next week
16:29:21 <david-lyle> but for now and as dar as sayali is concerned, the layout you have proposed looks like a great way to move forward and have a tangable endpoint
16:29:32 <david-lyle> s/dar/far/
16:29:40 <lsmola> lblanchard: great
16:29:41 <lblanchard> great, thanks!
16:30:10 <lblanchard> lsmola: will you follow up with her when she comes online? I know she was looking to hear from you on this to confirm.
16:30:31 <lsmola> lblanchard: we have talked today
16:30:33 <jpich> I'd love to get some attention on the host aggregates patch if some of the cores have a chance to take a look. I reviewed it a few times, not sure if it's ok to leave a final +2 since I made the last change (a couple of tests) -> https://review.openstack.org/#/c/71061/ . It'd be neat to have in Icehouse :)
16:30:38 <lblanchard> lsmola: perfect
16:31:32 <lsmola> lblanchard: she just need to make sure the meters gives us correct data and this can be done
16:31:55 <lblanchard> lsmola: sounds great, I'll hope they fit in :)
16:32:11 <david-lyle> jpich, just rebasing, I would say it's fine to +2
16:32:54 <jpich> david-lyle: I added a couple of tests as well
16:32:55 <jpich> :O
16:33:09 <david-lyle> well, that's just bonus points :)
16:33:16 <cgoncalves> hi all. I've a question regarding a blueprint I'm currently working on (https://blueprints.launchpad.net/horizon/+spec/download-images-and-snapshots). project dashboard implementation is ready and I'm currently addressing finishing adding support on the admin dashboard as requested in review.o.o which should be ready today. only UT missing as requested by mrunge. any chance of approving this  for I-3 or is it too late now?
16:33:26 <jpich> heh :)
16:35:30 <jpich> cgoncalves: It really help to set the milestone target when working on a blueprint so it can be considered during release tracking
16:35:59 <julim> lblanchard david-lyle -- in looking at the instance table, if we can drop some of the columns (and put them in details) that would be great, e.g. why do we need to include image name, size, key pair, ip address
16:36:11 <jpich> otherwise especially when approaching the end of a milestone it's unlikely to get as much review attention
16:36:13 <cgoncalves> jpich: I did set it, but david-lyle removed it very recently (today morning I think)
16:36:33 <julim> <sorry… late joining the meeting>
16:37:43 <david-lyle> cgoncalves, I did, I went through the bps targeted for icehouse and items that had not received much attention or looked like they had work left (adding tests) were moved out
16:37:43 <absubram> side Q sorry.. how do you set the milestone? I've never been able to edit that field.. bugs or bp
16:38:05 <lblanchard> julim: yes, I'm wondering something similar…what is important to see at this table level and what could be put into a details view. Perhaps we could do some user testing here to make sure we make informed changes.
16:38:20 <jpich> absubram: The assignee should be able to set the target on a blueprint, IIUC
16:38:31 <julim> sounds good lblanchard.
16:39:10 <absubram> jpich: thanks.. I'll keep an eye on it next time I open a bp :)
16:40:27 <cgoncalves> david-lyle: I didn't look yet for how to implement a UT for testing the correctness of downloading an image from horizon in client-side. in case it's feasible and somehow trivial, I should implement it in time
16:41:31 <cgoncalves> david-lyle: the request for such UT was only asked a couple hours ago. I've been addressing all comments on review.o.o as fast as I can as you can see (https://review.openstack.org/#/c/74799/)
16:41:41 <jpich> absubram: Ok! It's part of the steps for creating a blueprint so please say something if that's not actually possible ( https://wiki.openstack.org/wiki/Blueprints#Creation )
16:42:18 <david-lyle> cgoncalves, I'll look at it again a client side download test may not make sense in unit tests
16:42:58 <cgoncalves> david-lyle: thanks. that was what I understood from mrunge's comment, a client side download test.
16:43:17 <absubram> jpich: thanks for the link!
16:43:47 <jpich> absubram: I am a link factory, at your service :)
16:43:49 <david-lyle> jpich, they show up targeted all the time, so I hope someone is setting it :)
16:44:48 <jpich> Maybe someone wrote a prediction bot to save people's time
16:44:52 <absubram> david-lyle: haha yes.. I've only opened on bp myself (in grizzly!).. it's normally bugs that I open and that's more of what I was thinking of
16:45:00 <absubram> one*
16:45:46 <absubram> jpich: haha.. that'd be a nice bot to have!
16:47:54 <mrunge> ah no, I was just for something more checking than just watching if the menu item was added cgoncalves
16:48:21 <absubram> david-lyle: about my bp - https://blueprints.launchpad.net/horizon/+spec/neutron-subnet-mode-support… neutron side is still sitting on -1 review :(.. am tracking it daily.. I think amotoki is also a reviewer there
16:48:55 <absubram> will send you a note to let you know if they somehow get their code in
16:49:08 <david-lyle> absubram, thanks for the update, I have that bp slated as a possible FFE, may be on the neutron side too, not sure
16:49:26 <david-lyle> keep me posted
16:49:33 <absubram> will do
16:50:10 <absubram> I had a comment in my review about the edit subnet portion not working (wanted to talk to amotoki about that since he also has a comment in that piece of code)
16:50:28 <absubram> but its looking like neutron might not support edit in i.. only in J
16:50:51 <absubram> so even if we got our Horizon support in.. it would only be to add the two new ipv6 attributes during subnet create
16:50:59 <cgoncalves> mrunge: ok, thanks for your input here! do you happen to have a concrete idea of how that should be tested? any pointers? :-)
16:51:07 <absubram> we would have to fix update subnet in J
16:51:57 <mrunge> cgoncalves, look at the other tests, like launching machines, creating volumes...
16:52:36 <cgoncalves> mrunge: ok, will do.
16:52:55 <mrunge> cgoncalves, and if there's anything, feel free to drop me a note
16:53:39 <cgoncalves> mrunge: sure. thanks once again!
16:54:28 <absubram> on a separate note though.. I have a bunch of minor bug fix patches out in review and looking for reviewers :p.. I know everyone's trying to get the BP's in.. so whenever people get a chance.. (amotoki hehe)
16:55:06 <david-lyle> bugs will take a much higher priority after today
16:55:10 <jpich> bug fixes can be merged in till the RC, I think people will focus on these more once feature freeze has passed
16:55:11 <jpich> yeah
16:55:20 <jpich> stabilisation FTW
16:55:27 <mrunge> oh yes!
16:55:28 <absubram> yep.. figured so.. it's fine :) thanks
16:55:56 <mrunge> I can only encourage folks to install different environments to test!
16:57:50 <absubram> if we have time for open Qs.. I did have a question about one particular unit test that's giving me a little trouble on a separate issue.. the launch_instance_post
16:57:58 <absubram> if not I can send out an email to the mailer
16:58:51 <david-lyle> absubram, just post it in the regular room
16:58:58 <david-lyle> I don't think we have time here
16:59:02 <absubram> cool.. will do
16:59:05 <absubram> that's fine :)
16:59:58 <david-lyle> I'd like to thank everyone for the review efforts, core and non-core.  We've merged a lot of great work in icehouse and have a lot more ready for Juno.  If your bp doesn't make it into icehouse, I will target it for Juno as soon as it opens up. I think the release cycle is just here to add a huge amount of stress every 6 months. And, I suppose to keep us honest :) Thanks everyone.
17:00:26 <david-lyle> Have a great week!
17:00:30 <david-lyle> #endmeeting