16:03:44 <david-lyle> #startmeeting Horizon
16:03:45 <openstack> Meeting started Tue Jul  1 16:03:44 2014 UTC and is due to finish in 60 minutes.  The chair is david-lyle. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:03:46 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:03:48 <openstack> The meeting name has been set to 'horizon'
16:03:50 <jrist> o/
16:03:56 <jomara> hallo
16:03:56 <david-lyle> hello everyone
16:03:58 <crobertsrh> hello
16:04:00 <gary-smith_> hi
16:04:03 <tmazur> hello o/
16:04:07 <jgravel> hello
16:04:10 <jtomasek> hey
16:04:16 <lcheng__> hello
16:04:16 <tsufiev> hi
16:04:23 <clu_> HI!
16:04:27 <tzumainn> hiya!
16:05:19 <david-lyle> First general announcement: Welcome Ana and Zhenguo to the Horizon core team
16:05:27 <jpich> Welcome \o/
16:05:39 <tqtran> welcome!
16:05:44 <tmazur> Welcome!
16:05:48 <gary-smith_> welcome
16:05:48 <jomara> w00t, good job you two
16:05:51 <clu_> congrats
16:05:52 <doug-fish> congratulations!
16:05:55 <johnma> Congratulations
16:05:56 <tzumainn> congrats : )
16:06:03 <tzumainn> I think ana is on pto, though
16:06:05 <lcheng__> congrats, well deserved! :)
16:06:12 <jgravel> congrats!
16:06:20 <jrist> no she is not tzumainn
16:06:26 <jrist> she is at the mid-sprint for Horizon in Paris
16:06:29 <jtomasek> congrats!
16:06:46 <david-lyle> second item is https://launchpad.net/horizon/+milestone/juno-2
16:07:07 <jcoufal> o/
16:07:09 <david-lyle> this has over 50 blueprints targeting it
16:07:21 <david-lyle> that is a huge review load
16:07:45 <david-lyle> I would be happy if those slated as Needs Code Review made it
16:08:10 <david-lyle> considering J-2 closes on July 24
16:08:36 <david-lyle> most items that haven't been started are just started will likely end up in J-3
16:09:33 <clu_> yikes!
16:10:11 <david-lyle> There was only one item on the agenda today
16:10:25 <david-lyle> #topic SCSS Patches
16:10:44 <david-lyle> doug-fish or jtomasek?
16:10:48 <doug-fish> this came about during review of https://review.openstack.org/#/c/90371/
16:10:52 * jrist votes merge
16:10:52 <jtomasek> discussion regarding this is here: http://lists.openstack.org/pipermail/openstack-dev/2014-June/038971.html
16:11:18 <doug-fish> basically, the patch is for converting to SCSS, but in the level of bootstrap we have there are defects ....
16:11:36 <doug-fish> the defects will get fixed when we upgrade bootstrap
16:11:36 <david-lyle> that are particular to the SCSS version?
16:11:40 * jtomasek votes for merging too as that will definitely speed up the process
16:11:49 <jtomasek> david-lyle: yes
16:12:08 <jrist> I just don't think it's worth sitting on this patch for weeks/months, especially since we're near the beginning of Juno
16:12:10 <jtomasek> it is the bootstrap-scss pipy package that has the error
16:12:23 <doug-fish> Question is should we merge the SCSS conversion now, with its low impact but obvious bugs, or should we merge it now and fix later
16:12:41 <lblanchard> hi all!
16:12:42 <doug-fish> IMO we should be using patch dependencies to handle this
16:12:44 <david-lyle> what is the bug that surfaces?
16:12:57 <doug-fish> some of the buttons are styled strangely
16:13:01 <jtomasek> buttons on hover have wrong ackground
16:13:08 <tqtran> how long would it take to get a patch for bootstrap going?
16:13:38 <jtomasek> tqtran: it depends, but I have started looking into it and I'd like to have it finished next week
16:14:13 <jtomasek> it requires to get new bootstrap-scss version to requirements - I have created patch for that already
16:14:45 <jtomasek> and then go through the templates and code and update whatever is needed to adjust to new bootstrap
16:15:06 <jtomasek> I have already done this patch once, so I can base on that
16:15:26 <david-lyle> the bugs are merely cosmetic then? as they are SCSS related.  we can probably live with that until we can get the upgrade in
16:15:36 <jtomasek> +1
16:15:40 <doug-fish> yes, they are cosmetic
16:15:43 <david-lyle> I would be nice if the lag isn't too great
16:15:53 <tqtran> agree
16:16:03 <jrist> lag should be smaller with follow-on patches
16:16:08 <david-lyle> but a week or two with cosmetic issues is acceptable in my eyes
16:16:13 <jrist> much higher if we wait for dependent hell
16:16:13 <jtomasek> david-lyle: I'll try to makit as fast as possible
16:16:34 <doug-fish> So then its just a matter of getting core reviewers on https://review.openstack.org/#/c/90371/
16:16:35 <jrist> fwiw we've been bugging him for months to finish it :)
16:16:37 <jrist> jk
16:16:37 <jrist> haha
16:17:00 <jtomasek> jrist :)
16:17:01 <doug-fish> It sound like there is agreement merging is the right thing to do, despite cosmetic defects
16:17:18 <jrist> they are quick to fix and easier to uncover with more eyes
16:17:18 <david-lyle> looks like that patch needs a rebase
16:17:37 <david-lyle> better motivation to upgrade bootstrap
16:18:22 <david-lyle> #info merge less to scss conversion as soon as ready, bootstrap upgrade to follow shortly
16:18:45 <david-lyle> #topic Open Discussion
16:19:09 <crobertsrh> Sahara merge stuff....
16:19:34 <crobertsrh> We've had some more reviews this week.  A few from cores.  Changes continue to be small.  Since those reviews appear to be settling down, I have started porting a handful of changes that were made after the merging effort got underway (way back in April).  The velocity of reviews needs to increase in order to hit j2.
16:20:02 <jrist> yeah lets get cores on that! :)
16:20:14 <jrist> I've reviewed your massive patches like 5 times now
16:20:18 <jrist> it's a pain but lets get it done
16:20:31 <tmazur> Cores are working but there are a lot of nits and a lot of locs
16:20:43 <david-lyle> crobertsrh: I think the only blocker for the first patch at this point is the strange namespace workaround
16:21:14 <crobertsrh> Right.  I'm not so sure that the code wasn't intended to work that way.
16:21:21 <crobertsrh> But you guys would know for sure.
16:21:47 <david-lyle> I have it loaded in my devstack and I'm playing around with it now, to figure out the issue
16:22:29 <crobertsrh> Ok.  I went ahead and made that change after nobody responded to my email about the issue.  I took that as "go fly a kite, our code is just fine....deal with it"
16:23:27 <tmazur> And I still found issues when testing sahara stuff...
16:23:39 <david-lyle> crobertsrh: I think the issue is we're not sure
16:23:46 <crobertsrh> :)
16:23:58 <tmazur> crobertsrh, you mean "Other" naming?
16:24:05 <david-lyle> would like to figure it out before we approve a workaround
16:24:22 <crobertsrh> tmazur:  Yeah, the "workaround"  or "work-within" is for the "Other" naming
16:25:36 <tmazur> crobertsrh, I already wrote you at the bug report page my thoughts about this
16:26:38 <david-lyle> so, we need to work this out, but the plus side is it's getting lots of eyes
16:27:07 <crobertsrh> Great.
16:29:12 <david-lyle> Any other items?
16:29:58 <tqtran> any update on the client-side meetup?
16:29:58 <tsufiev> i'd like to ask about best practices for testing changes in client code
16:29:58 <david-lyle> https://etherpad.openstack.org/p/juno-horizon-meetup indicates there is limited interest in a late mid-cycle meetup
16:30:22 <tqtran> yeah....
16:30:36 <david-lyle> I'd like to give it another week to see if there is any more interest
16:31:01 <tsufiev> namely, I've started fixing the bug https://bugs.launchpad.net/horizon/+bug/1191006, but don't whether or not should I write tests for it
16:31:11 <david-lyle> I think it's difficult to express too strong an interest without a location in mind, so people know what travel arrangements they would have to get approved
16:32:11 <tqtran> thats true
16:33:07 <tqtran> party at my house? jk =P
16:33:33 <david-lyle> tsufiev: it would certainly be nice to have tests around it, but the reward/effort ratio has to be favorable
16:34:49 <david-lyle> Fixing the bug would be valuable even if we can't get a test to back it
16:35:43 <johnma> do these test cases that we write help towards the integration test effort that jpich is leading or is that a seperate set of test cases
16:35:55 <tsufiev> david-lyle, are there some general guidelines on writing js-code unit-tests in horizon? i'm a bit new to this kind of tests...
16:36:04 <david-lyle> we have a ton of javascript test debt that you can't be expected to take on to fix the bug.  New clientside functionality however should include tests
16:36:49 <david-lyle> tsufiev: there are two (yes two) javascript test frameworks in Horizon now, qunit and Jasmine, I would base a test of such examples
16:37:25 <david-lyle> there are not many, although for interaction testing the integration tests using Selenium are probably a better example to follow
16:37:48 <david-lyle> johnma: we have both
16:37:56 <tsufiev> david-lyle, should I write tests using both frameworks :) or one of them will suffice?
16:38:16 <david-lyle> tsufiev: one is plenty
16:38:22 <david-lyle> legacy vs future
16:38:38 <david-lyle> Jasmine will work better for angular
16:38:49 <tsufiev> ok, got it
16:40:44 <david-lyle> johnma: to follow on, I'm not sure testing this particular case in integration tests is necessary or beneficial as integration is not required
16:40:55 <david-lyle> for the tested functionality
16:41:35 <tsufiev> david-lyle, the other thing I wanted to ask is how the overall process of assigning bugs in Horizon is organized (as I'm starting to contribute more systematically to Horizon)? So, if bug is assigned to no one, I'm free to take it, otherwise (say, I have ready fix) I should discuss it on irc meeting, am I right?
16:41:47 <johnma> right, that makes sense David. Thank you
16:42:43 <doug-fish> I'm looking at the j-2 content list - there is a bug regarding quotas not being editable and I don't see that on the j2 list.  I think the fix has been out for review for a while
16:42:44 <doug-fish> https://bugs.launchpad.net/nova/+bug/1299517
16:42:52 <doug-fish> is that something that could be targetted for j-2?
16:43:07 <david-lyle> tsufiev: if there is not an owner, feel free to assign yourself to it, if there is an owner and you have a fix or interest, feel free to contact the assignee and ask if they are still interested/working on the bug
16:43:37 <david-lyle> if they have a strong desire to keep working on it, feel free to provide a suggestion in the bug on LP
16:43:57 <jpich> and offer your help reviewing the fix once it's ready :-)
16:44:22 <tsufiev> david-lyle, ok, will do :)
16:44:30 <david-lyle> if it sits stagnant for an extended period of time, a core can reassign it, but that doesn't need to happen very often
16:45:51 <jpich> I think if you've contacted the owner / left a comment on a bug that's been assigned for a long time and there's no answer it's ok to just take it on - but it's best etiquette to ask first
16:46:02 <david-lyle> doug-fish: if I recall that issue correctly, the support is in Horizon already, the problem is they removed the functionality from nova and need to restore it
16:46:08 <doug-fish> that's true
16:46:15 <doug-fish> but the support in nova has been readded
16:46:37 <doug-fish> and backported to icehouse
16:47:04 <jpich> I set the milestone to increase visibility
16:47:15 <jpich> I wonder if we should aim to backport it too
16:47:35 <doug-fish> Backporting makes sense to me, but it was unclear how translation might play in to that
16:47:59 <tsufiev> jpich, yep, will keep that in mind
16:47:59 <doug-fish> I assume at one time that panel was translation
16:48:39 <doug-fish> s/translation/translated
16:49:39 <jpich> First step is to get it into master anyway, we can ask the translation team for input later on. Previously they weren't opposed to additional small additions in translations in stable releases as long as they had some notice to work on them
16:50:09 <david-lyle> doug-fish: somehow I had missed that patch altogether, thanks for raising the issue
16:50:14 <doug-fish> sure, np
16:53:27 <david-lyle> I'm going to end early just so that I can say that I've done that at least once.  And we seem to run out of things to say to each other ;)  Thanks everyone for the reviews and have a great week.
16:53:34 <david-lyle> #endmeeting