16:01:52 <david-lyle> #startmeeting Horizon
16:01:52 <openstack> Meeting started Tue Jul 15 16:01:52 2014 UTC and is due to finish in 60 minutes.  The chair is david-lyle. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:01:53 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:01:56 <openstack> The meeting name has been set to 'horizon'
16:02:05 <david-lyle> Hello everyone
16:02:08 <tmazur> hello o/
16:02:10 <crobertsrh> Hello
16:02:14 <gary-smith_> hi
16:02:15 <doug-fish> Hi
16:02:16 <jrist> o/
16:02:17 <david-lyle> and welcome to a new installment of this week in Horizon
16:02:19 <lcheng> o/
16:02:22 <clu_> HI!
16:02:24 <jrist> haha
16:02:26 <david-lyle> I'll be your host
16:02:27 <ericpeterson> hi
16:02:30 <jrist> cheesy PBS music
16:02:33 <david-lyle> let's meet the panelists
16:02:39 <ericpeterson> two ferns
16:02:45 <akrivoka> hello
16:03:00 <tsufiev> hi
16:03:10 <tzumainn> hiya
16:03:24 <david-lyle> so July 24 is rapidly approaching
16:03:26 <david-lyle> https://launchpad.net/horizon/+milestone/juno-2
16:03:46 <david-lyle> I pruned most items not already up for review
16:03:53 <jtomasek> hey
16:04:04 <david-lyle> will likely prune some more today to let us focus our review attention
16:04:24 <david-lyle> several Sahara patches are getting very close
16:04:37 <rdopiera> hi
16:04:39 <david-lyle> should have most of those merged in J-2
16:04:41 <hurgleburgler> Hello
16:04:46 <jcoufal> o/
16:04:47 <david-lyle> thanks for the review attention on those
16:04:56 <crobertsrh> Yes...many thanks!
16:05:03 <tmazur> Yep, Sahara is merging.
16:05:15 <david-lyle> There are a couple of other I would like to get more status on
16:05:42 <david-lyle> https://blueprints.launchpad.net/horizon/+spec/navigation-styling and https://blueprints.launchpad.net/horizon/+spec/top-bar-styling
16:05:44 <jomara> ahoy!
16:05:58 <david-lyle> jcoufal: you had patches up for those in Icehouse, no?
16:06:17 <david-lyle> are you going to revitalize those, or put up new patches?
16:06:26 <david-lyle> and is that a j-3 target now?
16:06:43 <jcoufal> david-lyle: let's do it j-3, I will make sure we get it there
16:06:48 <david-lyle> jtomasek: how is https://blueprints.launchpad.net/horizon/+spec/bootstrap-update going
16:06:54 <jtomasek> david-lyle: https://review.openstack.org/#/c/107042/
16:07:11 <david-lyle> did that go in today?
16:07:14 <david-lyle> jtomasek:
16:07:22 <jtomasek> most of the stuff should be done, I'll continue working on it.
16:07:24 <jtomasek> david-lyle: yes
16:07:39 <david-lyle> ah, that's why I didn't see it yesterday ;)
16:07:46 <jtomasek> david-lyle: I'd really appretiate the reviews and some help too
16:08:15 <david-lyle> jtomasek: since I haven't looked at the review yet, what is needing help?
16:08:27 <jtomasek> david-lyle: I just wonder how to make the cooperetion on this as simple as possible
16:08:42 <clu_> hi jtomasek, i see the review as Workflow (X) - should that be removed so ppl will review it?
16:08:44 <lblanchard> hiya all
16:08:48 <jtomasek> david-lyle: mostly look for bugs and things that need to get fixed
16:09:15 <jtomasek> clu_: yeah, no problem. I didn't know it prevented people from reviewing
16:09:18 <david-lyle> ok, I will look at it some, any one else able to take a look
16:09:42 <david-lyle> jtomasek: doesn't prevent, but usually indicates it's not ready
16:09:42 <clu_> yep, me!
16:10:19 <david-lyle> jtomasek: I think if we find bugs and have fixes, we can post revisions to your patch
16:10:31 <david-lyle> as long as you're good with that
16:10:48 <jtomasek> david-lyle: ok,sure no problem!
16:11:30 <jtomasek> I removed workflow -1
16:11:55 <david-lyle> rdopiera: https://blueprints.launchpad.net/horizon/+spec/remove-javascript-bundling seems to be blocked by openstack/requirements is that the summary?
16:12:18 <rdopiera> david-lyle: yes
16:12:34 <rdopiera> david-lyle: although it seems that we finally got to some agreement about the versions
16:12:47 <jtomasek> david-lyle: clu_ : when you have found a bug and you inted to fix it, please note it in comments so we avoid working on the same thing
16:12:55 <rdopiera> david-lyle: so I'm hopeful :)
16:13:07 <clu_> jtomasek, k!
16:13:10 <david-lyle> ok, we now have two patches blocked by requirements changes
16:13:36 <david-lyle> I'll see if I can find some +2s
16:13:46 <rdopiera> that would help a lot, thank you
16:14:12 <david-lyle> mrunge, rdopiera, https://blueprints.launchpad.net/horizon/+spec/separate-horizon-from-dashboard seems blocked by the above bp so I'm going to move to j-3
16:14:39 <david-lyle> really need to get that to land in early j-3 or we'll have to push to K
16:14:41 <rdopiera> yes
16:16:07 <david-lyle> any other questions comments about what's slated for j-2?
16:16:14 <david-lyle> tzumainn: updated dashboard?
16:16:18 <david-lyle> :P
16:16:38 <tzumainn> david-lyle, you mean for tuskar-ui?
16:16:40 <tzumainn> oh
16:16:42 <tzumainn> right
16:16:44 <tzumainn> nevermind, yeah
16:16:52 <tzumainn> sorry, moment of confusion, give me a sec to shorten the url
16:17:17 <tzumainn> david-lyle, 	http://goo.gl/ZQObiL
16:17:34 <david-lyle> boom
16:17:37 <david-lyle> thanks tzumainn
16:17:41 <tzumainn> np!
16:17:43 <david-lyle> agenda for today: https://wiki.openstack.org/wiki/Meetings/Horizon
16:18:03 <david-lyle> #topic Client-side table rendering (https://review.openstack.org/#/c/94706/) thai tran, eric peterson
16:18:28 <tqtran> hi folks, wanted to bring to your attention that the patch is ready for review
16:18:31 <ericpeterson> We are getting farther .... have tests nearly working nwo
16:18:57 <rdopiera> nearly :)
16:18:59 <ericpeterson> but it's a patch that might be best if interested people just download it and run it
16:19:08 <david-lyle> so the summary is this is mechanism to do client side loading of table data
16:19:27 <david-lyle> and can be used inline in place of the synchronous table loading now
16:19:30 <ericpeterson> yes.   if you download / review the patch... the instances table now loads the table async
16:19:36 <tqtran> yes, basically. its sort of like a flag that you can switch on to get angular to render your data instead
16:19:48 <ericpeterson> we picked a nice easy table like the instances view :D
16:20:01 <david-lyle> but I want my 1990's internet back
16:20:35 <david-lyle> this will be a nice change and ability to have once we can merge it
16:20:43 <ericpeterson> you can actually have that too, at least as the patch currently stands.... you can add an extra query param to switch the format to old
16:20:46 <tqtran> david: you can have your dial-up back, just +2 it
16:20:59 <david-lyle> get off my lawn
16:21:08 <tqtran> haha
16:21:18 <ericpeterson> we will take out that query flag eventually.... it's there just so reviewers can look at both versions and compare
16:22:18 <david-lyle> thanks for the great work and once j-2 settles a bit, I'm sure it will get more review attention
16:22:28 <david-lyle> #topic Improve help messaging on modals https://review.openstack.org/#/c/104334/ (clu_)
16:22:35 <clu_> hi
16:22:49 <clu_> We'd like Horizon to improve help text on the modals - community member Ashish has started the work on this here: https://review.openstack.org/#/c/104334/
16:22:50 <clu_> Does anyone have any objections to changing text from:
16:22:52 <clu_> "From here you can create a new domain to organize projects, groups and users." ==> "Create a domain to organize projects, groups and users."
16:22:53 <clu_> "From here you can set quotas (max limits) for the project." ==> "Set quotas (max limits) for the project."
16:23:43 <david-lyle> removing the "From here you can"? that's the most important part
16:23:49 <david-lyle> :)
16:23:51 <clu_> yep
16:23:53 <david-lyle> no objections
16:23:59 <david-lyle> from me
16:24:03 <ericpeterson> +1 from here
16:24:16 <johnma> sounds good to me
16:24:26 <tmazur> clu_, nice improvement
16:24:31 <jpich> lblanchard had an awesome document on how to write good error and general messages - Liz do you have a link handy and/or thoughts on this rephrasing?
16:24:34 <lcheng> +1
16:24:41 <rbertram> I like it. Is UX involved in this? Or should they be?
16:24:50 <lblanchard> jpich: for sure…let me find it :)
16:25:26 <jpich> Ah I got it! https://wiki.openstack.org/wiki/UX/Improve_User_Experience_of_Messaging_in_Horizon#Tips_and_Best_Practices_for_all_Messages:
16:25:44 <johnma> this link is also mentioned in the defect that clu_ mentioned
16:25:47 <lblanchard> jpich: beat me to it :)
16:26:35 <jpich> lblanchard: Do you have any thoughts on the change suggested by clu_ above? It seems nice and more concise to me but you've thought about this more :-)
16:26:44 <jpich> johnma: My bad, I didn't notice
16:27:15 <tqtran> lblanchard: would be good if you a take a look at the patch and +1 it liz
16:27:43 <lblanchard> jpich, tqtran: I can definitely take a look
16:27:50 <david-lyle> lblanchard: thanks
16:27:53 <jpich> Thanks!
16:28:01 <clu_> thanks everyone, great!!!
16:28:49 <david-lyle> #topic Open Discussion
16:29:59 <tsufiev> could I take the bug https://bugs.launchpad.net/horizon/+bug/1158501 ? Previous assignee haven't been showing for a while
16:30:24 <david-lyle> I thought there was a patch for the duplicate session expiration message/form, does anyone know where that is?  that problem is really annoying
16:30:55 <tsufiev> david-lyle, here it is https://review.openstack.org/#/c/88220/
16:31:12 <tsufiev> blocked by pending change in openstack_auth
16:31:54 <david-lyle> tsufiev: on launchpad are you tsufiev or tsufiev-x?
16:31:58 <jpich> tsufiev: Usually I recommend asking first like you did, but when there's no activity for 4 months it's probably fine to go ahead and pick it up if you have a fix ready
16:32:09 <tsufiev> david-lyle, tsufiev-x
16:32:19 <david-lyle> yours
16:32:29 <tsufiev> thanks )
16:32:36 <david-lyle> thank you for following the established proceedure
16:32:48 <clu_> tsufiev: looking forward to it :)
16:32:49 <rdopiera> I wonder if there is a reason for the fact that the login form on / doesn't load any scripts, while the one on /auth/login does
16:33:06 <rdopiera> and if it's intetional
16:33:12 <rdopiera> intentional even
16:33:32 <tsufiev> david-lyle,  another thing that is not yet clear to me is a relation of this modal/upload bug to the file-upload-redux blueprint, see https://bugs.launchpad.net/horizon/+bug/1158501/comments/2
16:34:06 <david-lyle> ericpeterson: do you remember why there's two?
16:34:07 <doug-fish> rdopiera:  yes, good question.  Would be great to get the same behavior/appearance on both versions of the login screen.
16:34:09 <tsufiev> clu_, will do my best )
16:34:34 <david-lyle> may have been driven by the requirement to support non-js sessions
16:35:12 <ericpeterson> It might be when you switch regions / re login....
16:35:19 <ericpeterson> that gets poped up as a modal ??
16:35:29 <ericpeterson> at least it was that way at one point?
16:35:39 <doug-fish> david-lyle:  I'm not sure I understand what "requirement to support non-js sessions" means
16:35:43 <ericpeterson> and this is historical / legacy stuff
16:36:25 <rdopiera> I will report it as a bug then
16:36:46 <ericpeterson> the file names that are preceeded with a _ character are what gets used for a modal view....  and we had a fallback to use the other file name when js modal was not available
16:37:14 <rdopiera> and try to fix it
16:37:15 <ericpeterson> most of the time the file.html just includes the _file.html in the modal views
16:37:29 <david-lyle> tsufiev: I think it's ok go ahead and fix the bug
16:37:54 <tsufiev> david-lyle, ok
16:38:18 <david-lyle> rdopiera: +1
16:38:33 <tmazur> Speaking about reviews and J-2.. I hate to ask but it seems that my own patch sets are going to stuck in limbo. Thank you david-lyle for your +2 today however they need a bit more attention.
16:39:00 <david-lyle> tmazur: a lot of patches have been starved for attention
16:39:31 <tmazur> david-lyle, I'd love to review them all but I can't :)
16:39:48 <david-lyle> the dashboard that tzumainn posted before really helps draw attention to the j-2 milestone items
16:40:01 <david-lyle> I've been walking down the list as far as I can
16:41:16 <david-lyle> as for the sahara patches, I think we're going to have to let some blemishes in and fix after the fact.  The 2700+ LOC patch pretty much guarantees it will happen either way
16:42:11 <david-lyle> Things like exceptions popping up to the use etc, I would like fixed before hand, as best we can, but it will be easier to push minor cleanup later
16:42:50 <david-lyle> s/use/user/
16:43:57 <crobertsrh> Thanks for the good eyes on the reviews.
16:45:25 <absubram_> david-lyle: sorry to pile on :).. but thanks to tzumainn and jpich, I was able to make some small changes to the operational code for my review.. and now there is no more duplication of tests or a change to test/settings needed.. I know you higher priority reviews, but whenever you can give it a second look, would be great.. thanks!
16:45:56 <absubram_> amotoki: If amotoki is here.. if you could take a second look too would appreciate it.. thanks!
16:46:01 <david-lyle> absubram_: I hadn't realized you had worked through it, I will take a look
16:46:20 <absubram_> yep.. got it working finally last week and just updated the review a short while back :)
16:46:21 <david-lyle> I assume my suggestion was way off base and you came up with a better one?
16:46:34 <amotoki> absubram_: hi
16:47:07 <absubram_> haha not completely.. went with the similar line of thought - of making a change in the operational code.. but did manage to avoid duplication
16:47:32 <david-lyle> excellent, thanks for all your efforts to make it right
16:48:14 <absubram_> hi amotoki! I finally managed to address both your comments from the review and get it working.. I've updated it.. if you coould take a look when you can, it would be great..
16:48:37 <absubram_> thanks david.. I'm glad I did.. this is definitely a much better solution :)
16:49:47 <absubram_> https://review.openstack.org/#/c/90093/
16:49:47 <amotoki> absubram_: sorry for my less review activity these weeks. I am happy to hear you addressed the comments :-)
16:49:51 <amotoki> absubram_: will look
16:50:39 <absubram_> amotoki: no worries.. thanks for the suggestions.. it took a little effort getting it to work haha!
16:51:01 <absubram_> thanks again to tzumainn too for pointing out the change needed
16:51:13 <tzumainn> absubram_, lol, not at all, it was a fun exercise
16:55:29 <david-lyle> any last minute items?
16:56:33 <david-lyle> Thanks everyone! Have a great week.
16:56:36 <david-lyle> #endmeeting