16:00:52 <david-lyle> #startmeeting Horizon
16:00:53 <openstack> Meeting started Tue Jul 22 16:00:52 2014 UTC and is due to finish in 60 minutes.  The chair is david-lyle. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:54 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:57 <openstack> The meeting name has been set to 'horizon'
16:01:00 <david-lyle> Hello everyone
16:01:02 <tmazur> hello o/
16:01:12 <jgravel> hi
16:01:21 <clu_> hi!
16:01:23 <asahlin> Hello
16:01:25 <tsufiev> hi
16:01:47 <amotoki> hi
16:02:13 <crobertsrh> hello/
16:02:17 <david-lyle> I think EuroPython is going on right now and we have a few that won't make it to this meeting as a result
16:03:16 <david-lyle> J-2 closes on July 24
16:03:42 <david-lyle> https://launchpad.net/horizon/+milestone/juno-2
16:03:51 <david-lyle> we have a lot of items that still need review
16:04:37 <david-lyle> https://blueprints.launchpad.net/horizon/+spec/bootstrap-update is a large item that I would like to discuss first
16:05:13 <david-lyle> Tihomir proposed merging it and fixing the bugs related to the merge rather than trying to fix everything up front
16:05:23 <david-lyle> I think this is a good idea
16:05:43 <jrist> o/
16:05:44 <david-lyle> would like to know if there is a strong opposition to this path
16:05:59 <jrist> +1
16:06:00 <doug-fish> none here.  Getting that in is the path to getting it right.
16:06:06 <ericpeterson> +!
16:06:09 <ericpeterson> +1
16:06:10 <tqtran> +1
16:06:12 <clu_> +1!
16:06:29 <amotoki> agree. good direction
16:06:44 <david-lyle> so horizon in j-2 will have some visual issues
16:07:07 <david-lyle> I think that's fine, as it's not the final juno release
16:07:39 <clu_> it'll be easy to add small patches afterwards :)
16:07:53 <jrist> s/easy/easier/g
16:08:03 <david-lyle> ok, it's on it's long journey through the gate process
16:08:16 <clu_> should we write bug reports for that or just go off the etherpad list when picking off bugs?
16:08:39 <david-lyle> there are a few sahara patches that need another +2
16:09:01 <david-lyle> this is another case where I think we can only fix so much before we merge it
16:09:22 <ericpeterson> clu_ : I would prefer to have real bugs entered vs just a etherpad line of text
16:09:40 <david-lyle> remove the most egregious errors and move on to fix
16:10:11 <doug-fish> +1 on ericpeterson's suggestion
16:10:11 <david-lyle> two items are still blocked by requirements changes
16:10:37 <david-lyle> ericpeterson, doug-fish definitely should be launchpad bugs
16:10:57 <clu_> ericpeterson - okey, will open and tag bug reports with 'bootstrap' or something
16:11:10 <david-lyle> clu_: thanks
16:11:23 <clu_> np :)
16:12:34 <david-lyle> so please keep up with the reviews and let's get a few more bps merged into j-2
16:12:44 <david-lyle> the rest will slip to j-3
16:13:19 <david-lyle> That's the only item I had for the agenda today
16:13:27 <david-lyle> #topic Open Discussion
16:13:55 <crobertsrh> I think you covered my usual bit on sahara merge reviews....thanks.
16:14:13 <ericpeterson> anyone have some insight into when builds will get a bit more predictable ????
16:14:35 <ericpeterson> the gozer / zuul / review jobs / whatever stuff I mean
16:15:46 <david-lyle> ericpeterson: not really, there has been some discussion of the problem on the mailing list, but I haven't seen a road to an improvement yet
16:16:32 <tqtran> Clientside table rendering could use some love. https://review.openstack.org/#/c/94706/
16:16:33 <ericpeterson> a developer can dream, I guess
16:16:36 <david-lyle> unfortunately most of these bugs in the gating process are either race conditions in the tests, or issues in the code illuminated by the timing of the tests running
16:16:52 <doug-fish> Not a blueprint, but a bug fix I'd love to se go into j-2:  https://review.openstack.org/#/c/91338/  It's an enabler for making better translations for other panels too.
16:17:46 <david-lyle> doug-fish  I like fixing the issue, but oh my the solution is ugly
16:18:06 <david-lyle> no offense to ygbo
16:18:19 <doug-fish> lol
16:18:25 <tqtran> yeah, i think it can be done in a smaller patch
16:18:49 <david-lyle> you went from a one line class property to many line of method call for every action
16:19:10 <tqtran> heres something else to consider doug, the angular patch im introducing will help with translation as well
16:19:14 <david-lyle> seems like we could make it more developer friendly to get right
16:19:26 <tqtran> everything gets serialize to json, including the batch action names
16:19:39 <david-lyle> I'll leave my comments, as I see I forgot to last time I looked at the patch
16:19:42 <tsufiev> if anyone is already tired with modal forms losing modality when FileInput appears, the patch https://review.openstack.org/#/c/107769/ is ready for review
16:20:13 <doug-fish> david-lyle:  cool, thx - will be good to get attention on that and see if those concerns can be addressed
16:20:29 <clu_> tsufiev: YES!!!
16:20:43 <doug-fish> tqtran:  I actually didn't realized the angular fix would change that processing, I'll have to look at that more closely.
16:20:48 <tsufiev> clu_, I know you would be interested :)
16:21:02 <david-lyle> tsufiev: I'll take a look
16:21:22 <tsufiev> david-lyle, thank you :)
16:22:53 <tqtran> doug: it doesnt fix the processing, but it does make it easier
16:23:01 <david-lyle> tqtran: I'm trying to make it to the clientside table patch
16:23:12 <tqtran> david: awesome =)
16:23:47 <tqtran> would love to get some feedback from others before you get there
16:24:31 <amotoki> BTW, I would like to know some pointers related to review guidelines. I think there are some references on I18N and UX review guidelines but I couldn't find them so far...
16:24:49 <amotoki> if anyone has links, it will be appreciated.
16:25:06 <doug-fish> maybe https://wiki.openstack.org/wiki/I18n/TranslatableStrings
16:25:27 <amotoki> doug-fish: thanks. that's what I am looking for.
16:25:32 <doug-fish> cool, yw
16:26:05 <amotoki> i will add it to https://wiki.openstack.org/wiki/Horizon/Reviews after the meeting.
16:27:59 <amotoki> If anyone knows good guidelines or referecens for reviews, please add information to the above page. I would like to collect pointers to share.
16:31:26 <gugl> Also appreciate a good guideline for exception handling in Horizon. Have notice quite bit of code catched the exception, but lost it when present to the user.
16:33:14 <david-lyle> just typed some stuff in the wrong window
16:33:16 <david-lyle> :)_
16:33:28 <asahlin> amotoki:  As a newbie, a central place with pointers to documentation would be extremely helpful
16:33:35 <david-lyle> let's review this to make sure it's accurate and helpful
16:33:49 <david-lyle> https://review.openstack.org/#/c/100718/
16:34:08 <david-lyle> the old tutorial is just cruel
16:34:13 <gugl> david-lyle, thanks
16:37:11 <david-lyle> Any additional items?
16:38:25 <tqtran> just something in the back of my mind, we need more code control for javascripts
16:38:42 <david-lyle> code control?
16:38:49 <david-lyle> like verification tools?
16:38:51 <tqtran> some files define functions a certain way, others a another way
16:38:59 <tqtran> and the styling is all over the place
16:39:44 <david-lyle> yes
16:39:49 <david-lyle> :)
16:39:49 <rbertram> thinking of jshint settings?
16:40:04 <tqtran> yes =)
16:40:18 <tqtran> i think we should recommend a tool/plugin for people to use with certain settings
16:40:31 <tqtran> that way, its all consistent and easier to review/read/code
16:40:54 <doug-fish> I'm sure I saw I patch to intergrate jshint into our automated testing
16:40:54 <rbertram> jshint plugs into most editors
16:41:04 <doug-fish> but can't recall where it is just now
16:41:18 <david-lyle> we've gone through a round of jshint standardization, there is a bp to use node based tools in the dev environment
16:41:29 <david-lyle> doug-fish: there was a license issue
16:41:39 <david-lyle> was merged, pulled back out in icehouse
16:41:43 <david-lyle> "do no evil"
16:41:49 <tzumainn> is it this patch?
16:41:49 <tzumainn> https://review.openstack.org/#/c/97237/
16:41:53 <doug-fish> I thought there was a new and improved version that came about later
16:42:07 <tzumainn> ah
16:42:22 <doug-fish> tzumainn, yeah that's it!
16:42:43 <david-lyle> whoa, totally missed that
16:42:47 <david-lyle> thanks
16:43:21 <rbertram> I assume the license problem was with jshint and not with node?
16:43:29 <doug-fish> right
16:43:47 <doug-fish> The jshint developer added an extra clause to the license
16:44:03 <doug-fish> which causes lawyers great concern
16:44:07 <tqtran> lol
16:44:23 <rbertram> yep, I've run into the "do no evil" clause before
16:44:38 <tqtran> "do no evil" sounds like google
16:46:23 <rbertram> Did the jshint license cause it to be pulled from the build? Still OK for dev environments?
16:47:01 <tqtran> so whats is the procedure to formalize/propose code styling guidelines?
16:47:26 <doug-fish> rbertram  certainly okay for dev environments
16:47:28 <tqtran> i think jshint is nice to have, but we should provide an independent guideline that "could" work with jshint
16:47:33 <doug-fish> well, unless you are using it for evil.  :-)
16:47:49 <david-lyle> the "evil" is more a problem for distros
16:49:18 <amotoki> if we pass DFSG and Fedora, it is okay in most cases :-)
16:49:23 <rbertram> tqtran: I agree. The guideline should cover the kinds of things jshint covers, and some other things specific to AngularJS and jQuery.
16:50:14 <david-lyle> tqtran: volunteering?
16:50:23 <tqtran> david: sure =)
16:50:23 * david-lyle ducks
16:50:29 <tqtran> lol
16:50:41 <rbertram> tqtran: I'll be glad to help
16:50:50 <david-lyle> tqtran, rbertram: thanks
16:50:53 <tqtran> rbertram: awesome, thanks
16:52:31 <amotoki> i would like to know your opinion on extension supported aliases in api/neutron.py.
16:52:38 <amotoki> https://review.openstack.org/#/c/74066/8/openstack_dashboard/api/neutron.py
16:53:31 <david-lyle> amotoki: seems like we should have a generalized capabilities method for neutron that is memoized
16:53:41 <amotoki> in api/neutron.py there are several number of wrapper methods for extension, but most of them are unnecesssrty
16:53:43 <david-lyle> is a general method not supported in neutron
16:54:29 <amotoki> is_extension_supported() method is already memoized.
16:54:59 <amotoki> So I think we don't need wrapper methods per extension.
16:55:07 <david-lyle> amotoki: so it is, and I agree
16:55:30 <david-lyle> didn't expand enough code above before
16:56:02 <amotoki> david-lyle: thanks. i will ask patch authors to remove them and i will clean up existing ones.
16:56:44 <david-lyle> amotoki: thanks for point it out, I think sometimes gerrit collapsing unchanged code is a disservice
16:57:10 <david-lyle> s/point/pointing/
16:57:21 <amotoki> david-lyle: that's all I have after catching up horizon reviews :-)
16:58:02 <david-lyle> Let's call it. Thanks everyone. Keep up with the reviews and have a great week.
16:58:07 <david-lyle> #endmeeting