12:00:33 <david-lyle> #startmeeting Horizon
12:00:34 <openstack> Meeting started Wed Jan 20 12:00:33 2016 UTC and is due to finish in 60 minutes.  The chair is david-lyle. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:00:35 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
12:00:39 <openstack> The meeting name has been set to 'horizon'
12:00:50 <robcresswell> o/
12:00:52 <toabctl> hi
12:00:55 <mrunge> good morning david-lyle, good morning all o/
12:00:55 <zabolzadeh> Hi
12:01:09 <betherly> o/
12:02:37 <david-lyle> After a couple weeks off, I'm back
12:02:40 <tsufiev> o/
12:03:02 <masco> welcome back david-lyle
12:03:54 <david-lyle> There is no formal agenda for today. But I have a couple of items
12:03:59 <david-lyle> First
12:04:09 <toabctl> I also have one topic
12:04:23 <zabolzadeh> welcome back david-lyle,
12:04:43 <david-lyle> toabctl lets talk mitaka-2 first and then we can hit your item
12:04:52 <toabctl> david-lyle: sure
12:05:12 <david-lyle> Mitaka-2 will be tagged either later today or tomorrow AM at the latest
12:05:25 <david-lyle> so anything that has not merged will miss it
12:05:49 <david-lyle> unless some raises an issue that we should hold the tag for
12:05:57 <david-lyle> think critical bug on master
12:06:11 <david-lyle> does any one know of any such issues?
12:06:47 <robcresswell> Nope
12:06:55 <robcresswell> All seems fine to me.
12:06:57 <masco> i have one medium bug with one +2
12:07:03 <mrunge> yupp, looks good
12:07:04 <masco> for m2
12:07:16 <kzaitsev_mb> my a bit late o/
12:07:32 <mrunge> give the state of the gate, I would expect some delays though...
12:08:28 <david-lyle> ok, we'll run with what we have
12:08:40 <david-lyle> I'll push the release today
12:10:51 <david-lyle> the M-2 list in Launchpad is pretty sparse, are there items missing?
12:11:21 <david-lyle> #link https://launchpad.net/horizon/+milestone/mitaka-2
12:12:01 <mrunge> it feels like yes
12:12:58 <mrunge> but I don't have anything specific in mind, what's missing there
12:13:07 <david-lyle> I just marked Keystone Identity Provider as complete
12:13:16 <david-lyle> I will look for more later
12:13:22 <robcresswell> I think alot of work falls under blueprints. The bugs seems all there
12:13:26 <amotoki> i think fixed bugs are not targetted to M-2.
12:13:35 <robcresswell> I don't know if many bps are actually complete right now though. I'll look too.
12:13:50 <david-lyle> 2 is just very low for us
12:14:04 <david-lyle> based on past performance
12:14:21 <david-lyle> will look at bugs too
12:14:40 <david-lyle> ok, moving on
12:15:28 <david-lyle> I also want to check in quickly on the priorities list for Mitaka
12:16:51 <david-lyle> #link https://etherpad.openstack.org/p/mitaka-horizon-priorities
12:17:39 <david-lyle> for plugins, remaining documentation patches seem stalled
12:18:20 <robcresswell> Yeah, there's tons of comments on there
12:18:51 * david-lyle needs to read them
12:18:52 <robcresswell> There's ongoing work with plugin i18n too I believe. The JS part was solved, but we still need a better infra job for automating it.
12:19:32 <david-lyle> yes trove-dashboard is the proving ground I believe
12:19:47 <amotoki> re translations, ajaeger and i are working on translation setup on infra https://review.openstack.org/#/c/262545/
12:20:28 <amotoki> I believe it helps translation setup on horizon plugins.
12:20:39 <david-lyle> thanks amotoki
12:20:54 <robcresswell> Yes, I wasn't aware of that, scanning now, looks great! thanks!
12:20:59 <david-lyle> will read through that as well
12:21:23 <amotoki> i plan to write up a devref about this once it lands.
12:22:20 <david-lyle> robcresswell: for the horizon documentation patches are they of the "perfection is the enemy of good" variety, or what about this gaping whole variety?
12:22:27 <david-lyle> they === comments
12:24:41 <robcresswell> Er, a lot of them seem to be "This doesnt work"
12:25:05 <david-lyle> well we can't really skip those
12:25:07 <david-lyle> :)
12:25:39 <robcresswell> Yeah. I can do a pass on it if you like. I don't like the layout either, it really needs to be python or angular sections
12:25:51 <robcresswell> the mix and match is very confusing for those not familiar with horizon
12:26:24 <david-lyle> robcresswell: I agree, I keep starting the python side of things and stalling
12:27:01 <david-lyle> will see what I have and maybe do that separately
12:27:09 <david-lyle> we need some docs in Mitaka
12:28:05 <robcresswell> 100%, its critical.
12:28:17 <david-lyle> For angular content, I see lots of patches going by, not sure if they are getting us to our goal though
12:28:30 <david-lyle> some efforts seem stalled, others moving forward
12:28:34 <robcresswell> A lot of the easy ones are going in.
12:28:42 <robcresswell> But not much of the solid content.
12:29:00 <robcresswell> The images stuff seems to be mostly done, but needs reviews.
12:29:22 <zabolzadeh> robcresswell: Which parts are fully anguralized in horizon till now?
12:29:41 <robcresswell> So we could do with that to build patterns off. We also need to get magic search fixed because its blocking plugins like Magnum-ui
12:29:53 <robcresswell> zabolzadeh: Nothing in master uses a full angular panel.
12:30:30 <zabolzadeh> robcresswell: So, we won't have any angular content in Mitaka, is it?
12:30:50 <robcresswell> The plan is to get a couple of panels merged.
12:31:15 <tsufiev> zabolzadeh, AFAIK, we have some, but it's disabled by default
12:31:24 <tsufiev> zabolzadeh, for example, new Launch Instance wizard
12:31:41 <robcresswell> We have a couple of tables and a workflow, but nothing complete.
12:32:04 <zabolzadeh> tsufiev: disabled? what do you mean?
12:32:34 <robcresswell> zabolzadeh: The Angular images panel, Users panel and Launch instance workflow are disabled by default.
12:32:43 <tsufiev> zabolzadeh, https://github.com/openstack/horizon/blob/master/openstack_dashboard/enabled/_3031_identity_users_panel.py#L27
12:32:54 <robcresswell> See openstack_dashboard/enabled and local_settings.py
12:33:41 <robcresswell> #link https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L218
12:33:46 <zabolzadeh> robcresswell, tsufiev: I see. Thanks. But nothing merged into master so far.
12:34:00 <robcresswell> Nothing *complete* merged, no. Those panels are in master.
12:34:18 <robcresswell> :)
12:34:27 <zabolzadeh> robcresswell: :))
12:34:32 <tsufiev> david-lyle: btw, writing new integration tests have been going quite well, I haven't even been able to review them all so far (too many) :)
12:34:56 <chestack> robcresswell, Does ng-user panel not completed anguralized work yet?
12:34:58 <david-lyle> tsufiev: nice
12:35:17 <robcresswell> chestack: Nope, it's just a list of users right now.
12:36:59 <david-lyle> ok we have lots of stalled items and a little over a month to straighten them out
12:37:59 <david-lyle> I'm going to move on and let toabctl go
12:38:00 <tsufiev> zabolzadeh, I guess, you were going to promote Identity Topology blueprint :)?
12:38:12 <david-lyle> #topic Open Discussion
12:38:17 <toabctl> I want to ask how to continue with the local_settings.d/ changeset (see https://review.openstack.org/#/c/243974/ ).
12:38:30 <toabctl> There are pros and cons but no more progress. I'm fine with having another discussion, or a -2 so I can abandon the change (and search for another solution) or +2's so it's merged. Moving in one direction would be nice :)
12:38:31 <zabolzadeh> tsufiev: Yes, i started to develop.
12:38:46 <zabolzadeh> tsufiev: The review process, as you know has been finished.
12:39:17 <toabctl> so any suggestion howto proceed ?
12:39:23 <itxaka> toabctl, seems like its missing core votes on it, already has 8 +1
12:39:36 <itxaka> toabctl, should bother the cores, now that they are all in the channel :D
12:39:51 <itxaka> you*
12:40:02 <robcresswell> toabctl: I've left comments before on it, I don't like it because it doesn't really solve the main issues with .py vs .ini
12:40:03 <toabctl> itxaka: it's controversial .there was already a +2 and also a -1 from cores.
12:40:23 <robcresswell> Which is what the packagers dislike
12:40:38 <robcresswell> And I'd prefer a solution that lets us load .ini from external directories.
12:41:30 <robcresswell> Adding another python override to me seems like a poor solution. We already have override modules for hacks and enabled files.
12:42:27 <doug-fish> robcresswell: are you saying you'd like to see Django settings defined in an ini file as well?
12:42:37 <tsufiev> hm...
12:42:42 <itxaka> Do we have a bp for that ini thingie?
12:43:09 <robcresswell> doug-fish: It's one of the constant requests from people packaging
12:43:10 <toabctl> this local_settings.d is really about *all* django settings, not only about horizon specifics (plugins or whatever).
12:43:18 <amotoki> I tend to agree it to some extent, but local.settings.d helps distribution or horizon plugin I think.
12:43:48 <david-lyle> toabctl: I'm warming to the patch
12:43:52 <toabctl> I currently don't have another solution to change a setting during a package install
12:43:52 <amotoki> IMO a long term solution is to migrate ini style.
12:43:55 <tsufiev> itxaka, https://review.openstack.org/#/c/100521/
12:44:06 <david-lyle> I'm reluctant to make a wholesale switch to .ini
12:44:18 <itxaka> thanks tsufiev
12:44:18 <toabctl> amotoki: so do you want to map all possible settings from local_settings.py to a ini file?
12:44:47 <amotoki> toabctl: I hope so though there are some difficult points.
12:44:48 <david-lyle> mostly because django has a rather rich set of settings to try and support
12:44:48 <mrunge> ini file and toabctl s patch should be not connected here
12:45:30 <robcresswell> mrunge: Why? Local settings is all about deployments and dsitributions
12:45:31 <david-lyle> I think the .d patch helps distros and some plugins
12:45:36 <robcresswell> not Horizon specific settings
12:45:52 <mrunge> exactly. the .d patch is greatly welcome from distr side
12:46:14 <david-lyle> it will not really be used in tree
12:46:26 <toabctl> yes. that's also my understanding
12:46:42 <mrunge> robcresswell, the thing is, one can not change local_settings while adding plugins to horizon
12:46:49 <robcresswell> Yes, I understand
12:46:54 <mrunge> the change would then be manual
12:47:01 <mrunge> but that is not desirable
12:47:12 <robcresswell> My contention is that next summit, we will have packagers request .ini, as they do at every single summit :/
12:47:19 <david-lyle> my original thought was to use enabled files, but for theming that doesn't really make sense
12:47:29 <itxaka> well, probably becuase its the proper way robcresswell
12:47:39 <robcresswell> and the python change will not help us
12:47:42 <mrunge> david-lyle, there are other settings desired for changes
12:47:45 <itxaka> config whould not be mixed with code logic, one of the things that django does wrongly :P
12:47:52 <david-lyle> mrunge: I understand
12:47:52 <itxaka> whould == should!
12:47:53 <toabctl> robcresswell: I promise to not request .ini files :-)
12:48:12 <david-lyle> mrunge: using theming as an example
12:48:23 <david-lyle> just noting it doesn't really fit as a plugin
12:48:45 <mrunge> theming misuses plugins
12:48:53 <mrunge> due to better options
12:48:58 <mrunge> missing
12:49:06 <toabctl> here is what I'm doing with the patch for a theme: https://github.com/SUSE-Cloud/horizon-suse-theme
12:49:33 <mrunge> but one could add another auth plugin, which could require additional config
12:49:40 <mrunge> that's currently impossible
12:50:07 <mrunge> or think of adding a plugin for supporting more options in a storage driver
12:50:10 <mrunge> or what else
12:50:16 <zabolzadeh> david-lyle: I am working on glance image sharing mechanism in horizon & I think I can implement it completely for mitaka release(https://review.openstack.org/#/c/242691/).
12:50:25 <zabolzadeh> david-lyle: Does the feature set open right now?
12:50:53 <david-lyle> zabolzadeh: it's not locked
12:51:06 <amotoki> one question: why do we use underscore (_NNN_xxx filename) in enabled (and proposed local.settngs.d)  instead of NNN_xxxx filename)?
12:51:47 <david-lyle> python files can't start with numbers
12:52:10 <amotoki> ah..... I totally forgot it
12:52:12 <amotoki> thanks
12:52:13 <zigo> Ah, that's a good reason! :)
12:53:20 <david-lyle> toabctl: will do a proper review of your patch
12:53:24 <toabctl> so howto proceed now? I'm fine with having a -2 and also having 2x +2 (prefered)
12:53:39 <robcresswell> It seems the general consensus is to merge
12:53:48 <zabolzadeh> david-lyle: Ok, sound like good. The core has been implemented, Timur, wants me a slight change.
12:54:16 <david-lyle> zabolzadeh: just keep pushing on it
12:54:21 <david-lyle> the bp is approved
12:54:36 <david-lyle> so just needs reviews
12:55:12 <zabolzadeh> david-lyle: ok, I'll send the patch 4 days later.
12:55:26 <mrunge> reviews is an important point
12:55:36 <mrunge> we're currently lacking reviews in general
12:55:45 <toabctl> robcresswell: ok. then I'll wait for more comments and hopefully for some  +2's. thanks for the discussion everybody!
12:55:53 <david-lyle> mrunge: yeah I need to catch up
12:55:57 <mrunge> zabolzadeh, if you want your code reviewed, be prepared to review other code as well
12:56:04 <mrunge> david-lyle, I was not pointing at you
12:56:23 <zabolzadeh> mrunge: yeah, good point.
12:56:33 <mrunge> I just observed the review queue increasing by about 100 patches over the last 4 weeks
12:56:37 <mrunge> 400 to 500 now
12:57:04 * david-lyle wonders about signal to noise ratios
12:58:23 <mrunge> agreed, there are some patches aging since january
12:58:26 <robcresswell> If you want a fun one, check out https://review.openstack.org/#/c/118334/
12:58:35 <robcresswell> 364 days since last patch set.
12:58:44 <robcresswell> It's been rebased constantly :)
12:59:09 <robcresswell> We shouldn't be able to say happy birthday to a patch :p
12:59:31 <mrunge> robcresswell, we already had that at least twice
12:59:36 <david-lyle> I've always thought of that patch as a solution looking for a problem
12:59:48 <toabctl> lol
12:59:55 <robcresswell> Can someone -2 it then?
13:00:06 <david-lyle> there was an iteration before that even I believe
13:00:11 <tsufiev> robcresswell, no, we'r too polite :)
13:00:16 <robcresswell> tsufiev: ha :)
13:00:31 <david-lyle> robcresswell: I think I did on the previous incarnation
13:00:58 <robcresswell> Ah, I hadn't realised
13:01:00 <david-lyle> I'm also allowing for someone to explain why it's useful
13:01:35 <robcresswell> I have no interest in it personally, it's just a very old patch.
13:01:44 <david-lyle> robcresswell: understood
13:01:55 <robcresswell> #link http://russellbryant.net/openstack-stats/horizon-openreviews.html
13:01:56 <david-lyle> times up
13:01:57 <mrunge> that patch seems to fix a bug? https://bugs.launchpad.net/horizon/+bug/1363188
13:01:58 <openstack> Launchpad bug 1363188 in OpenStack Dashboard (Horizon) "Change user settings as non-admin user changes for all the users across all the projects" [Low,In progress] - Assigned to Rob Cresswell (robcresswell)
13:02:31 <robcresswell> lets continue in #horizon
13:02:38 <mrunge> yum, thank you all
13:03:18 <toabctl> thx
13:03:31 <alexpilotti> mrunge: can you please end the meeting? :)
13:03:38 <david-lyle> reminder of the midcycle sprint on Portland Feb 23-25, https://wiki.openstack.org/wiki/Sprints/HorizonMitakaSprint
13:03:47 <david-lyle> please register
13:03:51 <david-lyle> #endmeeting