20:00:00 <robcresswell> #startmeeting horizon
20:00:01 <openstack> Meeting started Wed Mar  1 20:00:00 2017 UTC and is due to finish in 60 minutes.  The chair is robcresswell. Information about MeetBot at http://wiki.debian.org/MeetBot.
20:00:02 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
20:00:04 <openstack> The meeting name has been set to 'horizon'
20:00:10 <r1chardj0n3s> o/
20:00:10 <robcresswell> o/
20:00:22 <david-lyle> o/
20:00:28 <betherly> o/
20:01:00 <robcresswell> Hey everyone
20:01:16 <robcresswell> So, announcements and such
20:01:21 <lcastell> o/
20:01:40 <robcresswell> I sent out a couple emails this week, one about the Pike PTG and another about single core approval for patches
20:01:43 * robcresswell finds links
20:02:49 <robcresswell> #link http://lists.openstack.org/pipermail/openstack-dev/2017-March/113101.html
20:03:18 <robcresswell> Urgh seems like the thread tracking is messed up. Not sure why
20:04:14 <robcresswell> #link http://lists.openstack.org/pipermail/openstack-dev/2017-February/112950.html
20:04:18 <robcresswell> Thats the PTG Summary
20:04:34 <robcresswell> #link http://lists.openstack.org/pipermail/openstack-dev/2017-February/113029.html
20:04:40 <robcresswell> and thats the single core approval mail
20:04:43 <robcresswell> Got there in the end :)
20:04:48 <r1chardj0n3s> \o/
20:04:56 <robcresswell> Thanks everyone for attending the PTG btw, was good to catch up and get organised
20:05:23 <r1chardj0n3s> hasn't been any response to the single-core email, which I find interesting
20:05:30 <robcresswell> We've got a nicely organised blueprint list now
20:05:39 <robcresswell> #list https://blueprints.launchpad.net/horizon
20:05:44 <robcresswell> argh, tired.
20:05:50 <robcresswell> #link https://blueprints.launchpad.net/horizon
20:06:06 <robcresswell> We'll be using this in place of the usual priorities etherpad
20:06:13 <r1chardj0n3s> adding "/pike" on the end is also useful, I find:
20:06:13 <r1chardj0n3s> https://blueprints.launchpad.net/horizon/pike
20:06:30 <robcresswell> Yep
20:06:51 <robcresswell> I'll be reviewing anything on there over the other patches to make sure we stay focused
20:07:23 <robcresswell> So please try to keep on top of these blueprints, everyone. Lets make it a productive cycle.
20:07:33 <r1chardj0n3s> I've been doing some maintenance on the high/medium priority BP whiteboards (as part of finding patches to review) and they're a little more up to date now (adding MERGED/ABANDONED)
20:07:45 <robcresswell> Awesome
20:08:27 <betherly> \o/
20:08:29 <robcresswell> On a side note, they've already announced the summit after Sydney will be back in Vancouver https://www.openstack.org/blog/2017/02/the-openstack-summit-is-returning-to-vancouver-in-may-2018/
20:09:11 <betherly> Gosh that's fast announcement! Haven't even had Boston yet
20:09:48 <robcresswell> I don't have much to say for this meeting, having done all of my talking last week. As we progress, I'll be asking for status updates on the prioritised blueprints so we can check people are getting reviews
20:10:06 <betherly> ++
20:10:25 <robcresswell> The agenda is empty (https://wiki.openstack.org/wiki/Meetings/Horizon) so we can move to open discussion
20:10:42 <robcresswell> Would it help if the agenda was in an etherpad format? Is the wiki a blocker?
20:10:51 <robcresswell> Or is everyone just quiet these days :)
20:11:02 <r1chardj0n3s> robcresswell: I found that people added stuff to the wiki just fine, when they needed to
20:11:19 <r1chardj0n3s> the meeting reminder email seemed to spur folks to do that sometimes
20:11:27 <betherly> Ye I think either works :) whatever suits you better I guess
20:11:41 <robcresswell> I'll leave it as a wiki then
20:11:51 <david-lyle> is the wiki still blocking new users?
20:11:54 <robcresswell> r1chardj0n3s: Sure, I can keep those up
20:12:02 <robcresswell> david-lyle: No idea
20:12:27 <r1chardj0n3s> it's just tied to the LP login, so should be open to all
20:12:44 <david-lyle> it wasn't for some time
20:12:47 <betherly> I can look into that as I know some new contributors. I'll let you know if they can access it.
20:13:01 <robcresswell> great, thanks betherly
20:13:07 <robcresswell> #topic Open Discussion
20:13:10 <david-lyle> r1chardj0n3s: there was a spamming issue
20:13:49 <r1chardj0n3s> ah the old spamming the wiki funtimes
20:14:07 <robcresswell> So if anyone has any general questions, blueprints etc, nows the time to ask
20:14:14 <r1chardj0n3s> right, so Rob, I'm still trying to decode your comment on https://blueprints.launchpad.net/horizon/+spec/reorganise-volumes ;-)
20:14:19 <robcresswell> \o/
20:14:46 <robcresswell> Right. In your original patch, you broke up all the code and added a new Volume panel group under the Admin nav
20:15:11 <robcresswell> All I was saying was that this highlights a need to break up admin, since it has something like 10+ panels under an ambiguous "System" group
20:15:33 <r1chardj0n3s> Yes, I agree on that
20:15:57 <robcresswell> So I was just saying, instead of adding one new group in your patch, and then doing the rest in a new bp, just add your content to "System" so its consistent, and then afterwards, we can reorg all of the Admin nav in a single blueprint
20:16:10 <robcresswell> that keeps the patch logic and release notes separate.
20:16:23 <betherly> So I'm wondering as well. Is there up to date documentation re creating angular panels? The techniques for plugins are a bit different and I'm not sure how to create the tables properly. The documentation for horizon dashboards seems to represent the older techniques but maybe I'm wrong?
20:16:57 <robcresswell> Otherwise you end up with a situation where you add a release note where you've added a new panel group, and then you've another where you've moved them around a bunch. It was literally just asking for a one line change on your enabled files
20:17:07 <robcresswell> But you interpreted that as me saying "dont do the admin work at all" :)
20:17:09 <r1chardj0n3s> robcresswell: I'm not sure I understand why I shouldn't add the new volume group in the same patch that splits out the panels, since it's such a small amount of code to add the new group
20:17:36 <r1chardj0n3s> I have a separate two patches which do the admin reorganisation, including the new panel group
20:17:41 <robcresswell> r1chardj0n3s: Because if the second effort ends up changing the numerical ordering again, its annoying for git history and release notes to follow.
20:18:02 <robcresswell> Like if we add Admin -> Instances, then we end up reorganising again
20:18:16 <robcresswell> So I was just saying keep those two efforts distinct
20:18:23 <robcresswell> betherly: One moment :)
20:18:26 <r1chardj0n3s> wait, so you don't want me to do the volume panel group until we reorganise *all* of admin?
20:18:45 <robcresswell> yes, that
20:18:51 <betherly> robcresswell: of course! Sorry didn't mean to interrupt discussion :) just dropped it in for as and when
20:19:08 <robcresswell> Just put the panels under System *for now* and then we can reorganise it all under the scope of one "reorg admin nav" bp
20:19:42 <r1chardj0n3s> oh, OK I guess
20:19:56 <robcresswell> rather than "split out volumes and start to change the admin nav" as one bp and then "oh and move some more panel groups around and rename the volumes enabled file again" as a second bp
20:20:31 <robcresswell> Its been kinda blown out of proportion because of my inability to explain myself :(
20:21:03 <robcresswell> But my original comment was really "yeah this is great and works, but just change this one line back to system until we can decide how to organise them all"
20:21:06 <r1chardj0n3s> no, I get what you're aiming for now. I don't know that I quite see the point, but I'm happy to toe the party line :-)
20:21:07 <ducttape_> I'd think doing the nav layout first is best.
20:21:23 <robcresswell> ducttape_: dont confuse things
20:21:28 <r1chardj0n3s> ohai ducttape_
20:21:33 * ducttape_ is confused
20:21:35 <robcresswell> all the volumes work is already done anyway
20:21:51 <robcresswell> I've been reviewing it, so should be able to merge it this week
20:21:51 <ducttape_> k.  nevermind.  don't want to delay betherly
20:21:57 <robcresswell> betherly: o/
20:22:00 <robcresswell> fire away
20:22:48 <lucasxu> o/ can I ask something ?
20:23:28 <robcresswell> betherly: Are you referring to https://docs.openstack.org/developer/horizon/tutorials/plugin.html#angularjs-plugin ?
20:23:44 <robcresswell> lucasxu: One moment, just discussing docs with betherly, then absolutely :)
20:23:52 <betherly> so I was just asking about panel work based on the qos panel I'm working on. I'm struggling with where to put some of the static files as it seems to change per panel and then also developing the angular tables
20:24:12 <betherly> so that documentation you linked to seems pretty specific to plugins
20:24:28 <robcresswell> https://github.com/openstack/horizon/tree/master/openstack_dashboard/static/app/core this stuff is probably "most correct"
20:24:36 <robcresswell> especially the images work
20:24:49 <betherly> So this is where I started https://docs.openstack.org/developer/horizon/tutorials/dashboard.html
20:24:52 <robcresswell> I know r1chardj0n3s has his swift panel and the new LI are still in a weird other path
20:25:00 <betherly> Ah perfect thank you
20:25:27 <betherly> robcresswell: would you mind if I pinged you in the morning to take a look at where I've placed things?
20:25:40 <robcresswell> betherly: Sure, no problem
20:25:45 <betherly> thanks so much!
20:25:51 <robcresswell> Though, ping in the Horizon IRC to keep the discussion public for others.
20:25:58 <robcresswell> That way more people can learn
20:25:59 <betherly> sure thing
20:26:06 <betherly> :)
20:26:12 <ducttape_> and spread confusion.  we do that too
20:26:16 <robcresswell> r1chardj0n3s: Didn't you document all the registry stuff a while back?
20:26:39 <lcastell> +1 ducttape_
20:26:56 <r1chardj0n3s> robcresswell:yes, I did a whole lotta work on the in-code docs
20:27:07 <robcresswell> ah awesome
20:27:08 <r1chardj0n3s> we're still not extracting those to HTML :/
20:27:12 <robcresswell> :(
20:27:30 <robcresswell> Well, thats a separate issue
20:27:42 <robcresswell> lucasxu: You had a question?
20:27:47 <betherly> nice r1chardj0n3s !!!
20:27:47 <lucasxu> Thanks! So currently the way for me to do the code review is to use a devstack, which i pull code from the gerrit and test. Is this the best way to do the code review?
20:27:58 <lucasxu> robcresswell: yes ;)
20:28:07 <betherly> lucasxu: that's how I test it
20:28:18 <betherly> git review -d is your friend
20:28:21 <robcresswell> lucasxu: Thats the best way to get started, yeah
20:28:28 <lucasxu> betherly: great! thanks!
20:28:52 <lucasxu> robcresswell: thank you :) trying to test some angular code
20:29:00 <robcresswell> once you're a bit more familiar, I tend to run with the latest stable branch devstack on a server somewhere, and then a local horizon
20:29:40 <ducttape_> if you can find 1000 spare servers, you can also use this as your horizon backend
20:29:54 <betherly> robcresswell: ++ to stable branch - devstack master is far from stable :'D
20:29:54 <lucasxu> hmm, sure. and connect the local horizon to the keystone in that devstack?
20:30:07 <robcresswell> lucasxu: Yup
20:30:09 <lucasxu> hah, if I could
20:30:15 <r1chardj0n3s> lucasxu: yep - that's how I run things
20:30:39 <lucasxu> r1chardj0n3s: thanks, glad that im on the right track!
20:30:41 <ducttape_> there is only one config setting to point to where keystone auth url is, then you are good to switch to any openstack deployment
20:31:04 <robcresswell> There's a few useful bits and pieces to know about too, like understanding virtualenv and the compression settings in Horizon
20:31:36 <robcresswell> Sometimes people don't know about them and end up doing things like restarting apache every time they change a line of JS
20:31:47 <lucasxu> yeah, and I believe currently horizon only depends on keystone now. so it would be really easy for me just set it up
20:32:28 <robcresswell> lucasxu: Yeah, you can disable devstacks horizon too to speed up the build. Although, if its on a remote system it shouldnt fall over that often.
20:33:48 <ducttape_> if you don't use devstack, you can just checkout the horizon repo and go
20:34:08 <betherly> snapshots before the build are useful to have a return to point
20:34:12 <lucasxu> robcresswell: nice. yeah, it would be really useful to know the compression settings and virtualenv. I have been trying them
20:34:23 * betherly learnt this the hard way :D
20:34:32 <lucasxu> robcresswell: sure. thanks for the suggestion :)
20:34:34 <robcresswell> ducttape_: Ha yep
20:34:39 <lucasxu> hah
20:35:13 <lucasxu> ducttape_: eventually i will do that :)
20:35:33 <lucasxu> betherly: thanks :D
20:35:56 <robcresswell> lucasxu: https://django-compressor.readthedocs.io/en/latest/settings/#django.conf.settings.COMPRESS_ENABLED and https://django-compressor.readthedocs.io/en/latest/settings/#django.conf.settings.COMPRESS_OFFLINE
20:36:19 <robcresswell> Those are probably the two most useful things to be able to toggle.
20:36:35 <ducttape_> plus collectstatic is also needed, its around the same place in django docs
20:36:47 <ducttape_> collectstatic first, then compress if needed
20:37:01 <robcresswell> Yeah, if you run with COMPRESS_OFFLINE = True, you'll need to run collectstatic and compress
20:37:39 <lucasxu> great, Thanks guys. that's really helpful!
20:37:40 <robcresswell> tox -e manage -- collectstatic -c and tox -e manage -- compress
20:38:25 <robcresswell> then you can do tox -e manage -- runserver and away you go
20:38:30 <robcresswell> iirc.
20:38:44 <robcresswell> lucasxu: Sure, ping any time if you need help
20:38:51 * ducttape_ coughs ./run_tests.sh
20:38:52 <r1chardj0n3s> robcresswell: "tox -e runserver" also works
20:38:54 <lucasxu> yes, I saw that in the doc and there was a typo in 'collectstatic' lol
20:38:59 <lucasxu> haha
20:39:15 <robcresswell> lucasxu: I hope you proposed a patch...
20:39:19 <r1chardj0n3s> ducttape_: no, you cannot have it work easily!
20:39:23 <robcresswell> ducttape_: No, run tests is dead
20:39:27 <robcresswell> I cannot wait to remove it
20:39:29 <r1chardj0n3s> robcresswell: it's already merged, IIRC ;-)
20:39:31 <lucasxu> robcresswell: yes and richard merged it
20:39:34 <robcresswell> :o
20:39:35 <david-lyle> robcresswell: watch it
20:39:36 <ducttape_> merely a flesh wound
20:39:44 <david-lyle> WTF?
20:39:55 <robcresswell> https://review.openstack.org/#/c/399842/
20:39:59 <robcresswell> Its not merged
20:40:00 * david-lyle looks for the exit
20:40:20 * david-lyle pauses at the door
20:40:22 <robcresswell> cant remove it till queens iirc.
20:40:32 * david-lyle looks back hopefully
20:40:34 <robcresswell> otherwise we arent following stable policy
20:40:42 <betherly> david-lyle: :'D
20:40:55 <david-lyle> I can't learn new things
20:41:27 <ducttape_> fun fact:  this is a photo of david-lyle and I - https://upload.wikimedia.org/wikipedia/en/0/02/Statler_and_Waldorf.jpg
20:41:36 <david-lyle> #truestory
20:41:39 * betherly needs to rewrite that part of my horizon blog post
20:41:58 <lucasxu> lol
20:41:58 <robcresswell> betherly: About david and eric being grumpy?
20:42:02 <betherly> hahaha
20:42:19 <david-lyle> you couldn't have gotten that part wrong
20:42:29 <betherly> robcresswell: about tox rather than runserver - but yes remind me to add that too ;)
20:42:50 <robcresswell> tox is the future
20:42:57 <david-lyle> help us all
20:42:59 <betherly> robcresswell: woot
20:43:03 <betherly> hahaha
20:43:23 <robcresswell> Right
20:43:27 <robcresswell> any other questions?
20:43:39 <david-lyle> why do you hate us?
20:43:52 <david-lyle> ;-)
20:43:54 <robcresswell> Us? Its not a general thing, its very targeted
20:43:59 <robcresswell> :D
20:43:59 <david-lyle> haha
20:44:27 <betherly> hahaha
20:44:59 <ducttape_> one more thing for david-lyle and I - https://cdn.meme.am/cache/instances/folder266/500x/75900266.jpg
20:45:24 <betherly> bwahaha!
20:45:32 * ducttape_ is pretty sure I am not invited anymore
20:45:46 <betherly> now having to explain to my boyfriend why I'm laughing out loud at my screen
20:45:50 <lucasxu> looooll
20:46:16 <robcresswell> haha
20:46:23 <robcresswell> Okay, we can call it here
20:46:25 <robcresswell> Thanks everyone
20:46:31 <betherly> cheers all!
20:46:35 <david-lyle> glad we resolved to keep run_tests.sh
20:46:39 <lucasxu> thanks!
20:46:39 <david-lyle> good meeting
20:46:48 <betherly> david-lyle: nice insert last minute ;)
20:46:56 <robcresswell> #endmeeting