20:01:00 <ying_zuo> #startmeeting horizon
20:01:01 <openstack> Meeting started Wed Oct 11 20:01:00 2017 UTC and is due to finish in 60 minutes.  The chair is ying_zuo. Information about MeetBot at http://wiki.debian.org/MeetBot.
20:01:02 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
20:01:05 <openstack> The meeting name has been set to 'horizon'
20:01:08 <ying_zuo> o/
20:01:17 <gary-smith> o/
20:01:22 <rdopiera> o/
20:01:26 <makowals_> Hello
20:01:39 <e0ne> hi
20:02:16 <rubasov_> o/
20:02:31 <ying_zuo> #topic Notices
20:02:37 <ying_zuo> #info Queens-1 milestone is expected to be released by Oct 18
20:02:42 <robcresswell> o/
20:02:54 <ying_zuo> please try to focus on closing the tickets listed on https://launchpad.net/horizon/+milestone/queens-1
20:03:19 <ying_zuo> #info Sydney summit sessions
20:03:40 <ying_zuo> we have the project update and project onboarding sessions confirmed
20:03:55 <ying_zuo> I am still waiting to hear about the user feedback session.
20:04:23 <ying_zuo> any suggestions on the topics for the project onboarding session?
20:04:29 * e0ne will miss this summit :(
20:04:43 <ying_zuo> :(
20:06:46 <ying_zuo> #topic Bug Reports Review
20:06:57 <ying_zuo> https://www.irccloud.com/pastebin/uClL7g56/
20:07:39 <ying_zuo> #link https://bugs.launchpad.net/horizon/+bug/1681627
20:07:40 <openstack> Launchpad bug 1681627 in Zun UI "Page not found error on refreshing bowser " [Critical,In progress] - Assigned to Shu Muto (shu-mutou)
20:07:40 <ying_zuo> #link https://bugs.launchpad.net/horizon/+bug/1704118
20:07:41 <openstack> Launchpad bug 1704118 in OpenStack Dashboard (Horizon) "Spinner is stuck when deleting image in angularized panel" [Medium,In progress] - Assigned to Lajos Katona (lajos-katona)
20:07:54 <ying_zuo> shu-mutou left a note to ask for reviews on the patches for these two tickets
20:08:14 <ying_zuo> these are the patches: https://review.openstack.org/#/c/491346/ https://review.openstack.org/#/c/490868/
20:08:25 <robcresswell> Yeah I haven't got round to looking at that refresh patch yet
20:08:44 <robcresswell> I'm not a big fan of the current solution. It's very verbose.
20:09:57 <ying_zuo> he made some changes
20:11:16 <ying_zuo> still a pretty big change
20:11:47 <ying_zuo> I left a comment on https://review.openstack.org/#/c/490868/
20:12:06 <ying_zuo> just a nitpick. I think it's good other than that
20:12:54 <ying_zuo> #link https://bugs.launchpad.net/horizon/+bug/1721286
20:12:55 <openstack> Launchpad bug 1721286 in OpenStack Dashboard (Horizon) "Create volume from image displays incorrect AZs" [High,Confirmed] - Assigned to Ivan Kolodyazhny (e0ne)
20:13:15 <ying_zuo> thanks e0ne picking it up
20:13:28 <e0ne> just assigned this bug to myself today. will take a look on this later this week
20:13:32 <e0ne> ying_zuo: np
20:13:44 <robcresswell> awesome
20:13:56 <ying_zuo> #link https://bugs.launchpad.net/horizon/+bug/1640537
20:13:56 <openstack> Launchpad bug 1640537 in OpenStack Dashboard (Horizon) "Federated users should not see change password page" [Undecided,New]
20:14:20 <gary-smith> I put that one on the list because I thought david-lyle could quickly triage it
20:14:45 <ying_zuo> thanks
20:15:06 <gary-smith> (I'm not very familiar with keystone federation)
20:15:40 <ying_zuo> I think it makes sense to hide the page
20:16:50 <robcresswell> Isn't this a policy issue really?
20:17:18 <robcresswell> I don't know if it stretches that far though
20:17:35 <gary-smith> Does being federated necessarily preclude the ability to change the password via keystone?
20:17:42 <robcresswell> Either way should be controllable by information that we already have
20:17:51 <ying_zuo> OPENSTACK_KEYSTONE_BACKEND is on local_seetings.py to control some actions on the identity panel
20:17:57 <robcresswell> gary-smith: I don't know unfortunately :(
20:18:38 <ying_zuo> I don't think it's policy
20:20:42 <gary-smith> would setting can_edit_user to False in OPENSTACK_KEYSTONE_BACKEND suppress the password change setting?
20:21:01 <ying_zuo> I think the user can still use keystone or other logins
20:21:04 <ying_zuo> on a cluster
20:21:33 <ying_zuo> gary-smith: I would think that just control the edit user action
20:21:42 <gary-smith> makes sense
20:21:51 <ying_zuo> I was thinking to add can_change_password there
20:22:23 <ying_zuo> but that will work just like setting a policy rule
20:22:42 <ying_zuo> so adding a setting probably won't work
20:24:01 <robcresswell> You could make it setting controlled, all I meant was that I think you may be able to already tell anyway
20:24:16 <robcresswell> I don't know enough about how keystone presents federated logins vs keystone ones
20:24:33 <robcresswell> If we can distinguish, we can just solve that bug without extra settings
20:24:52 <ying_zuo> yes
20:25:52 <ying_zuo> will need to make a call to check how the logged in user is authenticate instead of using a setting
20:26:28 <robcresswell> Yeah I don't know if there's any way of distinguishing. Lets put this to the side anyway, since none of us know
20:26:43 <ying_zuo> sure. that's a good start
20:26:53 <ying_zuo> #link https://bugs.launchpad.net/horizon/+bug/1690790
20:26:54 <openstack> Launchpad bug 1690790 in OpenStack Dashboard (Horizon) "policy checks for detach_interface not working correctly" [Undecided,Confirmed]
20:28:22 <ying_zuo> the policy rule for detach interface is still not defined on the sample nova policy
20:29:23 <ying_zuo> there's one for attach interface though
20:29:48 <ying_zuo> maybe we can use that for the detach interface too?
20:30:25 <ying_zuo> it's not ideal
20:31:43 <robcresswell> What does Nova do, just use attach for both?
20:31:59 <ying_zuo> good question
20:32:30 <ying_zuo> just need to look into that then :)
20:32:33 <robcresswell> also nova dont provide sample policy files, it needs to be generated
20:32:41 <ying_zuo> yes
20:32:42 <robcresswell> Yeah, just duplicate the nova equivalent
20:32:53 <robcresswell> Its a one line change at best, just need to check the rule
20:32:54 <ying_zuo> I was referring to the one in horizon
20:33:00 <ying_zuo> I didn't see one in nova
20:33:36 <ying_zuo> like you said, needs to be generated
20:33:51 <ying_zuo> #link https://bugs.launchpad.net/horizon/+bug/1686266
20:33:51 <openstack> Launchpad bug 1686266 in OpenStack Dashboard (Horizon) "upload images with an invalid URL lead to a "Queued" status image forever" [Undecided,New]
20:34:38 <ying_zuo> should we do any validation for the url?
20:34:40 <robcresswell> Yeah, but the one in Horizon isn't pushed automatically from anywhere; we just manually update it from time to time
20:35:10 <robcresswell> No, we should just do what the API does
20:35:17 <robcresswell> Which is leave it queued forever, apparently.
20:35:44 <ying_zuo> cool
20:35:57 <ying_zuo> #link https://bugs.launchpad.net/horizon/+bug/1649183
20:35:59 <openstack> Launchpad bug 1649183 in OpenStack Dashboard (Horizon) "image category buttons don't appear in newton" [Medium,Confirmed]
20:37:27 <robcresswell> pffft
20:37:33 <robcresswell> How demanding.
20:37:45 <robcresswell> Its a regression that we should fix
20:37:51 <robcresswell> Though I dislike their attitude :/
20:38:05 <robcresswell> "Would be good to have a test system with say 150 images so these bugs are found before release" Yes, that would be wonderful if someone would provide that.
20:38:50 <ying_zuo> is it a regression?
20:38:57 <robcresswell> Yep
20:39:30 <robcresswell> The bug explanation seems fairly clear IMO
20:39:37 <ying_zuo> I thought it's just asking for the option to filter
20:39:56 <robcresswell> No, its asking for an option that existed before, that was introduced in Grizzly
20:40:06 <robcresswell> https://docs.openstack.org/horizon/latest/configuration/settings.html#images-list-filter-tenants
20:40:21 <robcresswell> "Just installed the Newton version of the openstack dashboard and when listing images the buttons to filter by category no longer appear."
20:40:30 <robcresswell> Its when we used the new images panel
20:40:35 <robcresswell> added, even.
20:40:59 <ying_zuo> I see
20:42:25 <robcresswell> I'll leave a comment
20:42:36 <ying_zuo> thank you
20:42:38 <robcresswell> Just target it to Next or something, someone can pick it up
20:43:02 <ying_zuo> last one
20:43:06 <ying_zuo> #link https://bugs.launchpad.net/horizon/+bug/1722704
20:43:08 <openstack> Launchpad bug 1722704 in OpenStack Dashboard (Horizon) "Image name filter on instance panel doesn't work" [Undecided,New] - Assigned to Feilong Wang (flwang)
20:43:45 <ying_zuo> flwang asked about this in openstack-horizon
20:44:59 <ying_zuo> any thoughts about these two issues?
20:46:18 <e0ne> need to check #1722704
20:48:00 <e0ne> it should be easy to fix
20:48:20 <e0ne> let's wait or ask flwang we any help is needed
20:49:21 <ying_zuo> e0ne: can you give some pointers?
20:50:54 <e0ne> ying_zuo: looks like we just need put correct value for 'filters' param and pass it to glanceclient
20:51:12 <flwang> o/
20:51:16 <flwang> sorry, i was in a meeting
20:51:24 <e0ne> ying_zuo: I have not environment by the hand
20:51:34 <robcresswell> e0ne: I'm not sure its that simple. It looks like we are passing the correct item to glance, but only using the first image by that name
20:51:35 <flwang> e0ne: unfortunatley, we can't get the correct value :)
20:51:46 <flwang> robcresswell: exactly
20:52:06 <flwang> robcresswell: and even worse
20:52:45 <flwang> we're not sending the correct value to 'glance' but use the local image list already get based on a call /v2/images?limit=1000
20:52:49 <e0ne> :(
20:52:59 <flwang> it's related to the #1 issue i mentioned in the bug
20:53:31 <flwang> we're assume there are less than 1000 images the tenant can see and we assume there is no dup-name images
20:54:02 <flwang> that's alright for most of the cases,
20:54:04 <flwang> but
20:54:28 <flwang> the problem is to get the filter works, we have to make the call to glance and nova async
20:54:45 <flwang> i don't like it because I"m working on the performance improvement of the instance panel
20:54:58 <flwang> hence I'd like to raise the bug and get feedback from the team
20:55:53 <robcresswell> Why don't we just pass the name query straight to Glance?
20:56:27 <flwang> robcresswell: you can do that, and you still get a list of images
20:56:51 <flwang> and you still need to chose one, because I don't think the serach_ops of nova list api can support query many image ids?
20:57:03 * david-lyle arrives just in time for the end
20:57:26 <flwang> david-lyle: we're talking about the one you may interested in https://bugs.launchpad.net/horizon/+bug/1722704
20:57:27 <openstack> Launchpad bug 1722704 in OpenStack Dashboard (Horizon) "Image name filter on instance panel doesn't work" [Undecided,New] - Assigned to Feilong Wang (flwang)
20:57:34 <robcresswell> I think it just takes single IDs yeah.
20:57:54 <robcresswell> Well, thats problematic. One solution would be to display the image ID on hover or something, and then remove the Image Name filter entirely
20:58:17 <robcresswell> Nova doesnt support filtering by image name, so us working that in sounds awkward.
20:58:21 <robcresswell> afaik,
20:58:23 <rdopiera> that would make it hard to copy the id
20:58:38 <flwang> robcresswell: that's probably the one I'd like to do, though I know somebody don't like it.
20:58:49 <robcresswell> rdopiera: Not necessarily. The flavor popup is fine to copy from iirc.
20:58:59 <flwang> horizon is good, but we shouldn't do everything to make it perfect
20:59:05 <rdopiera> ah, as long as it's a popup and not a tooltip
20:59:15 <flwang> mapping the id to name is too heavy work for dash
20:59:39 <robcresswell> https://getbootstrap.com/docs/3.3/javascript/#popovers
20:59:45 <robcresswell> One of those
21:00:12 <flwang> we can still keep the image name in the instance detailed page
21:00:25 <ying_zuo> sorry guys. we are at the top of the hour. please continue the discussion on #openstack-horizon or on the ticket.
21:00:31 <ying_zuo> #endmeeting