20:01:09 <e0ne> #startmeeting horizon
20:01:10 <openstack> Meeting started Wed Mar  7 20:01:09 2018 UTC and is due to finish in 60 minutes.  The chair is e0ne. Information about MeetBot at http://wiki.debian.org/MeetBot.
20:01:11 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
20:01:14 <openstack> The meeting name has been set to 'horizon'
20:01:30 <ying_zuo> o/
20:01:38 <e0ne> hi
20:03:00 <e0ne> #topic Notices
20:03:19 <e0ne> thanks everybody who joined PTG last week
20:03:50 <e0ne> #link some PTG Highlights are available here http://lists.openstack.org/pipermail/openstack-dev/2018-March/127977.html
20:04:14 <e0ne> more details could be found on etherpad
20:04:16 <e0ne> #link https://etherpad.openstack.org/p/horizon-ptg-rocky
20:05:41 <e0ne> I hope, everybody returned back after snowpenstack
20:07:52 <ying_zuo> looks like a very productive meeting :)
20:08:41 <e0ne> ying_zuo: thanks! we missed you there
20:08:58 <ying_zuo> thank you
20:09:22 <ying_zuo> in-person discussion is always better
20:09:31 <e0ne> ying_zuo: do not hesitate to add your notes to the etherpad if any
20:09:59 <gugl> Hi
20:10:02 <e0ne> #topic Open Discussion
20:10:10 <ying_zuo> I agree on the one for angularjs
20:10:25 <ying_zuo> finish what we have and don't start new patches for migration
20:10:40 <gugl> have a defect submitted...let me find the link
20:11:10 <gugl> https://bugs.launchpad.net/horizon/+bug/1754133
20:11:11 <openstack> Launchpad bug 1754133 in OpenStack Dashboard (Horizon) "login page exception - hz-login-finder doesn't function because of horizon.app loading failure" [Undecided,New]
20:11:21 <e0ne> ying_zuo: good to know that we've got agreement on this
20:12:43 <e0ne> #link https://bugs.launchpad.net/horizon/+bug/1754133
20:12:45 <openstack> Launchpad bug 1754133 in OpenStack Dashboard (Horizon) "login page exception - hz-login-finder doesn't function because of horizon.app loading failure" [Undecided,New]
20:13:14 <e0ne> gugl: thanks for the bug report. I'll try to triage this issue soon
20:13:32 <gugl> some loading issue for horizon.app when load login page
20:13:39 <gugl> e0ne, thanks
20:15:14 <e0ne> I suppose that login feature works now because tempest tests passed
20:15:36 <gugl> for keystone credential type it is fine
20:16:27 <gugl> but if we want to use WEBSSO to use other login type...then it has problem
20:16:51 <e0ne> oh..I missed it
20:16:54 <david-lyle> o/
20:16:59 <gugl> it is fine for horizon login...it has exceptions , but it doesn't cause problem
20:17:22 <gugl> it doesn't hurt when login type is keystone credential
20:17:24 <e0ne> david-lyle: hi
20:17:28 <gugl> hi
20:17:42 * david-lyle straggling in late
20:18:11 <e0ne> I didn't use WEBSSO for a while
20:19:11 <gugl> anyway...that loading horizon.app issue cause problem when use WEBSSO
20:19:37 <gugl> without WEBSSO, you still see the exceptions
20:19:43 <e0ne> we need to fix it
20:19:57 <gugl> when you F12 in chrome in console
20:20:20 <ying_zuo> gugl: so you can't log in with other login types?
20:20:39 <e0ne> gugl: are you volunteering to fix it?
20:21:12 <david-lyle> I don't have the backlog since I joined late, but is there a bug?
20:21:14 <gugl> when WEBSSO enabled...with some other setup...there will be a dropdown
20:22:00 <ying_zuo> https://bugs.launchpad.net/horizon/+bug/1754133
20:22:01 <openstack> Launchpad bug 1754133 in OpenStack Dashboard (Horizon) "login page exception - hz-login-finder doesn't function because of horizon.app loading failure" [Undecided,New]
20:22:03 <gugl> click the choice in dropdown...it should hide the inputs user/pass
20:22:18 <david-lyle> ying_zuo, thank you
20:22:56 <ying_zuo> sure
20:22:56 <gugl> at this point...click choice doesn't do anything...user can need to put some junk in the user/pass then click signin ...then it goes to the enterprise login page
20:23:51 <david-lyle> this sounds familiar
20:25:00 <e0ne> david-lyle: I remember this patch https://review.openstack.org/#/c/517382/
20:25:17 <gugl> loading horizon.app for login page seems to be different from dashboard page
20:25:28 <e0ne> not sure that it's related
20:25:37 <e0ne> ^^ it was about patch above
20:25:49 <david-lyle> e0ne, that's what I was thinking of
20:27:23 <gugl> that looks like a work around?
20:28:19 <ying_zuo> but it's merged
20:28:35 <ying_zuo> gugl: this is reproducible in master?
20:29:08 <gugl> yes
20:29:44 <ying_zuo> maybe it's a different issue
20:29:56 <gugl> load the latest master ...just go to the login page...wait a little , you will see the exceptions in F12 console
20:30:21 <gugl> it is related to angularjs loading issue
20:31:12 <gugl> I am not sure what is the difference between the horizon.app module loading in login page and regular dashboard page
20:31:40 <gugl> once you login...the exceptions are gone
20:34:28 <e0ne> I can confirm that it's reproducible in Pike too:( even without webSSO
20:34:32 <gugl> QA found it when they tested WEBSSO...otherwise this error will be unnoticed
20:34:45 <gugl> yes we started on stable/pike
20:34:57 <gugl> we use stable/pike for our cloud release
20:35:03 <e0ne> my devstack env is broken now, so I can't confirm on master
20:37:28 <e0ne> we need to fix it at least in master
20:38:00 <david-lyle> I wonder if there is something strange about auth templates living in the horizon half of the treee
20:38:00 <ying_zuo> not many people have SSO set up
20:38:11 <e0ne> not sure that it could be backported to Pike since login page works and it's not a security issue
20:38:33 <e0ne> ying_zuo, gugl: I reproduced it on Pike *without* WebSSO
20:38:53 <gugl> yep..without SSO...the problem is still there
20:39:13 <david-lyle> not to stable/pike, but a patch to queens could easily be cherry picked downstream
20:39:13 <gugl> without SSO, it doesn't hurt
20:39:26 <e0ne> david-lyle: +1
20:39:38 <gugl> cool
20:40:25 <e0ne> let's go on forward
20:40:38 <gugl> ok
20:40:42 <e0ne> is anything else to discuss at the meeting?
20:41:04 <gugl> that's it for me.
20:41:30 <e0ne> gugl: thanks for bringing up this topic
20:41:51 <gugl> e0ne, you're welcome
20:42:23 <gugl> if you have any idea how to fix it....please let me know. Also I resolved some issues...but stuck at one point
20:46:34 <e0ne> gugl: I'll post update to the launchpad if any
20:47:42 <gugl> e0ne, thanks
20:47:55 <e0ne> do we have any other topics to talk?
20:49:08 <david-lyle> I have to drop again. Thanks e0ne
20:49:27 <e0ne> david-lyle: np. thanks for joining us
20:49:48 <e0ne> I'm going to end meeting  in few minutes
20:49:57 <gugl> thanks bye
20:50:28 <e0ne> thanks everybody. see you next week!
20:50:59 <e0ne> #endmeeting