15:01:16 <e0ne> #startmeeting horizon
15:01:16 <openstack> Meeting started Wed Feb 20 15:01:16 2019 UTC and is due to finish in 60 minutes.  The chair is e0ne. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:01:17 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:01:20 <openstack> The meeting name has been set to 'horizon'
15:01:43 <e0ne> hi. is anybody here for horizon meeting?
15:01:53 <vishalmanchanda> e0ne: hi
15:02:20 <rdopiera> hi
15:04:24 <e0ne> looks like we can start today
15:04:33 <e0ne> #topic Notices
15:04:47 <e0ne> we're two week before feature freeze
15:04:53 <e0ne> #link https://releases.openstack.org/stein/schedule.html
15:07:15 <e0ne> it would be good to have community goals completed by this milestone
15:07:25 <e0ne> #link https://etherpad.openstack.org/p/horizon-release-priorities
15:07:43 <e0ne> I will work on python3 first goal to finish it this week
15:08:22 <amotoki> hi
15:09:01 <e0ne> rdopiera: I was on PTO, so didn't check your patch upgrade_check command
15:09:16 <e0ne> rdopiera: I'll test and review it asap
15:09:38 <rdopiera> e0ne: I still need to fix all the stuff that amotoki wrote about it
15:09:46 <rdopiera> e0ne: so maybe wait for the next version
15:10:08 <e0ne> rdopiera: ok, thanks for letting me know
15:10:18 <rdopiera> e0ne: I'm working on a way to automatically fill the list of valid options before every release, so that we don't have to manually keep track of it
15:10:34 <e0ne> that's all updates from me this week
15:11:00 <e0ne> amotoki: do you have anything to add about community goals or we can move to the next topic?
15:11:20 <amotoki> e0ne: nothing from me
15:11:34 <e0ne> ok
15:11:56 <e0ne> sorry, I didn't add topics to the wiki this time:(
15:12:07 <e0ne> I've got two items in my mind
15:14:21 <e0ne> #topic horizon integration tests
15:14:30 <e0ne> #link http://lists.openstack.org/pipermail/openstack-discuss/2019-February/002374.html
15:14:48 <e0ne> the idea is to get some integration tests for plugins based on our integration tesst
15:15:21 <e0ne> heat, ironic and manila already merged patches with tests and jobs
15:15:37 <e0ne> vitrage patch is waiting to be reviewed
15:15:55 <e0ne> sahara has something but job failed
15:16:10 <e0ne> I'll reach other PTLs by email with ask to add such tests
15:16:34 <e0ne> so we can have a list of plugins which are maintained and working with a current release
15:16:45 <e0ne> that's my plan
15:17:26 <amotoki> is an integration test implementation a requirement for "maintained"?
15:17:27 <e0ne> I would like to have some periodic job in horizon to verify that plugins are working too
15:18:12 <e0ne> amotoki: I thinks. it's only way we can verify that plugin works with current version of horizon
15:18:34 <e0ne> amotoki: from my perspective, I don't care how plugins implement integration tests
15:18:43 <amotoki> I am maintaining neutron-fwaas/vpnaas-dashboard but personally I need volunteers to do it (though I test them every release during developing corresponding backend neutron serivces)
15:19:08 <e0ne> amotoki: I can help you with them next week
15:19:15 <e0ne> amotoki: here is an example https://review.openstack.org/#/c/634487/
15:19:42 <amotoki> yeah, I know it is simple
15:19:43 <e0ne> I've added simple tests just to install plugin and verify that new tabs could be opened
15:20:57 <e0ne> amotoki: once I finished with python3 stuff, I could implement basic smoke tests for that plugins
15:21:59 <amotoki> sounds nice
15:22:04 <e0ne> s/I could/I can
15:23:26 <e0ne> can we move to next topic?
15:23:59 <amotoki> sure
15:24:07 <e0ne> great
15:24:10 <rdopiera> y
15:24:39 <e0ne> #topic horizon plugins maintenance (heat-dashboard)
15:25:19 <e0ne> I was asked by Rico to help maintain heat dashboard last year
15:25:46 <e0ne> I mean, horizon-core will help maintain that plugin
15:26:00 <e0ne> I do understand that we don't have enough resources to do it
15:26:53 <e0ne> but since we'll got integration tests for plugins, I think it's a good idea to add horizon-core to heat core team
15:26:58 <amotoki> what kind of involvements are expected?
15:27:12 <amotoki> perhaps s/heat core/heat-dashboard core/
15:27:42 <e0ne> amotoki: anything I can promise, it's help with merge some gate blocker and critical patches if horizon breaks plugin
15:28:34 <amotoki> yeah, we already made similar things for many plugins related to integration tests, django2 and so on
15:28:52 <amotoki> so some level of help makes sense to me
15:29:18 <e0ne> amotoki: you types these examples faster than me:)
15:29:54 <e0ne> Rico (Heat PTL), is OK to add horizon-core team to heat-dashboard-core
15:29:58 <amotoki> project-specific stuffs like bug triaging might be beyond our resource
15:30:36 <e0ne> amotoki: +1
15:30:59 <e0ne> if we agree, I can add our team to the heat-dashboard-core
15:31:02 <amotoki> I am okay to do it. we already do it for some plugins.
15:31:23 <e0ne> I'm already a part heat-dashboard-core because this plugin is important to be working for my company
15:31:51 <e0ne> amotoki: yea, e.g. we've got +2 for manila and several others http://git.openstack.org/cgit/openstack-infra/project-config/tree/gerrit/acls/openstack/manila-ui.config
15:33:26 <e0ne> amotoki: I'll chat with Rico tomorrow and send a mail to openstack-discuss@ with details
15:34:33 <e0ne> that's all I have to discuss today
15:35:57 <e0ne> #topic Open discussion
15:36:48 <amotoki> e0ne: hopefully you can check my question in https://review.openstack.org/#/c/583093/ ? it is related to the integration tests
15:37:17 <rdopiera> e0ne: I just wanted to quickly mention that Beth is no longer going to work on any bugs in Horizon
15:37:40 <e0ne> rdopiera: it's a sad news to horizon team
15:37:40 <rdopiera> though she's still involved with triaging and such
15:38:04 <e0ne> amotoki: I'll take a look on it
15:38:13 <amotoki> rdopiera: how about blueprint(s?) she owns?
15:38:30 <rdopiera> amotoki: good point, I will probably take those over
15:38:31 <e0ne> amotoki: I'm expecting to get integration tests working with python3 this week
15:39:45 <amotoki> rdopiera: thanks. it is good to keep the status up-to-date anyway regardless of we can work on them or not.
15:40:43 <amotoki> e0ne: IIRC my main question is about sleep(1). if needed, it is nice if we have a comment on why.
15:40:56 <e0ne> amotoki: I understand it
15:41:35 <e0ne> I'll test this patch without sleep on my env
15:42:47 <amotoki> thanks
15:43:33 <e0ne> amotoki: thanks for reminding me
15:44:03 <amotoki> I noticed it when I looked through +2'ed reviews :)
15:44:25 <e0ne> :)
15:47:37 <amotoki> I am investigating the detail of horizon.exceptions.handle() now
15:47:49 <e0ne> rdopiera, amotoki, vishalmanchanda: do you have anything more to discuss?
15:47:55 <amotoki> the function potentially hides critical error like https://bugs.launchpad.net/bugs/1815639
15:47:56 <openstack> Launchpad bug 1815639 in OpenStack Dashboard (Horizon) "WARNING horizon.exceptions Recoverable error: 'module' object has no attribute 'tenant_limit_usages'" [High,In progress] - Assigned to Akihiro Motoki (amotoki)
15:48:16 <amotoki> so I am revisit the logic of exceptions.handle()
15:48:24 <amotoki> this is just FYI now.
15:48:54 <amotoki> that's all from me this week
15:48:58 <e0ne> amotoki: thanks
15:49:48 <e0ne> amotoki: did you see a comment to your patch?
15:50:06 <amotoki> e0ne: not yet
15:50:13 <e0ne> amotoki: ok
15:50:52 <e0ne> thanks everybody for participation!
15:50:57 <e0ne> see you next week
15:50:58 <amotoki> thanks!
15:51:09 <e0ne> #endmeeting