15:05:13 <e0ne> #startmeeting horizon
15:05:13 <openstack> Meeting started Wed Mar 20 15:05:13 2019 UTC and is due to finish in 60 minutes.  The chair is e0ne. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:05:14 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:05:17 <openstack> The meeting name has been set to 'horizon'
15:05:30 <e0ne> let's start horizon meeting
15:06:01 <e0ne> #topic Notices
15:06:24 <e0ne> Stein RC1 should be released this week
15:06:33 <e0ne> #link https://releases.openstack.org/stein/schedule.html
15:07:05 <e0ne> I'm going to update this patch https://review.openstack.org/#/c/644316/ tomorrow and add cycle highlights
15:07:40 <e0ne> after RC1 only high and critical bugs could me merged
15:08:03 <e0ne> AFAIR, we merged all fixes discussed last week
15:08:36 <e0ne> amotoki: do you know something should be included in RC1 but not merged yet?
15:08:57 <amotoki> I think we have nothing pending for RC1
15:09:28 <amotoki> hopefully we have string fixes before RC1
15:10:19 <e0ne> amotoki: +1
15:10:34 <e0ne> RC1 also means hard string freeze
15:10:51 <amotoki> note that once RC1 is shipped the master branch is open for Train cycle and we need to backport critical fixes.
15:11:09 <e0ne> amotoki: thanks for mention it
15:11:45 <amotoki> "hard string freeze" and "backport required" are good combination.  it allows us to review backports carefully
15:12:33 <e0ne> +1
15:14:07 <amotoki> so, we need to propose fixes for bug 1820935 and bug 1820938
15:14:08 <openstack> bug 1820935 in OpenStack Dashboard (Horizon) "typo of Horizon Dashboard UI" [Undecided,Confirmed] https://launchpad.net/bugs/1820935
15:14:09 <openstack> bug 1820938 in OpenStack Dashboard (Horizon) "typo of Horizon Dashboard UI" [Undecided,New] https://launchpad.net/bugs/1820938
15:14:54 <amotoki> I am looking into the second one.
15:15:20 <e0ne> amotoki: I can make a patch for the first one today right after the meeting
15:15:26 <amotoki> e0ne: thanks
15:16:00 <e0ne> I'll propose RC1 once these bugs will be resolved
15:16:14 <e0ne> I hope, we'll do it next 24 hours:)
15:16:24 <amotoki> e0ne: I just remembered one high priority bug. let me find a link
15:16:25 <vishalmanchanda> amotoki: I will purpose fix for the first one.
15:17:15 <amotoki> e0ne: I think it is worth fixed before the release. https://bugs.launchpad.net/horizon/+bug/1820260
15:17:17 <openstack> Launchpad bug 1820260 in OpenStack Dashboard (Horizon) "Network topology graph incorrectly renders instances in non-default availability zone" [High,Confirmed]
15:17:18 <e0ne> vishalmanchanda: ok, feel free to re-assign bug to you
15:17:37 <amotoki> we can handle it in RC2 because we will have RC2 at least for translation imports.
15:18:09 <e0ne> amotoki: I'll take a look on it
15:18:35 <e0ne> anything else related to Stein RC1?
15:18:51 <amotoki> e0ne: this is a valid bug. .startsWith() sounds fine
15:19:24 <amotoki> e0ne: one question is we can assume ES2015 or not
15:20:16 <e0ne> amotoki: I think yes, but if we don't have any ES2015+ specific code yet, I prefer to start using it since Train
15:20:56 <amotoki> e0ne: yeah, me too. the reason I raised is ES2015 introduced .startsWith()
15:20:57 <e0ne> #link https://docs.openstack.org/horizon/latest/user/browser_support.html
15:21:50 <e0ne> good point
15:22:43 <amotoki> my JS knowledge is the level of copy-and-paste though :(
15:22:58 <e0ne> amotoki: looking into https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/startsWith, I'm OK to use it.
15:23:19 <e0ne> #link https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/startsWith#Browser_compatibility
15:23:46 <amotoki> it sounds reasonable to me to assume ES2015 in horizon code base and let's fix them if we have bug reports :)
15:24:07 <e0ne> amotoki::)
15:24:24 <e0ne> amotoki: I'll try to reproduce this issue and propose a patch asap
15:24:54 <amotoki> e0ne: I confirmed this already. I will take care of it
15:25:12 <e0ne> amotoki: thanks for the help
15:25:33 <amotoki> btw, does everyone subscribe bug mails?
15:26:05 <e0ne> amotoki: I'm looking on 'new' bugs on a weekly basis
15:26:40 <amotoki> I subscribe new/close bug mails. it helps me
15:27:23 <e0ne> I subscribed only for new bugs now
15:27:53 <e0ne> amotoki: btw, what do you think about https://bugs.launchpad.net/horizon/+bug/1819951?
15:27:54 <openstack> Launchpad bug 1819951 in OpenStack Dashboard (Horizon) "Horizon enables consistency groups by default" [Undecided,New]
15:28:29 <amotoki> e0ne: it sounds better to sync the default with cinder.
15:28:37 <e0ne> amotoki: I thinks it's good to merge it before RC1
15:29:03 <e0ne> I'll propose a patch today
15:29:08 <amotoki> it was not introduced by the commit mentioned in the bug report. it was caused by out-of-sync policy-in-code at that time.
15:29:30 <amotoki> s/policy-in-code/policy.json/
15:29:53 <amotoki> do we need policy.json before Stein release?
15:30:26 <amotoki> I synced policy.json in past several releases, but I haven't done it in Stein yet.
15:30:55 <e0ne> yes, because horizon uses it for defaults
15:31:16 <e0ne> amotoki: that's something we missed. probably it could wait until rc2
15:32:14 <amotoki> perhaps we should set up a bot to propose policy.json/yaml changes automatically (based on policy-in-code or policy.json)
15:32:19 <amotoki> in Train
15:32:48 <amotoki> we completely depend on it by person.
15:33:09 <e0ne> added this into the PTG agenda
15:35:05 <e0ne> #link https://etherpad.openstack.org/p/horizon-train-ptg
15:36:39 <e0ne> #topic Open Discussion
15:37:13 <e0ne> does anybody have anything more to discuss?
15:37:19 <vishalmanchanda> amotoki: Can you please mark https://blueprints.launchpad.net/openstack/?searchtext=cinder-generic-volume-groups it as implemented as all the required patches have been pushed and merged.
15:37:42 <e0ne> vishalmanchanda: done
15:38:08 <vishalmanchanda> amotoki: e0ne Thanks for your valuable inputs for its completion.
15:38:27 <amotoki> vishalmanchanda: thanks for your effort!
15:38:31 <e0ne> vishalmanchanda: thanks for making this done!
15:39:12 <vishalmanchanda> e0ne: amotoki : yw
15:39:35 <amotoki> we have made a good collaboration.  I made the project panel in Rocky and vishalmanchanda completed the admin panel in Stein :)
15:40:10 <e0ne> amotoki, vishalmanchanda: good jib, guys!
15:40:58 <e0ne> s/jib/job
15:41:02 <amotoki> :)
15:41:18 <vishalmanchanda> :)
15:41:24 <e0ne> let's wrap up the meeting for today. hope to see you next week
15:42:36 <e0ne> #endmeeting