15:05:22 <e0ne> #startmeeting horizon
15:05:25 <openstack> Meeting started Wed Sep 25 15:05:22 2019 UTC and is due to finish in 60 minutes.  The chair is e0ne. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:05:26 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:05:28 <openstack> The meeting name has been set to 'horizon'
15:05:30 <e0ne> hi
15:05:58 <vishalmanchanda> e0ne: hi
15:06:09 <shilpasd> hi all
15:06:47 <e0ne> I home amotoki is here too
15:06:54 <amotoki> o/
15:06:57 <e0ne> #topic Notices
15:07:20 <e0ne> this week we'll meet feature freeze for Train
15:07:33 <e0ne> it also means that train rc1 will be available too
15:07:44 <amotoki> this week is NOT the feature freeze :p
15:07:46 <e0ne> and master branch will be open for U release development
15:07:49 <amotoki> RC1 week
15:07:58 <e0ne> amotoki: thanks a lot!
15:08:17 <e0ne> of course, we passed FF
15:08:19 <e0ne> my fail
15:08:20 <rdopiera> o/
15:09:05 <e0ne> after RC1 only critical fixes will be allowed for Train
15:09:28 <e0ne> also, any fix for Train after RC should be backported from master to stable/train
15:09:42 <e0ne> #topic Train priorities
15:10:03 <e0ne> here is our etherpad
15:10:04 <e0ne> #link https://etherpad.openstack.org/p/horizon-release-priorities
15:10:26 <e0ne> thanks to amotoki for RC1 milestone in the launchpad
15:10:29 <e0ne> #link https://bugs.launchpad.net/horizon/+milestone/train-rc1
15:11:00 <e0ne> it would be great to have all fixes targeted to RC landed
15:11:47 <amotoki> I am preparing a fix for bug 1843104
15:11:47 <openstack> bug 1843104 in OpenStack Dashboard (Horizon) "KeyError: 'default_dns_nameservers' in Horizon" [High,Triaged] https://launchpad.net/bugs/1843104 - Assigned to Akihiro Motoki (amotoki)
15:11:59 <amotoki> I will push the fix after the meeting.
15:12:12 <e0ne> amotoki: great! will review it once CI passed
15:12:29 <amotoki> The fix is straight forward, but it touches several number of files, so a couple of commits are coming.
15:13:10 <e0ne> amotoki: feel free to ping me if any help is needed
15:13:15 <amotoki> e0ne: sure
15:14:15 <amotoki> I will look thru pending bug fix reviews after that.
15:14:22 <e0ne> +1
15:14:27 <shilpasd> +1
15:15:19 <e0ne> I'm worried about https://bugs.launchpad.net/horizon/+bug/1834167
15:15:19 <openstack> Launchpad bug 1834167 in OpenStack Dashboard (Horizon) "Kolla affected by [Explicitly set LOCALE_PATHS for Horizon apps] - compilemessages via manage.py run extra compilations" [High,Confirmed]
15:15:47 <e0ne> it affects a lot of plugins or even all of them
15:16:34 <e0ne> my workaround https://review.opendev.org/#/c/667640/ is not an ideal solution but I failed to find a better one without a lot of changes to our translation service
15:16:39 <guglo> amotoki, just joined, hexchat doesn't seem to have history what is "The fix is straight forward, but it touches several number of files, so a couple of commits are coming." ?
15:16:40 <amotoki> Yeah, I honestly haven't understood the original change from e0ne....
15:17:14 <amotoki> guglo: let you know the log url in private channel
15:17:21 <guglo> k
15:17:49 <e0ne> amotoki: it forces django to use only locale from horizon's directories
15:18:31 <amotoki> e0ne: but I am still not sure why it is needed
15:19:24 <amotoki> e0ne: Doesn't it depend on deployment scenarios?
15:19:25 <e0ne> because of django switches to   zh-ch instead of zh-tw
15:20:16 <e0ne> if we use absolute paths with a limited set of locales, django doesn't do rollback to defaults and uses zh-tw from the provided directories
15:20:55 <e0ne> I'm open to any suggestions to fix it in another way
15:20:58 <amotoki> e0ne: I see. I am recovering my memory...
15:21:55 <amotoki> Apart from the workaround, it seems we need to change locale names near future
15:22:15 <e0ne> unfortunately, we do:(
15:22:41 <e0ne> it would be good to discuss it with i18n team during the PTG
15:22:48 <amotoki> +1
15:23:01 <e0ne> we can't do it without their help
15:23:22 <amotoki> According to the bug comment, Kolla team already has a workaround on it. do we need more work in Train on this?
15:23:49 <e0ne> IMO, it's better to have this fixed from the horizon's side too
15:24:16 <e0ne> maybe some other plugins are affected too and they just didn't report the bug
15:25:09 <amotoki> totally agree
15:26:18 <amotoki> your change is proposed to stable/stein but I hold my +2 because it affect kolla stable/stein branch.
15:26:39 <e0ne> amotoki: no worries, I understand it
15:28:01 <amotoki> I added it to the PTG etherpad.
15:28:17 <e0ne> thanks
15:30:36 <amotoki> regarding bug 1794421, shilpasd is working on UT.
15:30:36 <openstack> bug 1794421 in OpenStack Dashboard (Horizon) "Add allowed address pair button is only visible to admin" [Medium,In progress] https://launchpad.net/bugs/1794421 - Assigned to Shilpa Devharakar (shilpasd)
15:30:58 <e0ne> #link https://review.opendev.org/#/c/679967/
15:31:09 <amotoki> I think if we can confirm it fixes the behavior in our local testing, we can merge this and add UT coverage as follow-up change.
15:31:16 <e0ne> +1
15:31:37 <shilpasd> amotoki: UT is done
15:31:56 <amotoki> shilpasd: cool
15:32:51 <shilpasd> amotoki: i have also addressed today minor nit from vishalmanchanda, CI check is in progress
15:33:14 <vishalmanchanda> shilpasd: +1 thanks.
15:33:14 <amotoki> shilpasd: thanks.
15:33:38 <amotoki> regarding RC1 release patch https://review.opendev.org/#/c/684064/, I just added e0ne to the review list.
15:34:14 <amotoki> once e0ne or I give +1, the release team will approve it.
15:34:38 <e0ne> I'll wait until tomorrow evening to have more time for fixes
15:34:48 <amotoki> +1
15:35:13 <vishalmanchanda> amotoki: e0ne : should we need to add this  bp as well https://blueprints.launchpad.net/horizon/+spec/allow-users-change-expired-password in release highlights?
15:35:31 <vishalmanchanda> or it's too late for that?
15:35:39 <amotoki> vishalmanchanda: good point. let's add it.
15:35:54 <e0ne> vishalmanchanda: I don't know if we can add it now, but let's propose a patch:)
15:36:51 <amotoki> we also need to inform it to Kendall who is collecting cycle highlights.
15:37:12 <e0ne> good point
15:37:34 <amotoki> project teams with FFE might have similar needs, so it is worth tried.
15:41:26 <e0ne> do we have anything else to discuss today?
15:41:54 <amotoki> none from me
15:41:55 <vishalmanchanda> none from my side.
15:43:11 <vishalmanchanda> e0ne: amotoki I will be less active till next week due to some family proiorties.
15:43:23 <e0ne> ok. let's to our best to release rc1 tomorrow
15:43:43 <e0ne> vishalmanchanda: thanks for the reminder
15:43:53 <e0ne> s/reminder/information
15:44:15 <e0ne> see you next week!
15:44:18 <vishalmanchanda> bye all
15:44:24 <amotoki> o/
15:44:29 <shilpasd> thanks all for support in review
15:44:34 <shilpasd> and help provided
15:45:51 <e0ne> #endmeeting