15:00:47 <e0ne> #startmeeting horizon
15:00:48 <openstack> Meeting started Wed Aug  5 15:00:47 2020 UTC and is due to finish in 60 minutes.  The chair is e0ne. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:49 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:52 <openstack> The meeting name has been set to 'horizon'
15:00:58 <e0ne> hi
15:01:06 <vishalmanchanda> hi
15:02:02 <e0ne> vishalmanchanda: let's wait few minutes more
15:02:08 <amotoki> hi, beer time :)
15:02:10 <vishalmanchanda> sure.
15:02:43 <e0ne> amotoki: you're lucky enough. it's too early for beer for me
15:03:05 <vishalmanchanda> 🙂
15:03:23 <amotoki> I'm off today, so it is not surprising even if I have beer in your time :p
15:04:24 <e0ne> ok. let's start
15:04:28 <vishalmanchanda> e0ne: Do we have mid-cycle meeting?
15:04:39 <e0ne> #topic virtual mid-cycle
15:05:18 <e0ne> we've got a very few responses in the poll
15:05:20 <e0ne> https://doodle.com/poll/dkmsai49v4zzpca2
15:06:07 <e0ne> so I don't I'm not sure what to do
15:06:19 <e0ne> it's up to you to decide
15:07:03 <e0ne> do we want to have it this week or move later this cycle?
15:08:04 <amotoki> I just added my vote for case we have it this week
15:09:24 <vishalmanchanda> We can do it tomorrow
15:09:43 <e0ne> looks like tomorrow it the best date for everybody
15:11:08 <e0ne> we can do a call tomorrow to catch-up current release priorities
15:11:28 <vishalmanchanda> cool.
15:11:48 <e0ne> amotoki: what about you?
15:12:06 <amotoki> I am okay with tomorrow
15:12:37 <e0ne> good. I'll send an update to the mailing list once I'll manage what software will we use
15:12:56 <vishalmanchanda> at 13 UTC.
15:13:00 <amotoki> which time slots? 3UTC or 13UTC?
15:13:17 <e0ne> 13.00 UTC
15:13:50 <e0ne> it got more positive votes
15:14:39 <amotoki> sounds good. I haven't checked vote result.
15:16:39 <e0ne> #topic Open Discussion
15:16:59 <e0ne> I'm skipping updates because there are no updates from me
15:17:06 <e0ne> and Victoria priorities will be discussed tomorrow
15:17:20 <vishalmanchanda> amotoki: Could you take a look at this patch https://review.opendev.org/#/c/734161/
15:17:43 <vishalmanchanda> Ivan already voted.
15:18:23 <amotoki> vishalmanchanda: sure but you need to keep in mind that I am off this week
15:18:25 <vishalmanchanda> Let me know if any concern about this patch. I will try to fix asap.
15:18:36 <vishalmanchanda> amotoki: yeah.
15:19:46 <vishalmanchanda> e0ne: amotoki : Also i need your attention on this patch https://review.opendev.org/#/c/708069/
15:20:06 <vishalmanchanda> Please see my comment on P.S 15
15:20:39 <vishalmanchanda> sorry:(.
15:21:12 <vishalmanchanda> It is already fixed.
15:21:39 <e0ne> vishalmanchanda: according to docstring. here is a good example: https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html
15:22:04 <e0ne> vishalmanchanda: and here is a pep: https://www.python.org/dev/peps/pep-0257/
15:22:24 <vishalmanchanda> e0ne: thanks for the link i will take a look.
15:23:20 <vishalmanchanda> Actually I have left some comments on P.S 18 for this patch https://review.opendev.org/#/c/708069/
15:23:49 <vishalmanchanda> I am referring this situation https://pasteboard.co/JkaA9tX.png
15:24:03 <vishalmanchanda> We have fix this in plugins as well.
15:24:24 <vishalmanchanda> https://review.opendev.org/#/c/708069/18/openstack_dashboard/dashboards/admin/volume_types/forms.py@133
15:25:51 <e0ne> sorry, I didn't get what do you mean
15:28:03 <vishalmanchanda> I am trying to say we have to change this https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/volume_types/forms.py#L132
15:28:51 <vishalmanchanda> exceptions.handle(
15:28:51 <vishalmanchanda> request, _('Unable to create encrypted volume
15:28:51 <vishalmanchanda> type.'), redirect= redirect)
15:29:34 <vishalmanchanda> basically removes ex from here otherwise it looks like this https://pasteboard.co/JkaA9tX.png
15:30:27 <e0ne> yep, we need to remove it
15:30:43 <vishalmanchanda> yeah that's what i am trying to say.
15:30:51 <e0ne> and probably, we have to it in plugins too:)
15:30:53 <e0ne> :(
15:30:59 <vishalmanchanda> We have to do similar changes in plugins
15:31:04 <e0ne> vishalmanchanda: now I understand your comment
15:33:16 <vishalmanchanda> So we need be very careful about this patch https://review.opendev.org/#/c/708069/
15:33:40 <vishalmanchanda> I mean when to merge it.
15:33:54 <e0ne> +1
15:34:46 <vishalmanchanda> because let's say if we merge it in horizon for Victoria cycle then we need to same changes for plugins in the same cycle otherwise it looks ugly.
15:36:11 <e0ne> how many plugins are affected?
15:36:29 <vishalmanchanda> I have not checked it yet
15:36:56 <e0ne> it could be a blocker
15:37:01 <vishalmanchanda> but we have around 30 horizon plugins. I hope changes should be less.
15:37:22 <e0ne> e.g. if we need to fix only 3-5 plugins - we can do it fast
15:37:40 <e0ne> if we have to fix 10-15+ plugins - it will be painful
15:38:12 <vishalmanchanda> e0ne: ok I will check after the meeting .
15:38:22 <e0ne> thanks
15:38:44 <vishalmanchanda> In that case we also need to send a mail on open-discuss about this change.
15:38:45 <amotoki> we might check a caller in exceptions.handle() and determine if the new feature shoudl be enabled.
15:39:22 <e0ne> amotoki: it could be a pretty good workaround
15:39:22 <amotoki> we can disable it until we complete a plugin supports it (i means we need to drop exception messages from the base message)
15:40:05 <amotoki> another question: do we want to cover JS messages in this bp?
15:40:18 <vishalmanchanda> sounds good.
15:41:30 <vishalmanchanda> amotoki: TBH I haven't thought of it yet.
15:41:42 <vishalmanchanda> but we can take a look.
15:43:48 <amotoki> regardless of whether we cover JS side soon or not, we need to take it into account for consistency.
15:43:52 <e0ne> amotoki: JS side will be good too
15:44:33 <amotoki> e0ne: what do you mean by "good"?
15:44:33 <e0ne> I don't want to have more feature gaps between django and angular-based views
15:44:55 <e0ne> amotoki: I mean it would be great to have it in
15:45:08 <amotoki> e0ne: got it. we are in a same page
15:45:15 <e0ne> :)
15:45:52 <vishalmanchanda> then I will check how to cover Js/angular sides as well.
15:47:23 <e0ne> vishalmanchanda: thank you, Vishal!
15:47:34 <vishalmanchanda> e0ne: yw.
15:50:40 <e0ne> we've got 10 minutes more
15:51:02 <vishalmanchanda> I have noting more to discuss.
15:52:06 <amotoki> me either
15:53:22 <e0ne> thanks everybody for your contributions! see you tomorrow!
15:54:16 <vishalmanchanda> bye.
15:54:20 <amotoki> bye
15:54:26 <e0ne> #endmeeting