15:00:47 #startmeeting horizon 15:00:48 Meeting started Wed Aug 5 15:00:47 2020 UTC and is due to finish in 60 minutes. The chair is e0ne. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:00:49 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:00:52 The meeting name has been set to 'horizon' 15:00:58 hi 15:01:06 hi 15:02:02 vishalmanchanda: let's wait few minutes more 15:02:08 hi, beer time :) 15:02:10 sure. 15:02:43 amotoki: you're lucky enough. it's too early for beer for me 15:03:05 🙂 15:03:23 I'm off today, so it is not surprising even if I have beer in your time :p 15:04:24 ok. let's start 15:04:28 e0ne: Do we have mid-cycle meeting? 15:04:39 #topic virtual mid-cycle 15:05:18 we've got a very few responses in the poll 15:05:20 https://doodle.com/poll/dkmsai49v4zzpca2 15:06:07 so I don't I'm not sure what to do 15:06:19 it's up to you to decide 15:07:03 do we want to have it this week or move later this cycle? 15:08:04 I just added my vote for case we have it this week 15:09:24 We can do it tomorrow 15:09:43 looks like tomorrow it the best date for everybody 15:11:08 we can do a call tomorrow to catch-up current release priorities 15:11:28 cool. 15:11:48 amotoki: what about you? 15:12:06 I am okay with tomorrow 15:12:37 good. I'll send an update to the mailing list once I'll manage what software will we use 15:12:56 at 13 UTC. 15:13:00 which time slots? 3UTC or 13UTC? 15:13:17 13.00 UTC 15:13:50 it got more positive votes 15:14:39 sounds good. I haven't checked vote result. 15:16:39 #topic Open Discussion 15:16:59 I'm skipping updates because there are no updates from me 15:17:06 and Victoria priorities will be discussed tomorrow 15:17:20 amotoki: Could you take a look at this patch https://review.opendev.org/#/c/734161/ 15:17:43 Ivan already voted. 15:18:23 vishalmanchanda: sure but you need to keep in mind that I am off this week 15:18:25 Let me know if any concern about this patch. I will try to fix asap. 15:18:36 amotoki: yeah. 15:19:46 e0ne: amotoki : Also i need your attention on this patch https://review.opendev.org/#/c/708069/ 15:20:06 Please see my comment on P.S 15 15:20:39 sorry:(. 15:21:12 It is already fixed. 15:21:39 vishalmanchanda: according to docstring. here is a good example: https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html 15:22:04 vishalmanchanda: and here is a pep: https://www.python.org/dev/peps/pep-0257/ 15:22:24 e0ne: thanks for the link i will take a look. 15:23:20 Actually I have left some comments on P.S 18 for this patch https://review.opendev.org/#/c/708069/ 15:23:49 I am referring this situation https://pasteboard.co/JkaA9tX.png 15:24:03 We have fix this in plugins as well. 15:24:24 https://review.opendev.org/#/c/708069/18/openstack_dashboard/dashboards/admin/volume_types/forms.py@133 15:25:51 sorry, I didn't get what do you mean 15:28:03 I am trying to say we have to change this https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/volume_types/forms.py#L132 15:28:51 exceptions.handle( 15:28:51 request, _('Unable to create encrypted volume 15:28:51 type.'), redirect= redirect) 15:29:34 basically removes ex from here otherwise it looks like this https://pasteboard.co/JkaA9tX.png 15:30:27 yep, we need to remove it 15:30:43 yeah that's what i am trying to say. 15:30:51 and probably, we have to it in plugins too:) 15:30:53 :( 15:30:59 We have to do similar changes in plugins 15:31:04 vishalmanchanda: now I understand your comment 15:33:16 So we need be very careful about this patch https://review.opendev.org/#/c/708069/ 15:33:40 I mean when to merge it. 15:33:54 +1 15:34:46 because let's say if we merge it in horizon for Victoria cycle then we need to same changes for plugins in the same cycle otherwise it looks ugly. 15:36:11 how many plugins are affected? 15:36:29 I have not checked it yet 15:36:56 it could be a blocker 15:37:01 but we have around 30 horizon plugins. I hope changes should be less. 15:37:22 e.g. if we need to fix only 3-5 plugins - we can do it fast 15:37:40 if we have to fix 10-15+ plugins - it will be painful 15:38:12 e0ne: ok I will check after the meeting . 15:38:22 thanks 15:38:44 In that case we also need to send a mail on open-discuss about this change. 15:38:45 we might check a caller in exceptions.handle() and determine if the new feature shoudl be enabled. 15:39:22 amotoki: it could be a pretty good workaround 15:39:22 we can disable it until we complete a plugin supports it (i means we need to drop exception messages from the base message) 15:40:05 another question: do we want to cover JS messages in this bp? 15:40:18 sounds good. 15:41:30 amotoki: TBH I haven't thought of it yet. 15:41:42 but we can take a look. 15:43:48 regardless of whether we cover JS side soon or not, we need to take it into account for consistency. 15:43:52 amotoki: JS side will be good too 15:44:33 e0ne: what do you mean by "good"? 15:44:33 I don't want to have more feature gaps between django and angular-based views 15:44:55 amotoki: I mean it would be great to have it in 15:45:08 e0ne: got it. we are in a same page 15:45:15 :) 15:45:52 then I will check how to cover Js/angular sides as well. 15:47:23 vishalmanchanda: thank you, Vishal! 15:47:34 e0ne: yw. 15:50:40 we've got 10 minutes more 15:51:02 I have noting more to discuss. 15:52:06 me either 15:53:22 thanks everybody for your contributions! see you tomorrow! 15:54:16 bye. 15:54:20 bye 15:54:26 #endmeeting