15:00:25 <e0ne_> #startmeeting horizon
15:00:26 <openstack> Meeting started Wed Aug 12 15:00:25 2020 UTC and is due to finish in 60 minutes.  The chair is e0ne_. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:27 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:29 <openstack> The meeting name has been set to 'horizon'
15:00:43 <e0ne_> hi everybody
15:00:45 <rdopiera> o/
15:00:53 <vishalmanchanda> hi
15:01:53 <e0ne_> let's wait few minutes more to get people join us
15:02:47 <e0ne_> #link https://etherpad.opendev.org/p/horizon-release-priorities
15:03:08 <amotoki> hi
15:03:49 <e0ne_> #topic Notices
15:04:10 <e0ne_> we're about one month before victoria-3 milestone and feature freeze
15:04:18 <e0ne_> #link https://releases.openstack.org/victoria/schedule.html
15:05:26 <e0ne_> there is Wallaby release schedule proposal: https://review.opendev.org/#/c/744729/
15:07:33 <e0ne_> there is nothing special (yet) for horizon, it's just for your information
15:08:10 <e0ne_> I would like to say thank you for all Virtual PTG attendees
15:08:22 <e0ne_> I think it was very productive
15:08:40 <vishalmanchanda> e0ne_: thanks for hosting it.
15:09:00 <e0ne_> you can find notes in our etherpad with cycle priorities
15:09:04 <e0ne_> https://etherpad.opendev.org/p/horizon-release-priorities
15:09:31 <e0ne_> it's a new format for horizon team but I like it
15:10:26 <e0ne_> I miss offline communications but in a current situation virtual events are the best choice to keep everybody safe
15:10:59 <vishalmanchanda> yup.
15:11:13 <amotoki> e0ne_: do you mean "Release priorities" in the meeting agenda?
15:12:03 <e0ne_> amotoki:  I'm sorry, what do you mean?
15:12:04 <e0ne_> and the next PTG will be virtual too
15:12:21 <e0ne_> #link http://lists.openstack.org/pipermail/openstack-discuss/2020-August/016424.html
15:12:47 <e0ne_> Virtual PTG will be on the next week after the Summit and it's free
15:12:48 <amotoki> e0ne_: I wonder what is "a new format for horizon team".
15:13:18 <e0ne_> please, don't forget to register for the PTG
15:13:37 <e0ne_> amotoki: I mean: "virtual mid-cycle is a new thing for us"
15:14:56 <amotoki> e0ne_: ah I see. I misundrstood you that you've defined another priorities.
15:15:09 <amotoki> e0ne_: I got you now
15:16:12 <e0ne_> amotoki: I didn't change anything. even more: I don't feel it's a good to change priorities without discussion in community
15:16:56 <amotoki> e0ne_: no worries. i just would like to understand the context correctly
15:17:13 <e0ne_> amotoki: :)
15:17:37 <e0ne_> that's all updates from me this week
15:18:04 <e0ne_> #topic Open Discussion
15:18:16 <e0ne_> does anybody have any topic to discuss?
15:19:03 <vishalmanchanda> I am also not having much update today is holiday in India and I was on PTO yesterday.
15:19:25 <e0ne_> I've got some update about Chinese but it's not a priority for this cycle, so I put this topic to the end
15:19:39 <vishalmanchanda> But there is one issue i am facing in refactor-error-messages.
15:20:03 <vishalmanchanda> I am still not able to figure out how to use ng-if in this template https://review.opendev.org/#/c/708069/20/horizon/templates/horizon/client_side/_alert_message.html
15:20:08 <rdopiera> nothing from me
15:20:26 <e0ne_> vishalmanchanda: actually, it's not a angular template :(
15:20:47 <vishalmanchanda> I am not much familar with angular-js with django templates.
15:21:04 <vishalmanchanda> This is what i tried so far
15:21:04 <vishalmanchanda> <a ng-if="[[details]]" ng-href="#message_details"  data-toggle="collapse" data-target="#message_details">Details</a>
15:21:16 <e0ne_> https://github.com/openstack/horizon/blob/fb467ad60d8566d39bc61647f26643c63210ab04/horizon/templatetags/horizon.py#L185
15:22:28 <e0ne_> as I understand, we don't have 'if-statement' support in this kind of templates
15:24:02 <vishalmanchanda> I have used ng-if but when details is "" then it taking as < a ng-if ng-href="#message_details"  data-toggle="collapse" data-target="#message_details">Details</a>
15:24:11 <rdopiera> e0ne_: you can always use the django's mechanism
15:24:33 <vishalmanchanda> I observered this while debugging.
15:24:37 <e0ne_> https://github.com/openstack/horizon/blob/4e0ee573db4561dc7e0c10835d31d73eddb12aca/horizon/static/horizon/js/horizon.templates.js#L32
15:24:46 <e0ne_> rdopiera: it's a good idea
15:24:55 <e0ne_> we need to check this
15:25:08 <e0ne_> I didn't dig deep how these templates work
15:25:10 <rdopiera> I think this is actually what is happeningh
15:25:19 <rdopiera> django is substituting [[details]]
15:26:25 <vishalmanchanda> How can we handle this here https://review.opendev.org/#/c/708069/20/horizon/templates/horizon/client_side/_alert_message.html
15:26:52 <vishalmanchanda> I am referring this document https://django-angular.readthedocs.io/en/latest/template-sharing.html
15:27:40 <e0ne_> vishalmanchanda: we don't use django-angular
15:28:13 <vishalmanchanda> e0ne_: ohh I see.
15:28:15 <e0ne_> did you installed it on your env?
15:28:42 <vishalmanchanda> no
15:28:58 <vishalmanchanda> I thought it is used in horizon!
15:29:41 <rdopiera> I think we use a similar configuration to avoid conflicts between django templates and angular templates
15:29:43 <amotoki> vishalmanchanda: you can check our requirements.txt
15:31:38 <vishalmanchanda> amotoki: hmm django-angular is not used in our requirement.txt
15:32:21 <vishalmanchanda> Could you guys provide me  some references how to fix this issue?
15:33:15 <e0ne_> vishalmanchanda: I could try to do it on my env later tonight
15:33:35 <vishalmanchanda> e0ne_: thanks Ivan:)
15:33:45 <e0ne_> I don't have any solution by the hand because I'm not familiar enough with this  code
15:34:01 <vishalmanchanda> I will also try something else tomorrow.
15:34:27 <vishalmanchanda> In meanwhile i will push cleanup patches for horizon as well as for plugins which we discussed during mid-cycle.
15:34:42 <e0ne_> vishalmanchanda: awesome!
15:36:07 <vishalmanchanda> amotoki: are you planning to backport this patch https://review.opendev.org/#/c/737686/ in stable branches?
15:36:38 <vishalmanchanda> amotoki: or I can do it if it's fine for you.
15:36:42 <e0ne_> vishalmanchanda: do you think we need it?
15:36:54 <amotoki> vishalmanchanda: yeah, I am planning it. do you see any stable breakage now?
15:37:17 <amotoki> I didn't think it is urgent
15:37:27 <e0ne_> I didn't see any patches to stable branched during last few weeks
15:37:34 <vishalmanchanda> amotoki: no breakage till queen.
15:37:45 <vishalmanchanda> rocky is still broken
15:37:47 <e0ne_> maybe somebody merged them before I opened the gerrit
15:37:48 <amotoki> vishalmanchanda: good to hear it
15:38:57 <e0ne_> +1
15:39:15 <vishalmanchanda> nodejs job is still failing in stable/rocky.
15:39:58 <vishalmanchanda> that's all update from my side.
15:40:27 <e0ne_> vishalmanchanda: thanks for your work on stable branches CI issues
15:40:37 <vishalmanchanda> e0ne_: np.
15:41:42 <amotoki> vishalmanchanda: I am not sure when our discussion switched to stable branches....
15:42:12 <amotoki> vishalmanchanda: could you see examples of stable failures?
15:43:14 <vishalmanchanda> amotoki: test patch for stable/rocky https://review.opendev.org/#/c/737490/
15:43:44 <vishalmanchanda> tempest job is fixed as of now for stable/rocky.
15:45:18 <amotoki> vishalmanchanda: so, don't we have any breakage in master and branches before rocky?
15:46:15 <amotoki> I mean "after rocky".
15:47:51 <vishalmanchanda> amotoki: we already fixed it till queen  by Andreas Patch.
15:48:28 <vishalmanchanda> https://review.opendev.org/#/q/Icf82fa96f7d90453f78cf564c847682a286ed575
15:49:12 <amotoki> vishalmanchanda: okay. I just wonder why you mentioned https://review.opendev.org/#/c/737686/
15:49:16 <e0ne_> vishalmanchanda: is it enough to backport that patch to stable/rocky or we need to to something else?
15:49:44 <amotoki> vishalmanchanda: if our backports so far works, I think they are what we should have.
15:50:28 <amotoki> I was out last week, so I may be out of the context.
15:50:55 <vishalmanchanda> I have to check https://review.opendev.org/#/c/736992/ backport work for stable/rocky.
15:51:37 <e0ne_> we need to backport https://review.opendev.org/#/c/737577/
15:51:59 <e0ne_> it has some merge conflict, so we can't do it via gerrit UI :(
15:52:20 <vishalmanchanda> If I remember correctly tempest job is failing for stable/rocky which need to be fixed from devstack side.
15:53:19 <vishalmanchanda> it is fixed in devstack as of now so we can simply backport https://review.opendev.org/#/c/736992/ to stable/rocky.
15:53:32 <e0ne_> let's do it:)
15:55:08 <vishalmanchanda> sure.
15:55:12 * e0ne_ is's a friendly 5 minutes reminder
15:57:35 <e0ne_> we're almost out of time for this meeting
15:57:39 <e0ne_> thanks everybody for your contributions!
15:57:45 <vishalmanchanda> bye
15:57:48 <e0ne_> see you next week
15:58:24 <e0ne_> btw, we can do any discussions in #openstack-horizon, so we don't need to wait for a weekly meeting
15:58:32 <e0ne_> #endmeeting