15:01:00 <e0ne> #startmeeting horizon
15:01:01 <openstack> Meeting started Wed Sep  2 15:01:00 2020 UTC and is due to finish in 60 minutes.  The chair is e0ne. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:01:02 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:01:04 <openstack> The meeting name has been set to 'horizon'
15:01:09 <e0ne> hi everybody
15:01:14 <tmazur> hi o/
15:01:21 <vishalmanchanda> hi
15:04:00 <e0ne> ok, let's start
15:04:17 <e0ne> I hope amotoki and Radomir will join us later
15:04:24 <e0ne> #topic Notices
15:04:45 <tmazur> Radomir is on PTO
15:04:58 <e0ne> tmazur: thanks for the information
15:05:19 <e0ne> PTG planing
15:05:56 <e0ne> please, don't forget to register for PTG if you're going to attend it
15:05:59 <e0ne> #link https://www.openstack.org/ptg/
15:06:28 <e0ne> registration is free and fast enough
15:06:41 <e0ne> also, there is our usual PTG planning etherpad
15:06:43 <e0ne> #link https://etherpad.opendev.org/p/horizon-w-ptg
15:07:01 <e0ne> feel free to add topics you would like to discuss
15:07:22 <e0ne> you can find our timeslots in the etherpad
15:07:37 <e0ne> forgot to mention, it will be a virtual PTG again
15:11:26 <e0ne> #topic Release priorities
15:11:33 <e0ne> #link https://releases.openstack.org/victoria/schedule.html
15:12:14 <e0ne> we're one week away from Victoria-3 milestone
15:12:45 <e0ne> once we'll reach it, no more features will be allowed to merge
15:13:31 <e0ne> of course, FFE (Feature Freeze Exception) mechanism is still working but I would like to have everything merged before the deadline
15:15:09 <e0ne> you can find a list of proposed patches with features in our therpad https://etherpad.opendev.org/p/horizon-release-priorities
15:15:15 <e0ne> s/therpad/etherpad
15:15:31 <e0ne> feel free to add anything I missed
15:15:43 <vishalmanchanda> Can I have a 2nd review on https://review.opendev.org/#/c/734161/(cinder-user-facing-messages) and https://review.opendev.org/#/c/708069/(refactor-error-messages)
15:16:15 <vishalmanchanda> If I missed anything i can cover-up it in a follow-up patch.
15:16:50 <e0ne> vishalmanchanda: I will review your patches tonight or tomorrow morning
15:17:02 <vishalmanchanda> e0ne: thanks.
15:17:20 <e0ne> It will be great to have them merged
15:17:25 <e0ne> in this release :)
15:17:42 <vishalmanchanda> yeah
15:19:06 <e0ne> I hope, it will be a priority for all  cores to review new features
15:19:15 <e0ne> tmazur: your reviews are welcome too :)
15:19:47 <tmazur> e0ne, as a former/hopefully future core, yep
15:19:56 <e0ne> tmazur: :)
15:20:26 <e0ne> tmazur: I believe you know about angularized side more than all of us
15:20:51 <tmazur> Speaking of Angular! I have a question on AngularJS unit tests. Should I wait for the open discussion?
15:21:05 <e0ne> tmazur: please
15:22:58 <tmazur> So first of all thanks for the merging this small patch on filters. I ran into an interesting fact while working on it. We do have 22 tests with "SPEC HAS NO EXPECTATIONS" which means that those tests are doing nothing right now.
15:23:02 <e0ne> tmazur, vishalmanchanda:  do you have something to add about our future relese?
15:23:29 <tmazur> Oops, sorry. Please ignore until the open discussion
15:23:53 <vishalmanchanda> e0ne: nothing from my side.
15:24:00 <e0ne> vishalmanchanda: ok
15:24:00 <tmazur> Nothing from my side about future release
15:25:02 <e0ne> I've got few more topics to discuss in our etherpad (tempest plugin and Chainese languages), but I would ike to to discuss it with Akihiro and Radomir too
15:25:06 <e0ne> #topic Open Discussion
15:26:26 <e0ne> tmazur: TBH, I don't surprised on it, we'd got some unit/integration tests which were broken from the beginning in the past :(
15:26:47 <e0ne> tmazur: do you have a list of such tests?
15:27:10 <tmazur> So, the tests. I've made a quick research and it has to do with unresolved promises. Also they cannot be fixed all in once, each case is pretty unique.
15:27:23 <amotoki> hi, sorry for late.
15:27:31 <e0ne> amotoki: welcome!
15:28:19 <tmazur> I can make the list, it could be easily extracted from jasmine results
15:29:00 <tmazur> It would be nice to make them work one by one, otherwise it's just confusing.
15:29:26 <e0ne> tmazur: +1
15:29:36 <vishalmanchanda> +1.
15:30:42 <tmazur> I can start to work on it but I'm not sure about my current priorities. So apparently it hasn't to be scheduled to future release.
15:31:00 <e0ne> tmazur: is any way to catch such tests on CI to prevent such issues in the future?
15:31:49 <tmazur> e0ne: we should catch these "SPEC HAS NO EXPECTATIONS" warnings.
15:32:12 <e0ne> can we treat such warnings as errors on CI?
15:32:24 <amotoki> in my understandng, it means no test actually.
15:32:32 <e0ne> amotoki: +1
15:32:34 <tmazur> theoretically yes. I will tackle this as well
15:32:45 <e0ne> tmazur: it will be awesome
15:33:46 <tmazur> That means unresolved promise, once it is resolved, a test fails with an error.
15:34:41 <tmazur> But in the current way, yes, no test at all
15:36:09 <amotoki> tmazur: I don't see any "SPEC HAS NO EXPECTATIONS" in our npm test result. how did you get the warning?
15:36:41 <tmazur> amotoki, I was using jasmine
15:38:01 <amotoki> I see. so cannot we avoid it with our current test runner?
15:38:29 <amotoki> (I don't know JS test suite very much)
15:39:45 <tmazur> amotoki, I don't know yet. My plan is to fix current 22 tests which are doing nothing and then to tackle how we can avoid this situation in future
15:40:12 <amotoki> tmazur: no problem. your plan sounds good.
15:42:29 <tmazur> Also, another question. What is the current situation on angularization? I can see there were some efforts on instances page a while ago. I understand it's not a high priority right now, but what is the optimistic plan?
15:42:51 <e0ne> remove angularjs?
15:42:56 <tmazur> Essentially: do we still need it or not?
15:42:59 <e0ne> it's a joke
15:43:06 <tmazur> Haha, you got me :D
15:43:12 <e0ne> honestly, I don't know
15:43:29 <e0ne> from one side it would be good to to complete angularization
15:44:01 <e0ne> from other side, I don't like a lot to work with old almost unsupported framework
15:44:29 <tmazur> it's understandable.
15:45:13 <amotoki> I see one priority which is to close gaps in AngularJS panels used by default
15:45:19 <amotoki> like Instance Launch form.
15:45:37 <e0ne> amotoki: that's what I was going to say
15:45:42 <tmazur> and do not touch it anymore? :)
15:46:27 <amotoki> for others it needs more discussion.
15:46:47 <amotoki> Our current status comes from the lack of JS developers.
15:46:56 <tmazur> I was just looking on ugly filtering system at instances page and was thinking how it would be easier to angularize it, only the filter or the whole page
15:48:07 <e0ne> let's discuss it during the PTG
15:48:17 <e0ne> it's important topic
15:48:25 <tmazur> e0ne, Absolutely!
15:48:26 <amotoki> agree
15:48:50 <e0ne> it doesn't mean I don't want to discuss it now or on the next meeting
15:48:58 <amotoki> one thing I would like to note is that there is no way to call Django form or page from angular pages
15:49:21 <e0ne> I mean that during virtual face-to-face on the PTG it will be more productive for this particular case
15:49:25 <amotoki> so angular migration tends to be slow because we cannot switch it until the whole migration is completed.
15:50:16 <e0ne> amotoki: that's why I prefer to use modern frameworks like react or vue: they don't require to re-implement the whole page to start work
15:50:45 <amotoki> hehe
15:51:15 <e0ne> :)
15:53:33 <tmazur> ok let's discuss it during the PTG
15:54:22 <e0ne> we've got 5 minutes left
15:54:36 <e0ne> does anybody have anything to discuss?
15:54:50 <tmazur> Nothing more from my side
15:54:51 <amotoki> e0ne: I see you mentioned "tempest plugin and Chainese languages".
15:54:58 <vishalmanchanda> I am working on this bug https://bugs.launchpad.net/horizon/+bug/1893305 and need some help.
15:54:59 <openstack> Launchpad bug 1893305 in OpenStack Dashboard (Horizon) "Details href still displayed when details is empty and redirect is false." [Undecided,New] - Assigned to Vishal Manchanda (vishalmanchanda)
15:55:20 <vishalmanchanda> but we can discuss it in horizon channel.
15:55:21 <e0ne> amotoki: I moved them to the next meeting
15:55:45 <amotoki> e0ne: okay. I just wonder what is the topic about tempest plugin.
15:56:16 <e0ne> amotoki: QA team wants to merge our plugin (actually, only one test) into the tempest core
15:56:50 <amotoki> e0ne: ah, got it.
15:57:03 <e0ne> amotoki: that's what they said to me, so I decided to discuss it with the whole horizon team
15:58:57 <e0ne> we're almost out of time
15:59:26 <e0ne> vishalmanchanda: we can move to our channel if you need to dicsuss something
15:59:31 <e0ne> thanks everybody for your contributions! see you next week
15:59:35 <e0ne> #endmeeting