15:02:00 <e0ne_> #startmeeting horizon
15:02:01 <openstack> Meeting started Wed Sep 30 15:02:00 2020 UTC and is due to finish in 60 minutes.  The chair is e0ne_. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:02:02 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:02:05 <openstack> The meeting name has been set to 'horizon'
15:02:13 <tmazur> o/
15:02:33 <e0ne_> hi
15:03:26 <e0ne_> tmazur: let's wait few minutes more, maybe somebody else will join us
15:03:52 <tmazur> +1
15:09:19 <e0ne_> looks like team celebrates stable/victoria branch cut for horizon :)
15:09:57 <tmazur> Haha indeed
15:10:03 <e0ne_> #topic Notices
15:10:43 <e0ne_> here is usual reminder about OpenInfra summit and PTG
15:10:45 <e0ne_> #link https://www.openstack.org/summit
15:10:51 <e0ne_> #link https://www.openstack.org/ptg
15:11:03 <e0ne_> both events will be free and virtual
15:11:20 <e0ne_> so don't forget to register for them
15:11:35 * e0ne_ hopes somebody will read this meeting log
15:11:50 <tmazur> I keep checking I'm registered already, yes :)
15:12:10 <e0ne_> here is Horizon PTG planning etherpad:
15:12:11 <e0ne_> #link https://etherpad.opendev.org/p/horizon-w-ptg
15:12:37 <e0ne_> feel free to add topics you want to discuss
15:13:21 <e0ne_> that's all announcements I've got this week
15:13:28 <e0ne_> #topic Open Discussion
15:14:15 <e0ne_> looks like we broke got some plugins gates again:(
15:15:01 <e0ne_> I didn't check which plugins are affected by this patch https://review.opendev.org/#/c/752016/ #lnik
15:15:20 <e0ne_> the fix is simple per plugin https://review.opendev.org/#/c/754439/3/ironic_ui/karma.conf.js #link
15:15:42 <e0ne_> but it would be good to find some better way to do it
15:15:52 <tmazur> Do they have jasmine.html as well?
15:16:03 <e0ne_> tmazur: since you're working on our JS test, maybe you've got some idea how to fix it
15:16:10 <tmazur> Like we still have to fix in horizon itself?
15:17:06 <tmazur> I will tackle it, but I'm not sure about my priorities right now
15:18:04 <e0ne_> ironic-ui doesn't have jasmine.html
15:19:06 <e0ne_> #link https://review.opendev.org/#/c/754434/ - fix for jasmine runner in horizon
15:19:33 <e0ne_> tmazur: can we re-use jasmine.html and karma.conf.js from horizon in plugins?
15:20:39 <tmazur> That would be perfect solution. Theoretically we can, have to try this.
15:21:39 <tmazur> Do I need some special env to run ironic-ui?
15:22:25 <e0ne_> do you mean only to run tests?
15:22:30 <tmazur> Yes
15:22:57 <e0ne_> the easiest way is to checkout my patch
15:23:18 <e0ne_> it will install all deps via  tox
15:23:43 <e0ne_> it's almost the same as we do for horizon, just few more deps
15:24:37 <tmazur> The one on "Add npm tox env"?
15:24:42 <e0ne_> yes
15:25:04 <tmazur> Ok, will play with it then
15:25:11 <e0ne_> tmazur: thanks
15:25:27 <tmazur> yw
15:25:44 <tmazur> Also about gate jobs.
15:26:24 <e0ne_> sure, ask it
15:27:19 <tmazur> There is a solution to make these warnings fail. But I think better to discuss it on ptg, since it's about upgrading Karma and Jasmine
15:28:10 <tmazur> One of newer Karma and Jasmine versions have this functionality. So basically we have to "just" upgrade it.
15:28:23 <e0ne_> oh.. it sounds pretty risky
15:28:29 <tmazur> Exactly
15:29:04 <tmazur> I'm not sure it's the high priority for the new cycle
15:29:06 <e0ne_> keeping in mind how old dependencies we've got, it could be very complicated :(
15:29:22 <e0ne_> agree, let's discuss it at PTG
15:29:44 <tmazur> For Karma it's two versions ahead, for Jasmine I don't remember correctly but also not optimistic
15:29:58 <e0ne_> :(
15:30:46 <tmazur> Anyway I ask you again to review my patches on fixing Jasmine tests, if you have some time for this.
15:31:07 <tmazur> Let's make Jasmine Spec Runner happy. (and my OCD too)
15:31:25 <e0ne_> tmazur: will do it later today
15:31:39 <tmazur> e0ne: thank you!
15:31:43 <e0ne_> np
15:32:05 <e0ne_> tmazur: do you have anything more to discuss?
15:32:15 <tmazur> Nothing else
15:32:30 <e0ne_> ok, let's wrap up the meeting
15:32:40 <e0ne_> thanks for your participation
15:32:54 <tmazur> Thank you too! Have a nice week!
15:33:11 <e0ne_> #endmeeting