15:00:25 <e0ne> #startmeeting horizon
15:00:26 <openstack> Meeting started Wed Jan 13 15:00:25 2021 UTC and is due to finish in 60 minutes.  The chair is e0ne. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:27 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:29 <openstack> The meeting name has been set to 'horizon'
15:00:38 <e0ne> hi everybody
15:01:01 <vishalmanchanda> hi all
15:01:14 <tmazur> hi everyone!
15:01:57 <amotoki> hi
15:02:54 <e0ne> I hope you enjoyed Christmas and and New Year holidays
15:04:05 <e0ne> let's start our the first  meeting in 2021
15:04:41 <e0ne> #topic Notices
15:05:32 <e0ne> I spent last two weeks almost without my laptop, so there are no news from me
15:05:51 <e0ne> just a reminder that next week we'll reach Wallaby-2 milestone
15:06:28 <e0ne> nothing special for horizon deliveries
15:07:11 <e0ne> but we discussed in the past that it would be good to have a short (1-2 hours) mid-cycle call around this date
15:08:17 <rdopiera> o/
15:08:22 <e0ne> we can have a call instead ourIRC meeting if we want to have it
15:09:50 <e0ne> I'll send a mail with this proposal later tonight
15:10:14 <amotoki> I have no strong preference on it.
15:11:39 <e0ne> amotoki: it's just a proposal, so let's do it a bit loud in the mailing list
15:11:53 <tmazur> do we have separated etherpad for mid-cycle?
15:11:59 <e0ne> maybe we'll catch some new contributors
15:12:13 <e0ne> tmazur: not yet
15:14:20 <e0ne> #topic Open Discussion
15:14:45 <e0ne> there are some items in our etherpad
15:14:48 <e0ne> #link https://etherpad.opendev.org/p/horizon-release-priorities
15:15:01 <rdopiera> if you don't mind, I'd like to discss the plans for updating jquery -- amotoki mentioned in the review he would like to know it too
15:15:03 <e0ne> lines #55-65
15:16:54 <e0ne> rdopiera: sure
15:17:38 <e0ne> rdopiera: it's your turn
15:18:43 <rdopiera> from the testing I did (which didn't include plugins, I will still need to see about that), it seems that we are ready to update it -- we don't have any outstanding breaking incompatibilities. There are some warnings in the version of Angular that we use, but they are not errors, just warnings
15:19:19 <rdopiera> basically if we update the xstatic-jquery and xstatic-jquery-migrate and update the requirement versions, it will work
15:20:48 <e0ne> does it pass integration tests?
15:20:54 <amotoki> for reference rdopiera is talking about https://review.opendev.org/c/openstack/xstatic-jquery-migrate/+/764769
15:22:39 <rdopiera> it generates a lot of warnings in the js console, but we can fix them gradually
15:23:46 <rdopiera> e0ne: I only managed to run the selenium headless tests on my machine, I can't get the integration tests running :(
15:23:55 <e0ne> :(
15:24:21 <e0ne> rdopiera: we should be able to do it on or gate
15:24:33 <rdopiera> so the way I see it, my next steps would be testing the intergration tests and the plugins
15:24:41 <e0ne> +1
15:25:10 <amotoki> my point in the above review is jquery-migrate 3.x assumes jquery 1.12.x or 2.2.x but our requirement says jquery>=1.8.2.1
15:25:13 <e0ne> at least, we have to test it with plugins which we've got on ourgates too
15:25:25 <rdopiera> e0ne: to test it on the gate we would first need to merge the upgrade for xstatic-jquery-migrate and release it
15:25:29 <amotoki> at least I think we need to bump the min ver of jquery to >=1.12.x
15:25:39 <amotoki> * first
15:25:42 <e0ne> amotoki: that's a good point. we should to resole it first
15:26:03 <rdopiera> there is already a package for xstatic-jquery
15:26:04 <amotoki> this does not affect the current runtime reqs as u-c already speifies 1.12.x
15:26:08 <e0ne> amotoki: we can face issues with pip if we don't upgrade jquery
15:26:32 <e0ne> also, we can't be sure that jquery-migrate works well in horizon with older jquery
15:27:14 <rdopiera> actually we can be sure it doesn't
15:27:28 <rdopiera> we need to upgrade both
15:27:31 <rdopiera> at the same time
15:27:43 <amotoki> why "at the same time"?
15:28:04 <rdopiera> because either one of them will not work with older versions of the other
15:28:20 <amotoki> rdopiera: which versions of jquery and jquery-migrate are you talking about?
15:30:01 <amotoki> what I suggest is to bump the min ver of xstatic-jquery to >=1.12.x and then upgrade jquery-migrate to 3.x. I think it works well.
15:30:05 <vishalmanchanda> e0ne: I think integration test pass with this change https://review.opendev.org/c/openstack/horizon/+/765301
15:30:46 <rdopiera> XStatic_jQuery-3.5.1.1 and the jquery-migrate from that patch linked above
15:31:07 <amotoki> rdopiera: I see
15:31:32 <amotoki> so you are trying to bump both to 3.x era directly
15:31:50 <rdopiera> yes, I think it's the only sane way
15:33:06 <amotoki> IIUC jquery-migrate 3.x helps us upgrade to jquery 3.x
15:33:29 <amotoki> so I think jquery 1.12.x and jquery-migrate 3.x are compatbile. am I missing something?
15:35:27 <amotoki> hmm.... I might be wrong https://github.com/jquery/jquery-migrate/blob/master/package.json#L25-L27
15:35:27 <rdopiera> amotoki: it is compatible with 1.12, but not older
15:35:57 <rdopiera> from docs: NOTE: To upgrade to jQuery 3.0, you first need version 1.12.x or 2.2.x. If you're using an older version, first upgrade to one of these versions using jQuery Migrate 1.x, to resolve any compatibility issues. For more information about the changes made in jQuery 3.0, see the upgrade guide and blog post.
15:37:13 <amotoki> rdopiera: yeah, so my idea is to bump requirements in horizon from XStatic-jQuery>=1.8.2.1,<2 to XStatic-jQuery>=1.12.4.1(,<2)
15:37:26 <amotoki> I am not sure we need to bump jquery to 3.x together.
15:38:37 <rdopiera> we will want to ship jquery 3 sooner or later
15:38:47 <rdopiera> preferably sooner
15:39:02 <e0ne> rdopiera: +1
15:39:03 <amotoki> I am fine with jquery 3.
15:39:09 <rdopiera> there is a bunch of CVEs fixed in it
15:39:22 <amotoki> I am just talking about whether we need to bump both together.
15:40:24 <amotoki> but it is mainly for developers so bumping both together would be okay perhaps
15:40:26 <rdopiera> so we need to bump to 1.12 before we bump jquery-migrate, then we have to bump jquery-migrate before we bump jquery further
15:40:42 <amotoki> rdopiera: I think so
15:40:56 <amotoki> the first change can be done in the horizon repo.
15:41:30 <rdopiera> fun fact: we've been using jquery 1.12 in osp13 for several years now
15:42:29 <amotoki> ubuntu has python3-xstatic-jquery_1.12.4.1-2_all.deb too
15:43:28 <amotoki> (ubuntu focal)
15:44:00 <amotoki> perhaps cloud archive uses this version
15:44:40 <e0ne> it seems to be safe to upgrade to 1.12.x
15:45:08 <amotoki> e0ne: this is not a upgrade actually. this is just a min version bump.
15:45:13 <e0ne> but I prefer to read it's changelog to verify that nothing is dropped
15:45:35 <e0ne> amotoki: it's true only if jquery always respect to semver
15:46:30 <amotoki> e0ne: we already uses xstatic-jquery 1.12.4.1 since 2018
15:46:46 <e0ne> amotoki: it's good
15:47:31 <amotoki> I believe bumping the min version in horizon reqs has no issue
15:48:18 <e0ne> +1
15:49:56 <amotoki> so our plan would be: (1) bump to jquery 1.12 (2) release jquery migrate and update the reqs (g-r, u-c and horizon reqs) (3) upgrade jquery to 3.x
15:49:58 <amotoki> right?
15:51:15 <e0ne> sound good to me
15:53:08 <amotoki> there is one question: when should we have a checkpoit for horizon plugins?
15:53:13 <amotoki> after (2) or after (3)
15:55:55 <e0ne> we can delay it to (3) if we don't spend a lot of time between (2) and (3)
15:55:56 <amotoki> anyway wallaby-2 milestone is approaching, so it is better to do it soon so taht plguins can fix issues if any
15:56:35 <e0ne> +1
15:57:51 <amotoki> btw, please check L.55-63 in the etherpad on lower-constraints maintenance and horizon in requirements blacklist.txt. we have no time to discuss it.
15:59:29 <e0ne> amotoki: will do it. thanks for raising this topic
15:59:47 <e0ne> we're out of time. we can continue discussion in #openstack-horizon channel
16:00:00 <e0ne> thanks everybody for your contributions
16:00:06 <e0ne> #endmeeting