15:02:00 #startmeeting horizon 15:02:01 Meeting started Wed Feb 10 15:02:00 2021 UTC and is due to finish in 60 minutes. The chair is e0ne. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:02:02 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:02:05 The meeting name has been set to 'horizon' 15:03:57 hi 15:04:27 vishalmanchanda: let's wait few minutes more to allow people join us 15:04:29 o/ 15:04:46 o/ 15:14:33 ok, let's start 15:14:56 #topic Notices 15:15:20 just a regular reminder about our releases 15:15:25 #link https://releases.openstack.org/wallaby/schedule.html 15:15:53 there is about one month until we reach feature freeze 15:16:27 also, it will be a requirements freeze too 15:17:25 so we have to fix our issues with xstatic until that date to not ask for requirements freeze exception 15:19:05 Agree, but on the other hand, I am not sure what is the value only with the new jquery-migrate w/o jquery 3. 15:20:16 it depends if it has any CVE fix or not 15:21:11 correct. perhaps rdopiera knows more 15:22:24 the value would be that we would get warning in the console and could start fixing them already 15:22:58 but perhaps we could do that locally on our dev environments instead of including it in the release 15:23:40 rdopiera: it's ok in the begining of the cycle, but adding warnings after feature freeze doesn't give us a lot of time to fix them 15:24:04 I wa sunable to reproduce that problem when running the integration tests locally, and also when testing manually, so I suspect this is some kind of interaction with the exact versions of thing we have on the CI server 15:24:42 #topic jquery-* libs update 15:26:16 rdopiera, amotoki: in a current situation, I would like to cap jquery-migrate version to unblock CI for horizon and plugins 15:26:38 I think we did it already? 15:26:58 e0ne: the patch to cap xstatic-jqiery-migrate has landed. 15:27:19 https://review.opendev.org/c/openstack/requirements/+/773823 15:27:28 so the gate is back now 15:27:32 my bad, I was looking on https://review.opendev.org/c/openstack/horizon/+/773996 15:27:33 and by "we" I mean amotoki ;-) 15:27:40 rdopiera: :) 15:29:01 but I think that anybody who wants to work on those warnings can install newer jquery-migrate manually with pip in their dev env 15:29:05 if we are not able to reproduce the issue locally, we can propose a DNM/WIP patch to requirements repo to check the fix. 15:29:14 +1 15:29:51 looking at what happened, the project switcher in the integration tests never returns and causes timeout. 15:29:51 e0ne: +1 to which one? 15:30:27 rdopiera: to reproduce it with DNM/WIP patch on CI 15:30:56 sounds good 15:31:21 rdopiera: your comment is true and it is what I usually do :) 15:31:57 so I suppose that solves this. we can revisit upgrading jquery once we have all those warnings fixed 15:32:18 +1 15:32:20 rdopiera: +1 15:32:30 we will probably work on this gradually with tmazur 15:32:42 as time allows 15:33:46 I'm just not entirely sure what to do when the code that generates the warnings is inside angular.js 15:34:46 I am not sure too, just some ideas 15:34:47 rdopiera: are talking about warnings with the new jquery-migrate? or is it related to the integration test failure? 15:35:16 s/are/are you/ 15:35:28 amotoki: unrelated to the failure (unless it's the warnings that contribute to the failure), I'm thinking about further work on upgrading jquery here 15:35:39 rdopiera: got it 15:35:46 sorry for drifting off-topic 15:35:52 no worries 15:37:21 do we have anything more to discuss? 15:37:49 e0ne: I have a question about integration tests in train, but I can ask that on the channel 15:38:04 e0ne: none on this topic 15:39:09 let's move on 15:39:39 I've got a quick topic 15:39:46 #topic stable release 15:40:05 we didn't cut stable release for a while 15:40:41 I'm going to go throw open reviews https://review.opendev.org/q/status:open+AND+project:openstack/horizon+AND+NOT+branch:master and check stable branches if we need to do new releases 15:41:35 IIRC we cut train release recently. 15:41:49 we have no new release for a while for ussuri and victoria 15:41:57 amotoki: yes. 15:42:22 amotoki: correct, I would like to check all "active" branches 15:43:34 last release of ussuri is 10 months ago and victoria one is 4 months ago 15:43:53 it sounds good to cut new releases for them. 15:44:00 please, take a look on stable/* patches and put your vote if you didn't do it yet 15:44:15 also, you can cherry-pick fixes if any 15:44:37 I'll propose a patch with releases (if there are any changes) tonight 15:45:00 that's all from my side 15:45:45 rdopiera: just question: you voted not +2 but +1 to https://review.opendev.org/c/openstack/horizon/+/770750 is there anything to be improved? 15:46:58 amotoki: no, tmazur and me are from the same company, so I don't +2 her patches 15:47:53 I'll review them asap 15:48:06 rdopiera: fair enough (while we trust you) 15:48:45 amotoki, rdopiera: I think, it's OK to +2 on such patches if you're second reviewer 15:49:11 it's a good old policy, do we really need to go against it? 15:50:20 it's a working policy, so let's follow it 15:50:34 we are now a small team. Unless two +2 come from a same company I believe we don't have a problem. 15:50:44 also, speaking about simple cherry-picks, could I please ask for some attention on my patches? 15:51:15 tmazur: will review them after the meeting 15:51:25 *right after the meeting 15:51:42 e0ne: thanks! They all have +2 already 15:51:47 https://review.opendev.org/q/owner:t.v.ovtchinnikova%2540gmail.com+status:open 15:55:08 we've got 5 minutes lest 15:55:16 #topic Open Discussion 15:56:23 I have small updates on wallaby priority items which I am an owner for: rename Chinse locales and merge tempest-horizon 15:56:30 both are in good progress 15:56:48 regarding merge tempest-horizon, it is in the final process to retire tempest-horizon 15:56:57 https://review.opendev.org/q/topic:%22merge-horizon-test%22+(status:open%20OR%20status:merged) 15:57:49 regarding Chinse locale rename, most work has done and I am waiting for second +2 in openstack-zuul-jobs 15:57:50 https://review.opendev.org/q/topic:%22rename-chinese-locales%22+(status:open%20OR%20status:merged) 15:58:03 those are updates from me. 15:58:17 amotoki: thanks a lot on working on it! 15:59:14 Guys Can I also have a review on my backup-panel patch https://review.opendev.org/c/openstack/horizon/+/772603 15:59:43 ah, one more. a patch on secure RBAC https://review.opendev.org/c/openstack/horizon/+/750134 16:00:25 we're out of time 16:00:26 I have too many priority items. I should spread and/or transfer my load to you in the next cycle :) 16:00:37 hopefully I have no priority imte in Xena :) 16:00:39 let's review patches and discuss them in #openstack-horizon 16:00:49 thanks everybody for your contributiions 16:00:54 #endmeeting