15:00:18 <vishalmanchanda> #startmeeting horizon
15:00:19 <opendevmeet> Meeting started Wed Jun  9 15:00:18 2021 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:20 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:22 <opendevmeet> The meeting name has been set to 'horizon'
15:01:27 <e0ne> hi
15:01:46 <tmazur> o/
15:02:00 <rdopiera> o/
15:02:02 <vishalmanchanda> hello everyone.
15:02:38 <vishalmanchanda> this meeting will be short as I am not having much update.
15:02:44 <vishalmanchanda> ok let's start.
15:02:53 <vishalmanchanda> #topic Notices
15:03:21 <vishalmanchanda> I have no notices for this week.
15:03:53 <vishalmanchanda> if anyone else have any announcement please go ahead.
15:04:30 <rdopiera> I finally got the django-sass-processor to work
15:04:48 <e0ne> rdopiera: awesome!
15:04:49 <rdopiera> I have a proof of concept patch here: https://review.opendev.org/c/openstack/horizon/+/794809
15:04:52 <vishalmanchanda> rdopiera: nice🙂)
15:04:55 <amotoki> hi
15:05:05 <rdopiera> there three main problems:
15:05:32 <vishalmanchanda> rdopiera: ok let's discuss it after I change the topic
15:05:34 <rdopiera> 1. it doesn't seem to underastand absolute paths the same was as scss -- it looks for the files in that absolute location
15:05:40 <vishalmanchanda> #topic django sass processor
15:05:42 <rdopiera> ok, soryr
15:05:52 <rdopiera> there three main problems:
15:05:53 <vishalmanchanda> rdopiera: floor is yours, please go ahead.
15:05:55 <rdopiera> there three main problems:
15:05:57 <rdopiera> sorry
15:06:02 <rdopiera> 1. it doesn't seem to underastand absolute paths the same was as scss -- it looks for the files in that absolute location
15:06:14 <rdopiera> (we can probably fix it by subclassing it)
15:07:10 <rdopiera> 2. the way it uses a django template tag for inclusion, it doesn't allow templating inside the scss code, so we need to find a different way of including the style overrides from user settings (or remove that setting)
15:07:44 <rdopiera> 3. it has some problems with the material theme that I don't fully understand -- something about calling a function with a function as a parameter
15:09:54 <rdopiera> that's all I have
15:10:59 <vishalmanchanda> rdopiera: ok I will take a look and try your patch in my env.
15:12:30 <amotoki> regarding the second point, I am not sure it is really needed. it might be covered by a theme.
15:13:04 <rdopiera> amotoki: or an additional file outside the theme
15:13:32 <rdopiera> that we can @import
15:14:05 <amotoki> I see. it should work.
15:14:58 <rdopiera> the 3. is probably just something that libsass doesn't support
15:17:35 <rdopiera> do we have anything else to discuss?
15:17:45 <amotoki> rdopiera: regarding 3, what kind of functions?
15:17:59 <rdopiera> let me quickly re-run it
15:18:52 <rdopiera> Error: Functions may not be defined within control directives or other mixins. on line 5:13 of openstack_dashboard/themes/material/static/horizon/_styles.scss
15:18:55 <rdopiera> >>   @function selector-append($selector, $to-append) {
15:19:50 <rdopiera> (by the way, the error reporting seems much nicer too)
15:20:04 <amotoki> ah, we have some workdaround on this already.
15:21:32 <amotoki> that workaround was added to support the material theme with the current pyscss
15:22:05 <amotoki> we may be able to adjust it to django-scss-processor.
15:22:22 <e0ne> amotoki: +1
15:22:37 <rdopiera> the commands needed to generate the static files will change too
15:22:55 <rdopiera> we will need to add one more manage command
15:23:12 <rdopiera> but if we can solve 1. and 3., I think we can use this
15:23:43 <vishalmanchanda> rdopiera: great...
15:24:20 <vishalmanchanda> ok moving to next topic.
15:24:48 <vishalmanchanda> #Nodejs14 migration
15:24:58 <vishalmanchanda> #topic Nodejs14 migration
15:25:08 <vishalmanchanda> small update on this topic.
15:25:42 <vishalmanchanda> All horizon plugins run horizon nodejs14 job template
15:25:51 <vishalmanchanda> https://review.opendev.org/q/topic:%22migrate-to-nodejs14%22+(status:open%20OR%20status:merged)
15:26:24 <vishalmanchanda> I forgot to push patches for some plugins to drop nodejs10 job which I try to push by today.
15:26:48 <vishalmanchanda> https://review.opendev.org/q/topic:%22drop-nodejs10%22+(status:open%20OR%20status:merged)
15:27:16 <vishalmanchanda> I was thinking if we can drop horizon-nodejs10 job template from horizon.
15:28:36 <vishalmanchanda> then horizon plugins must have to drop horizon-nodejs10 template to make their CI/CD green.
15:29:10 <vishalmanchanda> What you say or we should wait for more time?
15:30:35 <amotoki> vishalmanchanda: why didn't you replace node10 jobs with node14 jobs in plugins rather than adding node14 jobs?
15:31:12 <amotoki> if so, dropping nodejs10 job template would be simpler.
15:31:58 <vishalmanchanda> amotoki: yeah I didn't done that initially to avoid any failure.
15:32:42 <amotoki> the goal is to migrate jobs to nodejs14, so we don't need to keep both in plugins
15:33:07 <amotoki> I am not sure how it is realted to avoiding failures...
15:33:07 <vishalmanchanda> amotoki: yes.
15:34:07 <amotoki> I am against dropping nodejs10 template from horizon first. I think we should avoid breakage we can easily expect.
15:34:08 <vishalmanchanda> yeah my bad I missed that:(
15:34:21 <amotoki> vishalmanchanda: np
15:35:33 <vishalmanchanda> amotoki: ok I will wait till horizon-nodejs10 template removed from all plugins.
15:36:05 <vishalmanchanda> that's all update from my side.
15:36:16 <vishalmanchanda> #topic open-discussion
15:37:05 <vishalmanchanda> This week I am working on testing horizon with XStatic-Angular 1.8.2.1 version.
15:37:13 <vishalmanchanda> npm-test are failing as of now.
15:37:26 <vishalmanchanda> https://review.opendev.org/c/openstack/horizon/+/794774
15:37:46 <vishalmanchanda> will reach to you guys if I need any help.
15:38:23 <amotoki> any update on django 3.x?
15:40:19 <vishalmanchanda> amotoki: I was thinking to start reviewing your django3 patches.
15:40:27 <vishalmanchanda> #link https://review.opendev.org/q/topic:%22django3-support%22+(status:open%20OR%20status:merged)
15:41:02 <amotoki> vishalmanchanda: how about django-pyscss? does it depend on rdopiera's effort?
15:42:28 <vishalmanchanda> amotoki: need to check, I was thinking how should I start.
15:43:00 <vishalmanchanda> amotoki: Should we merge that patch which add a django3 job(non-voting) first
15:43:56 <amotoki> vishalmanchanda: non-voting job patch is okay (unless the numberr of jobs is not a problem)
15:45:45 <amotoki> it is nice to have such jobs if we plan to move djnago30 support forward soon. otherwise, the django3 non-voting always fails and would be meaningless.
15:45:50 <amotoki> that's my point.
15:46:21 <vishalmanchanda> amotoki: sure, I will start with this one https://review.opendev.org/c/openstack/horizon/+/777390
15:46:34 <vishalmanchanda> amotoki: will reach to you if have any doubts.
15:47:12 <amotoki> thanks
15:47:31 <vishalmanchanda> Does anyone have any other topics to discuss?
15:47:44 <vishalmanchanda> or we can end this meeting.
15:48:03 <rdopiera> nothing
15:48:19 <amotoki> none from me
15:48:58 <tmazur> nothing
15:49:11 <vishalmanchanda> Thanks everyone for your contributions!
15:49:26 <vishalmanchanda> will see you next week.
15:49:45 <vishalmanchanda> #endmeeting