15:00:48 <vishalmanchanda> #startmeeting horizon
15:00:48 <opendevmeet> Meeting started Wed Jun 23 15:00:48 2021 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:48 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:48 <opendevmeet> The meeting name has been set to 'horizon'
15:02:29 <rdopiera> o/
15:02:36 <e0ne> hi
15:02:46 <vishalmanchanda> Hi everyone
15:03:01 <tmazur> o/
15:03:47 <vishalmanchanda> #topic Notices
15:04:47 <vishalmanchanda> Just an reminder next milestone i.e. Xena-2 is in week of Jul 12 - Jul 16.
15:05:30 <vishalmanchanda> Xena Schedule https://releases.openstack.org/xena/schedule.html
15:05:55 <vishalmanchanda> #topic stable branches
15:06:28 <vishalmanchanda> Does anybody have environment with stable/stein or stable/train branch?
15:07:05 <rdopiera> I do
15:07:09 <vishalmanchanda> I am asking because we have two backport purposed to those branches but it is abandoned by owner due to no reviews on those patches.
15:07:31 <amotoki> I prepare them when they are needed per review.
15:07:36 <vishalmanchanda> patch link https://review.opendev.org/c/openstack/horizon/+/781805 https://review.opendev.org/c/openstack/horizon/+/781804
15:07:57 <vishalmanchanda> rdopiera: amotoki : Could you please tests those patches.
15:07:59 <amotoki> I noticed these backports but I intentionlly wait for other reviews.
15:08:39 <amotoki> I usually review backports first but I would like to know what happens when I do not.
15:08:47 <vishalmanchanda> Now a days I am having bad-luck in setting devstack env. It always with new errors.
15:09:19 <vishalmanchanda> Also my OS is focal(20.04) and I can't those patches with current env.
15:10:05 <amotoki> I usually use VMs for testing, so I prepare required ubuntu versions depending on branches.
15:10:38 <amotoki> but I think horizon stable/stein or train works on focal too.
15:11:02 <rdopiera> I use a vm for the openstack, but run horizon itself with tox straight from the repository
15:11:25 <rdopiera> in this case it shouldn't matter what version of openstack horizon is connecting to
15:11:44 <vishalmanchanda> amotoki: really but when I try to test those patches horizon fails to run with python errors I think.
15:12:13 <vishalmanchanda> amotoki: with devstack on focal OS.
15:12:41 <amotoki> vishalmanchanda: it's not surprising as devstack target is only the latest ubuntu lts.
15:13:46 <amotoki> okay anyway let's check backports related to the material theme.
15:14:36 <vishalmanchanda> amotoki: rdopiera thanks, please restore and review those patches.
15:14:41 <amotoki> regarding queens, are we going to EOL queens?
15:14:58 <rdopiera> I'm fine with that
15:15:36 <amotoki> rdopiera: what is the current min release you would like to keep from RH perspective?
15:15:54 <rdopiera> amotoki: train
15:16:05 <amotoki> rdopiera: thanks. sounds good :)
15:16:13 <rdopiera> and then wallaby
15:17:10 <vishalmanchanda> I am also okay to move queen to EOL if nobody have any issue with that.
15:17:45 <amotoki> I am okay with it too
15:18:47 <vishalmanchanda> In that case I'll push a patch to release and sent a announcement mail about that on open-discuss.
15:20:09 <vishalmanchanda> Next one is https://review.opendev.org/c/openstack/horizon/+/725785
15:20:54 <vishalmanchanda> Could stable cores abandon this patch as there is no activity on this patch from long.
15:21:22 <vishalmanchanda> I am asking because I have purposed a patch to move stable/pike to EOL and for that this patch either need to merged or abandon.
15:22:29 <vishalmanchanda> Move pike to EOL patch link https://review.opendev.org/c/openstack/releases/+/791707
15:23:28 <amotoki> the author responded very slow and the patch stays for long. It was proposed just one year ago. so I think we can abandon this.
15:23:35 <tmazur> I've tried to fix the tests for that patch and apparently it's not that simple, a lot of code has been changed.
15:23:54 <tmazur> So +1 for abandoning
15:24:44 <opendevreview> Radomir Dopieralski proposed openstack/horizon stable/pike: Allow OVA upload for images  https://review.opendev.org/c/openstack/horizon/+/725785
15:25:00 <rdopiera> just fixed the indentation, but that's probably not enough
15:25:51 <rdopiera> +1 for abandon as well
15:26:39 <amotoki> IIRCthe related code was changed between pike and queens so UT is failing.
15:27:09 <rdopiera> right, it was just my OCD with the indentation
15:27:12 <vishalmanchanda> ok Stable cores please abandon above patch as discussed.
15:27:30 <amotoki> okay, I will take care of it with a comment
15:27:39 <vishalmanchanda> amotoki: thanks.
15:28:09 <rdopiera> oops, done already
15:28:26 <amotoki> rdopiera: np
15:29:08 <vishalmanchanda> I have no more specific topic to discuss for this week.
15:29:11 <vishalmanchanda> #topic open-discussion
15:29:47 <vishalmanchanda> amotoki: I left a comment on your patch https://review.opendev.org/c/openstack/horizon/+/777390.
15:30:18 <vishalmanchanda> Could you respond on that once you have time.
15:30:39 <rdopiera> I have two topics
15:30:50 <vishalmanchanda> rdopiera: please go ahead.
15:31:23 <amotoki> rdopiera: horizon-non-primary-django-jobs is to check non-default django version. it is not specific to pre-django 3.x.
15:31:41 <amotoki> rdopiera: sorry.
15:31:55 <amotoki> I meant vishalmanchanda :p
15:32:03 <rdopiera> We finally made progress with running the upstream integration tests on our downstream repo, but we face some problems because of our custom theme has different html structure and some of the CSS selectors need to be changed.
15:32:33 <rdopiera> We can do it with a downstream patch, but we think that a cleaner solution would be to make those selectors configurable in the local-horiozn.conf file.
15:32:46 <rdopiera> I proposed a blueprint for this: https://blueprints.launchpad.net/horizon/+spec/configurable-selectors-in-integration-tests
15:34:15 <e0ne> rdopiera: +1 on this. we'd got such issue in the past
15:34:17 <vishalmanchanda> rdopiera: cool..
15:34:24 <rdopiera> This would allow us to share the tests directly, and to make our QE write upstream tests
15:34:24 <amotoki> it would be nice if the problem description covers some examples.
15:34:46 <rdopiera> amotoki: I will add that
15:35:36 <ikanias> +1
15:35:40 <amotoki> anyway sharing integration tests is nice
15:36:07 <rdopiera> ikanias is our QE, by the way
15:36:15 <ikanias> :-)
15:37:36 <rdopiera> Second think is a question to amotoki. I know you wanted to write the base for the system-scope token yourself, but would you mind if I started with some simple proof of concept for that? I wanted to give it a try, but I'm not confident I can make it good enough.
15:37:43 <rdopiera> s/think/thing
15:38:14 <amotoki> I had some progress but my base machine was crusshed and lost the code....
15:38:19 <amotoki> am recovering my memory
15:38:35 <rdopiera> sorry for your loss
15:39:37 <amotoki> rdopiera: your POC is fine too.
15:39:49 <rdopiera> thanks, I will look into that then
15:40:30 <vishalmanchanda> great work team:)
15:41:22 <vishalmanchanda> talking about integration-test one of my college trying to add a integration job for tacker-horizon.
15:41:48 <vishalmanchanda> but it as of now it is failing due to some errors.
15:41:59 <vishalmanchanda> patch link https://review.opendev.org/c/openstack/tacker-horizon/+/790958
15:43:26 <vishalmanchanda> It would be great if anyone know the issue and help her to fix it.
15:43:44 <rdopiera> RuntimeError: Could not find firefox in your system PATH. Please specify the firefox binary location or install firefox
15:43:47 <rdopiera> hmmm
15:44:22 <amotoki> how is bindep.txt configured?
15:44:25 <e0ne> vishalmanchanda: I just setup env to test it. will to it tonight
15:44:36 <vishalmanchanda> e0ne: thanks Ivan.
15:46:38 <amotoki> vishalmanchanda: do you mean a failure in pre-run phase?
15:47:42 <vishalmanchanda> amotoki: yeah that one also.
15:48:07 <vishalmanchanda> amotoki: Also got ``RuntimeError: Could not find firefox in your system PATH. Please specify the firefox binary location or install firefox`` error.
15:49:28 <amotoki> vishalmanchanda: in which log?
15:49:49 <amotoki> vishalmanchanda: in the log of the last run, it failed with retry limit in pre-run phase.
15:51:17 <amotoki> woops. what I looked was not the last run..
15:52:53 <vishalmanchanda> current error log for integration-job https://zuul.opendev.org/t/openstack/build/b682dd24be274f0db624a389ff6cb681/log/job-output.txt#30449
15:53:56 <vishalmanchanda> amotoki: before that it is failing with OVN issues then I disable OVN.
15:57:20 <vishalmanchanda> ok does anyone have more topic to discuss?
15:58:30 <amotoki> none from me
15:59:00 <vishalmanchanda> Let's end this meeting.
15:59:26 <vishalmanchanda> Thanks everyone for joining, see you next week.
15:59:28 <vishalmanchanda> TC!
15:59:56 <vishalmanchanda> Just an reminder we have many open patches with no review from long.
16:00:05 <vishalmanchanda> Please take a look..
16:00:21 <vishalmanchanda> #endmeeting