15:00:31 <vishalmanchanda> #startmeeting horizon
15:00:31 <opendevmeet> Meeting started Wed Jul 14 15:00:31 2021 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:31 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:31 <opendevmeet> The meeting name has been set to 'horizon'
15:01:44 <vishalmanchanda> hi anyone around for horizon meeting?
15:02:30 <nitish> hi
15:03:27 <amotoki> hi
15:03:27 <vishalmanchanda> e0ne: rdopiera tmazur amotoki : around?
15:03:42 <tmazur> Hi!
15:03:44 <tmazur> Yes
15:04:22 <vishalmanchanda> Let's wait for 2 more minutes if more people joins us.
15:05:44 <vishalmanchanda> ok Let's start.
15:05:52 <vishalmanchanda> #topic Notices
15:06:14 <vishalmanchanda> This week is Xena-2 milestone.
15:06:33 <vishalmanchanda> Xena Schedule https://releases.openstack.org/xena/schedule.html
15:06:53 <vishalmanchanda> but nothing special for horizon.
15:07:23 <vishalmanchanda> next announcement is about Yoga Virtual PTG.
15:08:01 <vishalmanchanda> I have created a etherpad to collect topics for yoga ptg discussion.
15:08:19 <vishalmanchanda> #link https://etherpad.opendev.org/p/horizon-yoga-ptg
15:08:45 <vishalmanchanda> Please start adding your topics which you want to discuss during the ptg.
15:09:32 <vishalmanchanda> For the time slots I have created a poll please vote asap because we have to book the room before July 21.
15:09:45 <vishalmanchanda> #link https://doodle.com/poll/7vxwprypskrhidhq?utm_source=poll&utm_medium=link
15:10:45 <vishalmanchanda> I have added most of time slot which we used during past Virtual PTG.
15:11:24 <vishalmanchanda> I am not sure about how much we needed for ptg discussion atm but I think 4-5 hours are more than enough for us.
15:12:23 <vishalmanchanda> I have also kept some extra time slots in pole and we can unbook the room it if not required at that time.
15:12:59 <vishalmanchanda> e0ne: amotoki rdopiera :^^ please vote on doodle once you see.
15:13:18 <vishalmanchanda> anyway I will send a mail about it on open-discuss.
15:13:58 <vishalmanchanda> next announcement is about moving stable/queen to EOL
15:14:00 <amotoki> I cannot decide preferred timeslots as I don't have a priority on horizon sessions perhaps. it would be only up to my timezone and cannot vote more.
15:14:46 <vishalmanchanda> amotoki: fine.
15:14:54 <amotoki> my schedule would be decided considering session conflicts with others.
15:15:37 <rosmaita> (please forgive this interruption, but please ping me when you get to open discussion ... thanks!)
15:15:37 <vishalmanchanda> amotoki: yeah
15:15:46 <vishalmanchanda> rosmaita: sure.
15:15:53 <vishalmanchanda> https://review.opendev.org/c/openstack/releases/+/799543
15:17:02 <vishalmanchanda> There is only one issue in moving horizon stable/queen to EOL i.e. manial-ui stable/queens uses horizon stable/queens django template.
15:18:10 <amotoki> vishalmanchanda: what about points raised by elodilles?
15:18:11 <vishalmanchanda> but I think manila team also thinking about moving manial-ui stable/queens to EOL(current status EM) which they will discuss in tomorrow's weekly meeting.
15:18:46 <vishalmanchanda> amotoki: I will follow up with manila team about this.
15:19:23 <vishalmanchanda> that's all announcement from my side for today.
15:19:54 <vishalmanchanda> If anyone has other announcements to make please go ahead.
15:20:17 <nitish> I was working on QoS CRUD operations from Horizon
15:20:34 <nitish> made a base commit
15:20:36 <nitish> https://review.opendev.org/c/openstack/horizon/+/799461
15:20:48 <vishalmanchanda> nitish: we can discuss it in the end during open-discussion
15:20:58 <nitish> ok
15:20:59 <vishalmanchanda> nitish: please wait, thanks.
15:21:15 <vishalmanchanda> ok moving to next topic
15:21:47 <vishalmanchanda> #topic retire django_openstack_auth
15:22:12 <vishalmanchanda> ``django_openstack_auth`` code was merged into the main horizon repository during the queens release.
15:22:39 <vishalmanchanda> It is already deprecated and I have pushed a series of patches to retire it.
15:23:08 <vishalmanchanda> Please take a look once you have time and Let me know if I missed any steps for the retirement process.
15:23:19 <vishalmanchanda> #link https://review.opendev.org/q/topic:%22retire-django-openstack-auth%22+(status:open%20OR%20status:merged)
15:24:14 <amotoki> regarding tagging pike-eol, https://review.opendev.org/c/openstack/releases/+/800493 has landed and pike-eol tag was created but stable/pike branch was not deleted yet.
15:24:26 <amotoki> the post job failed https://zuul.opendev.org/t/openstack/build/aac7e7108b26477e9f30542b64ea8694
15:25:02 <amotoki> I am not sure this failuree is related to that stalbe/pike branch still exists.
15:26:02 <vishalmanchanda> but If I am correct then release going to delete stable/pike branch after https://review.opendev.org/c/openstack/releases/+/800493  merged.
15:26:30 <vishalmanchanda> I am not sure but it is what I observed so far.
15:27:13 <amotoki> that is what we expect but the script failed due to the absense of .gitreview in the master branch due to the master branch retirement.
15:27:54 <vishalmanchanda> amotoki: hmm I see.
15:28:34 <vishalmanchanda> I will discuss with the release team how to proceed further.
15:30:09 <vishalmanchanda> moving to next topic
15:30:24 <vishalmanchanda> #topic open-discussion
15:30:37 <vishalmanchanda> nitish: please go ahead.
15:31:14 <nitish> I was working on QoS CRUD operations from Horizon
15:31:37 <nitish> and made a commit for enablin qos panel and creating qos policy
15:32:18 <nitish> commit link : https://review.opendev.org/c/openstack/horizon/+/799461
15:33:19 <nitish> I want to know what are the expectations on this feature
15:33:28 <vishalmanchanda> nitish: thanks for working on that.
15:33:59 <vishalmanchanda> nitish: I will try to review it by end of this week and let you know.
15:34:10 <nitish> ok
15:34:19 <amotoki> nitish: what do you mean by "the expectations"?
15:34:40 <amotoki> nitish: you are working on the feature so I wonder you are more familiar with the feature.
15:35:12 <amotoki> (while I know the feature as I am working on neutron too)
15:36:25 <nitish> I was working on this feature by going through the openstack neutron qos docs
15:37:13 <amotoki> not now?
15:39:55 <vishalmanchanda> rosmaita: hi, ping.
15:40:02 <rosmaita> hello
15:40:10 <rosmaita> i have a quick question
15:40:27 <rosmaita> we are removing v2 support from the cinderclient
15:40:35 <rosmaita> #link https://review.opendev.org/c/openstack/python-cinderclient/+/792959
15:40:58 <rosmaita> and sorry, that patch had passed earlier, but now is failing tempest
15:41:10 <rosmaita> turns out that horizon is still using v2 a bit
15:41:18 <rosmaita> in this place:
15:41:27 <rosmaita> https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/api/cinder.py
15:41:33 <rosmaita> at lines 31
15:41:39 <rosmaita> and then 59-68
15:41:45 <rosmaita> i'm working on a patch
15:41:58 <rosmaita> but my question is,
15:42:18 <rosmaita> for xena horizon, you will be packaged with xena cinderclient, right?
15:42:46 <rosmaita> so horizon won't need to check anymore to see which client is available
15:42:55 <rosmaita> at lines 59-68
15:43:13 <rosmaita> or, i could put line 31 in a similar kind of try/catch block
15:43:28 <rosmaita> if you can't import v2, get list-extensions from v3
15:43:39 <rosmaita> was just wondering what you would suggest
15:44:07 <amotoki> generally speaking, horizon support should be along with corresponding back-end services from a same release,
15:44:35 <amotoki> so yes we need to clean up cinder v2 support.
15:44:54 <rosmaita> ok, so if i put up a patch that only uses v3, that would be OK with you?
15:45:21 <amotoki> i am fine.
15:45:22 <vishalmanchanda> rosmaita: +1.
15:45:31 <rosmaita> the only other place i see cinderclient v2 is in some tests, and those should convert to v3 fine
15:45:38 <rosmaita> https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/test/test_data/cinder_data.py
15:46:05 <rosmaita> i will get a patch up within the next hour
15:46:06 <amotoki> we also need to clean up attributes only available in cinder v2 API.
15:46:24 <amotoki> for example, consistencygroup_id at https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/api/cinder.py#L90
15:46:26 <rosmaita> amotoki: hopefully there won't be any
15:46:47 <rosmaita> i will check though
15:46:58 <amotoki> it can be cleanup separately though.
15:47:03 <rosmaita> version 3.0 is supposed to be exactly the same as v2
15:47:08 <rosmaita> but we will see if that is true!
15:47:43 <rosmaita> thanks, i will ping you here when the patch is ready
15:47:44 <amotoki> ah, consistency group feature is available in v3 while it is deprecated(?) in favor of the group feature.
15:48:13 <rosmaita> amotoki: yes, we never got rid of it
15:48:17 <rosmaita> at least not in the API
15:48:29 <rosmaita> hopefully , the client classes are consistent with that
15:48:38 <rosmaita> (it happened before i started working on cinder)
15:49:04 <amotoki> anyway the first step is to remove the dependency on cinderclient v2 code. I will help the effort.
15:49:31 <rosmaita> amotoki: ty, i will get a patch up, so if you can review quickly that will be awesome
15:49:37 <rosmaita> appreciate your help!
15:49:44 <vishalmanchanda> rosmaita: thanks for bringing this topic, I saw your mail about v2 removal but I thought we didn't use the v2 version.
15:49:50 <rosmaita> and sorry i didn't figure out until today that this was a problem!
15:50:17 <amotoki> rosmaita: no problem
15:50:18 <vishalmanchanda> rosmaita: just for curiosity could please paste here failed tempest patch link.
15:50:25 <rosmaita> sure
15:50:54 <rosmaita> https://zuul.opendev.org/t/openstack/build/e048e80cd52c4cb69a84e3a728ddf19d
15:51:35 <rosmaita> it's in tempest.scenario.test_dashboard_basic_ops.TestDashboardBasicOps.test_basic_scenario
15:51:35 <vishalmanchanda> rosmaita: thanks.
15:51:46 <rosmaita> right when tempest tries to log in to the dashboard
15:52:02 <rosmaita> good thing it's there!
15:52:34 <vishalmanchanda> rosmaita: nice we added it there during the last release.
15:52:43 <amotoki> it is a good side-effect which I did not expect when we merged tempest-horizon into horizon :)
15:52:59 <vishalmanchanda> haha🙂)
15:53:55 <amotoki> otherwise perhaps the horizon UT in the requirements repo after cinderclient release will detect this failure.
15:54:12 <amotoki> early detection would be much nicer :)
15:54:45 <vishalmanchanda> ok anyone has any other topic to discuss otherwise we can end this meeting.
15:56:51 <vishalmanchanda> thanks everyone for joining, see you next week!
15:56:56 <vishalmanchanda> tc.
15:57:10 <vishalmanchanda> #endmeeting