15:00:22 <vishalmanchanda> #startmeeting horizon
15:00:22 <opendevmeet> Meeting started Wed Nov 17 15:00:22 2021 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:22 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:22 <opendevmeet> The meeting name has been set to 'horizon'
15:00:44 <rdopiera> o/
15:01:00 <vishalmanchanda> hi all
15:01:29 <vishalmanchanda> #link https://etherpad.opendev.org/p/horizon-release-priorities (at line 30)
15:02:48 <vishalmanchanda> let's wait for few minutes if more people joins us.
15:02:52 <tmazur> o/
15:03:54 <vishalmanchanda> ok let's start the meeting.
15:04:03 <vishalmanchanda> #topic Notices
15:04:15 <vishalmanchanda> This week is Yoga-1 milestone.
15:04:24 <vishalmanchanda> Yoga Schedule https://releases.openstack.org/yoga/schedule.html
15:04:42 <vishalmanchanda> that's the only announcement from my side for this week, If anyone else have any announcement to make please go ahead.
15:05:31 <vishalmanchanda> moving to next topic
15:05:48 <vishalmanchanda> #topic Django3 Support
15:06:51 <vishalmanchanda> Patch to bump Django lower version to 3.2 is already merged in openstack/requirements.
15:06:59 <vishalmanchanda> #link https://review.opendev.org/c/openstack/requirements/+/815096
15:07:33 <vishalmanchanda> So Now we can drop the Django2.2 support from horizon and a patch for the same is already up and gate jobs are passing.
15:07:50 <vishalmanchanda> https://review.opendev.org/c/openstack/horizon/+/817814
15:08:10 <vishalmanchanda> Please take a look at patch, so we can drop Django2.2 support asap.
15:08:23 <vishalmanchanda> moving to next topic
15:08:34 <vishalmanchanda> #topic drop django launch instance implementation
15:08:56 <vishalmanchanda> Just an reminder CI is passing for the patch now so please so we can drop it early in this cycle.
15:09:03 <vishalmanchanda> https://review.opendev.org/c/openstack/horizon/+/816303
15:09:07 <vishalmanchanda> e0ne: ^^
15:09:25 <vishalmanchanda> next topic
15:09:34 <vishalmanchanda> #topic System Scope support in horizon
15:09:54 <vishalmanchanda> rdopiera: Please let me know once your patch is ready to review.
15:10:08 <vishalmanchanda> #link  https://review.opendev.org/c/openstack/horizon/+/816368
15:10:43 <rdopiera> vishalmanchanda: it should be ready as soon as the tests pass, but I keep finding things I forgot about
15:11:22 <rdopiera> I would like to ask about opinions on how to proceed from this patch
15:11:37 <vishalmanchanda> rdopiera: good, Do I have to apply python-keystoneclinet patch as well in my env to test it?
15:12:03 <rdopiera> It only adds the "system scope" menu entry to the context switcher, but we still need to display the correct panels when that is selected
15:12:37 <rdopiera> vishalmanchanda: I made it so that if the keystone client doesn't have that method, it falls back to just trying to get the token and catching the error if it fails
15:12:53 <rdopiera> vishalmanchanda: so it should work with any version of keystone client
15:13:19 <rdopiera> however, I noticed that our tests run with keystone api v2 configured, and we need v3 for this to work
15:14:14 <amotoki> rdopiera: which part of our tests uses keystone v2?
15:14:35 <vishalmanchanda_> sorry I got disconnected.
15:17:01 <rdopiera> amotoki: I got test failures with: AttributeError: 'AccessInfoV2' object has no attribute 'system_scoped'
15:17:52 <rdopiera> for example here: https://zuul.opendev.org/t/openstack/build/6f981fa3fcbe4e2789e5c34eb79bb8d7
15:18:03 <rdopiera> I made it fall back to False in such cases
15:21:43 <amotoki> thanks for the pointer. it seems v2 is still the default somewhere...
15:22:39 <amotoki> I see auth_ref contains keystone v2 information...
15:22:47 <rdopiera> for now I worked around this
15:23:58 <rdopiera> I also found another problem with tokens: it seems like we always provide the domain paramater when creating the token, and oslo.policy seems to think that the resulting token is a domain-scoped token, and issues a warning when we try to use it for project-scope actions
15:24:33 <rdopiera> I'm not sure if the check in oslo.policy is wrong, or if we really are getting domain-scoped token
15:24:55 <rdopiera> however, the warning says that it will become an error in the next version
15:27:16 <vishalmanchanda_> rdopiera: Also, some of the panel are completely broken like flavor panel.
15:27:50 <rdopiera> vishalmanchanda_: you mean when the system scope is selected?
15:28:01 <vishalmanchanda_> rdopiera: yes.
15:28:25 <rdopiera> vishalmanchanda_: the next step is to only display the panels that work with system scope when it is selected
15:28:56 <rdopiera> I'm unsure as to how to implement this exactly
15:29:21 <rdopiera> I will probably just add a flag in the panel definitions
15:29:36 <amotoki> rdopiera: re: domain_id waring, I think we need to adjust _user_to_credentials() in openstack_auth.policy. domain information is unnecesary for a project scope credential, but I need to confirm oslo.policy side too.
15:30:04 <vishalmanchanda_> amotoki: how can we decide to display which panel or not, any documentation for that?
15:30:16 <rdopiera> amotoki: I tested that the warning goes away when we remove the domain info from that function
15:30:45 <rdopiera> vishalmanchanda_: right now we check for the admin role, but that is going to be obsolete with system scope
15:31:05 <rdopiera> I think it is, at least
15:31:12 <rdopiera> I'm a bit fuzzy on the details
15:32:07 <amotoki> vishalmanchanda_: yeah, panel visibility is determined based on "permissions" and "policy_rules" fields in panels.
15:32:24 <amotoki> in addition, "admin" check might be affected since the initial impl.
15:32:33 <amotoki> s/be affected/affect/
15:33:30 <vishalmanchanda_> rdopiera: amotoki ok.
15:33:43 <amotoki> I don't think we have a doc on this :p
15:34:26 <vishalmanchanda_> amotoki: yeah we have to check policy rules for each backend services.
15:34:37 <rdopiera> another thing that worries me, is that when we switch to the system scope token, all apis stop working, including the ones that should work with system scope
15:34:48 <rdopiera> not sure if we need to configure something on the other side
15:35:23 <rdopiera> for instance, admin->system should probably work
15:35:29 <rdopiera> but it doesn't
15:36:11 <amotoki> at the moment, in TC discussion we don't plan to enforce system-scope in Yoga. There are still a lot of work required.
15:37:05 <amotoki> you can find some notes in https://etherpad.opendev.org/p/policy-popup-yoga-ptg (around L.548 - 569)
15:38:08 <rdopiera> thanks
15:38:16 <amotoki> rdopiera: what about the identity panel?
15:38:52 <amotoki> I think the identity dashboard is expected to work most.
15:39:48 <rdopiera> let me quickly check
15:40:16 <rdopiera> that works
15:40:54 <amotoki> awesome
15:41:06 <vishalmanchanda_> rdopiera: amotoki yeah Identity dashboard is working fine, just checked with rdopiera patch
15:41:47 <rdopiera> so it's probably on nova side
15:42:44 <rdopiera> or we need to do something special, like a system-scope token that also specifies a project
15:43:12 <rdopiera> I will try to find out
15:43:49 <amotoki> there is a discussion in the rbac meeting on how to handle a project-specific information with system-scoped tokens.
15:44:11 <rdopiera> amotoki: where is that meeting?
15:44:26 <amotoki> rdopiera: it is a meeting on RBAC
15:44:42 <amotoki> aka the policy-pop-up meeting
15:44:57 <rdopiera> ah the etherpad you linked
15:45:08 <amotoki> yes
15:45:17 <rdopiera> thanks, I will look into that
15:45:56 <rdopiera> that's it from me on the system-scope token
15:46:03 <amotoki> the current direction is to use a projet-scoped token for such cases but we are trying to document such things
15:46:24 <amotoki> in the governance patch https://review.opendev.org/c/openstack/governance/+/815158
15:46:50 <amotoki> there are many corner cases to be addressed.
15:47:31 <amotoki> nothing more from me
15:48:31 <vishalmanchanda_> ok let's keep discussing this topic in further meetings.
15:49:13 <vishalmanchanda_> Also, glance and neutron panels are also working if switch to system-scope
15:49:23 <vishalmanchanda_> rdopiera: nice work:)
15:50:10 <vishalmanchanda_> moving to next topic
15:50:21 <vishalmanchanda_> #topic Bug deputy report
15:50:36 <vishalmanchanda_> We have 3 new bugs reported in last 2 weeks.
15:51:30 <vishalmanchanda_> First one https://bugs.launchpad.net/horizon/+bug/1950933 need to be verified.
15:52:19 <vishalmanchanda_> Second looks like duplicate of some existing bug and for last a patch is already merged.
15:52:31 <amotoki> vishalmanchanda_: I think it is a report on a different project named "horizon" :p
15:53:35 <vishalmanchanda_> amotoki: yeah, I will mark it as invalid.
15:53:38 <rdopiera> written in C++
15:55:05 <vishalmanchanda_> I cannot see any topic to discuss in On-Demand Agenda
15:55:32 <vishalmanchanda_> If nothing else to discuss, we can end this meeting.
15:55:51 <amotoki> marked bug 1950933  as Invalid
15:55:57 <vishalmanchanda_> amotoki: thanks
15:56:37 <amotoki> my comment is "We never use C++. I believe you filed a bug to a wrong bug tracker." :-)
15:56:50 <vishalmanchanda_> Last just a review request from the author https://review.opendev.org/c/openstack/horizon/+/805360
15:58:13 <vishalmanchanda_> tmazur: Could you also take a look at above patch as code is in angular, thanks.
15:58:21 <amotoki> it is in my queue but I was busy with internal stuffs.... anyway I will check the qos one.
15:58:34 <vishalmanchanda_> amotoki: thanks.
15:58:45 <tmazur> I will
15:58:54 <vishalmanchanda_> tmazur: cool.
15:59:16 <vishalmanchanda_> Thanks everyone for joining, See you next week.
15:59:34 <vishalmanchanda_> #endmeeting
16:00:22 <amotoki> o/
16:03:29 <rdopiera> thanks
16:20:03 <amotoki> vishalmanchanda_: tmazur: please do not approve the QoS patch. I just checked the python side, but it already turns out It still needs a lot of cleanups unfortunately.
16:29:24 <tmazur> amotoki: ok, thank you for reviewing the patch. I'm checking the angular part now, and there's some minor nits so far
16:32:06 <amotoki> I am a bit afraid such python codes get +2..... should horizon be a pure JS project? (half joking)
16:34:37 <vishalmanchanda_> amotoki: I also raised a point about min packet rate but then nitish mentioned in release notes as a issues, So i thought we can accept that.
16:35:12 <amotoki> vishalmanchanda_: I don't think we accepted non-working code in our history.
16:35:35 <amotoki> I see no reason to accept non-working code
16:36:20 <amotoki> in addition, the release note is not a good place to mention such things.
16:36:21 <vishalmanchanda_> amotoki: a patch to add those attribute is already up in python-neutronclient
16:36:55 <amotoki> vishalmanchanda_: but there is no corresponding code in openstack_dashboard/api/neutron.py
16:37:38 <amotoki> vishalmanchanda_: I know it, but if so, the direction should be either to use Depends-On or to land the whole code without the neutronclient patch.
16:39:04 <amotoki> anyway, new code related to min packet rate needs to be added in openstack_dashboard/api/neutron.py later, so why not adding the whole code on min packet rate later.
16:39:41 <vishalmanchanda_> amotoki: code for the minimum packet rule is also added in openstack_dashboard/api/neutron.py https://review.opendev.org/c/openstack/horizon/+/805360/20/openstack_dashboard/api/neutron.py#2131
16:40:28 <vishalmanchanda_> amotoki: yeah, that make sense or use depends-on tag.
16:41:04 <amotoki> vishalmanchanda_: ah, I missed that part somehow. thanks
03:02:23 <opendevreview> OpenStack Proposal Bot proposed openstack/horizon stable/victoria: Imported Translations from Zanata  https://review.opendev.org/c/openstack/horizon/+/818681
03:02:40 <opendevreview> OpenStack Proposal Bot proposed openstack/horizon stable/wallaby: Imported Translations from Zanata  https://review.opendev.org/c/openstack/horizon/+/818682
12:38:55 <opendevreview> Itsik Kanias proposed openstack/horizon master: [WIP][DFG-UI]Adding test for admin tab - System information  https://review.opendev.org/c/openstack/horizon/+/818691
08:37:07 <opendevreview> Nitish Venkata Patcherla proposed openstack/horizon master: Add Rules operation to Network QoS Policy  https://review.opendev.org/c/openstack/horizon/+/805360
09:00:32 <opendevreview> Nitish Venkata Patcherla proposed openstack/horizon master: Add Rules operation to Network QoS Policy  https://review.opendev.org/c/openstack/horizon/+/805360
11:11:54 <opendevreview> Nitish Venkata Patcherla proposed openstack/horizon master: Add Rules operation to Network QoS Policy  https://review.opendev.org/c/openstack/horizon/+/805360
12:29:45 <mehrdadjalebi> hi everyone. i installed horizon with quickstart docs. after running tox -e runserver, i faced with two diffrenet issues. the first one is not loading of horizon styles. i have this console errors: Uncaught ReferenceError: horizon is not defined - Uncaught ReferenceError: $ is not defined
12:29:59 <mehrdadjalebi> the second one is more important
12:31:41 <mehrdadjalebi> i have two dicker container for keystone and network. after running this containers in localsetting.py i put my keystone ip
12:32:11 <mehrdadjalebi> so its successfully login but after that i have this error:
12:32:25 <mehrdadjalebi> DiscoveryFailure at /project/ Version requested but version discovery document was not found and allow_version_hack was False
12:32:41 <mehrdadjalebi> Exception Location:	/home/user1/workspace/quickstart/horizon/.tox/venv/lib/python3.9/site-packages/keystoneauth1/discover.py, line 1249, in _run_discovery
12:33:02 <mehrdadjalebi> Error during template rendering In template /home/user1/workspace/quickstart/horizon/horizon/templates/horizon/common/_sidebar.html, error at line 4
12:33:11 <mehrdadjalebi> any idea?
12:44:00 <opendevreview> Radomir Dopieralski proposed openstack/horizon master: WIP Add ENFORCE_SYSTEM_SCOPE setting that hides panels  https://review.opendev.org/c/openstack/horizon/+/818763
12:51:58 <opendevreview> Radomir Dopieralski proposed openstack/horizon master: WIP Add ENFORCE_SYSTEM_SCOPE setting that hides panels  https://review.opendev.org/c/openstack/horizon/+/818763
12:55:53 <mehrdadjalebi> i will check this. thanks
13:03:17 <rdopiera> mehrdadjalebi: I think you need to run collectstatic and compress first
13:03:32 <rdopiera> mehrdadjalebi: with the manage.py script
14:19:58 <rdopiera> vishalmanchanda: Did you have a chance to test the system-scope patch? I know it's a close call, but it would really be great if we could get it merged before the freeze on Thursday.
14:20:26 <rdopiera> amotoki: if you have a moment, could you also review https://review.opendev.org/c/openstack/horizon/+/816368?
14:38:42 <vishalmanchanda> rdopiera: hi, sure will test it asap, also feature freeze is around Feb 21 - Feb 25 https://releases.openstack.org/yoga/schedule.html#feature-freeze
14:39:48 <rdopiera> vishalmanchanda: I meant our internal feature freeze for osp17
14:40:08 <rdopiera> vishalmanchanda: I know doesn't concern upstream, but it would be great if we made it
14:40:09 <vishalmanchanda> rdopiera: okk.
16:20:13 <vmarkov> Hi all. Need some help related to async angularjs for this patch: https://review.opendev.org/c/openstack/designate-dashboard/+/816189 . It is really over my js skill(
16:32:08 <opendevreview> Radomir Dopieralski proposed openstack/horizon master: Add system scope support to context switcher  https://review.opendev.org/c/openstack/horizon/+/816368
17:12:00 <opendevreview> Radomir Dopieralski proposed openstack/horizon master: Add system scope support to context switcher  https://review.opendev.org/c/openstack/horizon/+/816368
21:40:48 <opendevreview> Sam Morrison proposed openstack/horizon master: Don't try and update port security if its not changing  https://review.opendev.org/c/openstack/horizon/+/819027
09:11:54 <opendevreview> Radomir Dopieralski proposed openstack/horizon master: Add system scope support to context switcher  https://review.opendev.org/c/openstack/horizon/+/816368
14:52:32 <opendevreview> Radomir Dopieralski proposed openstack/horizon master: Add system scope support to context switcher  https://review.opendev.org/c/openstack/horizon/+/816368
15:24:40 <opendevreview> Vadym Markov proposed openstack/horizon master: Make stack template page handle session expiration  https://review.opendev.org/c/openstack/horizon/+/819124
15:25:44 <opendevreview> Vadym Markov proposed openstack/horizon master: Make stack template page handle session expiration  https://review.opendev.org/c/openstack/horizon/+/819124
10:26:20 <vishalmanchanda> rdopiera: Hi, Could you take a look at open patches for stable/ussuri branch.
10:26:35 <vishalmanchanda> rdopiera: https://review.opendev.org/q/project:openstack/horizon+branch:stable/ussuri+status:open
10:27:11 <vishalmanchanda> Actually release team proposed a patch to move stable/ussuri to extended maintenance phase. So once above open patches are merged I'll cut a final release for stable/ussuri branch.
10:27:21 <vishalmanchanda> rdopiera: e0ne: ^^
11:11:13 <vmarkov> Seems that something broken near Selenium: https://zuul.opendev.org/t/openstack/build/2955e4ff96a74ebeba578f9be64675bd... (full message at https://matrix.org/_matrix/media/r0/download/matrix.org/ZdjXcJVQrMSuEqPfrdGxiHsw)
11:21:59 <vishalmanchanda> vmarkov: yeah, looks like integration job failing again after selenium version updated to 4.1.0 by https://review.opendev.org/c/openstack/requirements/+/818849
18:59:01 <opendevreview> Merged openstack/horizon stable/ussuri: Handle an attached volume without volume_image_metadata  https://review.opendev.org/c/openstack/horizon/+/814260
18:59:04 <opendevreview> Merged openstack/horizon stable/ussuri: Add horizontal scrollbar to role dropdown  https://review.opendev.org/c/openstack/horizon/+/810194
13:09:58 <opendevreview> Radomir Dopieralski proposed openstack/horizon master: Add system scope support to context switcher  https://review.opendev.org/c/openstack/horizon/+/816368
06:37:56 <MehrdadJalebi> hi everyone. i connected my horizon to a docker container keystone and network. login is successfull but after that i got this error:
06:38:15 <MehrdadJalebi> Version requested but version discovery document was not found and allow_version_hack was False
06:38:41 <MehrdadJalebi> anyone has any idea?
12:27:10 <milad> is there any compatibality issue between keystone v14 and horizon v20?
21:29:00 <opendevreview> Tatiana Ovchinnikova proposed openstack/horizon master: Integration tast navigation machinery for Angular pages  https://review.opendev.org/c/openstack/horizon/+/819725
02:48:55 <opendevreview> Sam Morrison proposed openstack/horizon master: Include the images name on the image detail page  https://review.opendev.org/c/openstack/horizon/+/819943
15:00:26 <opendevmeet> vishalmanchanda: Error: Can't start another meeting, one is in progress.  Use #endmeeting first.
15:00:54 <vishalmanchanda> #endmeeting