15:00:09 <vishalmanchanda> #startmeeting horizon
15:00:09 <opendevmeet> Meeting started Wed Jan 19 15:00:09 2022 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:09 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:09 <opendevmeet> The meeting name has been set to 'horizon'
15:01:02 <ganso> o/
15:01:10 <vishalmanchanda> hello everyone
15:01:52 <vishalmanchanda> rdopiera: tmazur e0ne amotoki : ping
15:01:59 <tmazur> o/
15:02:00 <e0ne> hi
15:02:34 <e0ne> vishalmanchanda: I just came back from the vacation. I'm going to continue my contributions starting this week
15:02:58 <vishalmanchanda> e0ne: great, welcome back:)
15:03:23 <vishalmanchanda> we will start in two minutes
15:05:02 <vishalmanchanda> ok let's start
15:05:04 <vishalmanchanda> #topic Notices
15:06:01 <vishalmanchanda> Agenda for today meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities (at line 31)
15:06:12 <vishalmanchanda> As usual Yoga Schedule https://releases.openstack.org/yoga/schedule.html
15:06:21 <vishalmanchanda> This week is R-10 week.
15:06:54 <vishalmanchanda> We have only one month left for feature freeze, so please a look at your bp if you want them to merge in yoga cycle.
15:07:18 <vishalmanchanda> next announcement about CFP
15:07:28 <vishalmanchanda> Call for Presentations: OpenInfra Summit Berlin 2022 is up.
15:07:49 <vishalmanchanda> So if you want to purpose any idea, please go for it.
15:07:57 <vishalmanchanda> The deadline for CFP is February 9th.
15:08:21 <vishalmanchanda> #link http://cfp.openinfra.dev/app/berlin-2022
15:08:43 <vishalmanchanda> moving to next announcement
15:09:38 <vishalmanchanda> nominations for "Z" release cycle is open till 24th January
15:10:02 <vishalmanchanda> #link http://lists.openstack.org/pipermail/openstack-discuss/2022-January/026620.html
15:10:02 <vishalmanchanda> 
15:10:18 <vishalmanchanda> that's all announcement from my side for this week.
15:10:56 <vishalmanchanda> Does anyone have any announcement to make.
15:11:28 <vishalmanchanda> moving to next topic
15:11:40 <vishalmanchanda> #topic release-priorities
15:12:37 <vishalmanchanda> Can I have 2nd review on Drop Django based implementation of launch instance patch
15:12:50 <vishalmanchanda> #link https://review.opendev.org/c/openstack/horizon/+/816303
15:13:31 <vishalmanchanda> So I can cut a new  release of horizon with this and drop of Django 2.2 support.
15:14:28 <vishalmanchanda> We also have to cut a new release of horizon so plugin like openstack/senlin-dashboard can consume this change https://review.opendev.org/c/openstack/horizon/+/822212
15:15:06 <vishalmanchanda> As of now openstack/senlin-dashboard doc job is failing, once we cut a new horizon release it will be fixed.
15:15:35 <vishalmanchanda> Taking about doc job, you have noticed horizon doc job is also failing.
15:16:01 <vishalmanchanda> I have purposed a patch to fix it https://review.opendev.org/c/openstack/horizon/+/825315
15:16:10 <vishalmanchanda> will let you know once it ready.
15:16:38 <vishalmanchanda> So Please take a look at https://review.opendev.org/c/openstack/horizon/+/825315
15:16:53 <vishalmanchanda> e0ne: tmazur :^^
15:17:26 <vishalmanchanda> moving to next item
15:17:31 <tmazur> I'll take a look later today, thanks
15:18:46 <vishalmanchanda> As you already know we decided some priority item in the last ptg we added it in our release priority etherpad
15:19:23 <vishalmanchanda> https://etherpad.opendev.org/p/horizon-release-priorities ( from L6 - L23)
15:19:56 <vishalmanchanda> So if you are working on of those item please add it's status so everybody.
15:20:29 <vishalmanchanda> like tmazur working on Improve integartion test and add more integartion test for angular view
15:21:06 <vishalmanchanda> Please add some summary/status about that so everybody know.
15:22:05 <vishalmanchanda> e0ne: Did you get time to test saas patch https://review.opendev.org/c/openstack/horizon/+/794809 ?
15:22:24 <e0ne> sorry, I just deployed devstack :(
15:22:34 <e0ne> will test. it asap
15:23:11 <vishalmanchanda> e0ne: ok please take a look and see if we can make it work with Default theme
15:23:47 <vishalmanchanda> moving to next topic
15:24:22 <vishalmanchanda> #topic Bug deputy report
15:25:59 <vishalmanchanda> We have 4 new bugs reported this week
15:26:10 <vishalmanchanda> I am working on first as of now
15:26:44 <vishalmanchanda> 2nd bug need to confirm
15:27:26 <vishalmanchanda> For 3rd bug I tried it on my env. but it works fine for me.
15:27:38 <vishalmanchanda> I will check it again on a new env.
15:28:07 <vishalmanchanda> tmazur: e0ne : Could you also try to reproduce in your env and confirm.
15:28:19 <vishalmanchanda> #link https://bugs.launchpad.net/horizon/+bug/1956552
15:29:47 <vishalmanchanda> 4th bug https://bugs.launchpad.net/horizon/+bug/1956091 also need to confirm
15:30:29 <vishalmanchanda> So please a look at all these bug and add your comment in bug summary on launchpad.
15:30:46 <vishalmanchanda> moving to next topic
15:30:59 <vishalmanchanda> #topic On-Demand Agenda
15:31:29 <vishalmanchanda> So there is a request for patch review https://review.opendev.org/c/openstack/horizon/+/808102
15:31:32 <ganso> o/ I added the above ^ link
15:32:00 <ganso> I just wanted to raise awareness for that patch, since it has been complete, with +1 from vishalmanchanda  and sitting from a while, looks like it is in a good shape to be merged
15:32:19 <vishalmanchanda> I have tested this patch long time back and it look fine to me
15:32:42 <vishalmanchanda> but got doubt about the naming convention for the unit tests.
15:33:08 <vishalmanchanda> See my comment at https://review.opendev.org/c/openstack/horizon/+/808102/7/openstack_dashboard/test/unit/api/test_nova.py
15:33:28 <vishalmanchanda> If it look fine to other core reviewer I will revote to +2.
15:33:30 <ganso> vishalmanchanda: I saw it, but I'm assuming you were ok with the response
15:34:01 <ganso> oh cool, so we could get an extra set of core-reviewer eyes it could be pushed to the gate
15:34:35 <vishalmanchanda> I tested this patch with microversion < or > 2. 46 and it works fine in both the cases.
15:35:07 <vishalmanchanda> e0ne tmazur : Could you also take a look at https://review.opendev.org/c/openstack/horizon/+/808102
15:36:35 <vishalmanchanda> added review-priority for above patch to get more eyes.
15:36:43 <ganso> thanks! that's all I had for today
15:37:22 <vishalmanchanda> Next topic is django issues with fips
15:37:26 <vishalmanchanda> ade_lee: ping
15:37:47 <ade_lee> hi all - so there is a general push to be able to run on fips enabled systems
15:37:57 <ade_lee> there is a proposed community goal -- https://review.opendev.org/c/openstack/governance/+/816587
15:38:14 <ade_lee> and many projects now have a fips gate
15:38:40 <ade_lee> I'd like to add one for horizon and will work on one, but there are some fips issues with django
15:39:05 <ade_lee> as you can see on the agenda, I put up a patch for those issues and it has been merged in django main
15:39:25 <ade_lee> which I guess means that it will show up in 5.x?
15:39:36 <ade_lee> but has not been backported
15:39:50 <ade_lee> so -- question is how we can deal with this?
15:40:59 <vishalmanchanda> looking at the links
15:41:55 <ade_lee> one possible approach is to update dependency to later version of django - but not sure if this is possible
15:44:36 <ade_lee> without the patch, when we run ci tests with devstack, a call to django-admin to set stuff up fails.  we could patch django in devstack to avoid this.
15:44:55 <vishalmanchanda> ade_lee: FYI horizon as of now horizon support Dajngo 3.2
15:45:38 <ade_lee> vishalmanchanda, yeah - unless django can be convinced otherwise, they rejected backport to 3.2
15:45:50 <ade_lee> or 4.x
15:46:20 <vishalmanchanda> ade_lee: few of thing already not working in horizon with django 3.2 like django-pyscss
15:47:22 <vishalmanchanda> ade_lee: django-pyscss doesn't support dajngo 3.2 so we some workaround for that and you are asking about moving Django version to 5.x
15:48:13 <ade_lee> vishalmanchanda, ack -- I didn;t think it was likely - but had to ask
15:49:07 <vishalmanchanda> ade_lee: I am not sure about the plan yet but will definitely bring this topic in next ptg.
15:50:57 <ade_lee> vishalmanchanda, ok -- until we move forward then, are you all ok with a patch to devstack to patch django 3.2?
15:51:01 <vishalmanchanda> ade_lee: We generally support Django LTS version in horizon like Django 3.2 have LTS support till April 2024.
15:51:11 <vishalmanchanda> #link https://www.djangoproject.com/download/
15:51:47 <vishalmanchanda> ade_lee: but if you can help in the effort in migrating to Django 5.x we can do that in coming cycle
15:52:20 <vishalmanchanda> ade_lee: even with reviews, as we not have much active contributor in horizon.
15:52:43 <ade_lee> vishalmanchanda, ack -- I can look - but don't really know horizon :/
15:53:03 <ade_lee> vishalmanchanda, but I'll keep that in mind
15:54:05 <ade_lee> vishalmanchanda, for now, I'll plan to patch devstack so that we can at least get testing going
15:54:28 <ade_lee> and I'll plan to add a patch for a fips gate for horizon shortly afterwards
15:54:40 <vishalmanchanda> ade_lee: About the fips, honestly I have no idea about it as of now, will go through the url you have added and let you know  the horizon team plan.
15:55:13 <ade_lee> vishalmanchanda, that would be great - feel free to ping me if you have questions
15:55:46 <ade_lee> but what we've done so far is create ci jobs that test functionality under fips enabled
15:56:03 <vishalmanchanda> ade_lee: but it will take time as migrating to 5.x not a easy thing.
15:56:06 <ade_lee> for bunches of the projects -- found and fixed any issues
15:56:17 <ade_lee> understood
15:56:45 <vishalmanchanda> ade_lee: anyway thanks for joining.
15:56:52 <ade_lee> that will be something I'll call out on the goal proposal
15:57:04 <ade_lee> yup - thanks for listening all.
15:57:11 <vishalmanchanda> anyone would like to add anything about this topic.
15:57:26 <vishalmanchanda> e0ne: tmazur :^^
15:59:17 <vishalmanchanda> If nothing else we can end this meeting.
15:59:35 <vishalmanchanda> Thanks everyone for joining. See you next week!
15:59:51 <vishalmanchanda> #endmeeting