15:00:27 <vishalmanchanda> #startmeeting horizon 15:00:27 <opendevmeet> Meeting started Wed Feb 23 15:00:27 2022 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:00:27 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:00:27 <opendevmeet> The meeting name has been set to 'horizon' 15:00:38 <vishalmanchanda> hello everyone 15:00:50 <ganso> o/ 15:01:36 <e0ne> hi 15:02:00 <vishalmanchanda> let's wait for 2-3 minutes if more people joins us. 15:02:31 <vishalmanchanda> amotoki: rdopiera tmazur: ping for horizon weekly meeting 15:04:18 <vishalmanchanda> ok Let's start the meeting. 15:04:27 <vishalmanchanda> #topic Notices 15:05:09 <vishalmanchanda> few announcement from my side for this week 15:05:26 <vishalmanchanda> As usual Yoga Schedule https://releases.openstack.org/yoga/schedule.html 15:05:42 <vishalmanchanda> This week is R-5 week. 15:06:36 <vishalmanchanda> This week is also Feature freeze weak but anyone can ask for feature freeze exception if you want your bp to merge in Yoga release. 15:07:34 <vishalmanchanda> but in case you are going to ask for feature freeze exception please let me know asap by this week 15:07:57 <vishalmanchanda> Horizon follows cycle-with-intermediary model. 15:08:09 <vishalmanchanda> So I will cut Final release of horizon in week of Mar 14 - Mar 18. 15:08:53 <vishalmanchanda> sorry forgot to drop agenda for today meeting link 15:08:54 <vishalmanchanda> https://etherpad.opendev.org/p/horizon-release-priorities 15:09:12 <vishalmanchanda> at Line 33 15:09:45 <vishalmanchanda> moving to next announcement 15:10:09 <vishalmanchanda> I have pushed a patch to add Yoga cycle highlights for horizon 15:10:28 <vishalmanchanda> Please take a look https://review.opendev.org/c/openstack/releases/+/830564 15:11:26 <rdopiera> o/ sorry for being late 15:11:44 <vishalmanchanda> Let me know if I missed any updates which can be add in cycle highlights 15:11:51 <vishalmanchanda> rdopiera: hi, np 15:12:18 <rdopiera> vishalmanchanda: I will need to merge a small patch that lets us disable the system scope token support on per-service basis, because only keystone is ready in yoga 15:12:52 <vishalmanchanda> rdopiera: ok, I See. 15:13:45 <vishalmanchanda> rdopiera: that patch also going to remove System Scope from context switch menu? 15:14:00 <rdopiera> vishalmanchanda: yes, if it's disabled for all services 15:14:30 <rdopiera> we can make that the default 15:15:03 <vishalmanchanda> rdopiera: ok, then I think I should remove System Scope update from Yoga Cycle highlights 15:15:19 <vishalmanchanda> https://review.opendev.org/c/openstack/releases/+/830564/1/deliverables/yoga/horizon.yaml 15:15:58 <rdopiera> I will remove it in the same patch? 15:16:17 <vishalmanchanda> e0ne: amotoki rdopiera : wdys. 15:17:12 <vishalmanchanda> rdopiera: No I am asking that either we should keep System Scope in Horizon Cycle highlights or not? 15:17:18 <amotoki> vishalmanchanda: I did not get your point. I am not sure what you are asking. 15:18:02 <vishalmanchanda> I have pushed a patch to add horizon Yoga cycle highlights 15:18:10 <vishalmanchanda> https://review.opendev.org/c/openstack/releases/+/830564/1/deliverables/yoga/horizon.yaml 15:18:29 <rdopiera> vishalmanchanda: I think we can keep it, even if it's disabled by default 15:18:36 <rdopiera> vishalmanchanda: it is a new feature after all 15:18:38 <vishalmanchanda> I also mention in that patch horizon added a entry of System scope. 15:18:54 <vishalmanchanda> but now rdopiera saying that he going to disable it 15:19:11 <vishalmanchanda> So that's why I am asking we should keep that point or not 15:19:19 <rdopiera> we can either disable it by default, or only enable it for keystone 15:19:19 <vishalmanchanda> Sorry for confusion! 15:19:30 <rdopiera> it's up to us 15:20:15 <rdopiera> I think that keeping it disabled for now, and only enabling it once it works with most of services is the best from the point of view of the user experience 15:20:32 <amotoki> regarding the cycle highlight, I think we can mention that the system-scope support in horizon is experimental or partially available for keystone operations. 15:20:36 <rdopiera> people who want to try it can always enable it themselves 15:20:47 <vishalmanchanda> rdopiera: amotoki ok cool, agreed. 15:22:07 <vishalmanchanda> I will update my cycle highlights patch after the meeting and mention that System scope feature is experimental as of now. 15:22:53 <vishalmanchanda> Also https://review.opendev.org/c/openstack/releases/+/830564 take a look if anything need to be updated there. 15:23:31 <vishalmanchanda> that's all announcement from my side for this week 15:23:51 <vishalmanchanda> If anyone else have any announcement to make please go ahead. 15:24:39 <vishalmanchanda> moving to next topic 15:24:46 <vishalmanchanda> #topic Release priorities 15:25:13 <opendevreview> Akihiro Motoki proposed openstack/horizon master: Avoid extra flavor_get in resize server form https://review.opendev.org/c/openstack/horizon/+/830630 15:25:57 <vishalmanchanda> New release of pyscss is up https://pypi.org/project/pyScss/1.4.0/ 15:26:06 <vishalmanchanda> thanks to Ivan 15:26:59 <vishalmanchanda> It include many fixes https://github.com/Kronuz/pyScss/commits/master 15:27:56 <vishalmanchanda> So I have pushed a patch to update pyScss version in requirements and horizon project. 15:28:06 <vishalmanchanda> https://review.opendev.org/c/openstack/requirements/+/830615 15:28:17 <vishalmanchanda> https://review.opendev.org/c/openstack/horizon/+/830618 15:28:29 <vishalmanchanda> Please take a look at patches. 15:29:27 <amotoki> what is the impcat to Yoga release? This week is the requirement freeze too (as you may know) 15:29:44 <amotoki> Can we defer it to Zed or do we need to land it in Yoga? 15:30:37 <e0ne> amotoki: it enables python 3.10 witch isn't an official runtime for Yoga 15:31:17 <vishalmanchanda> amotoki: I don't see any issue in bumping the pyScss version to latest. 15:31:47 <vishalmanchanda> It going to fix some deprecation warning as weel 15:31:49 <amotoki> e0ne: yes, so my understanding is we don't need to have it in Yoga necessarily, right? 15:31:51 <vishalmanchanda> well* 15:32:16 <e0ne> amotoki: it's not required 15:32:17 <vishalmanchanda> amotoki: I am also fine with doing it in Zed cycle. 15:32:32 <vishalmanchanda> early Zed cycle 15:32:43 <amotoki> early Zed cycle makes sense. 15:33:01 <amotoki> thanks. I just would like to clarify it as this week is the requirement freeze. 15:34:17 <vishalmanchanda> ok Let's do it in early in Zed early cycle to avoid any issues. 15:34:59 <vishalmanchanda> moving to next topic 15:35:14 <vishalmanchanda> #topic Bug deputy report 15:35:31 <vishalmanchanda> We have 1 new bugs reported from last week. 15:35:43 <vishalmanchanda> #link https://bugs.launchpad.net/horizon/+bug/1961560 15:36:44 <vishalmanchanda> It is related to Zun but I am not have such env. to confirm it. 15:37:29 <vishalmanchanda> So if anyone else use Zun please confirm the bug or I will also ask the author to add some error logs for the bug 15:38:11 <vishalmanchanda> moving to next topic 15:38:13 <amotoki> trying to reproduce it is not the only way to confrim a bug. I 15:38:45 <amotoki> for example, you can ask an example of volume information response and/or related information to the bug author. 15:39:18 <vishalmanchanda> amotoki: +1. 15:39:24 <amotoki> it will help narrowing down the issue 15:40:01 <vishalmanchanda> #topic On-Demand Agenda 15:41:03 <vishalmanchanda> there is a patch purposed in openstack/governance about runtime of Nodejs for Zed cycle 15:41:23 <vishalmanchanda> #link https://review.opendev.org/c/openstack/governance/+/830454/2/reference/runtimes/zed.rst#35 15:42:00 <vishalmanchanda> I would like to know your opinion about migration to next nodejs version. 15:42:23 <vishalmanchanda> Do you think we should migrate to next node js version in next release 15:43:30 <amotoki> basically yes. horizon dependency on node.js is just a test env, so it should work and otherwise we need to adjust our test env. 15:44:36 <vishalmanchanda> amotoki: ok. 15:45:03 <vishalmanchanda> that's all from my side for this week 15:45:07 <amotoki> I plan to clean up a lot of warnings we see before the yoga release. 15:45:10 <amotoki> for example RemovedInDjango40 warning, oslo.policy warnings on deprecated rules 15:45:37 <amotoki> regarding RemovedInDjango40, patches are already proposed. 15:45:48 <vishalmanchanda> amotoki: that would be great:) 15:45:57 <amotoki> I am preparing a patch for oslo.policy warnings too 15:46:16 <vishalmanchanda> amotoki: thanks for letting me know. 15:46:30 <amotoki> one thing I would like to ask is about django.template debug message. 15:46:49 <rdopiera> I looked into that 15:47:10 <rdopiera> it's not possible to fix the templates to not generate those messages 15:47:31 <rdopiera> the best we can do is silence them 15:47:59 <amotoki> yeah, previously we did not filter django.template log message as we try to fix but it is not easy and practical to pass ALL parametres in templates. 15:48:24 <rdopiera> even Django's own built-in templates have that 15:48:25 <amotoki> so I am wondering to change the log level of django.template to INFO. 15:48:37 <rdopiera> yes, please 15:49:18 <vishalmanchanda> +1 on changing log level to INFO. 15:49:30 <amotoki> thanks for the feedback. I will push a patch on this too 15:50:08 <vishalmanchanda> Does anyone else have any topic to discuss, please go ahead. 15:50:12 <ganso> I just wanted to raise awareness of post-merge comments on https://review.opendev.org/c/openstack/horizon/+/806454 so right now it is unclear to me whether there is a problem that would need to be addressed in Yoga or not. Right now everything looks fine to me but I just wanted to make sure we are in agreement 15:51:32 <amotoki> ganso: I confirmed all pages work after your commit, so there is no issue from user perspective. 15:51:54 <ganso> IMO there is much more that I wanted to accomplish within Yoga w.r.t to pagination but we are too far late in the dev cycle for this release IMO. Patch https://review.opendev.org/c/openstack/horizon/+/829843 looks like the next step in that big network pagination effort, but I tested it and didn't work for me, or I just don't understand how it works 15:52:56 <ganso> amotoki: thanks! I was mostly referring to your concern on the function return value, but as I said, it is part of a bigger incremental effort until the old return value type is no longer needed 15:54:25 <ganso> that's all I had 15:54:43 <ganso> if there is nothing to discuss further in this topic 15:55:35 <vishalmanchanda> ganso: I will try to test soon https://review.opendev.org/c/openstack/horizon/+/829843 15:56:23 <vishalmanchanda> ganso: You don't see any changes after applying tatina patch? 15:56:31 <ganso> vishalmanchanda: yea, zero changes 15:56:49 <ganso> vishalmanchanda: I tried clearing browser cache, restarting services and stuff 15:56:50 <vishalmanchanda> ganso: maybe you browser not picking up latest code. 15:57:51 <vishalmanchanda> ganso: just check in developer mode for your browser that these files static/dashboard/project/workflow/launch-instance/network/network.controller.js picks new code or not 15:58:24 <ganso> vishalmanchanda: thanks, I will try that and report back in the patch 15:58:39 <vishalmanchanda> ganso: thanks for working on Pagination patch. 15:58:48 <amotoki> ganso: I understand the situation, but perhaps perhaps we need to have separate functions for paged/non-paged usages. in addition, we should not have an argument for internal usage insdie neutron.py like "single_page" in functions exposed to other layer even during refactoring, but all can be done separately. I am exploring how we can make it more readable. 16:00:13 <vishalmanchanda> ok we are out of time. 16:00:30 <vishalmanchanda> thanks everyone for joining. 16:00:37 <ganso> amotoki: thanks! 16:00:41 <vishalmanchanda> #endmeeting