15:01:47 <vishalmanchanda> #startmeeting horizon
15:01:47 <opendevmeet> Meeting started Wed Mar  9 15:01:47 2022 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:01:47 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:01:47 <opendevmeet> The meeting name has been set to 'horizon'
15:03:07 <vishalmanchanda> Hi, anyone around for horizon weekly meeting.
15:03:33 <e0ne> hi
15:04:28 <rdopiera> hi
15:05:37 <vishalmanchanda> I can't find any topic to discuss for today's meeting in our etherpad.
15:05:47 <vishalmanchanda> https://etherpad.opendev.org/p/horizon-release-priorities (at line 32)
15:05:59 <vishalmanchanda> Also Not any updates from my side for this week.
15:06:18 <vishalmanchanda> I just want to remind about some patches which are good to have in yoga release.
15:06:44 <vishalmanchanda> So moving directly to open-discussion.
15:06:54 <vishalmanchanda> #topic open-discussion
15:07:18 <vishalmanchanda> https://review.opendev.org/c/openstack/horizon/+/832735 (trivial patch)
15:07:41 <vishalmanchanda> Can I have quick approval on this one.
15:08:27 <vishalmanchanda> Next I am waiting for patch which hides System Scope menu.
15:08:33 <vishalmanchanda> https://review.opendev.org/c/openstack/horizon/+/818763
15:08:47 <vishalmanchanda> rdopiera: Is it ready for review?
15:09:32 <rdopiera> vishalmanchanda: I need to add docs and release note, I'm working on it
15:09:57 <rdopiera> vishalmanchanda: but I would be grateful for any feedback on what is there so far
15:10:02 <vishalmanchanda> rdopiera: ok, thanks
15:10:11 <vishalmanchanda> rdopiera: I tested your patch today
15:10:47 <vishalmanchanda> rdopiera: but It also hided the Identity dashboard which is wrong.
15:10:54 <vishalmanchanda> hides*
15:11:28 <rdopiera> it just moves it between the system scope and admin menus
15:11:45 <rdopiera> depending on whether identity is enabled or not
15:13:12 <rdopiera> by default, with the list empty, there should be no change from previous versions of horizon
15:13:13 <vishalmanchanda> rdopiera: So I have do some changes to see identity dashboard after applying your patch
15:13:32 <vishalmanchanda> ?
15:14:07 <rdopiera> with SYSTEM_SCOPE_SERVICES = [] the behavior of horizon should be exactly the same as before the system scope patche3s
15:15:52 <vishalmanchanda> rdopiera: but it is different for me
15:16:17 <rdopiera> that's a bug in my code then
15:17:07 <vishalmanchanda> rdopiera: It look like this https://ibb.co/2qgjVKx to me
15:17:19 <vishalmanchanda> rdopiera: after applying your patch
15:17:42 <vishalmanchanda> rdopiera: No Identity dashboard.
15:18:55 <rdopiera> I will check it, thanks
15:18:58 <vishalmanchanda> Maybe tmazur or e0ne can test your patch and let's see.
15:19:02 <vishalmanchanda> rdopiera: cool.
15:19:28 <vishalmanchanda> Next one is https://review.opendev.org/c/openstack/horizon/+/819725
15:19:43 <vishalmanchanda> some minor comments from amotoki otherwise LGTM
15:21:16 <tmazur> I'll address them asap
15:21:23 <vishalmanchanda> Last one in my list series to fix Django4 deprecation warning.
15:21:28 <vishalmanchanda> tmazur: thanks:)
15:21:36 <vishalmanchanda> https://review.opendev.org/q/topic:django40-warnings+status:open
15:22:33 <vishalmanchanda> Please a look at above patches, once you have time.
15:23:41 <vishalmanchanda> Most of them look into good shape to merge in yoga cycle except System Scope hide Menu
15:24:20 <vishalmanchanda> I hope rdopiera fix that issue I mentioned above soon in his patch.
15:24:50 <vishalmanchanda> Otherwise we will backport it to stable/yoga once merged in the master branch.
15:26:58 <vishalmanchanda> Also, we follow cycle with intermediary releases, So either me or release team cut a final release for horizon with latest patch in week of Mar 21 - Mar 25.
15:27:16 <vishalmanchanda> that's all update from my side for this week.
15:27:39 <vishalmanchanda> If anyone like to raise any other topic here, please go ahead.
15:28:05 <amotoki> one question on an old backport patch https://review.opendev.org/c/openstack/horizon/+/797104
15:28:26 <amotoki> Do you think it is feasible to backport or is it a feature backport?
15:31:23 <vishalmanchanda> amotoki: Looking at this patch now, I am not in favor of backporting this to stable/wallaby.
15:32:24 <vishalmanchanda> If stable cores want to merge this in stable/wallaby, please go ahead.
15:32:43 <amotoki> I was waiting for feedbacks from other reviewers for over 6 months but did not get any, so i am raising it here.
15:33:01 <e0ne> amotoki: it's a good question. it changes defaults so I'm going put -2 on it
15:33:33 <vishalmanchanda> If we support this now, we see more features backport into stable branches which doesn't look good to me.
15:33:43 <e0ne> amotoki: it does really good thing, some some users could expect their current 'random default'
15:33:48 <vishalmanchanda> although it's a minor feature.
15:34:21 <amotoki> one reason I think it is a kind of bug too is that the current implementation does not allow users to specify "any" as AZ.
15:34:49 <amotoki> Once a user selects AZ, theree is no way to cancel the selection (i.e. "any")
15:34:51 <e0ne> hm... interesting
15:35:03 <amotoki> only way is to close the form and re-open it.
15:36:33 <e0ne> amotoki: now I'm ok to have this fix with a propper commit message
15:37:53 <amotoki> if ok, I can update the commit mesasge to explain why.
15:38:12 <vishalmanchanda> ok if stable core have no objection with merging into stable/wallaby, please go ahead.
15:38:21 <vishalmanchanda> One more question here.
15:39:07 <vishalmanchanda> Are we going to backport it into more stable branches like ussuri, victoria?
15:40:13 <amotoki> I think the implementation is same for such branches, so if we accept the backport in wallaby there is no reason to reject it.
15:40:41 <vishalmanchanda> ok thanks for clarifying.
15:41:33 <amotoki> thanks all. I will follow it up including the commit mesasge and the release note to describe the situation.
15:43:11 <vishalmanchanda> If nothing more to discuss, we can end this meeting.
15:43:40 <vishalmanchanda> thanks everyone for joining.
15:43:42 <amotoki> nothing more from me
15:43:52 <vishalmanchanda> TC.
15:44:10 <vishalmanchanda> #endmeeting