15:00:29 <vishalmanchanda> #startmeeting horizon
15:00:29 <opendevmeet> Meeting started Wed May 11 15:00:29 2022 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:29 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:29 <opendevmeet> The meeting name has been set to 'horizon'
15:00:46 <rdopiera> o/
15:00:56 <vishalmanchanda> hello everyone
15:00:56 <tmazur> o/
15:01:20 <amotoki> hi
15:01:25 <vishalmanchanda> ok let's start the meeting.
15:01:39 <vishalmanchanda> agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L38
15:02:09 <vishalmanchanda> #topic Notices
15:02:24 <vishalmanchanda> This week is R-21 week.
15:02:38 <vishalmanchanda> Next week is Zed-1 milestone.
15:03:04 <vishalmanchanda> For more info. about the schedule please refer https://releases.openstack.org/zed/schedule.html
15:03:43 <vishalmanchanda> I have no other announcement for this week, if anyone want to make any announcement, please go ahead.
15:04:28 <vishalmanchanda> looks like nothing more to announce, moving to next topic
15:04:52 <vishalmanchanda> #topic Release priorities
15:05:22 <vishalmanchanda> few updates from my side.
15:05:56 <vishalmanchanda> Deprecate Django based Panel for Images, Keypair, and roles looks in good shape.
15:06:10 <vishalmanchanda> Please review it asap so we can deprecate this in early cycle.
15:06:24 <vishalmanchanda> https://review.opendev.org/c/openstack/horizon/+/838333
15:07:14 <vishalmanchanda> moving to next update
15:07:53 <vishalmanchanda> Patch to migrate nodejs14 -> nodejs 16 also look good to merge, already have one +2.
15:08:05 <vishalmanchanda> Please take a look https://review.opendev.org/c/openstack/horizon/+/831929
15:08:48 <vishalmanchanda> Also, I have pushed a series of patches in horizon plugins so that they can use the new nodejs template to run nodejs jobs in horizon plugins.
15:08:56 <vishalmanchanda> https://review.opendev.org/q/topic:migrate-to-nodejs16
15:10:56 <vishalmanchanda> Next, I have a query regarding moving application credentials panel under project tab
15:11:48 <vishalmanchanda> I am not sure where exactly we have to move under project tab, So I just want to confirm this before pushing a patch.
15:12:25 <vishalmanchanda> Do I need to move it under 'Project api' panel?
15:13:09 <amotoki> vishalmanchanda: it is required if all panels under the indentity dashboard works with the system-scoped token.
15:13:53 <amotoki> if we switch token types per panel, it is not required.
15:16:27 <vishalmanchanda> hmm, So we have to check the token first, then on that basis we have to decide where application credentials will display?
15:16:29 <rdopiera> then there would be an identity group with just a single panel?
15:16:33 <vishalmanchanda> or I am wrong?
15:16:37 <rdopiera> when you are in a project scope
15:19:30 <vishalmanchanda> Sorry I am confused now, Can someone elaborate here. What exactly we have to do with application credential panel?
15:19:35 <vishalmanchanda> amotoki: ^^
15:20:34 <amotoki> vishalmanchanda: what I can say is that we need to use a project-scoped token when handling the app credential panel.
15:20:51 <amotoki> vishalmanchanda: it is just a requirement to make it work.
15:23:04 <vishalmanchanda> ok , then there would be an identity group with just a single panel(application credentials) when we are in a project scope?
15:23:26 <vishalmanchanda> rdopiera question.
15:25:25 <vishalmanchanda> amotoki: So rdopiera is right?
15:26:11 <amotoki> vishalmanchanda: I cannot answer right now as i need to check the code base.
15:26:25 <vishalmanchanda> ok np.
15:26:45 <vishalmanchanda> that's all update from my side for this topic.
15:27:29 <vishalmanchanda> I can see rdopiera updated django sass processor patch https://review.opendev.org/c/openstack/horizon/+/794809
15:27:53 <rdopiera> the patch worked for me even before updating, but I fixed some cosmetic things in it
15:28:16 <rdopiera> note that you *have* to do collectstatic for it to work
15:28:44 <vishalmanchanda> rdopiera: thanks for updating it.
15:28:50 <rdopiera> it still fails with the material theme
15:29:03 <vishalmanchanda> :(
15:29:10 <rdopiera> something about a function defined inside a function
15:29:31 <rdopiera> I don't understand sass enough to fix this
15:30:16 <vishalmanchanda> maybe e0ne have some idea how to fix that issue, but he is not here right now.
15:31:07 <vishalmanchanda> Does anyone want to discuss anything about release priorities topic?
15:31:57 <amotoki> re: sass topic, is it about @selector-append?
15:32:36 <amotoki> IIRC, there are @selector-append and @append-selector. We added a fallback logic.
15:33:15 <amotoki> I am not sure which is the standard, but it is okay if either works
15:33:50 <rdopiera> I see, I will try replacing it then
15:34:37 <vishalmanchanda> moving to next topic
15:34:46 <vishalmanchanda> #topic open-discussion
15:35:34 <vishalmanchanda> I have a request for patch review from author https://review.opendev.org/q/topic:horizon-keystoneauth-original_ip
15:36:29 <vishalmanchanda> Can someone please take a look, I have +1 on one patch because I am not completely sure about the change.
15:36:51 <vishalmanchanda> So it will be nice if more people can take a look.
15:37:13 <vishalmanchanda> rdopiera: tmazur :^^
15:37:17 <amotoki> I am aware of it, but I am part-time developer almost with 25%, so I could not have time so far. anyway I will look at it this week.
15:38:12 <vishalmanchanda> amotoki: arigato gozaimasu.
15:38:57 <vishalmanchanda> Does anyone wants to discuss any other topic?
15:39:08 <vishalmanchanda> Please go ahead.
15:41:01 <vishalmanchanda> If nothing more to discuss, let's end this meeting.
15:41:28 <vishalmanchanda> Thanks everyone for joining.
15:41:34 <vishalmanchanda> See you next week!
15:41:45 <vishalmanchanda> #endmeeting