15:00:13 <vishalmanchanda> #startmeeting horizon
15:00:13 <opendevmeet> Meeting started Wed May 25 15:00:13 2022 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:13 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:13 <opendevmeet> The meeting name has been set to 'horizon'
15:00:56 <tmazur> o/
15:01:08 <vishalmanchanda> hello everyone
15:01:16 <rdopiera> o/
15:02:13 <vishalmanchanda> ok let's start the meeting
15:02:46 <vishalmanchanda> agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L39
15:02:55 <vishalmanchanda> #topic Notices
15:03:26 <vishalmanchanda> A casual reminder about schedule. We passed Zed-1 milestone last week.
15:03:38 <vishalmanchanda> This week is R-19 week.
15:03:52 <vishalmanchanda> For more info about schedule please refer https://releases.openstack.org/zed/schedule.html
15:04:49 <vishalmanchanda> I have no other announcements to make, if anyone have any announcement to make. please go ahead
15:05:41 <vishalmanchanda> moving to next topic
15:05:52 <vishalmanchanda> #topic Release priorities
15:06:30 <vishalmanchanda> few  updates from my side on this topic.
15:07:15 <vishalmanchanda> tmazur: I am waiting for your review on deprecation patch https://review.opendev.org/c/openstack/horizon/+/838333
15:07:34 <vishalmanchanda> Could take a look asap, so can merge this asap.
15:07:43 <tmazur> I'll review it asap
15:07:53 <vishalmanchanda> tmazur: thanks.
15:08:25 <vishalmanchanda> about migration to nodejs16  https://review.opendev.org/c/openstack/horizon/+/831929 is merged last week
15:08:57 <vishalmanchanda> Now waiting for plugins to use new nodejs template
15:10:10 <vishalmanchanda> Gate is passing for all the plugins but unfortunately,  few plugins maintainers/core team is not active in horizon plugins.
15:10:31 <vishalmanchanda> So if you guys can take a look, would be great.
15:10:41 <vishalmanchanda> https://review.opendev.org/q/topic:migrate-to-nodejs16
15:11:41 <vishalmanchanda> that's all  update from my side on release-priorities topic.
15:12:12 <vishalmanchanda> If anyone would like to share any updates on this topic, please go ahead.
15:13:52 <tmazur> vishalmanchanda: I have some news about the migration to angular 1.8.2
15:15:04 <tmazur> It's done, and I tested it on my env. The patch is coming today I hope, just need some grooming.
15:15:26 <vishalmanchanda> tmazur: awesome🙂)
15:15:43 <tmazur> But we really need to test it as much as we can, since the changes are critical
15:16:05 <vishalmanchanda> tmazur: +1.
15:16:56 <tmazur> Also, I had to skip a couple tests on promise rejections, since the rejection process itself has been changed after 1.5.8
15:17:51 <tmazur> So a rejection is like a resolved promise now, which makes those tests useless, and they need to be rewritten completely
15:18:02 <tmazur> But that's out of the current scope for sure
15:19:19 <vishalmanchanda> ok, will wait for your patch then let's discuss it in detail.
15:20:17 <vishalmanchanda> moving to next topic
15:20:47 <vishalmanchanda> #topic Bug deputy report
15:21:21 <vishalmanchanda> we have 3 new bugs reported in last two weeks.
15:22:09 <vishalmanchanda> for the bug https://bugs.launchpad.net/horizon/+bug/1974184 I have already added my thoughts in bug summary.
15:25:10 <amotoki> as I commented, when disabling the create button, the usage does not exceed the quota. it just reaches the quota. I think this is the point of the bug.
15:25:25 <vishalmanchanda> I am also fine with using 'Quota reached'  or 'Quota exceeded'
15:25:58 <vishalmanchanda> because neutron also uses 'Quota exceeded'
15:26:01 <amotoki> in case fo API response, it means the usage would exceed the quota if a requested resource is crated.
15:27:50 <vishalmanchanda> We can use 'Quota reached'  as it looks more correct.
15:29:53 <vishalmanchanda> moving to next bug  https://bugs.launchpad.net/horizon/+bug/1974470
15:31:22 <vishalmanchanda> 2nd bug looks valid to me
15:33:56 <rdopiera> we were looking already into using the new apis
15:34:03 <rdopiera> but this is more an RFE than a bug
15:34:17 <vishalmanchanda> I am still investigating the 2nd bug, will take a look how to use placement api
15:34:29 <vishalmanchanda> rdopiera: yeah.
15:36:55 <vishalmanchanda> rdopiera: sorry, what you mean, are we already using placement apis?
15:37:44 <rdopiera> vishalmanchanda: tmazur and me were already looking into adding the placement apis to horizon, but we don't have anything working yet
15:38:01 <vishalmanchanda> rdopiera: ok.
15:38:34 <rdopiera> and I think that getting the libraries updates is higher priority right now
15:39:57 <vishalmanchanda> yeah, anyway I will take a look at this(use placement-api in horizon) but it will take time.
15:40:15 <vishalmanchanda> moving to last bug https://bugs.launchpad.net/horizon/+bug/1971592
15:40:46 <vishalmanchanda> for 3rd bug, we already know this a known issue.
15:41:36 <vishalmanchanda> I have also replied to the author on open-discuss ML.
15:42:23 <vishalmanchanda> but I guess we have to add it in horizon documentation as a known issue.
15:43:18 <vishalmanchanda> Otherwise people are going to ask it again and again.
15:44:28 <vishalmanchanda> I can push a patch to add this in horizon documentation.
15:44:48 <vishalmanchanda> but I forgot, will do that asap.
15:46:02 <vishalmanchanda> moving to next topic
15:46:13 <vishalmanchanda> #topic On-Demand Agenda
15:46:25 <vishalmanchanda> Restructuring of integration tests
15:47:00 <vishalmanchanda> rdopiera: Floor is yours.
15:48:26 <rdopiera> right, so I was thinking a little bit more about the integration tests, because they give us a lot of headache recently
15:48:45 <vishalmanchanda> 100%
15:48:54 <rdopiera> and I noticed that we have a lot of duplicate tests in there, for example
15:49:05 <rdopiera> we have a test that checks if you can log in into horizon
15:49:17 <rdopiera> but then every other test also logs in into horizon
15:49:30 <rdopiera> and the login test doesn't even run first
15:49:37 <rdopiera> which makes it completely useless
15:50:02 <rdopiera> the thing is, we wrote those tests like one would write unit tests -- each testing one specific thing
15:50:24 <rdopiera> when for integration tests, we should instead write them from user stories
15:51:00 <rdopiera> so we would, for example, have one "story" about how flavors work, and all flavor operations would be tested in it
15:51:19 <rdopiera> of course it would be a lot of work to rewrite those tests we have right now
15:51:56 <rdopiera> so as a stop-gap solution, I propose that we for now simply skip the tests that add no coverage -- like the login test -- specifying which other test also tests the same thing
15:52:12 <rdopiera> that should reduce the time of running the tests
15:52:45 <vishalmanchanda> Is there any specific reason or history, we login again for each test?
15:53:24 <rdopiera> you want to be able to run each test independently
15:53:48 <rdopiera> this brings me to a second point
15:54:30 <rdopiera> we need to make use of the setup and teardown functions for the tests -- especially for deleting any leftover objects when a test has failed
15:55:56 <amotoki> +1. perhaps addCleanup would be better rather than teardown though
15:56:10 <rdopiera> right, pytest has some cool mechanisms for this
15:56:23 <rdopiera> that could even let us avoid having to log in every time
15:57:10 <vishalmanchanda> rdopiera: I am agreed with both of your points.
15:57:36 <vishalmanchanda> As it is really irritating to do recheck on patches.
15:57:48 <rdopiera> the rechecks are mostly due to no cleanup
15:58:12 <rdopiera> then it's stuck broken until the vm is reprovisioned
15:58:13 <vishalmanchanda> No patch is merged in horizon last week due to these random integration tests failure.
15:58:49 <vishalmanchanda> rdopiera: ok.
15:59:28 <vishalmanchanda> rdopiera: are you already working on that patch to fix it.
15:59:56 <rdopiera> vishalmanchanda: I wanted to make sure there is an agreement to that first
16:00:05 <rdopiera> I will start on it next week
16:00:19 <vishalmanchanda> I have no issue with it.
16:00:48 <vishalmanchanda> amotoki: tmazur : please let us know, if you see any issues here?
16:00:59 <vishalmanchanda> we are out of time.
16:01:05 <amotoki> I am fine with it
16:01:18 <rdopiera> I suppose the cleanup part is the most urgent now
16:01:21 <vishalmanchanda> let me just end this meeting and continue the discussion here.
16:01:34 <vishalmanchanda> #endmeeting