15:00:33 <vishalmanchanda> #startmeeting horizon
15:00:33 <opendevmeet> Meeting started Wed Jun  8 15:00:33 2022 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:33 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:33 <opendevmeet> The meeting name has been set to 'horizon'
15:01:09 <vishalmanchanda> hi
15:01:52 <tmazur> o/
15:02:12 <rdopiera> o/
15:03:36 <vishalmanchanda> There is no topic added in etherpad for today's discussion https://etherpad.opendev.org/p/horizon-release-priorities#L39
15:04:01 <vishalmanchanda> I also have no update for this week.
15:04:24 <rdopiera> \o/
15:04:34 <vishalmanchanda> So moving to open-discussion.
15:04:50 <vishalmanchanda> #topic Open-discussion
15:05:03 <tmazur> I want to talk about AngularJS update :)
15:05:22 <vishalmanchanda> tmazur: ok please go ahead.
15:05:46 <tmazur> Apparently the patches https://review.opendev.org/c/openstack/requirements/+/843505 and https://review.opendev.org/c/openstack/horizon/+/843346 are kind of depend on each other
15:06:00 <vishalmanchanda> tmazur: yes
15:06:20 <vishalmanchanda> tmazur: So, I have one question
15:06:28 <tmazur> The horizon one needs a new requirement, and the requirements one needs fixes from horizon
15:07:10 <vishalmanchanda> tmazur: What if you don't update 'requirements.txt' in horizon patch
15:07:12 <vishalmanchanda> https://review.opendev.org/c/openstack/horizon/+/843346/1/requirements.txt
15:07:32 <tmazur> vishalmanchanda: that's exactly what I'm thinking about
15:07:49 <tmazur> It seems the only one reasonable option to have them both
15:07:59 <vishalmanchanda> You can update requirements.txt after you bump angular version in openstack/requirements
15:08:11 <vishalmanchanda> tmazur: yeah that should work.
15:09:02 <amotoki> tmazur: can we make horizon work with AngularJS 1.5.8 and 1.8.2? If possible it would be ideal
15:10:42 <tmazur> I don't know, I haven't tried yet.
15:11:25 <amotoki> tmazur: np. if it is possbile, we can land the horizon patch first and then update the upper-constraints.txt
15:11:27 <tmazur> I will, and if my changes work with 1.5.8, keeping the old version until the requirements patch is merged is the solution
15:11:41 <amotoki> I am also afraid that bumping AngularJS to 1.8.2 would break AngularJS based plugins considering the current test failure in the requirements patch.
15:11:50 <tmazur> amotoki: yes
15:12:25 <vishalmanchanda> :(
15:13:30 <tmazur> I am going to write some notes on what I did to make Horizon work with the new version. That should help with plugins too
15:13:32 <amotoki> I am a fan of upgading AngularJS to 1.8.2, but at least it would be better to try some (1 or 2?) plugins. it will show how simple the upgrade is.
15:14:22 <amotoki> on the other hand, we are in the middle of the dev cycle, so it would be a good chance to upgrade AngularJS.
15:14:36 <amotoki> tmazur: thanks. let's try
15:16:29 <tmazur> Ok, so the plan is: I'll see first if my changes work with 1.5.8. If yes, we can merge the patch and then go with upper constraints
15:16:29 <vishalmanchanda> I am just wondering why 'horizon-cross-ironic-ui-npm' didn't run on patch https://review.opendev.org/c/openstack/horizon/+/843346
15:18:14 <vishalmanchanda> tmazur: yes, if that works we can cut a new release of horizon that work with both angular version 1.5.8 and 1.8.2
15:20:19 <vishalmanchanda> tmazur: don't worry about release thing, I can take care of that.
15:20:56 <vishalmanchanda> We follow the same approch during Django migration.
15:23:02 <vishalmanchanda> about testing the plugins we can push a DNM patch in horizon adding horizon-cross-npm job for plugins using angularjs.
15:23:49 <tmazur> vishalmanchanda: that's a good idea
15:24:11 <amotoki> vishalmanchanda: re: cross-ironic-ui, https://opendev.org/openstack/horizon/src/branch/master/.zuul.d/cross-jobs.yaml#L22
15:24:29 <amotoki> the parent job is nodejs *10* surprisingly
15:25:01 <vishalmanchanda> amotoki: oops, I will update that.
15:25:19 <amotoki> but I am not sure why zuul config-error is detected
15:27:30 <vishalmanchanda> Does anyone have any other topic to discuss?
15:27:51 <amotoki> I just would like to request reviews https://review.opendev.org/c/openstack/horizon/+/829629 and https://review.opendev.org/c/openstack/horizon/+/830936
15:28:03 <amotoki> the first one is just a maintenance patch
15:28:39 <amotoki> I would like to have the latter in a backport. Otherwise, UT coverage in the backport is nothing.
15:29:23 <vishalmanchanda> I have already reviewed both of the patches.
15:29:33 <vishalmanchanda> tmazur: rdopiera : Please take a look.
15:29:40 <tmazur> will do
15:29:54 <vishalmanchanda> thanks
15:30:52 <amotoki> thanks
15:32:18 <vishalmanchanda> If no other topic to discuss, let's end this meeting.
15:32:31 <vishalmanchanda> Thanks everyone for your contribution!
15:32:37 <vishalmanchanda> See you next week.
15:32:53 <tmazur> Thanks everyone!
15:32:59 <vishalmanchanda> #endmeeting