15:00:27 <vishalmanchanda> #startmeeting horizon
15:00:27 <opendevmeet> Meeting started Wed Jun 22 15:00:27 2022 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:27 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:27 <opendevmeet> The meeting name has been set to 'horizon'
15:01:35 <tmazur> o/
15:01:54 <vishalmanchanda> hello everyone
15:02:42 <rdopiera> o/
15:03:44 <vishalmanchanda> ok let's start the meeting
15:04:00 <vishalmanchanda> agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L39
15:04:26 <vishalmanchanda> #topic Notices
15:04:48 <vishalmanchanda> A casual reminder about schedule.
15:05:01 <vishalmanchanda> This week is R-15 week.
15:05:17 <vishalmanchanda> For more info about schedule please refer https://releases.openstack.org/zed/schedule.html
15:05:49 <vishalmanchanda> moving to next announcement
15:06:09 <vishalmanchanda> As Some of you already know that dates and venue for the next PTG is already announced.
15:06:33 <vishalmanchanda> Next PTG is going to be physical this time in October 17-20th at the Hyatt Regency in lovely Columbus, Ohio.
15:07:09 <vishalmanchanda> So I want to know how many of you planning to attend it phyiscally?
15:07:28 <vishalmanchanda> We also have to sigup for PTG https://openinfrafoundation.formstack.com/forms/oct2022_ptg_team_signup
15:08:08 <rdopiera> tmazur and me are very unlikely to come, since our company asically disallowed all travel
15:08:19 <rdopiera> basically*
15:09:14 <vishalmanchanda> rdopiera: ok, thanks for letting me know.
15:10:22 <vishalmanchanda> rdopiera: In case there is any change in travel policy on your company side, please let me know.
15:11:24 <vishalmanchanda> I have no other announcements to make, if anyone have any announcement to make. please go ahead
15:12:02 <vishalmanchanda> moving to next topic
15:12:14 <vishalmanchanda> #topic Release priorities
15:12:53 <vishalmanchanda> Xstatic-angular migartion to 1.8.2.2
15:13:23 <vishalmanchanda> npm job is failing for 4 horizon plugins, You can find more info. about it in etherpad
15:13:36 <vishalmanchanda> https://etherpad.opendev.org/p/Fix_Horizon_Plugins_With_Angularjs_v1.8.2.2
15:14:17 <vishalmanchanda> I have pushed patches to fix it in openstack/senlin-dashboard and openstack/magnum-ui
15:14:34 <vishalmanchanda> but still there are many npm test fails.
15:15:40 <vishalmanchanda> Octavia-dashboard team also pushed a patch to make it work with angularjs 1.8.2.2
15:15:49 <vishalmanchanda> https://review.opendev.org/c/openstack/octavia-dashboard/+/846176
15:16:14 <johnsom> Designate-dashboard is here:
15:16:15 <johnsom> https://review.opendev.org/c/openstack/designate-dashboard/+/847096
15:16:17 <vishalmanchanda> but there are still 57 tests fails and acc. to them these tests pass locally.
15:16:40 <vishalmanchanda> johnsom: thanks
15:17:38 <vishalmanchanda> So Octavia team saying we have to cut a new release of horizon, So plugins can consume tmazur  patch https://review.opendev.org/c/openstack/horizon/+/843346
15:17:54 <vishalmanchanda> but I am not completely sure about that.
15:18:16 <vishalmanchanda> I mean cutting a new release going to fix these failed npm tests.
15:18:54 <vishalmanchanda> tmazur: I would like to know your opinion on this?
15:19:19 <tmazur> Let me have a quick look
15:21:41 <tmazur> I am not sure actually
15:22:02 <tmazur> Promise.catch works with AngularJS 1.5.8 as well
15:23:27 <johnsom> It looks like the Octavia patch is failing on test coverage issues.
15:24:28 <vishalmanchanda> ok, Let's cut a new release because when I look at failure logs of openstack/ironic-ui then some tests looks related to me with your change https://review.opendev.org/c/openstack/horizon/+/843346
15:24:53 <vishalmanchanda> i guess those test are going to fix once we cut a new release of horizon.
15:25:45 <tmazur> Ok
15:26:17 <vishalmanchanda> I have one more thing to discuss related to this topic.
15:27:03 <vishalmanchanda> You may have noticed "test_basic_image_browse" integration test start failing
15:27:17 <vishalmanchanda> https://github.com/openstack/horizon/blob/6a84dd2b9aee3b398a9d6fed2bc5f51dcde6263b/openstack_dashboard/test/integration_tests/tests/test_images.py#L49
15:27:42 <tmazur> Yes. I have to investigate it but I am oretty sure my patch has nothing to do with it
15:27:48 <vishalmanchanda> It starts failing after 13th June https://zuul.openstack.org/builds?job_name=horizon-integration-tests&project=openstack%2Fhorizon&branch=master&pipeline=periodic
15:27:52 <vishalmanchanda> tmazur: yeah.
15:28:30 <vishalmanchanda> I am not sure why it start failing now.
15:31:00 <rdopiera> it fails because the title of the page is empty, most likely because the page didn't load
15:32:23 <rdopiera> however, the screenshot shows the page loaded https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_6ce/846424/1/check/horizon-integration-tests/6cea2c6/tox/test_reports/TestImagesAngular.test_basic_image_browse/screenshot.png
15:32:54 <rdopiera> the page html also has the title in it properly
15:33:04 <rdopiera> so could it be something with the geckodriver?
15:33:53 <vishalmanchanda> not sure, I am thinking about skiping this test untill we fixed it.
15:34:15 <vishalmanchanda> I will check if that is due to geckodriver.
15:34:21 <rdopiera> I think then just another test will fail with the same problem, I really doubt the problem is with the test
15:35:07 <rdopiera> by the way, is there any particular reason why we use firefox for the integration tests?
15:35:25 <rdopiera> the integration of selenium with chrome/chromium is *much* better and more stable
15:36:24 <vishalmanchanda> rdopiera: If I rember correctly when we use chrome some url are blocked on infra side.
15:36:41 <vishalmanchanda> rdopiera: that's why we switched to firefox.
15:38:16 <rdopiera> I understand they might block chrome, because it's proprietary, but chromium should be fine?
15:39:26 <vishalmanchanda> chromium we didn't tried.
15:39:31 <vishalmanchanda> https://review.opendev.org/c/openstack/horizon/+/765865
15:40:08 <rdopiera> it says chromium in that patch
15:40:44 <rdopiera> I see it was a temporary solution that stayed
15:40:57 <rdopiera> temporary solutions are forever XD
15:42:25 <vishalmanchanda> rdopiera: So you are suggesting we should switch to chrome/chromium from firefox?
15:43:52 <rdopiera> I can't be entirely sure that the problems we have are due to geckodriver, but I suspect that at least some of them are, since Mozilla really doesn't support geckodriver very well, and actively fights it
15:44:22 <rdopiera> there are APIs waiting to be added to it for years
15:45:07 <vishalmanchanda> rdopiera: ohh I see.
15:46:33 <vishalmanchanda> let me try to run these tests with chromium/chrome and I will also take a look if it is an issue with geckodriver.
15:47:44 <vishalmanchanda> moving to next topic
15:48:04 <vishalmanchanda> #topic On-Demand Agenda
15:49:32 <vishalmanchanda> there is request for patch review https://review.opendev.org/q/topic:keystone-endpoint-type
15:52:55 <vishalmanchanda> TBH, I am not completely sure about the use case of this patch.
15:53:14 <vishalmanchanda> that's why I didn't voted.
15:53:51 <rdopiera> maybe if your keystone is in a different datacenter than the other services? ;-)
15:55:06 <vishalmanchanda> I use devstack so no idea abt that use case.
15:55:45 <vishalmanchanda> anyway I will check with my colllegue who maybe familiar with this use case and review it.
15:56:49 <vishalmanchanda> rdopiera: Please take a look if you are also familir with the use case.
15:57:58 <vishalmanchanda> Next one is also a review request https://review.opendev.org/c/openstack/horizon/+/790504/
15:59:25 <vishalmanchanda> Patch is waiting for review from long time.
15:59:32 <vishalmanchanda> Please take a look.
15:59:48 <vishalmanchanda> That's all from my side for this week.
16:00:02 <rdopiera> vishalmanchanda: I was joking, nobody would do that
16:00:10 <rdopiera> vishalmanchanda: I will ask about the use case
16:00:51 <vishalmanchanda> rdopiera: no, I saw that use case in our company.
16:01:20 <rdopiera> oh my
16:02:34 <vishalmanchanda> rdopiera: we are using keystone of other deployment to authenticate but provinding other services like nova/neutron/cinder and so on.
16:04:14 <vishalmanchanda> rdopiera: even if we merge those patches, It doesn't going to change the default behaviour.
16:04:43 <vishalmanchanda> If we have nothing more to discuss, We can end this meeting.
16:05:26 <vishalmanchanda> Thanks evryone for joining, See you next week.
16:05:42 <vishalmanchanda> #endmeeting