15:00:07 <vishalmanchanda> #startmeeting horizon
15:00:07 <opendevmeet> Meeting started Wed Jun 29 15:00:07 2022 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:07 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:07 <opendevmeet> The meeting name has been set to 'horizon'
15:02:21 <vishalmanchanda> hello, anyone around for horizon weekly meeting.
15:02:26 <rdopiera> o/
15:02:37 <rdopiera> Tatiana is on pto
15:02:50 <vishalmanchanda> rdopiera: ok
15:03:07 <vishalmanchanda> then I guess only two of us.
15:03:14 <vishalmanchanda> ok let's start the meeting.
15:03:29 <vishalmanchanda> #topic Notices
15:03:43 <vishalmanchanda> A casual reminder about schedule.
15:03:56 <vishalmanchanda> This week is R-14 week
15:04:24 <vishalmanchanda> For more info about schedule please refer https://releases.openstack.org/zed/schedule.html
15:04:38 <vishalmanchanda> agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L39
15:05:09 <vishalmanchanda> moving to next announcement
15:06:08 <vishalmanchanda> release team purposed a patch to cut a new release of horizon for stable/wallaby branch.
15:06:42 <vishalmanchanda> As of now, there is no open patch for horizon stable/wallaby branch.
15:06:57 <vishalmanchanda> https://review.opendev.org/c/openstack/releases/+/847908
15:07:21 <vishalmanchanda> that's all announcment from my side for this week.
15:07:31 <vishalmanchanda> moving to next topic
15:07:42 <vishalmanchanda> #topic Release priorities
15:07:59 <vishalmanchanda> Xstatic angular migartion to 1.8.2
15:08:46 <vishalmanchanda> there are many horizon plugins in which npm job is failing with error
15:09:03 <vishalmanchanda> https://zuul.opendev.org/t/openstack/build/680a0fe17bcb468db43aa17d4e774c7f/log/job-output.txt#3308-3314
15:10:54 <vishalmanchanda> rdopiera: any idea why job is failing with syntax error in horizon plugins?
15:13:08 <rdopiera> looks like it's using ` instead of ' to close the string
15:13:32 <rdopiera> I can make a patch for that
15:14:41 <rdopiera> no, wait, maybe that's intentional, I don't know js/angular enough to tell
15:15:21 <rdopiera> ah, it's a template literal
15:15:36 <rdopiera> https://betterprogramming.pub/javascript-how-backticks-work-de269e0fb8ba
15:15:54 <rdopiera> maybe that job is running with too old version of javascript to understand it?
15:17:09 <vishalmanchanda> I am just wondering why we see this error in horizon plugins side but not in horizon
15:18:13 <rdopiera> node version?
15:19:05 <vishalmanchanda> 14 I guess atleast in case of octavia-dashboard and senlin-dashboard
15:19:28 <rdopiera> I see they are using PhantomJS 2.1.1 to run their tests
15:20:36 <rdopiera> we use firefox...
15:21:15 <rdopiera> we can rewrite that to not use that syntax
15:21:57 <vishalmanchanda> rdopiera: +1.
15:22:57 <vishalmanchanda> that's all from my side for this week.
15:23:29 <vishalmanchanda> I purposed patches for few horizon plugins to make it work with angular 1.8.2.2
15:23:41 <vishalmanchanda> If you have time, please take a look.
15:23:58 <vishalmanchanda> You can find more details here https://etherpad.opendev.org/p/Fix_Horizon_Plugins_With_Angularjs_v1.8.2.2
15:24:13 <rdopiera> will do
15:24:21 <vishalmanchanda> rdopiera: thanks.
15:24:28 <rdopiera> I'm still working on making the integration tests a bit more reliable
15:24:53 <vishalmanchanda> rdopiera: yeah i saw your patch but didn't look at it yet.
15:25:05 <rdopiera> I have three patches up that add setup/teardown and deleting of any leftover data -- even just running the tests for them cleared our gate
15:25:16 <rdopiera> we don't even need to merge them
15:25:27 <rdopiera> we can just do a recheck on them each time the gate is stuck ;-)
15:25:40 <vishalmanchanda> rdopiera: ohh cool
15:26:03 <rdopiera> though of course I would prefer to merge them eventually
15:26:20 <rdopiera> there are still some random failures that I can't quite diagnoze
15:26:32 <rdopiera> I get them on my laptop too, but only with firefox
15:26:37 <vishalmanchanda> rdopiera: sure, let me know once they are ready to review.
15:27:03 <rdopiera> all except the volumes should be ready
15:27:11 <rdopiera> the failures are random
15:27:31 <vishalmanchanda> ok
15:28:09 <vishalmanchanda> you use chrome to run integration test in your local env?
15:28:17 <rdopiera> I have also discovered that though you can set things like the public network name or the demo project name in the config file for the tests, most of those values are ignored as they are hardcoded in the tests
15:28:41 <rdopiera> vishalmanchanda: I have also proposed a patch to add an option to run the tests using chromium or chrome
15:29:14 <vishalmanchanda> rdopiera: this one https://review.opendev.org/c/openstack/horizon/+/847763
15:29:35 <rdopiera> right
15:29:48 <rdopiera> it will use chrome if you set an environment variable
15:30:26 <rdopiera> it will use either chrome or chromium, depending on which chromedriver you have in path
15:30:45 <vishalmanchanda> rdopiera: ok will try your patch.
15:31:05 <rdopiera> you can also try the phantomjs
15:31:17 <rdopiera> I didn't, because I don't have it packaged for fedora
15:31:59 <vishalmanchanda> rdopiera: one question on this, Doesn't it going to use the browser we pass in karma.conf.js
15:32:02 <vishalmanchanda> https://github.com/openstack/horizon/blob/master/horizon/karma.conf.js#L123
15:32:46 <rdopiera> I think that just tells zuul what to install in the vm
15:32:58 <rdopiera> horizon has firefox hardcoded
15:33:32 <vishalmanchanda> rdopiera: yes
15:34:01 <vishalmanchanda> rdopiera: ok thanks for the detailed info. will test your patch asap.
15:34:31 <vishalmanchanda> moving to next topic
15:34:40 <vishalmanchanda> #topic open-discussion
15:34:56 <vishalmanchanda> rdopiera: Do you have any other topic to discuss?
15:35:20 <rdopiera> not really, I'm focusing on the integration tests right now
15:35:36 <vishalmanchanda> ok then let's end this meeting.
15:35:42 <rdopiera> I will probably not be able to upgrade jquery
15:35:47 <rdopiera> in this release
15:36:40 <vishalmanchanda> rdopiera: no worries, I will take a look once angularjs migration is completed.
15:36:54 <vishalmanchanda> thanks for joining.
15:36:59 <vishalmanchanda> See you next week.
15:37:07 <rdopiera> thanks, bye
15:37:15 <vishalmanchanda> #endmeeting