15:00:10 <vishalmanchanda> #startmeeting horizon
15:00:10 <opendevmeet> Meeting started Wed Aug  3 15:00:10 2022 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:10 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:10 <opendevmeet> The meeting name has been set to 'horizon'
15:01:07 <e0ne_> hi
15:01:28 <vishalmanchanda> e0ne_: hello, how you doing?
15:01:44 <e0ne_> I'm still alive and pretty secure
15:02:05 <e0ne_> and I'm going to start contribution asap
15:02:16 <vishalmanchanda> e0ne_: nice, good to see you back.
15:02:56 <vishalmanchanda> tmazur: rdoperia: ping for horizon weekly meeting.
15:03:15 <tmazur> o/
15:03:27 <vishalmanchanda> ok let's start the meeting.
15:03:31 <alistarle> o/
15:03:54 <vishalmanchanda> agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L39
15:04:28 <vishalmanchanda> There is nothing much on etherpad, but let's start the meeting.
15:04:38 <vishalmanchanda> #topic Notices
15:04:51 <vishalmanchanda> A casual reminder about schedule.
15:05:16 <vishalmanchanda> This week is R-9 week.
15:05:46 <vishalmanchanda> So we have only 1 month left before the feature freeze.
15:06:06 <vishalmanchanda> For more info about schedule please refer https://releases.openstack.org/zed/schedule.html
15:06:47 <vishalmanchanda> moving to next announcement
15:07:03 <vishalmanchanda> announcement about the PTG
15:08:07 <vishalmanchanda> I remember radomir asking about this. I was thinking if we can do it virtually as most of us not travelling this time.
15:08:47 <vishalmanchanda> e0ne_: what about you,  any travel plans for ptg?
15:09:21 <amotoki> hi
15:09:48 <amotoki> e0ne_: very good to hear from you
15:09:55 <e0ne_> vishalmanchanda: unfortunately, I can't leave Ukraine until the end of the war
15:10:03 <vishalmanchanda> e0ne_: ack.
15:10:14 <e0ne_> amotoki: thanks. I'm glad to be here too
15:10:49 <vishalmanchanda> There is no option for virtual signup of PTG, so we have to arrange a zoom session on our own.
15:11:20 <vishalmanchanda> What we can do, is decide a date for PTG discussion that works for all of us and share the same on open-discuss ML.
15:12:09 <vishalmanchanda> Does anyone have any issues with that?
15:12:44 <tmazur> Works for me
15:14:51 <vishalmanchanda> ok, I guess no one has any issues here.
15:15:27 <vishalmanchanda> JFYI I am not going to do team signup for the horizon as we are going to do it virtually.
15:15:35 <vishalmanchanda> https://lists.openstack.org/pipermail/openstack-discuss/2022-August/029831.html
15:16:35 <vishalmanchanda> I have no other announcements to make, if anyone have any announcement to make. please go ahead
15:17:32 <vishalmanchanda> moving to next topic
15:17:51 <vishalmanchanda> #topic Release priorities
15:18:15 <vishalmanchanda> Xstatic angular migartion to 1.8.2
15:20:24 <vishalmanchanda> As some of you already know that many horizon plugins are broken after we migrated to xstatic-angular 1.8.2.2
15:21:07 <vishalmanchanda> You can check the status here https://etherpad.opendev.org/p/Fix_Horizon_Plugins_With_Angularjs_v1.8.2.2
15:22:07 <amotoki> my question is which plugins really need for a help to catch up with AngularJS 1.8.2.2 and which pluigns are actually unmaintained....
15:22:35 <vishalmanchanda> Last time I checked there are some unit test failing for openstack/octavia-dashboard.
15:22:48 <vishalmanchanda> amotoki: I'll come to your point.
15:22:55 <amotoki> IMHO horizon team is NOT a maintainer for plugins. we just help it if needed.
15:23:10 <vishalmanchanda> amotoki: yes, agreed.
15:23:41 <vishalmanchanda> If I switch to firefox then only 2 npm tests which fails.
15:24:01 <vishalmanchanda> tmazur: Do you get time to look into that issue?
15:24:15 <amotoki> vishalmanchanda: which plugin are you talking about? octavia-dashboard?
15:24:28 <vishalmanchanda> amotoki: yes, octavia-dashboard
15:24:35 <vishalmanchanda> https://review.opendev.org/c/openstack/octavia-dashboard/+/850528
15:24:58 <johnsom> Yeah, I have seen a recent issue with phantomjs jobs. I thought someone had an idea of what was wrong there: SyntaxError: Invalid character: '`'
15:28:00 <tmazur> vishalmanchanda: about octavia-dashboard it's hard to tell without running it. I had no issues like these with horizon while working on the migration
15:28:20 <tmazur> And yes, it's phantomjs issue with backticks
15:30:12 <vishalmanchanda> amotoki: about your point on unmaintained plugins, let's consider, we figure out that this plugin is unmainted then what should be our next step as horizon team?
15:30:21 <johnsom> Are we moving everything to use the firefox engine for testing? I.e. is the phantomjs issue not going to be resolved? I think we switched from firefox to phantomjs in history due to some issue. But if that is resolved now we can move back.
15:33:21 <amotoki> vishalmanchanda: according to the recent test result, we hit 5 failures and 2 errors. you said only 2 npm tests failed with firefox. have other 5 failures gone after switching to firefox?
15:36:21 <vishalmanchanda> amotoki: yes, after switching to firefox only 2 errors left.
15:37:10 <vishalmanchanda> johnsom: yes, we can switch back to firefox or even try chrome I guess.
15:39:08 <johnsom> Ok, I have no problem with that. It would be nice to be consistent across horizon and the plugins which engine we use.
15:39:21 <vishalmanchanda> johnsom: +1
15:39:55 <vishalmanchanda> johnsom: Could you take a look at https://review.opendev.org/c/openstack/octavia-dashboard/+/850528 once you have time.
15:40:55 <johnsom> Yeah, I can update that for merge. I can also attempt a look at those two unit test failures, but sadly my skills in this area are light.
15:41:59 <johnsom> We have people for reviews, etc. but not many with node/angular experience in the current Octavia community.
15:42:20 <amotoki> Syntax error has gone, so perhaps it was due to phantomjs. failures we still have seem to related to AngularJS 1.8.2.
15:43:06 <vishalmanchanda> johnsom: thanks.
15:43:25 <vishalmanchanda> I will take a another look at failed test after the meeting.
15:43:47 <johnsom> Thank you for your help!
15:44:02 <vishalmanchanda> e0ne_: tmazur : you guys also take a look, maybe you find something!
15:44:12 <tmazur> vishalmanchanda: sure
15:44:49 <vishalmanchanda> error logs https://zuul.opendev.org/t/openstack/build/4c96982091bc45a89d774d3caa3c66eb/log/job-output.txt#3285
15:44:54 <vishalmanchanda> tmazur: thanks.
15:45:26 <vishalmanchanda> ok do we have anything else to discuss about this topic?
15:45:55 <amotoki> https://lists.openstack.org/pipermail/openstack-discuss/2022-August/029825.html
15:46:09 <amotoki> perhaps we also need to tackle jquery
15:47:17 <vishalmanchanda> yeah, that's in my TODO list, once we done with this angular migration.
15:47:49 <amotoki> I might post a wrong URL. this is another one https://lists.openstack.org/pipermail/openstack-discuss/2022-August/029796.html which I would like to share initially.
15:49:00 <amotoki> the first link (029825) is about a generic issue around xstatic and the latter is specific to jquery
15:54:53 <vishalmanchanda> amotoki: ack, I'll push a WIP in gate which migrate jquery-migrate version to 3.3.2.1 in horizon and then we can investigate what need to be fixed.
15:57:45 <vishalmanchanda> moving to next topic
15:57:57 <vishalmanchanda> #topic open-discussion
15:58:19 <alistarle> Hi, I just revived a bug about panel dispaly when l3-extension is not enabled: https://bugs.launchpad.net/horizon/+bug/1389489
15:58:20 <vishalmanchanda> Does anyone wants to any other topic?
15:59:08 <alistarle> I was struggling with unit test a lot, but I think I finally found somewhere to mock the allowed() method easily, like we do for the volume_group and vg_snapshot panels, just tell me if you agree with the approach :)
15:59:45 <amotoki> alistarle: thanks for the fix. I agree with the direction as I commented in the bug long ago, but I am not a fan to mocking is_extension_list() globally.
15:59:56 <amotoki> alistarle: I will look into the patch.
16:00:01 <alistarle> yeah thats what I changed
16:00:20 <alistarle> I mock the allowed() method instead in my local env, and it seams to work far better
16:00:35 <vishalmanchanda> alistarle: thanks for fix, will take a look asap.
16:00:35 <alistarle> I will update this in a few minutes
16:00:58 <alistarle> great, thanks :D
16:01:39 <amotoki> alistarle: I don't suggest to mock allowed() completely.... it does not test the logic proposed... I will explore an approach too
16:03:16 <alistarle> can't be mock allowed() by default, and override it for tests specific to this part of the code ?
16:03:53 <alistarle> issue is is_extension_list heavily used, mocked, with a lot of assert, so it manually require to fix about 200 tests
16:03:54 <amotoki> alistarle: yes, I think it is better.
16:04:20 <alistarle> cool, I just need to find if TEST_GLOBAL_MOCKS_ON_PANELS is overridable for a single test
16:04:39 <vishalmanchanda> amotoki: I need your help in fixing gate for openstack/ui-cookiecutter.
16:04:59 <vishalmanchanda> amotoki: I tried to fix it locally, but not succeded.
16:04:59 <amotoki> vishalmanchanda: are we still interested in maintaining ui-cookiecutter?
16:05:01 <vishalmanchanda> https://review.opendev.org/c/openstack/ui-cookiecutter/+/839978
16:06:04 <vishalmanchanda> amotoki: we can make that job as non-voting🙂)
16:06:38 <opendevreview> Victor Coutellier proposed openstack/horizon master: Adapt panel display based on enabled extensions  https://review.opendev.org/c/openstack/horizon/+/851914
16:07:32 <e0ne_> need to drop. see you
16:07:48 <vishalmanchanda> e0ne_: thanks for joining, see you.
16:08:57 <amotoki> who needs ui-cookiecutter? if needed it is worth maintaining it but if not it just wastes our time.
16:09:18 <amotoki> this is the only job in ui-cookiecutter, so making it non-voting is meaningless.
16:09:40 <amotoki> non voting job means it is not tested unfrotunately.....
16:09:56 <amotoki> s/non voting/no voting/
16:11:18 <vishalmanchanda> amotoki: make sense.
16:11:46 <amotoki> looking at the failure log, I see "Syntax error" in karma-local tox env. perhaps it is due to the same reason as we see in octavita-dashboard with phantomjs.
16:12:10 <vishalmanchanda> amotoki: hmm.
16:12:44 <vishalmanchanda> amotoki: It fails for me with different error in local-env.
16:12:59 <vishalmanchanda> ok let's end this meeting.
16:13:15 <vishalmanchanda> Thanks everyone for joining, See you next week!
16:13:20 <amotoki> o/
16:13:24 <alistarle> \o
16:13:26 <vishalmanchanda> #endmeeting