15:00:14 <vishalmanchanda> #startmeeting horizon
15:00:14 <opendevmeet> Meeting started Wed May  3 15:00:14 2023 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:14 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:14 <opendevmeet> The meeting name has been set to 'horizon'
15:04:07 <rdopiera> o/
15:04:10 <tmazur> o/
15:04:25 <vishalmanchanda> hello everyone
15:04:37 <vishalmanchanda> agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L39
15:04:46 <vishalmanchanda> let's start the meeting
15:04:56 <vishalmanchanda> #topic Notices
15:05:21 <vishalmanchanda> First of all, a casual reminder about the schedule. This week is R-22 week.
15:06:07 <vishalmanchanda> Next week is Bobcat-1 milestone week.
15:06:40 <vishalmanchanda> For more info. about schedule please refer https://releases.openstack.org/bobcat/schedule.html
15:07:10 <vishalmanchanda> moving to next announcement
15:07:51 <vishalmanchanda> release team purposed a patch to move stable/rocky branch of horizon to EOL and we discuss this topic in the past and agreed with that.
15:08:11 <vishalmanchanda> So I +1ed on the patch https://review.opendev.org/c/openstack/releases/+/881626
15:08:42 <vishalmanchanda> that's all announcement for this week from my side.
15:10:04 <vishalmanchanda> moving to next topic
15:10:20 <vishalmanchanda> #topic Release priorities
15:10:51 <vishalmanchanda> One update from my side on jQuery update.
15:11:31 <vishalmanchanda> The VM from where I am pushing jQuery update patches is not booting Up.
15:11:39 <vishalmanchanda> I tried to recover it, but looks like it will be difficult.
15:12:01 <vishalmanchanda> Lost some code changes which I done on that VM.
15:12:57 <vishalmanchanda> Anyway, I already set up a new devstack env. in another VM but am getting many error messages for angular in the browser 'Developer Tool' option.
15:13:43 <vishalmanchanda> Like this https://paste.openstack.org/show/b2v6zxyyuUKJSNNZpCOK/
15:14:11 <vishalmanchanda> Can you check if you are also getting the same error messages.
15:14:49 <vishalmanchanda> Like If I try to Launch or create an instance I am seeing these errors although the instance was created without any issues.
15:15:29 <rdopiera> you can get your patches back from gerrit
15:16:05 <vishalmanchanda> no I have more code which I didn't push on Gerrit.
15:16:10 <rdopiera> oof
15:16:17 <vishalmanchanda> yup.
15:16:23 <rdopiera> that error looks like there is a spurious [
15:16:32 <rdopiera> or maybe a missing ]
15:16:35 <vishalmanchanda> yes
15:17:16 <rdopiera> isn't "!--" a comment in html?
15:17:19 <vishalmanchanda> are you also getting those errors with the latest horizon code?
15:17:41 <rdopiera> I havent tried the latest code in a while, my env is broken at the moment
15:17:50 <rdopiera> I'm mostly working on backports right now
15:17:54 <vishalmanchanda> ok
15:18:17 <rdopiera> I will try and let you know tomorrow
15:18:26 <vishalmanchanda> thanks.
15:19:04 <vishalmanchanda> moving to next topic
15:19:51 <vishalmanchanda> setup tool bug https://bugs.launchpad.net/horizon/+bug/2007574
15:19:55 <rdopiera> yup, \x3C!-- is <!-- which is start of a comment...
15:20:52 <vishalmanchanda> sorry what do you mean, is it due to some patch we merged recently?
15:21:13 <rdopiera> no idea, but I suspect that the parser is getting confused by this somehow
15:21:48 <vishalmanchanda> ok
15:22:04 <rdopiera> that setuptools bug should be fixed with that patch I submitted for xstatic
15:22:14 <vishalmanchanda> your patch is merged https://github.com/xstatic-py/xstatic/pull/11
15:22:27 <vishalmanchanda> but I am not sure if it fixes the issue.
15:22:40 <rdopiera> yeah, I suppose we need to make a release and make horizon require that version?
15:22:48 <vishalmanchanda> I rechecked on Kolla patch https://review.opendev.org/c/openstack/kolla/+/876460
15:23:10 <rdopiera> mnasiadka: do you think you could try with the xstatic version from master?
15:23:32 <vishalmanchanda> rdopiera: ok. I will cut a new release then and see.
15:24:01 <vishalmanchanda> rdopiera: yeah, that would be good if somehow we can test locally first.
15:25:47 <vishalmanchanda> rdopiera: we can drop a comment on https://review.opendev.org/c/openstack/kolla/+/876460
15:25:48 <rdopiera> I meant a pypi release for xstatic
15:26:08 <vishalmanchanda> Ohh ok.
15:27:23 <rdopiera> I added a comment
15:27:48 <vishalmanchanda> rdopiera: Could you take care of the release thing for this pypi, if required.
15:28:03 <rdopiera> yeah, I will look into it
15:28:12 <vishalmanchanda> cool.
15:28:21 <vishalmanchanda> thanks
15:28:57 <vishalmanchanda> ok, one more thing I would like to discuss here.
15:30:38 <vishalmanchanda> I am seeing a lot of warnings in CI jobs like "Package would be ignored" , do we need to worry about this
15:30:49 <vishalmanchanda> see https://zuul.opendev.org/t/openstack/build/b965c032465549ed86ac2ed45670715c/log/job-output.txt#25810-25834
15:31:50 <rdopiera> no idea, I haven't been paying attention to what new marvelous changes our python 3 overlords are making to pypi
15:32:32 <vishalmanchanda> ok.
15:33:09 <vishalmanchanda> that's all update from my side for this week.
15:33:16 <vishalmanchanda> moving to next topic
15:33:29 <vishalmanchanda> #topic open-discussion
15:34:06 <rdopiera> relevant: https://setuptools.pypa.io/en/latest/deprecated/distutils/sourcedist.html#specifying-the-files-to-distribute
15:34:18 <rdopiera> https://setuptools.pypa.io/en/latest/deprecated/distutils/setupscript.html#distutils-installing-package-data
15:35:09 <vishalmanchanda> thanks, will look in the documentations.
15:35:26 <vishalmanchanda> I just want to raise some awareness about bug https://bugs.launchpad.net/horizon/+bug/2018232
15:35:44 <vishalmanchanda> It is a valid bug.
15:36:21 <rdopiera> looks like we just need to list those directories in https://github.com/openstack/horizon/blob/master/setup.cfg#L32
15:36:41 <vishalmanchanda> rdopiera: ok got it.
15:37:45 <vishalmanchanda> tmazur: If you have time, please take a look at https://bugs.launchpad.net/horizon/+bug/2018232
15:38:02 <tmazur> Looking
15:38:56 <vishalmanchanda> I fixed the bug partially like I handled the exception but still not able to see any entries in the Ui side and not seeing error after updating the code.
15:39:38 <tmazur> I don't have any env with trunks, so I'll need to deploy one and take a proper look
15:39:51 <vishalmanchanda> what about qos?
15:40:15 <tmazur> Same I'm afraid
15:40:23 <vishalmanchanda> I done some changes in the previous env.
15:40:35 <vishalmanchanda> ok.
15:41:04 <tmazur> It looks like my upgrade missed something
15:41:36 <vishalmanchanda> Please check if you have some time to look into those issues. I will also try again.
15:41:42 <tmazur> Simply because I didn't have an env to check. I'll start on the new env asap and take a look
15:41:49 <tmazur> Yeah
15:42:21 <vishalmanchanda> Thanks.
15:42:44 <vishalmanchanda> Does anyone have any other topic to discuss?
15:46:49 <vishalmanchanda> if no other topic to discuss, let's end this meeting
15:47:01 <vishalmanchanda> Thanks everyone for joining.
15:47:06 <tmazur> Thanks!
15:47:10 <vishalmanchanda> #endmeeting