15:00:17 <vishalmanchanda> #startmeeting horizon
15:00:17 <opendevmeet> Meeting started Wed Jun 21 15:00:17 2023 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:17 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:17 <opendevmeet> The meeting name has been set to 'horizon'
15:01:35 <tmazur> o/
15:02:04 <vishalmanchanda> Hello everyone
15:04:22 <vishalmanchanda> only two of us.
15:04:35 <vishalmanchanda> let's start the meeting
15:05:45 <vishalmanchanda> agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L39
15:06:20 <vishalmanchanda> I have no announcements for this week.
15:06:42 <vishalmanchanda> so moving to release priorities topic
15:06:46 <rdopiera> o/
15:06:55 <vishalmanchanda> #topic Release priorities
15:07:36 <vishalmanchanda> there is no update from my side on jQuery update.
15:07:59 <vishalmanchanda> I am investigating the horizon integration job failure issue.
15:08:12 <vishalmanchanda> I am unable to reproduce the issue in local env.
15:09:01 <vishalmanchanda> Now I am trying to create a new devstack env. using debian-bullseye distribution which our gate CI is using.
15:10:20 <vishalmanchanda> I tried to revert few of my jQuery changes but still random integration tests fails https://review.opendev.org/c/openstack/horizon/+/886244
15:10:21 <rdopiera> I'm thinking we could perhaps get more insight into the issue, if we got the javascript console logs. That is not possible with firefox, but I was thinking maybe we could add a non-voting job with chromium to our gate?
15:11:04 <vishalmanchanda> rdopiera: ok, sounds good.
15:11:18 <rdopiera> I proposed a patch that fixes some issues with chromium in our tests, but I have no idea where to even start with the new job
15:12:35 <vishalmanchanda> rdopiera: what you want to run a integration job(non-voting) with chromium browser?
15:12:49 <rdopiera> yes
15:13:52 <rdopiera> on the tests side, we just need to set the SELENIUM_CHROME environment variable, but on the setup side we have to make sure chromium is installed
15:14:13 <vishalmanchanda> what if we change default browser to chromium in ``karma.conf.js`` file.
15:14:57 <rdopiera> where is that file?
15:15:12 <vishalmanchanda> This is the patch where we switch to firefox browser.
15:15:12 <vishalmanchanda> https://review.opendev.org/c/openstack/horizon/+/765865
15:16:47 <rdopiera> that's for angular unit tests
15:16:52 <rdopiera> not for selenium
15:17:03 <tmazur> Isn't it just for npm tests?
15:17:18 <tmazur> Yeah
15:18:05 <rdopiera> for integration tests, we just need SELENIUM_CHROME=1 in the environment variables
15:18:18 <vishalmanchanda> oh, sorry my bad.
15:18:32 <rdopiera> but chromium or chrome has to be installed on the vm
15:18:44 <rdopiera> I don't know if it's currently installed by default
15:22:12 <rdopiera> another thing we could try to at least get the patches merging again is to change the test that is failing to go to the settings page by entering an url in the location bar, instead of clicking on the menu
15:22:26 <rdopiera> because right now it's the clicking on the menu that is failing
15:22:40 <rdopiera> however, I think that will just expose further problems
15:23:23 <rdopiera> if we are getting a javascript error and the menus stop working, then the tests will just fail in a different spot
15:26:36 <vishalmanchanda> yeah we can merge atleast https://review.opendev.org/c/openstack/horizon/+/883953
15:27:57 <vishalmanchanda> for cirros image issue
15:28:34 <rdopiera> if everything else fails, we could set the integration tests to non-voting
15:29:03 <rdopiera> but I wouldn't want to do that
15:31:12 <vishalmanchanda> yeah me too.
15:31:35 <vishalmanchanda> Does this patch https://review.opendev.org/c/openstack/horizon/+/886260/6/horizon/test/webdriver.py change default browser to chrome?
15:32:17 <rdopiera> no, it doesn't change the browser, it only fixes the download directory when using chrome
15:32:33 <rdopiera> you still have to explicitly define SELENIUM_CHROME to use chrome
15:33:00 <rdopiera> I can add a tox environemnt that does it?
15:33:27 <vishalmanchanda> there is abandon patch which try to run integartion test with chrome
15:33:37 <vishalmanchanda> please see if it helps you https://review.opendev.org/c/openstack/horizon/+/583093
15:34:35 <rdopiera> ooh, fancy, it has a --headless option, that means we wouldn't even need the xvfbwrapper
15:35:07 <rdopiera> but I wouldn't want to just switch, preferably I would prefer to have a separate job
15:35:29 <tmazur> Maybe we could have a non-voting job first?
15:35:38 <tmazur> And then if it works we could switch?
15:37:13 <rdopiera> just a non-voting job would give us the browser log file
15:37:25 <rdopiera> so that would be a win
15:38:14 <rdopiera> vishalmanchanda: I will add an environment to tox, and then we can add a job that runs it
15:38:51 <vishalmanchanda> rdopiera: yes.
15:39:23 <vishalmanchanda> I will help to add a new job that will use chrome browser.
15:40:25 <opendevreview> Radomir Dopieralski proposed openstack/horizon master: Fix test_credentials for Chrome browser in integration tests  https://review.opendev.org/c/openstack/horizon/+/886260
15:41:38 <rdopiera> now we have tox -e integration-chrome
15:42:07 <rdopiera> it still uses the xvfbwrapper mechanism like with firefox
15:42:30 <rdopiera> we can later improve it
15:48:14 <vishalmanchanda> ok I will check how to add a new job which only use chrome browser for horizon integration job
15:56:14 <vishalmanchanda> I have nothing more to discuss here.
15:56:25 <vishalmanchanda> #topic open-discussion
15:56:40 <vishalmanchanda> Does anyone have any topic to discuss?
15:59:52 <rdopiera> thanks everyone
16:00:10 <vishalmanchanda> thanks everyone for joining.
16:00:23 <vishalmanchanda> #endmeeting